VSE: Wrap Width different between preview and render #98482

Open
opened 2022-05-29 16:13:05 +02:00 by Kevin · 11 comments

System Information
Operating system: Linux-5.15.0-30-generic 64 Bits
Graphics card: NVIDIA GeForce GTX 650 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86

Blender Version
Broken: 3.2, 3.3 alpha
Worked: 3.0.1

Short description of error
The text doesn't wrap the same way in the VSE preview and in the actual render. This changes randomly depending on the render size
Screenshot from 2022-05-29 14-54-46.png
untitled.jpg

Exact steps for others to reproduce the error
textVSE.blend

I suppose one needs the right mix of text length, Wrap Width, and Font Size for the bug to show up. In my example file, rendering at 50% goes wrong but at 100% it's fine. When I came across this by accident, it was the opposite.

**System Information** Operating system: Linux-5.15.0-30-generic 64 Bits Graphics card: NVIDIA GeForce GTX 650 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86 **Blender Version** Broken: 3.2, 3.3 alpha Worked: 3.0.1 **Short description of error** The text doesn't wrap the same way in the VSE preview and in the actual render. This changes randomly depending on the render size ![Screenshot from 2022-05-29 14-54-46.png](https://archive.blender.org/developer/F13121086/Screenshot_from_2022-05-29_14-54-46.png) ![untitled.jpg](https://archive.blender.org/developer/F13121090/untitled.jpg) **Exact steps for others to reproduce the error** [textVSE.blend](https://archive.blender.org/developer/F13121093/textVSE.blend) I suppose one needs the right mix of text length, Wrap Width, and Font Size for the bug to show up. In my example file, rendering at 50% goes wrong but at 100% it's fine. When I came across this by accident, it was the opposite.
Author

Added subscriber: @jack.herbert

Added subscriber: @jack.herbert
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @iss

Added subscriber: @iss

Could be some inaccuracy in code, because with wrap values different than 0.75 it matches.

Could be some inaccuracy in code, because with wrap values different than 0.75 it matches.

Added subscriber: @tintwotin

Added subscriber: @tintwotin

Text size is not adjusted to fit when there is a resolution change and Preview is not updated either:
res_text.gif

Text size is not adjusted to fit when there is a resolution change and Preview is not updated either: ![res_text.gif](https://archive.blender.org/developer/F13122636/res_text.gif)

Added subscriber: @hamdio

Added subscriber: @hamdio
Hamdi Ozbayburtlu self-assigned this 2022-06-24 14:53:25 +02:00

Yes, I can confirm the inconsistency. After debugging it, I see the preview window is doing the wrap calculation based on unscaled resolution while rendering uses the line width from scaled resolution when I follow the repro steps.
So is it better to align preview to render flow and use scaled scene resolution for word wrap or the other way around?
But even if the Proxy Render Size is set to Scene Size to have same text wrap result for render and preview window, changing scaling between 50% and 100% generates different wrapping results. This's mostly because of because of having the wrapping calculation in BLF_wordwrap using scaled down integer width value. Investigating if it can be done in a better way.

Yes, I can confirm the inconsistency. After debugging it, I see the preview window is doing the wrap calculation based on unscaled resolution while rendering uses the line width from scaled resolution when I follow the repro steps. ~~So is it better to align preview to render flow and use scaled scene resolution for word wrap or the other way around?~~ But even if the `Proxy Render Size` is set to `Scene Size` to have same text wrap result for render and preview window, changing scaling between `50%` and `100%` generates different wrapping results. This's mostly because of because of having the wrapping calculation in `BLF_wordwrap` using scaled down integer width value. Investigating if it can be done in a better way.
Hamdi Ozbayburtlu removed their assignment 2022-06-28 15:49:34 +02:00

Added subscriber: @Harley

Added subscriber: @Harley

I've debugged the text wrapping code flow and couldn't find anything wrong with width, height, size values coming into blf_font_wrap_apply from VSE point of view. And at first glance the wrapping calculation seems consistent. I reached out @Harley to understand the root cause. So the possible reason could be:

Wrapping code uses a measure of the string that should only ever overestimate by about the space between a pair of characters (because it includes the space after the last one) so is usually within a couple pixels of perfect.

I'm un-claiming this ticket as I don't have much expertise in font rendering but will keep posting the updates if I hear/find more.

I've debugged the text wrapping code flow and couldn't find anything wrong with width, height, size values coming into `blf_font_wrap_apply` from VSE point of view. And at first glance the wrapping calculation seems consistent. I reached out @Harley to understand the root cause. So the possible reason could be: > Wrapping code uses a measure of the string that should only ever overestimate by about the space between a pair of characters (because it includes the space after the last one) so is usually within a couple pixels of perfect. I'm un-claiming this ticket as I don't have much expertise in font rendering but will keep posting the updates if I hear/find more.
Philipp Oeser removed the
Interest
VFX & Video
label 2023-02-10 09:31:30 +01:00
Sergey Sharybin added
Type
Bug
and removed
Type
Report
labels 2023-02-16 10:45:20 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#98482
No description provided.