Window Decorations Not Present on GNOME - Wayland #98612

New Issue

Caden Mitchell · 2022-06-05T14:34:16+02:00

Caden Mitchell commented

2022-06-05 14:34:16 +02:00

System Information
Operating system: Fedora Linux 36 (amd64)
Graphics card: AMD Radeon RX 5700 XT

Blender Version
Broken: example: 3.3.0 Alpha, e90ba74d3e, master, 2022-06-5

Short description of error
Following official Fedora instructions to build on Linux with Walyand support, Blender launches perfectly functional, but without Window decorations. Works as expected with only X11 support.

Exact steps for others to reproduce the error
Build Blender with wayland flags on GNOME 42, Wayland.

Screenshot

**System Information** Operating system: Fedora Linux 36 (amd64) Graphics card: AMD Radeon RX 5700 XT **Blender Version** Broken: example: 3.3.0 Alpha, e90ba74d3eb8, master, 2022-06-5 **Short description of error** Following official Fedora instructions to build on Linux with Walyand support, Blender launches perfectly functional, but without Window decorations. Works as expected with only X11 support. **Exact steps for others to reproduce the error** Build Blender with wayland flags on GNOME 42, Wayland. **Screenshot** ![Screenshot from 2022-06-05 06-33-23.png](https://archive.blender.org/developer/F13133661/Screenshot_from_2022-06-05_06-33-23.png)

Caden Mitchell commented

2022-06-05 14:34:16 +02:00

Added subscriber: @Caden-Mitchell

Anton Raves commented

2022-06-05 23:16:58 +02:00

Added subscriber: @Memento

Omar Emara commented

2022-06-08 14:21:49 +02:00

Added subscribers: @christian.rauch, @OmarEmaraDev

Omar Emara commented

2022-06-08 14:21:49 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Omar Emara commented

2022-06-08 14:21:49 +02:00

Gnome on Wayland doesn't support server side window decorations as far as I know, so maybe this is a known limitation? See D11368.
Maybe @christian.rauch can give more information about this.

Gnome on Wayland doesn't support server side window decorations as far as I know, so maybe this is a known limitation? See [D11368](https://archive.blender.org/developer/D11368). Maybe @christian.rauch can give more information about this.

Christian Rauch commented

2022-06-08 14:52:06 +02:00

Yes, GNOME does not implement server-side decorations. But this is not a requirement for Wayland. Actually, Wayland clients are expected to draw their own decorations (like on Windows and macOS). There are ways to have the compositor draw the decorations or libraries to draw them client-side.

There is the xdg-decoration protocol - to negotiate with a compositor/server who is drawing the window decorations. But this one is not implemented by GNOME Shell and it is unlikely that it will be supported by GNOME in the long-term.
There is also a library libdecor - , which I am contributing to too, to implement client-side decorations. I actually implemented this for Blender a long time ago on one of my branches (D7989), but did not go ahead because of the uncertainty around Blender on Wayland. This needs a rebase and a couple of changes to work with the most recent state. I may come back to this once the issues around EGL (#90676) are sorted out.

Yes, GNOME does not implement server-side decorations. But this is not a requirement for Wayland. Actually, Wayland clients are expected to draw their own decorations (like on Windows and macOS). There are ways to have the compositor draw the decorations or libraries to draw them client-side. 1. There is the `xdg-decoration` protocol - [x] to negotiate with a compositor/server who is drawing the window decorations. But this one is not implemented by GNOME Shell and it is unlikely that it will be supported by GNOME in the long-term. 2. There is also a library `libdecor` - [x], which I am contributing to too, to implement client-side decorations. I actually implemented this for Blender a long time ago on one of my branches ([D7989](https://archive.blender.org/developer/D7989)), but did not go ahead because of the uncertainty around Blender on Wayland. This needs a rebase and a couple of changes to work with the most recent state. I may come back to this once the issues around EGL (#90676) are sorted out. - [x] https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/unstable/xdg-decoration/xdg-decoration-unstable-v1.xml - [x] https://gitlab.gnome.org/jadahl/libdecor

Omar Emara commented

2022-06-08 15:20:43 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Omar Emara commented

2022-06-08 15:20:43 +02:00

Thanks for the information. Then I think we can confirm this for now until the necessary patches land.

Caden Mitchell commented

2022-06-09 08:59:44 +02:00

Alright I see. I'm eagerly awaiting these changes. Currently, when Blender (with Wayland support) summons a new window under Wayland, it appears initially with the completely wrong dimensions and position. Moving the window using something like the meta/super/Windows key will make it snap back into the right dimensions. It also seems like you can use window tiling just fine. Seems at least most of this will probably be fixed when we have correct window decorations.

Alvaro Perez commented

2022-06-16 22:55:04 +02:00

Added subscriber: @alvaroperez

Eric Engestrom commented

2022-06-17 09:01:37 +02:00

Added subscriber: @1ace

Campbell Barton commented

2022-06-24 16:18:37 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2022-06-24 16:18:37 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2022-06-24 16:18:37 +02:00

Campbell Barton self-assigned this 2022-06-24 16:18:37 +02:00

Campbell Barton commented

2022-06-24 16:18:37 +02:00

Closing this task as resolves since support has been committed 29755e1df8, although there is some work left with library linking to enable this by default.

Closing this task as resolves since support has been committed 29755e1df8, although there is some work left with library linking to enable this by default.

Luya Tshimbalanga commented

2022-09-12 04:07:29 +02:00

Added subscriber: @Luya-Tshimbalanga

Luya Tshimbalanga commented

2022-09-12 04:07:29 +02:00

Thank you very much Caden for implementing Wayland support for Blender. For further testing the implementation, as a Fedora maintainer, we will enable support on the development repository for testing.

Caden Mitchell commented

2022-09-18 08:16:55 +02:00

In #98612#1415351, @Luya-Tshimbalanga wrote:
Thank you very much Caden for implementing Wayland support for Blender. For further testing the implementation, as a Fedora maintainer, we will enable support on the development repository for testing.

Thank you for the kind words, but honestly I didn't do shit. Thank Campbell, Christian Rauch, and the others. I just complained.

I would also wait on building for Wayland. It seems Wayland support is still incomplete as the program still has no titlebar, and enabling the optional window decoration system looks completely wrong. It is not a native QT or GTK titlebar, but rather an obscure, ugly system called "libdecor". If you want to test it with the titlebar, you need to build with this: make release -j BUILD_CMAKE_ARGS="-DWITH_GHOST_WAYLAND=ON -DWITH_GHOST_WAYLAND_LIBDECOR=ON"

> In #98612#1415351, @Luya-Tshimbalanga wrote: > Thank you very much Caden for implementing Wayland support for Blender. For further testing the implementation, as a Fedora maintainer, we will enable support on the development repository for testing. Thank you for the kind words, but honestly I didn't do shit. Thank Campbell, Christian Rauch, and the others. I just complained. I would also wait on building for Wayland. It seems Wayland support is still incomplete as the program still has no titlebar, and enabling the optional window decoration system looks completely wrong. It is not a native QT or GTK titlebar, but rather an obscure, ugly system called "libdecor". If you want to test it with the titlebar, you need to build with this: `make release -j BUILD_CMAKE_ARGS="-DWITH_GHOST_WAYLAND=ON -DWITH_GHOST_WAYLAND_LIBDECOR=ON"`

Eric Engestrom commented

2022-09-18 12:23:12 +02:00

In #98612#1418958, @Caden-Mitchell wrote:

window decoration system looks completely wrong. It is not a native QT or GTK titlebar, but rather an obscure, ugly system called "libdecor".

Calling libdecor "ugly" and "obscure" is unkind and certainly not fair. It has it's own style instead of chasing after QT or GTK (and neither of them chases after the other one and you're not calling them ugly for that, are you?), and it's become the standard for any app that's not built on QT or GTK, and it's used by frameworks such as SDL which are very popular, so it's definitely not obscure either.

If you don't like design choices you can always raise an issue to suggest what you'd prefer to see, instead of name-calling.

> In #98612#1418958, @Caden-Mitchell wrote: > - [x] window decoration system looks completely wrong. It is not a native QT or GTK titlebar, but rather an obscure, ugly system called "libdecor". Calling libdecor "ugly" and "obscure" is unkind and certainly not fair. It has it's own style instead of chasing after QT or GTK (and neither of them chases after the other one and you're not calling them ugly for that, are you?), and it's become the standard for any app that's not built on QT or GTK, and it's used by frameworks such as SDL which are very popular, so it's definitely not obscure either. If you don't like design choices you can always raise an issue to suggest what you'd prefer to see, instead of name-calling.

Caden Mitchell commented

2022-09-18 22:44:13 +02:00

In #98612#1418999, @1ace wrote:

In #98612#1418958, @Caden-Mitchell wrote:

window decoration system looks completely wrong. It is not a native QT or GTK titlebar, but rather an obscure, ugly system called "libdecor".

Calling libdecor "ugly" and "obscure" is unkind and certainly not fair. It has it's own style instead of chasing after QT or GTK (and neither of them chases after the other one and you're not calling them ugly for that, are you?), and it's become the standard for any app that's not built on QT or GTK, and it's used by frameworks such as SDL which are very popular, so it's definitely not obscure either.

If you don't like design choices you can always raise an issue to suggest what you'd prefer to see, instead of name-calling.

Sorry. Perhaps I was a bit harsh. Please understand, most Linux users expect applications that match the rest of the system style. Anything that breaks the system theme sticks out and looks subjectively bad, and objectively worse than using native libraries. At any rate, this change feels like a major regression from the X11 method. In X11, Blender will inherit a native titlebar due to the way X11 works. It would be nice to see the Wayland implementation do this.

It is my understanding that Wayland does not add Window Decorations on it's own like X11. Perhaps Blender can be built with BOTH QT and GTK systems, and then switch accordingly. This would make more sense to me personally, as Gnome and KDE Plasma are pretty much the only two desktops that can completely support Wayland properly, and QT and GTK are the two primary graphics libraries for the Linux desktop.

> In #98612#1418999, @1ace wrote: >> In #98612#1418958, @Caden-Mitchell wrote: >> - [x] window decoration system looks completely wrong. It is not a native QT or GTK titlebar, but rather an obscure, ugly system called "libdecor". > > Calling libdecor "ugly" and "obscure" is unkind and certainly not fair. It has it's own style instead of chasing after QT or GTK (and neither of them chases after the other one and you're not calling them ugly for that, are you?), and it's become the standard for any app that's not built on QT or GTK, and it's used by frameworks such as SDL which are very popular, so it's definitely not obscure either. > > If you don't like design choices you can always raise an issue to suggest what you'd prefer to see, instead of name-calling. Sorry. Perhaps I was a bit harsh. Please understand, most Linux users expect applications that match the rest of the system style. Anything that breaks the system theme sticks out and looks subjectively bad, and objectively worse than using native libraries. At any rate, this change feels like a major regression from the X11 method. In X11, Blender will inherit a native titlebar due to the way X11 works. It would be nice to see the Wayland implementation do this. It is my understanding that Wayland does not add Window Decorations on it's own like X11. Perhaps Blender can be built with BOTH QT and GTK systems, and then switch accordingly. This would make more sense to me personally, as Gnome and KDE Plasma are pretty much the only two desktops that can completely support Wayland properly, and QT and GTK are the two primary graphics libraries for the Linux desktop.

Christian Rauch commented

2022-09-18 23:29:19 +02:00

In #98612#1419180, @Caden-Mitchell wrote:
Sorry. Perhaps I was a bit harsh. Please understand, most Linux users expect applications that match the rest of the system style. Anything that breaks the system theme sticks out and looks subjectively bad, and objectively worse than using native libraries. At any rate, this change feels like a major regression from the X11 method.

In the perfect Linux-Desktop world, every application would use the same toolkit. Every application that uses a different toolkit than the majority of your applications will visually stick out. There is no way around it. I doubt that Blender wants to implement the UI in every desktop's native toolkit.

In X11, Blender will inherit a native titlebar due to the way X11 works. It would be nice to see the Wayland implementation do this.

I suggest you read a bit about how decorations are implemented in Wayland to understand why things are how they are. You will soon find out that there are client-side decorations (CSD) and server-side decorations (SSD). If you want to improve either of them, there are plenty of projects to contribute.

It is my understanding that Wayland does not add Window Decorations on it's own like X11. Perhaps Blender can be built with BOTH QT and GTK systems, and then switch accordingly. This would make more sense to me personally, as Gnome and KDE Plasma are pretty much the only two desktops that can completely support Wayland properly, and QT and GTK are the two primary graphics libraries for the Linux desktop.

Not sure if you have seen the "native" Qt decorations. They also stick out on GTK desktop environments and are missing some functionality. If you want to convince developers to use GTK or Qt for Blenders windowing, go ahead. Otherwise, have a look at https://gitlab.gnome.org/jadahl/libdecor/-/merge_requests/43.

> In #98612#1419180, @Caden-Mitchell wrote: > Sorry. Perhaps I was a bit harsh. Please understand, most Linux users expect applications that match the rest of the system style. Anything that breaks the system theme sticks out and looks subjectively bad, and objectively worse than using native libraries. At any rate, this change feels like a major regression from the X11 method. In the perfect Linux-Desktop world, every application would use the same toolkit. Every application that uses a different toolkit than the majority of your applications will visually stick out. There is no way around it. I doubt that Blender wants to implement the UI in every desktop's native toolkit. > In X11, Blender will inherit a native titlebar due to the way X11 works. It would be nice to see the Wayland implementation do this. I suggest you read a bit about how decorations are implemented in Wayland to understand why things are how they are. You will soon find out that there are client-side decorations (CSD) and server-side decorations (SSD). If you want to improve either of them, there are plenty of projects to contribute. > It is my understanding that Wayland does not add Window Decorations on it's own like X11. Perhaps Blender can be built with BOTH QT and GTK systems, and then switch accordingly. This would make more sense to me personally, as Gnome and KDE Plasma are pretty much the only two desktops that can completely support Wayland properly, and QT and GTK are the two primary graphics libraries for the Linux desktop. Not sure if you have seen the "native" Qt decorations. They also stick out on GTK desktop environments and are missing some functionality. If you want to convince developers to use GTK or Qt for Blenders windowing, go ahead. Otherwise, have a look at https://gitlab.gnome.org/jadahl/libdecor/-/merge_requests/43.

Campbell Barton referenced this issue

2023-03-16 03:47:11 +01:00

GHOST/Wayland Support #76428

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Window Decorations Not Present on GNOME - Wayland #98612