Regression: Crash when adding color attribute in edit mode #98673

New Issue

Dvorakir · 2022-06-08T17:00:37+02:00

Dvorakir commented

2022-06-08 17:00:37 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: 3.1

Caused by 3d5f5c2d9a

Short description of error
Adding a color attribute to a mesh from the Color Attribute panel causes a crash if the object is in edit mode.
A crash does not occur if a color type attribute is added manually from the Attributes panel

Exact steps for others to reproduce the error
Based on the default startup file:

enter edit mode on the cube
try adding a color attribute
crash

blender_2022-06-08_16-58-25.mp4

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: 3.1 Caused by 3d5f5c2d9a **Short description of error** Adding a color attribute to a mesh from the Color Attribute panel causes a crash if the object is in edit mode. A crash does not occur if a color type attribute is added manually from the Attributes panel **Exact steps for others to reproduce the error** Based on the default startup file: 1. enter edit mode on the cube 2. try adding a color attribute 3. crash [blender_2022-06-08_16-58-25.mp4](https://archive.blender.org/developer/F13138594/blender_2022-06-08_16-58-25.mp4)

Dvorakir commented

2022-06-08 17:00:37 +02:00

Added subscriber: @Dvorakir

blender-admin commented

2022-06-08 17:00:37 +02:00

#99160 was marked as duplicate of this issue

blender-admin commented

2022-06-08 17:00:37 +02:00

#98819 was marked as duplicate of this issue

Richard Antalik commented

2022-06-08 20:18:49 +02:00

Added subscriber: @iss

Richard Antalik commented

2022-06-08 20:18:49 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-06-08 20:18:49 +02:00

Can confirm, in debug build this triggers assert BLI_assert(me->edit_mesh == nullptr);

 	blender.exe!_BLI_assert_abort() Řádek 47	C
>	blender.exe!ED_mesh_color_ensure(Mesh * me, const char * name) Řádek 430	C++

 	blender.exe!vertex_color_set<blender::ColorSceneLinear4f<0>,blender::color::FloatTraits,0>(Object * ob, blender::ColorSceneLinear4f<0> paintcol_in, blender::ColorSceneLinear4f<0> * color_layer) Řádek 4104	C++
 	blender.exe!paint_object_attributes_active_color_fill_ex(Object * ob, blender::ColorSceneLinear4f<0> fill_color, bool only_selected) Řádek 4172	C++
 	blender.exe!BKE_object_attributes_active_color_fill(Object * ob, const float * fill_color, bool only_selected) Řádek 4200	C++
 	blender.exe!blender::ed::geometry::geometry_color_attribute_add_exec(bContext * C, wmOperator * op) Řádek 241	C++
 	blender.exe!wm_operator_exec(bContext * C, wmOperator * op, const bool repeat, const bool store) Řádek 1099	C++
 	blender.exe!WM_operator_call_ex(bContext * C, wmOperator * op, bool store) Řádek 1147	C++
 	blender.exe!dialog_exec_cb(bContext * C, void * arg1, void * arg2) Řádek 1427	C
 	blender.exe!ui_apply_but_funcs_after(bContext * C) Řádek 1038	C
 	blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Řádek 11522	C
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Řádek 732	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Řádek 3166	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Řádek 3285	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Řádek 3878	C++
 	blender.exe!WM_main(bContext * C) Řádek 626	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Řádek 551	C
 	[Externí kód]

Can confirm, in debug build this triggers assert `BLI_assert(me->edit_mesh == nullptr);` ``` blender.exe!_BLI_assert_abort() Řádek 47 C > blender.exe!ED_mesh_color_ensure(Mesh * me, const char * name) Řádek 430 C++ blender.exe!vertex_color_set<blender::ColorSceneLinear4f<0>,blender::color::FloatTraits,0>(Object * ob, blender::ColorSceneLinear4f<0> paintcol_in, blender::ColorSceneLinear4f<0> * color_layer) Řádek 4104 C++ blender.exe!paint_object_attributes_active_color_fill_ex(Object * ob, blender::ColorSceneLinear4f<0> fill_color, bool only_selected) Řádek 4172 C++ blender.exe!BKE_object_attributes_active_color_fill(Object * ob, const float * fill_color, bool only_selected) Řádek 4200 C++ blender.exe!blender::ed::geometry::geometry_color_attribute_add_exec(bContext * C, wmOperator * op) Řádek 241 C++ blender.exe!wm_operator_exec(bContext * C, wmOperator * op, const bool repeat, const bool store) Řádek 1099 C++ blender.exe!WM_operator_call_ex(bContext * C, wmOperator * op, bool store) Řádek 1147 C++ blender.exe!dialog_exec_cb(bContext * C, void * arg1, void * arg2) Řádek 1427 C blender.exe!ui_apply_but_funcs_after(bContext * C) Řádek 1038 C blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Řádek 11522 C blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Řádek 732 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Řádek 3166 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Řádek 3285 C++ blender.exe!wm_event_do_handlers(bContext * C) Řádek 3878 C++ blender.exe!WM_main(bContext * C) Řádek 626 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Řádek 551 C [Externí kód] ```

Philipp Oeser commented

2022-06-09 09:12:27 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2022-06-09 09:12:27 +02:00

Philipp Oeser commented

2022-06-09 09:12:27 +02:00

Will check

Philipp Oeser changed title from ~~Crash when adding color attribute in edit mode~~ to Regression: Crash when adding color attribute in edit mode

2022-06-09 10:11:24 +02:00

Jesse Yurkovich commented

2022-06-12 22:12:51 +02:00

Added subscriber: @beta-tester

Philipp Oeser removed their assignment 2022-06-23 18:31:12 +02:00

Philipp Oeser commented

2022-06-23 18:31:12 +02:00

I claimed this because I thought I had the fix already, turns out there might be a better way to do it.
Cannot tell if I can get a solution for 3.2.1, so will step down if others are quicker...

I claimed this because I thought I had the fix already, turns out there might be a better way to do it. Cannot tell if I can get a solution for 3.2.1, so will step down if others are quicker...

Evan Wilson commented

2022-06-25 07:09:22 +02:00

Added subscriber: @Shady.Hamza