Regression: Switching shading color type crashes blender (using the sculpting template) #98842

New Issue

Nelson · 2022-06-13T13:39:32+02:00

Nelson commented

2022-06-13 13:39:32 +02:00

System Information
Operating system: Windows 10

Blender Version
Broken: blender-3.3.0-alpha+master.c55dac9904d7-windows.amd64-release
Worked: 3.2 (Prior to 285a68b7bb?)

Short description of error
This is a follow up of #98784 (Sculpting template crash)
The initial crash was resolved, but it now crashes if I choose the Texture color type after choosing something else first.

Exact steps for others to reproduce the error
File/New/Sculpting
In the shading popover switch to a color type like "Single" for example
Then switch to "Texture"
Crash

blender_2022-06-13_06-34-41.mp4
And as @TheRedWaxPolice found out, it seems like switching back to material color type also crashes
blender.crash.txt

**System Information** Operating system: Windows 10 **Blender Version** Broken: blender-3.3.0-alpha+master.`c55dac9904d7`-windows.amd64-release Worked: 3.2 (Prior to 285a68b7bb?) **Short description of error** This is a follow up of #98784 (Sculpting template crash) The initial crash was resolved, but it now crashes if I choose the Texture color type after choosing something else first. **Exact steps for others to reproduce the error** File/New/Sculpting In the shading popover switch to a color type like "Single" for example Then switch to "Texture" Crash [blender_2022-06-13_06-34-41.mp4](https://archive.blender.org/developer/F13154301/blender_2022-06-13_06-34-41.mp4) And as @TheRedWaxPolice found out, it seems like switching back to material color type also crashes [blender.crash.txt](https://archive.blender.org/developer/F13154300/blender.crash.txt)

Nelson commented

2022-06-13 13:39:32 +02:00

Added subscribers: @TheRedWaxPolice, @NelsonNAS

Jesse Yurkovich commented

2022-06-13 19:38:25 +02:00

Added subscriber: @deadpin

Jesse Yurkovich commented

2022-06-13 19:38:25 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jesse Yurkovich commented

2022-06-13 19:38:25 +02:00

Looks like there's still issues for a variety of cases of switching back and forth between those shading types:

==52680==ERROR: AddressSanitizer: heap-use-after-free on address 0x124559f1c4f0 at pc 0x7ff7d566a026 bp 0x00f2c6ffdbc0 sp 0x00f2c6ffdbc8
WRITE of size 8 at 0x124559f1c4f0 thread T0
    - 0 0x7ff7d566a025 in GPU_batch_set_shader D:\source\blender-git\blender\source\blender\gpu\intern\gpu_batch.cc:214
    - 1 0x7ff7c732e1d1 in draw_geometry_bind D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:534
    - 2 0x7ff7c732e266 in draw_geometry_execute D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:557
    - 3 0x7ff7c73311f0 in draw_call_single_do D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:868
    - 4 0x7ff7c7332c15 in draw_shgroup D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:1040
    - 5 0x7ff7c73338d4 in drw_draw_pass_ex D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:1177
    - 6 0x7ff7c732c6fd in DRW_draw_pass D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:1217
    - 7 0x7ff7c745c82e in workbench_draw_sample D:\source\blender-git\blender\source\blender\draw\engines\workbench\workbench_engine.c:540
    - 8 0x7ff7c745f438 in workbench_draw_scene D:\source\blender-git\blender\source\blender\draw\engines\workbench\workbench_engine.c:615
    - 9 0x7ff7c72fc24d in drw_engines_draw_scene D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1092
    - 10 0x7ff7c72eb424 in DRW_draw_render_loop_ex D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1714
    - 11 0x7ff7c72e9f60 in DRW_draw_view D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1593
    #12 0x7ff7cb137ef1 in view3d_draw_view D:\source\blender-git\blender\source\blender\editors\space_view3d\view3d_draw.c:1540

0x124559f1c4f0 is located 176 bytes inside of 256-byte region [0x124559f1c440,0x124559f1c540)
freed by thread T0 here:
    - 0 0x7ffe23d105b2  (D:\source\blender-git\build-full-asan\bin\Debug\clang_rt.asan_dbg_dynamic-x86_64.dll+0x1800505b2)
    - 1 0x7ff7d60207f9 in MEM_lockfree_freeN D:\source\blender-git\blender\intern\guardedalloc\intern\mallocn_lockfree_impl.c:116
    - 2 0x7ff7d56745d1 in blender::gpu::GLBatch::operator delete(void *) D:\source\blender-git\blender\source\blender\gpu\opengl\gl_batch.hh:113
    - 3 0x7ff7d56749a6 in blender::gpu::GLBatch::`vector deleting dtor'(unsigned int) (D:\source\blender-git\build-full-asan\bin\Debug\blender.exe+0x1522549a6)
    - 4 0x7ff7d566951c in GPU_batch_discard D:\source\blender-git\blender\source\blender\gpu\intern\gpu_batch.cc:114
    - 5 0x7ff7d56641fb in gpu_pbvh_buffers_clear D:\source\blender-git\blender\source\blender\gpu\intern\gpu_buffers.c:1455
    - 6 0x7ff7d565fe26 in GPU_pbvh_buffers_free D:\source\blender-git\blender\source\blender\gpu\intern\gpu_buffers.c:1481
    - 7 0x7ff7c60aaf64 in pbvh_free_draw_buffers D:\source\blender-git\blender\source\blender\blenkernel\intern\pbvh.c:1389
    - 8 0x7ff7c60b6bdb in pbvh_update_draw_buffers D:\source\blender-git\blender\source\blender\blenkernel\intern\pbvh.c:1465
    - 9 0x7ff7c609c560 in BKE_pbvh_draw_cb D:\source\blender-git\blender\source\blender\blenkernel\intern\pbvh.c:2890
    - 10 0x7ff7c7325dd6 in drw_sculpt_generate_calls D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_data.c:1236
    - 11 0x7ff7c731a044 in DRW_shgroup_call_sculpt D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_data.c:1265
    - 12 0x7ff7c7564023 in OVERLAY_sculpt_cache_populate D:\source\blender-git\blender\source\blender\draw\engines\overlay\overlay_sculpt.c:56
    - 13 0x7ff7c7458310 in OVERLAY_cache_populate D:\source\blender-git\blender\source\blender\draw\engines\overlay\overlay_engine.c:429
    - 14 0x7ff7c72fbca8 in drw_engines_cache_populate D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1062
    - 15 0x7ff7c72eb296 in DRW_draw_render_loop_ex D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1683
    #16 0x7ff7c72e9f60 in DRW_draw_view D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1593

Looks like there's still issues for a variety of cases of switching back and forth between those shading types: ``` ==52680==ERROR: AddressSanitizer: heap-use-after-free on address 0x124559f1c4f0 at pc 0x7ff7d566a026 bp 0x00f2c6ffdbc0 sp 0x00f2c6ffdbc8 WRITE of size 8 at 0x124559f1c4f0 thread T0 - 0 0x7ff7d566a025 in GPU_batch_set_shader D:\source\blender-git\blender\source\blender\gpu\intern\gpu_batch.cc:214 - 1 0x7ff7c732e1d1 in draw_geometry_bind D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:534 - 2 0x7ff7c732e266 in draw_geometry_execute D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:557 - 3 0x7ff7c73311f0 in draw_call_single_do D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:868 - 4 0x7ff7c7332c15 in draw_shgroup D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:1040 - 5 0x7ff7c73338d4 in drw_draw_pass_ex D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:1177 - 6 0x7ff7c732c6fd in DRW_draw_pass D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_exec.c:1217 - 7 0x7ff7c745c82e in workbench_draw_sample D:\source\blender-git\blender\source\blender\draw\engines\workbench\workbench_engine.c:540 - 8 0x7ff7c745f438 in workbench_draw_scene D:\source\blender-git\blender\source\blender\draw\engines\workbench\workbench_engine.c:615 - 9 0x7ff7c72fc24d in drw_engines_draw_scene D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1092 - 10 0x7ff7c72eb424 in DRW_draw_render_loop_ex D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1714 - 11 0x7ff7c72e9f60 in DRW_draw_view D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1593 #12 0x7ff7cb137ef1 in view3d_draw_view D:\source\blender-git\blender\source\blender\editors\space_view3d\view3d_draw.c:1540 0x124559f1c4f0 is located 176 bytes inside of 256-byte region [0x124559f1c440,0x124559f1c540) freed by thread T0 here: - 0 0x7ffe23d105b2 (D:\source\blender-git\build-full-asan\bin\Debug\clang_rt.asan_dbg_dynamic-x86_64.dll+0x1800505b2) - 1 0x7ff7d60207f9 in MEM_lockfree_freeN D:\source\blender-git\blender\intern\guardedalloc\intern\mallocn_lockfree_impl.c:116 - 2 0x7ff7d56745d1 in blender::gpu::GLBatch::operator delete(void *) D:\source\blender-git\blender\source\blender\gpu\opengl\gl_batch.hh:113 - 3 0x7ff7d56749a6 in blender::gpu::GLBatch::`vector deleting dtor'(unsigned int) (D:\source\blender-git\build-full-asan\bin\Debug\blender.exe+0x1522549a6) - 4 0x7ff7d566951c in GPU_batch_discard D:\source\blender-git\blender\source\blender\gpu\intern\gpu_batch.cc:114 - 5 0x7ff7d56641fb in gpu_pbvh_buffers_clear D:\source\blender-git\blender\source\blender\gpu\intern\gpu_buffers.c:1455 - 6 0x7ff7d565fe26 in GPU_pbvh_buffers_free D:\source\blender-git\blender\source\blender\gpu\intern\gpu_buffers.c:1481 - 7 0x7ff7c60aaf64 in pbvh_free_draw_buffers D:\source\blender-git\blender\source\blender\blenkernel\intern\pbvh.c:1389 - 8 0x7ff7c60b6bdb in pbvh_update_draw_buffers D:\source\blender-git\blender\source\blender\blenkernel\intern\pbvh.c:1465 - 9 0x7ff7c609c560 in BKE_pbvh_draw_cb D:\source\blender-git\blender\source\blender\blenkernel\intern\pbvh.c:2890 - 10 0x7ff7c7325dd6 in drw_sculpt_generate_calls D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_data.c:1236 - 11 0x7ff7c731a044 in DRW_shgroup_call_sculpt D:\source\blender-git\blender\source\blender\draw\intern\draw_manager_data.c:1265 - 12 0x7ff7c7564023 in OVERLAY_sculpt_cache_populate D:\source\blender-git\blender\source\blender\draw\engines\overlay\overlay_sculpt.c:56 - 13 0x7ff7c7458310 in OVERLAY_cache_populate D:\source\blender-git\blender\source\blender\draw\engines\overlay\overlay_engine.c:429 - 14 0x7ff7c72fbca8 in drw_engines_cache_populate D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1062 - 15 0x7ff7c72eb296 in DRW_draw_render_loop_ex D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1683 #16 0x7ff7c72e9f60 in DRW_draw_view D:\source\blender-git\blender\source\blender\draw\intern\draw_manager.c:1593 ```

Nelson commented

2022-06-13 23:06:29 +02:00

wait, crashes are not high prio anymore?

Jesse Yurkovich commented

2022-06-14 02:03:09 +02:00

Will raise to High since this is a recent regression most likely related to the work done for 285a68b7bb

Will raise to High since this is a recent regression most likely related to the work done for 285a68b7bb

Pratik Borhade changed title from ~~Sculpt: Switching shading color type crashes blender (using the sculpting template)~~ to Regression: Switching shading color type crashes blender (using the sculpting template)

2022-06-14 08:07:08 +02:00

Pratik Borhade commented

2022-06-28 06:14:01 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-06-28 06:14:01 +02:00

In #98836#1381417, @deadpin wrote:
I'm no longer able to reproduce this issue or #98842 as well... these 2 issues must've been addressed as part of other changes.

@NelsonNAS hi, could you check again in fresh 3.3 build?: https://builder.blender.org/download/daily

> In #98836#1381417, @deadpin wrote: > I'm no longer able to reproduce this issue or #98842 as well... these 2 issues must've been addressed as part of other changes. @NelsonNAS hi, could you check again in fresh 3.3 build?: https://builder.blender.org/download/daily

Nelson commented

2022-06-28 08:35:03 +02:00

@PratikPB2123 Fixed. It's not crashing anymore. (blender-3.3.0-alpha+master.7a44f62bdb60-windows.amd64-release)

Pratik Borhade commented

2022-06-28 09:21:38 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Pratik Borhade closed this issue

2022-06-28 09:21:38 +02:00

Pratik Borhade self-assigned this 2022-06-28 09:21:38 +02:00

Pratik Borhade commented

2022-06-28 09:21:38 +02:00

@NelsonNAS, thanks, closing this report :)

Pratik Borhade removed their assignment 2022-06-28 09:21:45 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Switching shading color type crashes blender (using the sculpting template) #98842