Regression: Geometry nodes: Object info does not care if referenced obejcts subdivision surface modifier is disabled #99058

New Issue

D0ppelgaenger · 2022-06-21T16:31:21+02:00

D0ppelgaenger commented

2022-06-21 16:31:21 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.95

Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-06-20 22:42, hash: a18c291435
Worked: 3.2.0

Caused by ca9d65cc97

Short description of error
As in Title
I might be misunderstanding things, but it seems to be the inverse of https://developer.blender.org/T96264
However, this doesn't seem to be linked to GPU subdivision, since it is also the case if GPU subdivision is disabled, and/or the subdiv is not the last modifier int eh stack (which should also disable it)
Obejct info.mp4

Exact steps for others to reproduce the error
Ensure GPU subdivision is disabled
Add two objects
Add a subdivision surface modifier to one of the objects and disable it
Add a geometry nodes modifier to the other object
Add an object info node to the GN tree and reference to other obejct
Plug the geometry output of the obejct info into the node tree output
Enable/disable subdiv modifier - It should work correctly
Enable GPU subdivision
Enable/disable subdiv modifier - The object created via GN does not care if the original object's modifier is disabled and will always reference it with it enabled

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.95 **Blender Version** Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-06-20 22:42, hash: `a18c291435` Worked: 3.2.0 Caused by ca9d65cc97 **Short description of error** As in Title I might be misunderstanding things, but it seems to be the inverse of https://developer.blender.org/T96264 However, this doesn't seem to be linked to GPU subdivision, since it is also the case if GPU subdivision is disabled, and/or the subdiv is not the last modifier int eh stack (which should also disable it) [Obejct info.mp4](https://archive.blender.org/developer/F13212492/Obejct_info.mp4) **Exact steps for others to reproduce the error** Ensure GPU subdivision is disabled Add two objects Add a subdivision surface modifier to one of the objects and disable it Add a geometry nodes modifier to the other object Add an object info node to the GN tree and reference to other obejct Plug the geometry output of the obejct info into the node tree output Enable/disable subdiv modifier - It should work correctly Enable GPU subdivision Enable/disable subdiv modifier - The object created via GN does not care if the original object's modifier is disabled and will always reference it with it enabled

D0ppelgaenger commented

2022-06-21 16:31:21 +02:00

Added subscriber: @Leo-Luther

Richard Antalik commented

2022-06-21 22:18:11 +02:00

Added subscribers: @kevindietrich, @iss

Richard Antalik commented

2022-06-21 22:18:11 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-06-21 22:18:12 +02:00

This actually is working correctly here until the moment GPU subdivision is enabled. Then it does not work even if it is disabled.

CC @kevindietrich

This actually is working correctly here until the moment GPU subdivision is enabled. Then it does not work even if it is disabled. CC @kevindietrich

Jacques Lucke commented

2022-06-23 12:47:05 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2022-06-23 12:47:05 +02:00

I'm also running into this issue right now. Looks like the issue is that me->runtime.mesh_eval and me->runtime.wrapper_type are set in mesh_wrapper_ensure_subdivision, but are never unset when the modifier is disabled or the subdivision level is set to zero.

File to reproduce the issue:
subdivision_update_bug.blend

Just disable the Subdivision modifier and see that the other object does not change.
It does work when reloading the file with the modifier being disabled.

I'm also running into this issue right now. Looks like the issue is that `me->runtime.mesh_eval` and `me->runtime.wrapper_type` are set in `mesh_wrapper_ensure_subdivision`, but are never unset when the modifier is disabled or the subdivision level is set to zero. File to reproduce the issue: [subdivision_update_bug.blend](https://archive.blender.org/developer/F13220456/subdivision_update_bug.blend) Just disable the Subdivision modifier and see that the other object does not change. It does work when reloading the file with the modifier being disabled.

Kévin Dietrich commented

2022-06-23 12:57:49 +02:00

A subdivision level of 0 will effectively disable the modifier. I guess a fix could be to unset/delete the runtime subdivision data before executing the modifier stack, if no subsurf modifier is enabled.

Jacques Lucke commented

2022-06-23 13:04:46 +02:00

Yes that sounds reasonable. Can you look into that?

Kévin Dietrich commented

2022-06-23 13:10:37 +02:00

I can look into it, yes.

Philipp Oeser commented

2022-06-24 18:53:34 +02:00

Added subscribers: @brecht, @lichtwerk

Philipp Oeser commented

2022-06-24 18:53:34 +02:00

Caused by ca9d65cc97

CC @brecht

Caused by ca9d65cc97 CC @brecht

Philipp Oeser changed title from ~~Geometry nodes: Object info does not care if referenced obejcts subdivision surface modifier is disabled~~ to Regression: Geometry nodes: Object info does not care if referenced obejcts subdivision surface modifier is disabled

2022-06-24 18:53:56 +02:00

blender-admin commented

2022-06-24 19:03:05 +02:00

This issue was referenced by 0357dbf148

This issue was referenced by 0357dbf148dcbfcf6c35a5e9e34cdfa272dc7a98

blender-admin commented

2022-06-24 19:03:05 +02:00

This issue was referenced by 35da733e6b

This issue was referenced by 35da733e6b87d96a1cf319b7b5328e6031d6931f

Brecht Van Lommel commented

2022-06-24 20:01:40 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2022-06-24 20:01:40 +02:00

Brecht Van Lommel self-assigned this 2022-06-24 20:01:40 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Geometry nodes: Object info does not care if referenced obejcts subdivision surface modifier is disabled #99058