Some settings and themes makes date in file browser to be ended by ellipsis. #99207

New Issue

Michael Soluyanov · 2022-06-27T15:15:57+02:00

Michael Soluyanov commented

2022-06-27 15:15:57 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: (newest version of Blender that worked as expected)

Short description of error
Some settings and themes makes date in file browser to be ended by ellipsis.

Exact steps for others to reproduce the error
Set theme to "modo", open file browser:

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: (newest version of Blender that worked as expected) **Short description of error** Some settings and themes makes date in file browser to be ended by ellipsis. **Exact steps for others to reproduce the error** Set theme to "modo", open file browser: ![image.png](https://archive.blender.org/developer/F13232556/image.png)

Michael Soluyanov commented

2022-06-27 15:15:57 +02:00

Added subscriber: @crantisz

SHnJ commented

2022-06-27 15:24:49 +02:00

Added subscriber: @SUNGHOON-JEONG

SHnJ commented

2022-06-27 15:24:49 +02:00

There may be other factors that determine the size of the text. But I noticed that the Modo theme changes the Widget Points value in the Text Style panel. Other themes default to 11, but the Modo theme is 10. If you change this value to 11, the contents of the Date Modified column are not omitted.
If Widget Points are the main cause of this problem, it may be a good idea to set the default value for Widget Points in the Modo theme to 11 as in other themes so that it becomes the default behavior of Blender.

There may be other factors that determine the size of the text. But I noticed that the Modo theme changes the Widget Points value in the Text Style panel. Other themes default to 11, but the Modo theme is 10. If you change this value to 11, the contents of the Date Modified column are not omitted. If Widget Points are the main cause of this problem, it may be a good idea to set the default value for Widget Points in the Modo theme to 11 as in other themes so that it becomes the default behavior of Blender. ![image.png](https://archive.blender.org/developer/F13232566/image.png) ![image.png](https://archive.blender.org/developer/F13232569/image.png)

Julian Eisel commented

2022-06-27 16:00:39 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2022-06-27 16:00:41 +02:00

Can be fixed with this:

diff --git a/source/blender/editors/space_file/filesel.c b/source/blender/editors/space_file/filesel.c
index e42e1e98660..4fdde7a63fe 100644
--- a/source/blender/editors/space_file/filesel.c
+++ b/source/blender/editors/space_file/filesel.c
@@ -890,8 +890,8 @@ FileAttributeColumnType file_attribute_column_type_find_isect(const View2D *v2d,
 float file_string_width(const char *str)
 {
   const uiStyle *style = UI_style_get();
-  UI_fontstyle_set(&style->widget);
-  return BLF_width(style->widget.uifont_id, str, BLF_DRAW_STR_DUMMY_MAX);
+  UI_fontstyle_set(&style->widgetlabel);
+  return BLF_width(style->widgetlabel.uifont_id, str, BLF_DRAW_STR_DUMMY_MAX);
 }
 
 float file_font_pointsize(void)
@@ -905,8 +905,8 @@ float file_font_pointsize(void)
   return style->widget.points;
 #else
   const uiStyle *style = UI_style_get();
-  UI_fontstyle_set(&style->widget);
-  return style->widget.points * UI_DPI_FAC;
+  UI_fontstyle_set(&style->widgetlabel);
+  return style->widgetlabel.points * UI_DPI_FAC;
 #endif
 }

However I'm wondering if it makes sense even for the File Browser text to use the Widget Label font style. I'd suggest using the Widget font style instead:

diff --git a/source/blender/editors/space_file/file_draw.c b/source/blender/editors/space_file/file_draw.c
index 0e2b98ca349..f3359336b14 100644
--- a/source/blender/editors/space_file/file_draw.c
+++ b/source/blender/editors/space_file/file_draw.c
@@ -202,7 +202,7 @@ static void file_draw_string(int sx,
   }
 
   const uiStyle *style = UI_style_get();
-  fs = style->widgetlabel;
+  fs = style->widget;
 
   BLI_strncpy(fname, string, FILE_MAXFILE);
   UI_text_clip_middle_ex(&fs, fname, width, UI_DPI_ICON_SIZE, sizeof(fname), '\0');
@@ -245,7 +245,7 @@ static void file_draw_string_multiline(int sx,
   }
 
   const uiStyle *style = UI_style_get();
-  int font_id = style->widgetlabel.uifont_id;
+  int font_id = style->widget.uifont_id;
   int len = strlen(string);
 
   rcti textbox;

@pablovazquez any opinion on what font style to use for the text in the File Browser? Widget Label or Widget?

Can be fixed with this: ```lines=10 diff --git a/source/blender/editors/space_file/filesel.c b/source/blender/editors/space_file/filesel.c index e42e1e98660..4fdde7a63fe 100644 --- a/source/blender/editors/space_file/filesel.c +++ b/source/blender/editors/space_file/filesel.c @@ -890,8 +890,8 @@ FileAttributeColumnType file_attribute_column_type_find_isect(const View2D *v2d, float file_string_width(const char *str) { const uiStyle *style = UI_style_get(); - UI_fontstyle_set(&style->widget); - return BLF_width(style->widget.uifont_id, str, BLF_DRAW_STR_DUMMY_MAX); + UI_fontstyle_set(&style->widgetlabel); + return BLF_width(style->widgetlabel.uifont_id, str, BLF_DRAW_STR_DUMMY_MAX); } float file_font_pointsize(void) @@ -905,8 +905,8 @@ float file_font_pointsize(void) return style->widget.points; #else const uiStyle *style = UI_style_get(); - UI_fontstyle_set(&style->widget); - return style->widget.points * UI_DPI_FAC; + UI_fontstyle_set(&style->widgetlabel); + return style->widgetlabel.points * UI_DPI_FAC; #endif } ``` However I'm wondering if it makes sense even for the File Browser text to use the *Widget Label* font style. I'd suggest using the *Widget* font style instead: ```lines=10 diff --git a/source/blender/editors/space_file/file_draw.c b/source/blender/editors/space_file/file_draw.c index 0e2b98ca349..f3359336b14 100644 --- a/source/blender/editors/space_file/file_draw.c +++ b/source/blender/editors/space_file/file_draw.c @@ -202,7 +202,7 @@ static void file_draw_string(int sx, } const uiStyle *style = UI_style_get(); - fs = style->widgetlabel; + fs = style->widget; BLI_strncpy(fname, string, FILE_MAXFILE); UI_text_clip_middle_ex(&fs, fname, width, UI_DPI_ICON_SIZE, sizeof(fname), '\0'); @@ -245,7 +245,7 @@ static void file_draw_string_multiline(int sx, } const uiStyle *style = UI_style_get(); - int font_id = style->widgetlabel.uifont_id; + int font_id = style->widget.uifont_id; int len = strlen(string); rcti textbox; ``` @pablovazquez any opinion on what font style to use for the text in the File Browser? *Widget Label* or *Widget*?

Julian Eisel commented

2022-06-27 16:03:53 +02:00

Added subscriber: @pablovazquez