Fillet curve node's limit radius mode is too often problematic #99232

New Issue

Zhen Dai · 2022-06-28T11:05:59+02:00

Zhen Dai commented

2022-06-28 11:05:59 +02:00

System Information
Operating system: Windows-10-10.0.18363-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: N/A

Short description of error

One problem with Fillet Curve node is its Limit Radius mode, which is very prone to create strange curves when users don't make use of the count field.
The count field however is only available in Poly mode, making the Bezier mode basically unusable for any large radius.
I argue Fillet Curve should ignore curve point with 180 curve angle by default.

Exact steps for others to reproduce the error

Download attached blend file;
Notice the fillet curve is probably not what the user want, with or without limit radius mode;
The only solution, is to put fillet curve under poly mode, and then use count field to filter points where curve angle isn't 180 (with dot product; this is do-able in GN but non-trivial for new users if they want to handle cyclic + multi splines).

fillet-behaviour.blend

**System Information** Operating system: Windows-10-10.0.18363-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: N/A **Short description of error** - One problem with Fillet Curve node is its Limit Radius mode, which is very prone to create strange curves when users don't make use of the count field. - The count field however is only available in Poly mode, making the Bezier mode basically unusable for any large radius. - I argue Fillet Curve should ignore curve point with 180 curve angle by default. ![Screenshot 2022-06-28 165629.jpg](https://archive.blender.org/developer/F13234195/Screenshot_2022-06-28_165629.jpg) ![Screenshot 2022-06-28 165624.jpg](https://archive.blender.org/developer/F13234194/Screenshot_2022-06-28_165624.jpg) **Exact steps for others to reproduce the error** - Download attached blend file; - Notice the fillet curve is probably not what the user want, with or without limit radius mode; - The only solution, is to put fillet curve under poly mode, and then use count field to filter points where curve angle isn't 180 (with dot product; this is do-able in GN but non-trivial for new users if they want to handle cyclic + multi splines). [fillet-behaviour.blend](https://archive.blender.org/developer/F13234189/fillet-behaviour.blend)

Zhen Dai commented

2022-06-28 11:05:59 +02:00

Added subscriber: @Zhen-Dai

Zhen Dai commented

2022-06-28 11:14:45 +02:00

Poly mode issue might be easier to overcome for users, if curvature node is merged: https://developer.blender.org/D12550

But Bezier mode would still be unusable.

Poly mode issue might be easier to overcome for users, if curvature node is merged: https://developer.blender.org/D12550 But Bezier mode would still be unusable.

Zhen Dai commented

2022-06-28 13:13:27 +02:00

just to show what i want by default (already do-able in poly mode).

just to show what i want by default (already do-able in poly mode). ![Screenshot 2022-06-28 190600.jpg](https://archive.blender.org/developer/F13234423/Screenshot_2022-06-28_190600.jpg)

Germano Cavalcante commented

2022-06-29 16:36:54 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-06-29 16:36:54 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Germano Cavalcante commented

2022-06-29 16:36:54 +02:00

I can confirm the weirdness of the Fillet Curve when the curve makes some angles, but it is possible that this is more of a limitation of the algorithm than an actual bug.

Jacques Lucke commented

2022-07-26 12:47:17 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2022-07-26 12:47:17 +02:00

Seems to be fixed in latest master (likely due to 2551cf9087).
Can you confirm that?

Seems to be fixed in latest master (likely due to 2551cf9087). Can you confirm that?

Hans Goudey commented

2022-07-27 19:57:40 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2022-07-27 19:57:40 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Hans Goudey closed this issue

2022-07-27 19:57:40 +02:00

Hans Goudey self-assigned this 2022-07-27 19:57:40 +02:00

Hans Goudey commented

2022-07-27 19:57:40 +02:00

The bug part of this report is fixed by default. For the others I'm not quite sure.

There is no "count" option on Bezier mode because it's easy to make curves with a crazy amount of evaluated points. But you're right that it doesn't work as well for very large curves, at least not until we can choose a segment resolution (the subdivide node might help?)
For ignoring points between parallel segments, I agree it would be helpful, but maybe a good first step would be adding a point selection input to the node.
The node could also merge points that meet because of the limit radius option.

I made two TODO tasks: #100032 and #100031

The bug part of this report is fixed by default. For the others I'm not quite sure. There is no "count" option on Bezier mode because it's easy to make curves with a crazy amount of evaluated points. But you're right that it doesn't work as well for very large curves, at least not until we can choose a segment resolution (the subdivide node might help?) For ignoring points between parallel segments, I agree it would be helpful, but maybe a good first step would be adding a point selection input to the node. The node could also merge points that meet because of the limit radius option. I made two TODO tasks: #100032 and #100031

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fillet curve node's limit radius mode is too often problematic #99232