Regression: location override ignored when used in a shadertree (Texture Coordinates node, object coordinates) #99272

Closed
opened 2022-06-29 16:24:08 +02:00 by Emre Jamie · 18 comments

System Information
Operating system: Windows 11
Graphics card: RTX 2060 mobile

Blender Version
Broken: 3.2.0, Caused by {1695d38989fd482d3c010dc9ba4b0cb8e07a7139}
Worked: 3.1.2

It seems the location override does not ripple down into the usage of the location in the Texture Coordinate object coordinates.
Its coordinates are fine in the 3DView though.

Here is a simplified example:
#99272.zip

  • lib.blend with an empty that controls a gradient position on a plane via Texture Coordinate object coordinates
  • main_override.blend with the collection from lib.blend linked, and the location of the empty overriden.
  • this first works, but when saved and reloaded, the override seems to get ignored

expected:
image.png
observed:
image.png

Original report

The shading setup made in 3.1.2 yields an unexpected result in 3.2.0 and higher.
3.2.0_Result
3.2.0_Result.png
3.2.1_Release_Candidate
3.2.1_Release_Candidate.png
3.1.2_CORRECT_VERSION
3.1.2_CORRECT_VERSION.png
Exact steps for others to reproduce the error

  1. Open "PROJECT" folder > "SCENES" > "WIP" > "TrainStation_Render_Scene_01_Instance.blend" in 3.1.2
  2. At the same time open "PROJECT" folder > "SCENES" > "WIP" > "TrainStation_Render_Scene_01_Instance.blend" in 3.2.0 or higher
  3. Compare the rendered result in "Eevee"

PROJECT.zip

**System Information** Operating system: Windows 11 Graphics card: RTX 2060 mobile **Blender Version** Broken: 3.2.0, Caused by {1695d38989fd482d3c010dc9ba4b0cb8e07a7139} Worked: 3.1.2 It seems the location override does not ripple down into the usage of the location in the `Texture Coordinate` object coordinates. Its coordinates are fine in the 3DView though. Here is a simplified example: [#99272.zip](https://archive.blender.org/developer/F13243698/T99272.zip) - `lib.blend` with an empty that controls a gradient position on a plane via `Texture Coordinate` object coordinates - `main_override.blend` with the collection from `lib.blend` linked, and the location of the empty overriden. - this first works, but when saved and reloaded, the override seems to get ignored expected: ![image.png](https://archive.blender.org/developer/F13243713/image.png) observed: ![image.png](https://archive.blender.org/developer/F13243709/image.png) **Original report** The shading setup made in 3.1.2 yields an unexpected result in 3.2.0 and higher. 3.2.0_Result ![3.2.0_Result.png](https://archive.blender.org/developer/F13238285/3.2.0_Result.png) 3.2.1_Release_Candidate ![3.2.1_Release_Candidate.png](https://archive.blender.org/developer/F13238284/3.2.1_Release_Candidate.png) 3.1.2_CORRECT_VERSION ![3.1.2_CORRECT_VERSION.png](https://archive.blender.org/developer/F13238283/3.1.2_CORRECT_VERSION.png) **Exact steps for others to reproduce the error** 1. Open "PROJECT" folder > "SCENES" > "WIP" > "TrainStation_Render_Scene_01_Instance.blend" in 3.1.2 2. At the same time open "PROJECT" folder > "SCENES" > "WIP" > "TrainStation_Render_Scene_01_Instance.blend" in 3.2.0 or higher 3. Compare the rendered result in "Eevee" [PROJECT.zip](https://archive.blender.org/developer/F13238271/PROJECT.zip)
Author

Added subscriber: @Jalmaries

Added subscriber: @Jalmaries

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

I can confirm the problem.
Apparently the nodes in the linked material that return the position of Empties are not returning the correct position.

Certainly the file can be simplified further (I tried but for some reason the objects returned after reloading the file).

I'm investigating to find where the problem was introduced.

I can confirm the problem. Apparently the nodes in the linked material that return the position of Empties are not returning the correct position. Certainly the file can be simplified further (I tried but for some reason the objects returned after reloading the file). I'm investigating to find where the problem was introduced.

Added subscriber: @mont29

Added subscriber: @mont29

{1695d38989fd482d3c010dc9ba4b0cb8e07a7139} is the first bad commit
Author: @mont29

{1695d38989fd482d3c010dc9ba4b0cb8e07a7139} is the first bad commit Author: @mont29
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

OK, it seems the location override does not ripple down into the usage of the location in the Texture Coordinate object coordinates.
Its coordinates are fine in the 3DView though.

Here is a simplified example:
#99272.zip

  • lib.blend with an empty that controls a gradient position on a plane via Texture Coordinate object coordinates
  • main_override.blend with the collection from lib.blend linked, and the location of the empty overriden.
  • this first works, but when saved and reloaded, the override seems to get ignored
OK, it seems the location override does not ripple down into the usage of the location in the `Texture Coordinate` object coordinates. Its coordinates are fine in the 3DView though. Here is a simplified example: [#99272.zip](https://archive.blender.org/developer/F13243698/T99272.zip) - `lib.blend` with an empty that controls a gradient position on a plane via `Texture Coordinate` object coordinates - `main_override.blend` with the collection from `lib.blend` linked, and the location of the empty overriden. - this first works, but when saved and reloaded, the override seems to get ignored
Philipp Oeser changed title from Errors after updating from 3.1.2 to 3.2.0 to Regression: location override ignored when used in a shadertree (Texture Coordinates node, object coordinates) 2022-06-30 21:40:18 +02:00

This issue was referenced by 7f24d90f11

This issue was referenced by 7f24d90f11a6d26b2737bf28df1c66d169e7e8c2

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Bastien Montagne self-assigned this 2022-07-05 12:59:36 +02:00

Added subscriber: @noc2

Added subscriber: @noc2

You guys marked this as "Fixed" yet the bug persists. What gives???????

image.png

EDIT: Just found out now that the shader tree setup in the source library works as expected only if it is linked to the main scene from scratch and the scene file is saved. Yet, the result is as before when the original scene file is opened in 3.2.1 So, the whole scene needs to be assembled from scratch in this case??

You guys marked this as "Fixed" yet the bug persists. What gives??????? ![image.png](https://archive.blender.org/developer/F13262798/image.png) EDIT: Just found out now that the shader tree setup in the source library works as expected only if it is linked to the main scene from scratch and the scene file is saved. Yet, the result is as before when the original scene file is opened in 3.2.1 So, the whole scene needs to be assembled from scratch in this case??
Author

This comment was removed by @Jalmaries

*This comment was removed by @Jalmaries*
Author

Tested the scene on 3.2.1 and the bug is still there. Did you actually test your bug fix on the scene that I sent you before marking the bug report as fixed? Any hope linking will be fixed on this version or will we have to wait for 3.3 and higher to be able to use library linking in production work.
EDIT: The problem occurs while upgrading version, linking from start in 3.2.1 works fine. While tresspassing in versions document corrupts.

Tested the scene on 3.2.1 and the bug is still there. Did you actually test your bug fix on the scene that I sent you before marking the bug report as fixed? Any hope linking will be fixed on this version or will we have to wait for 3.3 and higher to be able to use library linking in production work. EDIT: The problem occurs while upgrading version, linking from start in 3.2.1 works fine. While tresspassing in versions document corrupts.
Member

Added subscriber: @LazyDodo

Added subscriber: @LazyDodo
Member

Bug is currently only fixed in master, you'd have to download a nightly 3.3 build from builder.blender.org to test it.

Bug is currently only fixed in master, you'd have to download a nightly 3.3 build from builder.blender.org to test it.

In #99272#1386390, @LazyDodo wrote:
Bug is currently only fixed in master, you'd have to download a nightly 3.3 build from builder.blender.org to test it.

So this didn't actually make it into 3.2.1??? What's the point of having a bug fix release if such crucial bugs are fixed solely toward a main release? You guys came up saying that 3.2's file referencing was improved. Here's a really crucial bug with file linking and it only makes it into master. I'm stumped... :( :( :(

> In #99272#1386390, @LazyDodo wrote: > Bug is currently only fixed in master, you'd have to download a nightly 3.3 build from builder.blender.org to test it. So this didn't actually make it into 3.2.1??? What's the point of having a bug fix release if such crucial bugs are fixed solely toward a main release? You guys came up saying that 3.2's file referencing was improved. Here's a really crucial bug with file linking and it only makes it into master. I'm stumped... :( :( :(
  • This is not a trivial fix, and as such would be risky for a hotfix release (chances of it triggering another issue are not neglectable, and there would have been so to speak no test of it).
  • This only worked in 3.1 by chance/mistake/because of other bug. The actual issue has been in code since the origin (since some needed piece was not implemented).

Also as a reminder, overrides of materials remain dodgy at best, and is not officially supported so far.

- This is not a trivial fix, and as such would be risky for a hotfix release (chances of it triggering another issue are not neglectable, and there would have been so to speak no test of it). - This only worked in 3.1 by chance/mistake/because of other bug. The actual issue has been in code since the origin (since some needed piece was not implemented). Also as a reminder, overrides of materials remain dodgy at best, and is not officially supported so far.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#99272
No description provided.