Animated Holdout & Shadow do not update in Cycles #99450

New Issue

Travis · 2022-07-05T00:55:36+02:00

Travis commented

2022-07-05 00:55:36 +02:00

Animated holdout and shadow catcher properties do not update when rendering in Cycles. Change frames in the following file, the holdout state of the object should change but will not until the user manually changes any property in the object.

animatedHoldout.blend

Original Report

System Information
Operating system: MacOS Monterey
Graphics card: Apple M1 Max

Blender Version
3.2 - (also tried 3 & 2.9)

Short description of error
I'm rendering a product shot for a client that wants the shadows as a seperate file. I animated 2 frames in my blender file. Frame one is the product and the "ground plane" is set as holdout. Frame 2 has the product as holdout and the ground plane as a shadow catcher. The reason i've set it up animated is the output files are HUGE resolution and i'm rendering it all on blendergrid.

This solution worked until a couple of months ago I upgraded to a M1 macbook pro and now the animations don't work - they don't even preview properly in blender. Sometimes the ground plane is visible despite it being set as either holdout or shadow catcher. The products sometimes holdouts when it should appear and sometimes it stays the same for both frames. I've tested it on blendergrid with a small output - it seemed to replicate the problem.
I also tried on 2 older versions of blender and re-animated the holdout / shadow catcher setting to no avail.

MMMilk_Endorphone_cards_170x170.blend
Exact steps for others to reproduce the error
attached .blend file (as simple as possible).

Animated holdout and shadow catcher properties do not update when rendering in Cycles. Change frames in the following file, the holdout state of the object should change but will not until the user manually changes any property in the object. [animatedHoldout.blend](https://archive.blender.org/developer/F13265355/animatedHoldout.blend) ### Original Report **System Information** Operating system: MacOS Monterey Graphics card: Apple M1 Max **Blender Version** 3.2 - (also tried 3 & 2.9) **Short description of error** I'm rendering a product shot for a client that wants the shadows as a seperate file. I animated 2 frames in my blender file. Frame one is the product and the "ground plane" is set as holdout. Frame 2 has the product as holdout and the ground plane as a shadow catcher. The reason i've set it up animated is the output files are HUGE resolution and i'm rendering it all on blendergrid. This solution worked until a couple of months ago I upgraded to a M1 macbook pro and now the animations don't work - they don't even preview properly in blender. Sometimes the ground plane is visible despite it being set as either holdout or shadow catcher. The products sometimes holdouts when it should appear and sometimes it stays the same for both frames. I've tested it on blendergrid with a small output - it seemed to replicate the problem. I also tried on 2 older versions of blender and re-animated the holdout / shadow catcher setting to no avail. [MMMilk_Endorphone_cards_170x170.blend](https://archive.blender.org/developer/F13259412/MMMilk_Endorphone_cards_170x170.blend) **Exact steps for others to reproduce the error** attached .blend file (as simple as possible).

Travis commented

2022-07-05 00:55:36 +02:00

Added subscriber: @MMMilk

Travis commented

2022-07-05 01:12:51 +02:00

....seems to work in 2.92.
no luck with other versions though

....seems to work in 2.92. no luck with other versions though

Omar Emara commented

2022-07-05 09:28:36 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-07-05 09:28:36 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Omar Emara commented

2022-07-05 09:28:36 +02:00

In the attached file, the RNA paths of the animation are set to cycles.is_shadow_catcher and cycles.is_holdout, and it seems the API changed and the properties are now part of the ID directly, so you should remove the cycles. prefix from the path in order for the animation to work again. That might indicate that versioning does not exist for this change.

In the attached file, the RNA paths of the animation are set to `cycles.is_shadow_catcher` and `cycles.is_holdout`, and it seems the API changed and the properties are now part of the ID directly, so you should remove the `cycles.` prefix from the path in order for the animation to work again. That might indicate that versioning does not exist for this change.

Omar Emara commented

2022-07-05 09:30:30 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Omar Emara commented

2022-07-05 09:30:30 +02:00

Looks like versioning for animations is not available indeed.

Omar Emara commented

2022-07-05 09:33:40 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Omar Emara commented

2022-07-05 09:33:40 +02:00

But you say this also happens in 2.9, so there might be an issue other than versioning here.

Travis commented

2022-07-06 07:13:37 +02:00

yes the original file didn't work past 2.92

I did also clear the animation keys in 3.2 and reanimated the holdout / shadow catcher check boxes and still had inconsistent results

yes the original file didn't work past 2.92 I did also clear the animation keys in 3.2 and reanimated the holdout / shadow catcher check boxes and still had inconsistent results

Omar Emara commented

2022-07-06 08:25:19 +02:00

Could you attach the files after you cleared and reanimated the animation keys? I did the same but can't seem to replicate the issue.

Travis commented

2022-07-07 13:43:44 +02:00

MMMilk__cards_170x170_b3.2_test.blend

[MMMilk__cards_170x170_b3.2_test.blend](https://archive.blender.org/developer/F13265269/MMMilk__cards_170x170_b3.2_test.blend) ![Screen Shot 2022-07-07 at 9.39.36 pm.png](https://archive.blender.org/developer/F13265271/Screen_Shot_2022-07-07_at_9.39.36_pm.png)

Omar Emara commented

2022-07-07 14:07:34 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Omar Emara changed title from ~~Animating Holdout & Shadow catcher not working (cycles)~~ to Animated Holdout & Shadow do not update in Cycles

2022-07-07 14:11:16 +02:00

Lukas Stockner commented

2022-08-22 01:14:43 +02:00

Added subscribers: @Sergey, @brecht, @LukasStockner

Lukas Stockner commented

2022-08-22 01:14:43 +02:00

The problem here appears to be that the Holdout control is handled through the view layer system - to be precise, layer_collection_objects_sync. This gets called from the RNA update handler of the holdout property, but that doesn't get called for animated properties on frame change of course.

I guess a simple fix would be to call BKE_layer_collection_sync before rendering? That seems like a hack though, I feel like there should be a cleaner way to handle this update.

cc @brecht and @sergey.

The problem here appears to be that the Holdout control is handled through the view layer system - to be precise, `layer_collection_objects_sync`. This gets called from the RNA update handler of the holdout property, but that doesn't get called for animated properties on frame change of course. I guess a simple fix would be to call `BKE_layer_collection_sync` before rendering? That seems like a hack though, I feel like there should be a cleaner way to handle this update. cc @brecht and @sergey.

Brecht Van Lommel commented

2022-08-22 16:14:07 +02:00

@LukasStockner I think we should remove handling of the object holdout settings from layer collection sync, and instead wrapper access to it in a function that checks both the base flag and the object flag.

At some point it would be good to integrate layer collection sync better with the depsgraph, but I wouldn't get into that for this bugfix.

@LukasStockner I think we should remove handling of the object holdout settings from layer collection sync, and instead wrapper access to it in a function that checks both the base flag and the object flag. At some point it would be good to integrate layer collection sync better with the depsgraph, but I wouldn't get into that for this bugfix.

Kamil commented

2022-10-07 15:44:29 +02:00

Added subscriber: @KamilD

Kamil commented

2022-10-07 15:44:29 +02:00

Hello.
I have the same issue with one of my scene.
holdout is not animated.
Is there any solution for it ? I really need this funkcionality.
probably I could use blender 2.92 but cycles is more faster in 3.3

Hello. I have the same issue with one of my scene. holdout is not animated. Is there any solution for it ? I really need this funkcionality. probably I could use blender 2.92 but cycles is more faster in 3.3

blender-admin commented

2022-10-15 22:51:21 +02:00

This issue was referenced by 1492f566c8

This issue was referenced by 1492f566c83c7c7a631ecc8b0c9113981fda75c5

blender-admin commented

2022-10-15 22:51:21 +02:00

This issue was referenced by b898330c37

This issue was referenced by b898330c3744669a8c3805f1560130821422cca1

Lukas Stockner commented

2022-10-15 23:12:52 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Lukas Stockner closed this issue