Assert hit when splitting video sequencer area horizontally #99641

New Issue

Pratik Borhade · 2022-07-12T15:23:27+02:00

Pratik Borhade commented

2022-07-12 15:23:27 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41

Blender Version
Broken: version: 3.3.0 Alpha, bb3a538843
Worked: unsure

Short description of error
Assert hit when splitting video sequencer area

Exact steps for others to reproduce the error

Open attached .blend
A horizontal split by dragging from any corner seems to always result in a crash: manual

seq-assert.blend

Call Stack:
 	ucrtbased.dll!00007ffdcfa77475()	Unknown
 	ucrtbased.dll!00007ffdcfa77613()	Unknown
 	ucrtbased.dll!00007ffdcfa8d86d()	Unknown
>	blender.exe!_BLI_assert_abort() Line 47	C

 	blender.exe!BLI_rctf_sanitize(rctf * rect) Line 446	C
 	blender.exe!BLI_rctf_init(rctf * rect, float xmin, float xmax, float ymin, float ymax) Line 415	C
 	blender.exe!label_rect_init(const SeqChannelDrawContext * context, const int channel_index, const float used_width) Line 224	C
 	blender.exe!draw_channel_labels(const SeqChannelDrawContext * context, uiBlock * block, const int channel_index, const float used_width) Line 233	C
 	blender.exe!draw_channel_header(const SeqChannelDrawContext * context, uiBlock * block, const int channel_index) Line 299	C
 	blender.exe!draw_channel_headers(const SeqChannelDrawContext * context) Line 313	C
 	blender.exe!draw_channels(const bContext * C, ARegion * region) Line 364	C
 	blender.exe!sequencer_channel_region_draw(const bContext * C, ARegion * region) Line 992	C
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 551	C
 	blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 945	C
 	blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 1114	C
 	blender.exe!wm_draw_update(bContext * C) Line 1339	C
 	blender.exe!WM_main(bContext * C) Line 638	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 551	C
 	[External Code]

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41 **Blender Version** Broken: version: 3.3.0 Alpha, bb3a53884394908ba34459c38d419e6c4abe6107 Worked: unsure **Short description of error** Assert hit when splitting video sequencer area **Exact steps for others to reproduce the error** - Open attached .blend - A horizontal split by dragging from any corner seems to always result in a crash: [manual ](https://docs.blender.org/manual/en/latest/interface/window_system/areas.html#splitting) [seq-assert.blend](https://archive.blender.org/developer/F13288823/seq-assert.blend) ```lines=18 Call Stack: ucrtbased.dll!00007ffdcfa77475() Unknown ucrtbased.dll!00007ffdcfa77613() Unknown ucrtbased.dll!00007ffdcfa8d86d() Unknown > blender.exe!_BLI_assert_abort() Line 47 C blender.exe!BLI_rctf_sanitize(rctf * rect) Line 446 C blender.exe!BLI_rctf_init(rctf * rect, float xmin, float xmax, float ymin, float ymax) Line 415 C blender.exe!label_rect_init(const SeqChannelDrawContext * context, const int channel_index, const float used_width) Line 224 C blender.exe!draw_channel_labels(const SeqChannelDrawContext * context, uiBlock * block, const int channel_index, const float used_width) Line 233 C blender.exe!draw_channel_header(const SeqChannelDrawContext * context, uiBlock * block, const int channel_index) Line 299 C blender.exe!draw_channel_headers(const SeqChannelDrawContext * context) Line 313 C blender.exe!draw_channels(const bContext * C, ARegion * region) Line 364 C blender.exe!sequencer_channel_region_draw(const bContext * C, ARegion * region) Line 992 C blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 551 C blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 945 C blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 1114 C blender.exe!wm_draw_update(bContext * C) Line 1339 C blender.exe!WM_main(bContext * C) Line 638 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 551 C [External Code] ```

Pratik Borhade commented

2022-07-12 15:23:27 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-07-13 14:29:45 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-07-14 03:35:55 +02:00

Added subscriber: @iss

Richard Antalik commented

2022-07-14 03:35:55 +02:00

I was not able to reproduce - is this reproducible every time for you?

Pratik Borhade commented

2022-07-14 04:58:48 +02:00

Changed status from 'Confirmed' to: 'Needs Triage'

Pratik Borhade commented

2022-07-14 04:58:48 +02:00

Yes, can repro it every time. I'll attach a screen recording (maybe that will help)

Richard Antalik commented

2022-07-14 08:16:06 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-07-14 08:16:06 +02:00

I was able to reproduce now, but I had to do a few attempts. So no need for recording.

Richard Antalik commented

2022-08-17 04:20:58 +02:00

@PratikPB2123 Can you still reproduce this? There have been some changes, but not sure if this could be resolved by them...

Siddhartha Jejurkar commented

2022-11-03 19:12:14 +01:00

Added subscriber: @sidd017

Siddhartha Jejurkar commented

2022-11-03 19:12:14 +01:00

A horizontal split by dragging from any corner seems to always result in a crash.
Vertical splitting seems to work correctly.

Checked in debugger and it seems NaN values are being generated while channel drawing.

From what I can tell, channel_height gets initialized to 0 when the newly created sequencer area is too small.
This results in various divide by zero calculations in label_rect_init() which generate the NaN values seen in the screenshot.

A horizontal split by dragging from any corner seems to always result in a crash. Vertical splitting seems to work correctly. Checked in debugger and it seems `NaN` values are being generated while channel drawing. ![seq_crash_nan.png](https://archive.blender.org/developer/F13850464/seq_crash_nan.png) From what I can tell, `channel_height` gets initialized to 0 when the newly created sequencer area is too small. This results in various **divide by zero** calculations in `label_rect_init()` which generate the NaN values seen in the screenshot.

Pratik Borhade commented

2022-11-04 06:28:50 +01:00

@iss, yes, can reproduce this.

@sidd017 's findings are also seems true

And Sorry, I totally missed your notification :)

@iss, yes, can reproduce this. @sidd017 's findings are also seems true - - - And Sorry, I totally missed your notification :)

Pratik Borhade changed title from ~~Assert hit when splitting video sequencer area~~ to Assert hit when splitting video sequencer area horizontally

2022-11-04 06:29:59 +01:00

blender-admin commented

2022-11-04 20:57:23 +01:00

This issue was referenced by bba6d28942

This issue was referenced by bba6d2894290244be847a6d4ee7722c82ec01c0e

Richard Antalik commented

2022-11-04 21:06:00 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2022-11-04 21:06:00 +01:00

Richard Antalik self-assigned this 2022-11-04 21:06:00 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Assert hit when splitting video sequencer area horizontally #99641