Regression: "Store Named Attribute" node affects all vertex groups after than the one specified. #99791

New Issue

Chris D · 2022-07-17T10:12:17+02:00

Chris D commented

2022-07-17 10:12:17 +02:00

System Information
Operating system: Arch Linux w/ Linux-5.18.10-zen1-1-zen-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.57

Blender Version
Broken: version: 3.3.0
Worked: 3.2.1
Caused by 12bde317f4

Short description of error
Seems to be related to #99787
Modifying a vertex group with the "Store Named Attribute" node affects all groups after that one.

Exact steps for others to reproduce the error

Add many one vertex groups to a mesh.
Assign some weight to the vertex groups to make the issue more clear.
Add a "Store Named Attribute" node to a geometry nodes group on the object.
Set the target attribute to a vertex group near the top of list in the properties panel.

Note that the vertex group's weights of groups after the targeted group have been shifted up on in the list.

NoArmature.blend
Peek 2022-07-17 04-01.webm

**System Information** Operating system: Arch Linux w/ Linux-5.18.10-zen1-1-zen-x86_64-with-glibc2.35 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.57 **Blender Version** Broken: version: 3.3.0 Worked: 3.2.1 Caused by 12bde317f4 **Short description of error** Seems to be related to #99787 Modifying a vertex group with the "Store Named Attribute" node affects all groups after that one. **Exact steps for others to reproduce the error** - Add many one vertex groups to a mesh. - Assign some weight to the vertex groups to make the issue more clear. - Add a "Store Named Attribute" node to a geometry nodes group on the object. - Set the target attribute to a vertex group near the top of list in the properties panel. # Note that the vertex group's weights of groups after the targeted group have been shifted up on in the list. [NoArmature.blend](https://archive.blender.org/developer/F13297059/NoArmature.blend) [Peek 2022-07-17 04-01.webm](https://archive.blender.org/developer/F13297060/Peek_2022-07-17_04-01.webm)

Chris D commented

2022-07-17 10:12:17 +02:00

Added subscriber: @CheesecakeCG

blender-admin commented

2022-07-17 10:12:17 +02:00

#99787 was marked as duplicate of this issue

Pratik Borhade commented

2022-07-18 02:38:43 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-07-18 02:38:43 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-07-18 02:38:43 +02:00

Thanks for the report. I can confirm this. Will do the bisect

Pratik Borhade commented

2022-07-18 07:26:52 +02:00

Added subscriber: @HooglyBoogly

Pratik Borhade commented

2022-07-18 07:26:52 +02:00

Broken since 12bde317f4
cc @HooglyBoogly

Broken since 12bde317f4 cc @HooglyBoogly

Pratik Borhade changed title from ~~"Store Named Attribute" node affects all vertex groups after than the one specified.~~ to Regression: "Store Named Attribute" node affects all vertex groups after than the one specified.

2022-07-18 07:27:17 +02:00

Jacques Lucke commented

2022-07-23 13:43:13 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2022-07-23 13:43:13 +02:00

Can you check if that is fixed? Think it was fixed by c40971d79a + 5da807e00f.

It seems like it might not have been a bug in geometry nodes before, but I'm not sure. The spreadsheet already showed the correct values, just the viewport was drawing the wrong data it seems.

Can you check if that is fixed? Think it was fixed by c40971d79a + 5da807e00f. It seems like it might not have been a bug in geometry nodes before, but I'm not sure. The spreadsheet already showed the correct values, just the viewport was drawing the wrong data it seems.

Pratik Borhade commented

2022-07-23 15:37:02 +02:00

Works fine in current master (d53ea1d0af58cfdcd230e75ba4ac58453bdbd808)
We can now close this report :)

Works fine in current master (`d53ea1d0af58cfdcd230e75ba4ac58453bdbd808`) We can now close this report :)

Jacques Lucke commented

2022-07-23 15:39:47 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-07-23 15:39:47 +02:00

Jacques Lucke self-assigned this 2022-07-23 15:39:47 +02:00

Alexander Gavrilov commented

2022-07-25 13:42:55 +02:00

Added subscriber: @angavrilov

Alexander Gavrilov commented

2022-07-25 13:42:55 +02:00

In #99791#1394416, @JacquesLucke wrote:
It seems like it might not have been a bug in geometry nodes before, but I'm not sure.

The 'affects all group after' part is a manifestation of a 'name list vs data' mismatch bug, which is a consequence of code incompletely updated to account for the possibility of the vertex group list being changed by modifiers, which wasn't possible before. For instance, 80b2fc59d1 fixes the Armature modifier; however there are very likely other cases of this.

The Store Named Attribute node also had a bug where it always deleted the existing attribute and created it from scratch, instead of writing to the existing one. This part was fixed by the commits you mentioned above, however the mismatch bug may still be triggerable via the Remove node.

The 12bde317f4 commit does not cause any bug, it merely revealed hidden bugs in other code by fixing a bug.

> In #99791#1394416, @JacquesLucke wrote: > It seems like it might not have been a bug in geometry nodes before, but I'm not sure. The 'affects all group after' part is a manifestation of a 'name list vs data' mismatch bug, which is a consequence of code incompletely updated to account for the possibility of the vertex group list being changed by modifiers, which wasn't possible before. For instance, 80b2fc59d1 fixes the Armature modifier; however there are very likely other cases of this. The Store Named Attribute node also had a bug where it always deleted the existing attribute and created it from scratch, instead of writing to the existing one. This part was fixed by the commits you mentioned above, however the mismatch bug may still be triggerable via the Remove node. The 12bde317f4 commit does not *cause* any bug, it merely revealed hidden bugs in other code by fixing a bug.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: "Store Named Attribute" node affects all vertex groups after than the one specified. #99791

Note that the vertex group's weights of groups after the targeted group have been shifted up on in the list.