Regression: Video in node group doesn't play #99932

New Issue

Joey Carlino · 2022-07-23T18:17:25+02:00

Joey Carlino commented

2022-07-23 18:17:25 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-22 21:12, hash: 82467e5dcf
Worked: 3.1.2

Caused by f517b3a295

Short description of error
image texture videos don't play while in a node group

Exact steps for others to reproduce the error

add a mesh (plane)
add new material
add image texture node and plug into surface output
choose a video file
put it into a node group
It should stop playing at this point.
If there is another image texture using the same video OUTSIDE the group at the same time, the video from the group still works. It will break as soon as the outside image texture is deleted.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76 **Blender Version** Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-22 21:12, hash: `82467e5dcf` Worked: 3.1.2 Caused by f517b3a295 **Short description of error** image texture videos don't play while in a node group **Exact steps for others to reproduce the error** - add a mesh (plane) - add new material - add image texture node and plug into surface output - choose a video file - put it into a node group It should stop playing at this point. If there is another image texture using the same video OUTSIDE the group at the same time, the video from the group still works. It will break as soon as the outside image texture is deleted.

Joey Carlino commented

2022-07-23 18:17:25 +02:00

Added subscriber: @JoeyC

blender-admin commented

2022-07-23 18:17:25 +02:00

#100283 was marked as duplicate of this issue

Pratik Borhade commented

2022-07-25 03:11:24 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-07-25 03:11:34 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-07-25 03:24:55 +02:00

Added subscriber: @fclem

Pratik Borhade commented

2022-07-25 03:24:55 +02:00

Introduced between 8c4bd02b06 - ae2d2c9361
I don't use full builds so can't really bisect. But I suspect one of the Clemet's commit has caused this
cc @fclem (Feel free to unsubscribe if you're not responsible for this issue :) )

Introduced between 8c4bd02b067a - ae2d2c936161 I don't use full builds so can't really bisect. But I suspect one of the Clemet's commit has caused this cc @fclem (Feel free to unsubscribe if you're not responsible for this issue :) )

Pratik Borhade changed title from ~~Video in node group doesn't play~~ to Regression: Video in node group doesn't play

2022-07-25 03:25:30 +02:00

Jeroen Bakker commented

2022-08-02 08:00:05 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker self-assigned this 2022-08-02 08:00:05 +02:00

Jeroen Bakker commented

2022-08-02 08:00:05 +02:00

Assign to me for bisecting, and making an example file.

Jeroen Bakker commented

2022-08-02 10:24:15 +02:00

Added subscribers: @HooglyBoogly, @JacquesLucke

Jeroen Bakker commented

2022-08-02 10:24:15 +02:00

Issue is that the iuser->framenr of the NodeTextureImage isn't updated when in a node-group. Doesn't seem to be related to eevee/viewport.
Most likely to be introduced by D14957

think that the issue is that update_has_image_animation assumes that the group nodes are always evaluated before the main shader tree.
@JacquesLucke, @HooglyBoogly is it ok to appoint this one to one of you?

I would add a flag if the evaluation is 'up-to-date' but not sure what the definition is.

index be087c0b2d4..257002dfefd 100644
    - a/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc
+++ b/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc
@@ -1106,6 +1106,8 @@ void DepsgraphNodeBuilder::build_animation_images(ID *id)

 has_image_animation = true;

}
}

+  printf("%s %d\n", __func__, has_image_animation);
+  has_image_animation = ELEM(GS(id->name), ID_MA, ID_WO);

if (has_image_animation || BKE_image_user_id_has_animation(id)) {
ID *id_cow = get_cow_id(id);

diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
index f36d94c7563..18699349a7d 100644
    - a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
+++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
@@ -1,4 +1,4 @@
- /* SPDX-License-Identifier: GPL-2.0-or-later
+/* SPDX-License-Identifier: GPL-2.0-or-laterZ
  * Copyright 2013 Blender Foundation. All rights reserved. */
 
 /** \file
@@ -1487,6 +1487,8 @@ void DepsgraphRelationBuilder::build_animation_images(ID *id)

 has_image_animation = true;

}
}

+  printf("%s %d\n", __func__, has_image_animation);
+  has_image_animation = ELEM(GS(id->name), ID_MA, ID_WO);

if (has_image_animation || BKE_image_user_id_has_animation(id)) {
OperationKey image_animation_key(```


Issue is depsgraph related. the relations aren't added so not updated.

Issue is that the `iuser->framenr` of the `NodeTextureImage` isn't updated when in a node-group. Doesn't seem to be related to eevee/viewport. Most likely to be introduced by [D14957](https://archive.blender.org/developer/D14957) think that the issue is that `update_has_image_animation` assumes that the group nodes are always evaluated before the main shader tree. @JacquesLucke, @HooglyBoogly is it ok to appoint this one to one of you? I would add a flag if the evaluation is 'up-to-date' but not sure what the definition is. ```diff --git a/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc b/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc index be087c0b2d4..257002dfefd 100644 - a/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc @@ -1106,6 +1106,8 @@ void DepsgraphNodeBuilder::build_animation_images(ID *id) ``` has_image_animation = true; } } ``` + printf("%s %d\n", __func__, has_image_animation); + has_image_animation = ELEM(GS(id->name), ID_MA, ID_WO); ``` if (has_image_animation || BKE_image_user_id_has_animation(id)) { ID *id_cow = get_cow_id(id); ``` diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc index f36d94c7563..18699349a7d 100644 - a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc @@ -1,4 +1,4 @@ - /* SPDX-License-Identifier: GPL-2.0-or-later +/* SPDX-License-Identifier: GPL-2.0-or-laterZ * Copyright 2013 Blender Foundation. All rights reserved. */ /** \file @@ -1487,6 +1487,8 @@ void DepsgraphRelationBuilder::build_animation_images(ID *id) ``` has_image_animation = true; } } ``` + printf("%s %d\n", __func__, has_image_animation); + has_image_animation = ELEM(GS(id->name), ID_MA, ID_WO); ``` if (has_image_animation || BKE_image_user_id_has_animation(id)) { OperationKey image_animation_key(``` ``` Issue is depsgraph related. the relations aren't added so not updated.

Jeroen Bakker removed their assignment 2022-08-02 10:26:45 +02:00

Pratik Borhade commented

2022-08-08 12:36:26 +02:00

Added subscriber: @Wassily