Page MenuHome
Feed Advanced Search

Tue, Sep 10

Peter Fog (tintwotin) added a project to T68656: Info Editor's Replay fails, properly because of bad context: Text Editor.
Tue, Sep 10, 11:08 AM · Text Editor, BF Blender

Wed, Sep 4

Campbell Barton (campbellbarton) added a project to T67213: Add a text editor indent-or-auto-complete operator: Text Editor.
Wed, Sep 4, 2:42 PM · Text Editor, BF Blender
Campbell Barton (campbellbarton) added a project to T69490: External Text Data Support: Text Editor.
Wed, Sep 4, 2:41 PM · Text Editor
Campbell Barton (campbellbarton) updated the task description for T68061: Text Editor Module.
Wed, Sep 4, 2:41 PM · Text Editor, BF Blender

Mon, Sep 2

Campbell Barton (campbellbarton) updated the task description for T68061: Text Editor Module.
Mon, Sep 2, 9:08 AM · Text Editor, BF Blender

Mon, Aug 26

Campbell Barton (campbellbarton) updated the task description for T68061: Text Editor Module.
Mon, Aug 26, 4:34 AM · Text Editor, BF Blender

Aug 15 2019

Peter Fog (tintwotin) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

Now this patch has been abandoned, who has a better solution, and how/where to discuss it?

Aug 15 2019, 11:10 AM · Text Editor, BF Blender
Dalai Felinto (dfelinto) closed T68658: Text offset makes scale to fit not to work as Resolved by committing rBcb7ead2e3b62: Fix T68658: Text offset makes scale to fit not to work.
Aug 15 2019, 12:23 AM · Text Editor, BF Blender

Aug 14 2019

Philipp Oeser (lichtwerk) added a revision to T68658: Text offset makes scale to fit not to work: D5484: Fix T68658: Text offset makes scale to fit not to work.
Aug 14 2019, 8:36 PM · Text Editor, BF Blender
Dalai Felinto (dfelinto) added a project to T68658: Text offset makes scale to fit not to work: Text Editor.
Aug 14 2019, 8:08 PM · Text Editor, BF Blender
Peter Fog (tintwotin) abandoned D5444: Info Editor - Add Menus.
Aug 14 2019, 12:38 PM · Text Editor, User Interface, BF Blender
Peter Fog (tintwotin) abandoned D5474: Horizontal Find & Replace for the Text Editor.
Aug 14 2019, 12:35 PM · Text Editor, BF Blender
Brecht Van Lommel (brecht) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Closing diff since this was committed, further changes can be submitted as separate code review if needed.

Aug 14 2019, 11:48 AM · Text Editor, BF Blender
D5474: Horizontal Find & Replace for the Text Editor now requires changes to proceed.

Setting as requesting changes, although it might be better to close the patch since the design hasn't been agreed on.

Aug 14 2019, 11:05 AM · Text Editor, BF Blender
Campbell Barton (campbellbarton) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

Would prefer this be handled as a design task before going though code review.

Aug 14 2019, 9:46 AM · Text Editor, BF Blender
Campbell Barton (campbellbarton) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

I think it's a nice overall goal to do it this way, more like dedicated text and code editors. So if the issues can do handled, I do think it makes sense to do something like this.

I don't really agree that this is more like dedicated text editors. In VS Code it is actually more similar to the current implementation. That is not to say, that this would not be an improvement, just for other reasons maybe.

Aug 14 2019, 9:29 AM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

An alternative way would be if the scrollbar was moved to the right of the side bar and the unused part of the sidebar was made transparent, like the 3D View:

Aug 14 2019, 8:48 AM · Text Editor, BF Blender
Jacques Lucke (JacquesLucke) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

I think it's a nice overall goal to do it this way, more like dedicated text and code editors. So if the issues can do handled, I do think it makes sense to do something like this.

Aug 14 2019, 8:07 AM · Text Editor, BF Blender

Aug 13 2019

William Reynish (billreynish) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

I think it's a nice overall goal to do it this way, more like dedicated text and code editors. So if the issues can do handled, I do think it makes sense to do something like this.

Aug 13 2019, 8:57 PM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5474: Horizontal Find & Replace for the Text Editor.

I think the main question is if this kind of design is worth pursuing? This is more like a test of concept and in the end of the day, it may not the best idea to actually code the operator in Python ex. with no text.get_selection in the API(for adding selection to find box), and the other things @Campbell Barton (campbellbarton) points out here.

Aug 13 2019, 8:50 PM · Text Editor, BF Blender
Campbell Barton (campbellbarton) added a comment to D5474: Horizontal Find & Replace for the Text Editor.
  • The text field is no longer active upon pressing Ctrl-F.
  • If you want to enable wrap for Ctrl-G (next selected). There is no longer an obvious way to do this.
  • If you're finding long words, the text fields are quite small and there is no way to make them bigger.
  • This removes use of iface_ for translating File.
  • There is no reason to add this property to the window manager as far as I can see.
Aug 13 2019, 7:46 PM · Text Editor, BF Blender
Peter Fog (tintwotin) updated the summary of D5474: Horizontal Find & Replace for the Text Editor.
Aug 13 2019, 7:08 PM · Text Editor, BF Blender
Peter Fog (tintwotin) created D5474: Horizontal Find & Replace for the Text Editor.
Aug 13 2019, 6:04 PM · Text Editor, BF Blender
Dalai Felinto (dfelinto) moved T68068: Text editor undo system, undo step limiting behavior from Backlog to Curated on the Text Editor board.
Aug 13 2019, 2:58 PM · Text Editor, Datablocks and Libraries, BF Blender
Dalai Felinto (dfelinto) added a project to T68068: Text editor undo system, undo step limiting behavior: Text Editor.
Aug 13 2019, 2:57 PM · Text Editor, Datablocks and Libraries, BF Blender
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

Let's move Register to the Text menu and add the view toggles to the header. That's what @Peter Fog (tintwotin)'s patch did anyway, but it was filtered out.

Aug 13 2019, 2:34 PM · BF Blender, Text Editor
Sybren A. Stüvel (sybren) added inline comments to D5028: Text Editor UI updates.
Aug 13 2019, 2:01 PM · BF Blender, Text Editor

Aug 11 2019

Campbell Barton (campbellbarton) closed T68062: Support Text Editor Comment/Indent w/o selection as Resolved.
Aug 11 2019, 2:15 PM · Text Editor

Aug 9 2019

Campbell Barton (campbellbarton) added a comment to D5028: Text Editor UI updates.

Added back the icon toggles rB58f38ff5c1a392b40129cad100e8c1e5371d7169

Aug 9 2019, 5:29 PM · BF Blender, Text Editor
Campbell Barton (campbellbarton) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Added the icons back, rB58f38ff5c1a392b40129cad100e8c1e5371d7169

Aug 9 2019, 5:17 PM · Text Editor, BF Blender
Sybren A. Stüvel (sybren) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

As Campbell wrote, when he cherry picked what to commit: "would rather separate header reorganization from changing menus", so no header changes, except menus have been committed, so I guess this diff can be closed?

Aug 9 2019, 2:51 PM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

As Campbell wrote, when he cherry picked what to commit: "would rather separate header reorganization from changing menus", so no header changes, except menus have been committed, so I guess this diff can be closed?

Aug 9 2019, 2:39 PM · Text Editor, BF Blender
Sybren A. Stüvel (sybren) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Alternatively we could even completely remove the Run Script button, since it's in the menu and available in the context menu and via keyboard shortcuts also.

Aug 9 2019, 2:33 PM · Text Editor, BF Blender
Sybren A. Stüvel (sybren) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

NB. I reinserted the view toggle buttons in the header, because removing them seemed to cause a lot of dislikes: D5028

Aug 9 2019, 2:20 PM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

Since the Toggle Comment with a shortcut key was implemented, I'll abandon this diff, though I still think 'Find Set Selected' now called 'Find Next" in the menus, could use a shortcut key.

Aug 9 2019, 2:11 PM · BF Blender, Text Editor
D5444: Info Editor - Add Menus is now accepted and ready to land.
Aug 9 2019, 1:40 PM · Text Editor, User Interface, BF Blender
Campbell Barton (campbellbarton) closed D5443: Python Console Menus - Updated .
Aug 9 2019, 11:30 AM · Text Editor, BF Blender
D5443: Python Console Menus - Updated is now accepted and ready to land.

Thanks, committed rB533e48520e8639854df91593cc1be435c53f5357

Aug 9 2019, 11:30 AM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5443: Python Console Menus - Updated .

This update adds the Console menu as Context menu(w/right click).

Aug 9 2019, 11:23 AM · Text Editor, BF Blender
William Reynish (billreynish) added a comment to D5444: Info Editor - Add Menus.

Not sure if we want to define the context menu separately from the Info menu or not. In any case this seems to work ok and is vastly better than before.

Aug 9 2019, 11:11 AM · Text Editor, User Interface, BF Blender
Peter Fog (tintwotin) updated the summary of D5444: Info Editor - Add Menus.

Update adds the Info menu as Context menu.

Aug 9 2019, 11:09 AM · Text Editor, User Interface, BF Blender
Peter Fog (tintwotin) created D5444: Info Editor - Add Menus.
Aug 9 2019, 10:38 AM · Text Editor, User Interface, BF Blender
Peter Fog (tintwotin) added a comment to D5443: Python Console Menus - Updated .

More class renaming.

Aug 9 2019, 7:44 AM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5443: Python Console Menus - Updated .

Cleaned up class naming.

Aug 9 2019, 7:39 AM · Text Editor, BF Blender
Peter Fog (tintwotin) created D5443: Python Console Menus - Updated .
Aug 9 2019, 7:31 AM · Text Editor, BF Blender

Aug 8 2019

Peter Fog (tintwotin) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

@Campbell Barton (campbellbarton) Thank you for committing this.

Aug 8 2019, 10:07 AM · Text Editor, BF Blender
Campbell Barton (campbellbarton) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Committed rB512b562b3b96d365dce35d91d2a64a78c4483dca but left some changes out.

Aug 8 2019, 8:25 AM · Text Editor, BF Blender
Peter Fog (tintwotin) updated the summary of D5434: Text Editor Menus - Refreshed & Proposals.

Remove Refresh.
Remove wrapping of args.
Rename to Move Line(s) Up/Down.

Aug 8 2019, 7:21 AM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Added select Word to Select menu.

Aug 8 2019, 7:06 AM · Text Editor, BF Blender
D5434: Text Editor Menus - Refreshed & Proposals now requires changes to proceed.

The patch is a little out of date (comment/uncomment have been removed).

Aug 8 2019, 6:58 AM · Text Editor, BF Blender
Peter Fog (tintwotin) updated the summary of D5434: Text Editor Menus - Refreshed & Proposals.
Aug 8 2019, 6:45 AM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Swapped the viewport toggles with the Run Script operator button:

Aug 8 2019, 6:43 AM · Text Editor, BF Blender

Aug 7 2019

Peter Fog (tintwotin) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

It\s possible to move Run Script a little closer, and maybe a little space around the view buttons is an improvement.

Aug 7 2019, 10:54 PM · Text Editor, BF Blender
William Reynish (billreynish) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.
Aug 7 2019, 10:45 PM · Text Editor, BF Blender
Peter Fog (tintwotin) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

@William Reynish (billreynish) Like this?

Aug 7 2019, 10:28 PM · Text Editor, BF Blender
William Reynish (billreynish) added a comment to D5434: Text Editor Menus - Refreshed & Proposals.

Nice fixes and changes. I would probably swap the viewport toggles with the Run Script operator button. Other than that it looks good to me.

Aug 7 2019, 10:06 PM · Text Editor, BF Blender
Peter Fog (tintwotin) created D5434: Text Editor Menus - Refreshed & Proposals.
Aug 7 2019, 10:03 PM · Text Editor, BF Blender

Aug 6 2019

Sebastian Koenig (sebastian_k) added a comment to D5028: Text Editor UI updates.

Since the "Edit Source" context menu item only auto-opens the file and auto-scrolls to the correct line when the text editor is in the current workspace, this default in the Scripting workspace doesn't help much.

Aug 6 2019, 4:16 PM · BF Blender, Text Editor
Sybren A. Stüvel (sybren) added a comment to D5028: Text Editor UI updates.

Luckily it seems that the default is that syntax highlighting and numbers are enabled by default. So it doesnt hurt so much in this case.

Aug 6 2019, 4:12 PM · BF Blender, Text Editor
Sebastian Koenig (sebastian_k) added a comment to D5028: Text Editor UI updates.

I agree that hiding everything behind dropdown menus is super annoying and doesn't improve the UI at all.
Register Script is still an item in the header, taking up way more space than those 3 toggles we previously had, even though I believe that one is used far less.
Luckily it seems that the default is that syntax highlighting and numbers are enabled by default. So it doesnt hurt so much in this case.
In general I'd wish that items in the header were not regarded as visual clutter so much.

Aug 6 2019, 4:01 PM · BF Blender, Text Editor
Sybren A. Stüvel (sybren) added a comment to D5028: Text Editor UI updates.
  • Remove Line Number, Word Wrap and Syntax Highlighting toggles from the header. I don't think these are necessary if they are in the View menu, and we get some space back for the things that are exclusive to the header
Aug 6 2019, 3:51 PM · BF Blender, Text Editor

Aug 5 2019

Campbell Barton (campbellbarton) closed T68060: Text Editor Toggle Comment Behavior as Resolved by committing rB94dce826a9a7: Text: only un-comment blocks which are completely commented.
Aug 5 2019, 8:04 AM · Text Editor

Aug 4 2019

William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

Committed already.

Aug 4 2019, 3:02 PM · BF Blender, Text Editor
Brecht Van Lommel (brecht) accepted D5028: Text Editor UI updates.
Aug 4 2019, 12:01 PM · BF Blender, Text Editor
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.
  • Fixed the versioning code no longer applying to master
  • Removed the contextual part of the context menu for opening texts etc when none are selected.
Aug 4 2019, 10:33 AM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5028: Text Editor UI updates.

Some parts where rejected when I tried to apply this patch, but has the sidebar been moved to the right in the Workspace too?

Aug 4 2019, 9:11 AM · BF Blender, Text Editor
Peter Fog (tintwotin) removed a reviewer for D5097: Adding 'Trim Whitespace' and 'Change Case' to Text Editor : William Reynish (billreynish).

Change info about whitespace trimmed lines from popover to report in statusbar.

Aug 4 2019, 8:34 AM · BF Blender, Python, Text Editor

Aug 2 2019

Brecht Van Lommel (brecht) added inline comments to D5028: Text Editor UI updates.
Aug 2 2019, 1:40 PM · BF Blender, Text Editor
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

Yes I can update the context menu thing.

Aug 2 2019, 12:51 AM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5028: Text Editor UI updates.

Both suggestions are fine by me. What do @William Reynish (billreynish) say?

Aug 2 2019, 12:14 AM · BF Blender, Text Editor

Aug 1 2019

D5028: Text Editor UI updates now requires changes to proceed.
Aug 1 2019, 11:48 PM · BF Blender, Text Editor
Brecht Van Lommel (brecht) added inline comments to D5028: Text Editor UI updates.
Aug 1 2019, 6:27 PM · BF Blender, Text Editor
Campbell Barton (campbellbarton) updated the task description for T68061: Text Editor Module.
Aug 1 2019, 2:12 PM · Text Editor, BF Blender
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

Updated with the versioning code from @Brecht Van Lommel (brecht), and the latest layout tweaks from @Peter Fog (tintwotin).

Aug 1 2019, 1:49 PM · BF Blender, Text Editor
Campbell Barton (campbellbarton) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

Committed toggle comments rB5fde4494f6542739ec4184312d0a937c500e0595, rB433eb3f35d5cf3933801027e33399923609c6539

Aug 1 2019, 12:46 PM · BF Blender, Text Editor
Campbell Barton (campbellbarton) triaged T68060: Text Editor Toggle Comment Behavior as Normal priority.
Aug 1 2019, 12:45 PM · Text Editor
Campbell Barton (campbellbarton) updated the task description for T68061: Text Editor Module.
Aug 1 2019, 12:45 PM · Text Editor, BF Blender
Campbell Barton (campbellbarton) updated the task description for T68061: Text Editor Module.
Aug 1 2019, 12:45 PM · Text Editor, BF Blender
Campbell Barton (campbellbarton) created T68062: Support Text Editor Comment/Indent w/o selection.
Aug 1 2019, 12:45 PM · Text Editor
Campbell Barton (campbellbarton) created T68061: Text Editor Module.
Aug 1 2019, 12:42 PM · Text Editor, BF Blender
Campbell Barton (campbellbarton) updated the task description for T68060: Text Editor Toggle Comment Behavior.
Aug 1 2019, 12:42 PM · Text Editor
Campbell Barton (campbellbarton) created T68060: Text Editor Toggle Comment Behavior.
Aug 1 2019, 12:42 PM · Text Editor

Jul 31 2019

Peter Fog (tintwotin) updated the summary of D5097: Adding 'Trim Whitespace' and 'Change Case' to Text Editor .
Jul 31 2019, 8:38 PM · BF Blender, Python, Text Editor
Peter Fog (tintwotin) retitled D5097: Adding 'Trim Whitespace' and 'Change Case' to Text Editor from Adding 'Trim Whitespaces', 'Split & Join Line' and 'Change Case' to Text Editor to Adding 'Trim Whitespace' and 'Change Case' to Text Editor .

Updated the diff: Using clipboard code has been removed, instead code to get selection by @Dalai Felinto (dfelinto) has been used: https://developer.blender.org/diffusion/BAC/browse/master/text_editor_hastebin.py If/when this function will be added to the API this def can be removed.

Jul 31 2019, 1:10 PM · BF Blender, Python, Text Editor
Brecht Van Lommel (brecht) added a comment to D5028: Text Editor UI updates.

Here's the code to move the sidebar to the right:

1diff --git a/source/blender/blenloader/intern/versioning_280.c b/source/blender/blenloader/intern/versioning_280.c
2index cb2b649..545908c 100644
3--- a/source/blender/blenloader/intern/versioning_280.c
4+++ b/source/blender/blenloader/intern/versioning_280.c
5@@ -3535,5 +3535,18 @@ void blo_do_versions_280(FileData *fd, Library *UNUSED(lib), Main *bmain)
6
7 {
8 /* Versioning code until next subversion bump goes here. */
9+ for (bScreen *screen = bmain->screens.first; screen; screen = screen->id.next) {
10+ for (ScrArea *sa = screen->areabase.first; sa; sa = sa->next) {
11+ for (SpaceLink *sl = sa->spacedata.first; sl; sl = sl->next) {
12+ if (sl->spacetype == SPACE_TEXT) {
13+ ListBase *regionbase = (sl == sa->spacedata.first) ? &sa->regionbase : &sl->regionbase;
14+ ARegion *ar = do_versions_find_region(regionbase, RGN_TYPE_UI);
15+ if (ar) {
16+ ar->alignment = RGN_ALIGN_RIGHT;
17+ }
18+ }
19+ }
20+ }
21+ }
22 }
23 }
24diff --git a/source/blender/editors/space_text/space_text.c b/source/blender/editors/space_text/space_text.c
25index 24f282f..9a7debe 100644
26--- a/source/blender/editors/space_text/space_text.c
27+++ b/source/blender/editors/space_text/space_text.c
28@@ -82,7 +82,7 @@ static SpaceLink *text_new(const ScrArea *UNUSED(area), const Scene *UNUSED(scen
29
30 BLI_addtail(&stext->regionbase, ar);
31 ar->regiontype = RGN_TYPE_UI;
32- ar->alignment = RGN_ALIGN_LEFT;
33+ ar->alignment = RGN_ALIGN_RIGHT;
34 ar->flag = RGN_FLAG_HIDDEN;
35
36 /* main region */

Jul 31 2019, 12:30 PM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5028: Text Editor UI updates.

Here are the small changes I mentioned above:


Unfortunately I can't update this patch(missing rights?), but here it is for download:

Jul 31 2019, 9:59 AM · BF Blender, Text Editor

Jul 30 2019

William Reynish (billreynish) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

@Campbell Barton (campbellbarton) Sounds like a good plan I think.

Jul 30 2019, 2:35 PM · BF Blender, Text Editor
Campbell Barton (campbellbarton) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

It's probably simplest to add a toggle-comment operator to Blender, internally it can just call uncomment, if that does nothing, call comment.

Jul 30 2019, 2:25 PM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5028: Text Editor UI updates.

Oh, this is strange. I did a build with this patch, and now the Text Editor won't load a text block anymore. Can anyone confirm this?

Jul 30 2019, 2:00 PM · BF Blender, Text Editor
William Reynish (billreynish) updated the summary of D5028: Text Editor UI updates.
Jul 30 2019, 12:33 PM · BF Blender, Text Editor
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

I would also prefer if we could get rid of this button altogether, and infer this depending on the selection when you launch Find & Replace. Might be outside the scope of this though, I certainly don't know how to implement that.

Jul 30 2019, 12:30 PM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5028: Text Editor UI updates.

On the icon, the first button seems to copy&paste&find, which I feel isn't covered with an Import icon or a Paste icon, but maybe that's just me? (Actually this function should have been build into the Find operator - so highlighting text and hit ctrl+f would do that, and there would be no need for a button). Maybe the Eyedropper icon could cover the process of extracting a string and add it to the panel? Maybe it's better, but it still doesn't cover the additional find function.

Jul 30 2019, 12:28 PM · BF Blender, Text Editor
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

I'm sorry. I'm hesitating a bit, because are we sure about the 'Download' icons? Or do we need more exact icons created for these buttons?

Jul 30 2019, 11:40 AM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5028: Text Editor UI updates.

I'm sorry. I'm hesitating a bit, because are we sure about the 'Download' icons? Or do we need more exact icons created for these buttons?
Are we sure, we want the Find&Replace settings above the search fields(normally these settings are below the search fields)?
Should Find&Replace be on top in the Sidebar. Having the most used functions on top?
Are we sure we do want Highlight Line unselected as default setting?

Jul 30 2019, 11:35 AM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

If Ctrl + / is it, which is industry standart for Line Comment(?), then this is all it takes(in Python) to add Line Comment to the current comment function. Code by Lapineige:

class BetterComment(bpy.types.Operator):
    """  """
    bl_idname = "text.better_comment"
    bl_label = "Better Comment"
Jul 30 2019, 11:27 AM · BF Blender, Text Editor
William Reynish (billreynish) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

I checked over a dozen or so text/code editors. Almost all used Cmd or Ctrl-/ for *toggle* comments.

Jul 30 2019, 10:29 AM · BF Blender, Text Editor
Peter Fog (tintwotin) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

Ctrl + / is actually line comment(in PyCharm), where the location of the cursor determines which line to comment and this is typically a toggle function - this line comment function doesn't exist in Blender.

Jul 30 2019, 10:18 AM · BF Blender, Text Editor
William Reynish (billreynish) added a comment to D5028: Text Editor UI updates.

@Campbell Barton (campbellbarton) it’s ready, except for the fact that I moved the Sidebar to the right. This requires some Do Version magic that neither @Peter Fog (tintwotin) or I can do.

Jul 30 2019, 9:07 AM · BF Blender, Text Editor
Campbell Barton (campbellbarton) added a comment to D5028: Text Editor UI updates.

Is this ready for review or are other changes planned?

Jul 30 2019, 8:46 AM · BF Blender, Text Editor
Campbell Barton (campbellbarton) added a comment to D5175: Text Editor Missing Hotkey Fix: Comment assigned Ctrl+H, Uncomment assigned Alt+H, Replace Ctrl+R, Find Set Selected Alt + F.

What do other applications which use Ctrl-/ do for non-English environments

Jul 30 2019, 8:37 AM · BF Blender, Text Editor