• Cycles: Fixed typos in Crytpomatte code.

• Cycles: More Cryptomatte code review changes.
• Cycles: Skip calls to CPU kernel coverage buffer when accurate cryptomatte layers are turned off.

I support this.

I'm seeing CUDA renders on macOS giving wrong results starting with rBd611cf923358 (determined via git bisect, MBP Retina, 15-inch, Late 2013, GeForce GT 750M, Xcode 9.2, CUDA 9.2). The code in rBd611cf923358 looks innocent to me, may be that commit just exposed a compiler bug on macOS?

• Cycles: A little refactor of the cryptomatte ID pass writting to reduce #ifdef clutter
• Cycles: Removed PathState::matte_weight, using throughput instead for Cryptomatte

Addressed some of Sergey's comment.s

• Merge branch 'master' of git.blender.org:blender into cycles_cryptomatte
• Merge branch 'master' of git.blender.org:blender into cycles_cryptomatte
• Cycles: Implemented full sorting for Cryptomatte layers for all possible renderign devices.
• Cycles: Refactoring to remove duplicate Cyryptomatte id pass code.
• Cycles: Addressed some of Sergey's comments on D3538
• Cycles: Stochastic cryptomatte writing now adds coverage to last ID when it runs out of slots.

Without resorting to dynamic memory allocations inside the kernel or grossly over allocating memory, there will always be a chance of randomly skipped data.

• Cycles: Compile fixes for OpenCL kernel.

I think I found a way to write id passes using atomics.

• Cycles: Cryptomatte writing now uses atomics on GPUs to avoid race conditions.
• Cycles: Code style, fixed typos moving murmurhash to its own cpp file.

• Reverted an accidental change.

• Compositor: Fixed Cryptomatte string handling.
• Compositor: Applied Brecht's UI improvements to Cryptomatte node
• Compositor: Fixed broken add/remove in Cryptomatte node.
• Compositor: Raised default number of Crypto inputs to three, as recommended by the Cryptomatte specification.

• Compositor: Cryptomatte node now uses a dynamic string for matte ids, no more 1024 character limit.

Cryptomatte output for Cycles is now in D3538

• Cycles: Addressed Lukas' comments for Cryptomatte output.

Looks good to me. The test renders I did didn't show any differences.

Cryptomatte support for Cycles is in D3538.

Still to do:

• Fixed indentation.

@Brecht Van Lommel (brecht) This patch changes array<Pass> back to vector<Pass>, as it was before you did some refactoring. Is that safe to do or are there dangers that I'm overlooking? Since I'd like Pass to contain a name string, it would be important that its destructor gets called.

• Cycles: Fixed Cryptomatte pass names to match between Python and C++ code.

• Cycles: Code styling fixes for murmurhash.

A Cryptomatte compositing node is in this patch: D3531

• More code styling changes in Cryptomatte compositing node.
• Code styling and warning suppression in murmur3 hash.
• Removed unused code.

x - Compositor: Addressed Brecht's comments for Cryptomatte node.

• Compositor: Added static sizeof() checks before type punning. Currently, sizeof(float) == 4 on all of our supported platforms, but the standards don't require that. You never know...

This is a patch against the current master. Should I rather rebase this on top of the 2.8 branch?

Should be fixed now in d20d2bcb7fe7

• Removed whitespace change in unrelated code - let's keep this patch to the point.

• Addressed Sergey's comments regarding code style