Feed Advanced Search

Today

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Fixed typos in Crytpomatte code.
Mon, Aug 20, 2:18 PM · Cycles

Fri, Aug 17

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: More Cryptomatte code review changes.
  • Cycles: Skip calls to CPU kernel coverage buffer when accurate cryptomatte layers are turned off.
Fri, Aug 17, 8:51 PM · Cycles
Stefan Werner (swerner) added a comment to D2326: Disable compilation of sse2 and ssse3 kernels on MacOS.

I support this.

Fri, Aug 17, 8:40 PM · Cycles

Tue, Aug 14

Stefan Werner (swerner) committed rBa9700e7ad276: Fix T56359: Unitialized variable in Cycles OpenCL could cause crashes. (authored by Stefan Werner (swerner)).
Fix T56359: Unitialized variable in Cycles OpenCL could cause crashes.
Tue, Aug 14, 10:52 PM
Stefan Werner (swerner) closed T56359: Blender 2.8 Alpha 2 - GPU Rendering in Cycles Crashes with dual AMD WX 7100 card setup... as Resolved by committing rBa9700e7ad276: Fix T56359: Unitialized variable in Cycles OpenCL could cause crashes..
Tue, Aug 14, 10:52 PM · BF Blender: 2.8, Cycles, Rendering
Stefan Werner (swerner) claimed T56359: Blender 2.8 Alpha 2 - GPU Rendering in Cycles Crashes with dual AMD WX 7100 card setup....
Tue, Aug 14, 10:47 PM · BF Blender: 2.8, Cycles, Rendering
Manu Järvinen (maxon) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Tue, Aug 14, 9:08 PM · Cycles
Stefan Werner (swerner) committed rB94b7f17180c9: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Tue, Aug 14, 2:51 PM
Stefan Werner (swerner) committed rB97d4e3f0e739: Cycles: Fixes for transparent shadows and SSS when using Embree. (authored by Stefan Werner (swerner)).
Cycles: Fixes for transparent shadows and SSS when using Embree.
Tue, Aug 14, 2:51 PM

Mon, Aug 13

Stefan Werner (swerner) added a comment to T56234: Artifacts when render in Hybrid mode in version 2.8.

I'm seeing CUDA renders on macOS giving wrong results starting with rBd611cf923358 (determined via git bisect, MBP Retina, 15-inch, Late 2013, GeForce GT 750M, Xcode 9.2, CUDA 9.2). The code in rBd611cf923358 looks innocent to me, may be that commit just exposed a compiler bug on macOS?

Mon, Aug 13, 12:11 PM · Cycles, BF Blender

Thu, Aug 9

Andrew Charlton (Scaredyfish) awarded D3538: Cycles: Added Cryptomatte passes. a 100 token.
Thu, Aug 9, 7:02 AM · Cycles

Sun, Aug 5

Tanguy Weyland (Tanguy) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Sun, Aug 5, 4:18 PM · Cycles

Sat, Aug 4

Vitor Balbio (vitorbalbio) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Sat, Aug 4, 12:11 AM · Cycles

Fri, Aug 3

Steffen Dünner (SteffenD) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Fri, Aug 3, 10:08 PM · Cycles
Bruno Ortolland (Noss) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Fri, Aug 3, 9:37 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: A little refactor of the cryptomatte ID pass writting to reduce #ifdef clutter
  • Cycles: Removed PathState::matte_weight, using throughput instead for Cryptomatte
Fri, Aug 3, 9:28 PM · Cycles
Stefan Werner (swerner) committed rB295944b49e45: Merge branch 'master' of git.blender.org:blender into cycles_texture_cache (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_texture_cache
Fri, Aug 3, 6:03 AM

Thu, Aug 2

Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Addressed some of Sergey's comment.s

Thu, Aug 2, 4:19 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Merge branch 'master' of git.blender.org:blender into cycles_cryptomatte
  • Merge branch 'master' of git.blender.org:blender into cycles_cryptomatte
  • Cycles: Implemented full sorting for Cryptomatte layers for all possible renderign devices.
  • Cycles: Refactoring to remove duplicate Cyryptomatte id pass code.
  • Cycles: Addressed some of Sergey's comments on D3538
  • Cycles: Stochastic cryptomatte writing now adds coverage to last ID when it runs out of slots.
Thu, Aug 2, 4:07 PM · Cycles
Stefan Werner (swerner) committed rB7e25ad60517b: Set thread stack size on macOS to 1MB for Embree builds. (authored by Stefan Werner (swerner)).
Set thread stack size on macOS to 1MB for Embree builds.
Thu, Aug 2, 4:04 PM
Stefan Werner (swerner) committed rB9ca5945934a9: Revert "Cycles: Raised thread stack size to 1MB for macOS to be consistent with… (authored by Stefan Werner (swerner)).
Revert "Cycles: Raised thread stack size to 1MB for macOS to be consistent with…
Thu, Aug 2, 4:04 PM
Stefan Werner (swerner) added a reverting commit for rB151b5a9a1e56: Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows.: rB9ca5945934a9: Revert "Cycles: Raised thread stack size to 1MB for macOS to be consistent with….
Thu, Aug 2, 4:04 PM

Wed, Aug 1

Stefan Werner (swerner) committed rB151b5a9a1e56: Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows. (authored by Stefan Werner (swerner)).
Cycles: Raised thread stack size to 1MB for macOS to be consistent with Windows.
Wed, Aug 1, 11:02 PM
Stefan Werner (swerner) committed rB04ffa455a164: Cycles: Updated Embree integration to version 3.2 (authored by Stefan Werner (swerner)).
Cycles: Updated Embree integration to version 3.2
Wed, Aug 1, 11:00 PM

Mon, Jul 30

Stefan Werner (swerner) committed rBb59d85b5a56c: Cycles: Fixed OpenCL build. sqr(float4) is available on CUDA and CPU, but not… (authored by Stefan Werner (swerner)).
Cycles: Fixed OpenCL build. sqr(float4) is available on CUDA and CPU, but not…
Mon, Jul 30, 3:42 PM

Tue, Jul 24

Stefan Werner (swerner) created P756 Faster volume mesh generation.
Tue, Jul 24, 11:06 AM · Cycles

Mon, Jul 23

Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Without resorting to dynamic memory allocations inside the kernel or grossly over allocating memory, there will always be a chance of randomly skipped data.

Mon, Jul 23, 12:19 PM · Cycles

Jul 20 2018

Rainer Trummer (aliasguru) awarded D3538: Cycles: Added Cryptomatte passes. a Love token.
Jul 20 2018, 6:43 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 20 2018, 5:04 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Compile fixes for OpenCL kernel.
Jul 20 2018, 3:28 PM · Cycles
Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

I think I found a way to write id passes using atomics.

Jul 20 2018, 12:32 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Cryptomatte writing now uses atomics on GPUs to avoid race conditions.
  • Cycles: Code style, fixed typos moving murmurhash to its own cpp file.
Jul 20 2018, 12:31 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 20 2018, 12:02 PM · Cycles

Jul 18 2018

Stefan Werner (swerner) committed rBbdda0964e0a5: Compositor: Cryptomatte compositing node. (authored by Stefan Werner (swerner)).
Compositor: Cryptomatte compositing node.
Jul 18 2018, 1:04 PM
Stefan Werner (swerner) closed D3531: Compositor: Cryptomatte compositing node..
Jul 18 2018, 1:03 PM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Reverted an accidental change.
Jul 18 2018, 1:02 PM · Compositing

Jul 16 2018

Stefan Werner (swerner) committed rBc29429bded85: Merge branch 'master' of git.blender.org:blender into cycles_embree (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into cycles_embree
Jul 16 2018, 4:08 PM
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Compositor: Fixed Cryptomatte string handling.
  • Compositor: Applied Brecht's UI improvements to Cryptomatte node
  • Compositor: Fixed broken add/remove in Cryptomatte node.
  • Compositor: Raised default number of Crypto inputs to three, as recommended by the Cryptomatte specification.
Jul 16 2018, 3:47 PM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • Compositor: Cryptomatte node now uses a dynamic string for matte ids, no more 1024 character limit.
Jul 16 2018, 1:00 PM · Compositing
Stefan Werner (swerner) added a comment to D2106: Cycles: Proof-of-Concept Implementation of Cryptomatte Matte ID pass system.

Cryptomatte output for Cycles is now in D3538

Jul 16 2018, 12:58 PM
Stefan Werner (swerner) added a project to D3538: Cycles: Added Cryptomatte passes.: Cycles.
Jul 16 2018, 12:56 PM · Cycles

Jul 13 2018

Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Addressed Lukas' comments for Cryptomatte output.
Jul 13 2018, 2:51 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 13 2018, 2:38 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 13 2018, 2:16 PM · Cycles
Stefan Werner (swerner) added a comment to D3540: Cycles: Save a few instructions in area light sampling.

Looks good to me. The test renders I did didn't show any differences.

Jul 13 2018, 10:24 AM
Stefan Werner (swerner) added inline comments to D3540: Cycles: Save a few instructions in area light sampling.
Jul 13 2018, 9:01 AM

Jul 12 2018

Stefan Werner (swerner) added a comment to D3531: Compositor: Cryptomatte compositing node..

Cryptomatte support for Cycles is in D3538.

Jul 12 2018, 11:14 PM · Compositing
Stefan Werner (swerner) added a comment to D3538: Cycles: Added Cryptomatte passes..

Still to do:

Jul 12 2018, 11:13 PM · Cycles
Stefan Werner (swerner) added inline comments to D3538: Cycles: Added Cryptomatte passes..
Jul 12 2018, 11:12 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Fixed indentation.
Jul 12 2018, 11:08 PM · Cycles
Stefan Werner (swerner) updated subscribers of D3538: Cycles: Added Cryptomatte passes..

@Brecht Van Lommel (brecht) This patch changes array<Pass> back to vector<Pass>, as it was before you did some refactoring. Is that safe to do or are there dangers that I'm overlooking? Since I'd like Pass to contain a name string, it would be important that its destructor gets called.

Jul 12 2018, 11:05 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Fixed Cryptomatte pass names to match between Python and C++ code.
Jul 12 2018, 11:03 PM · Cycles
Stefan Werner (swerner) added a reviewer for D3538: Cycles: Added Cryptomatte passes.: Cycles.
Jul 12 2018, 11:00 PM · Cycles
Stefan Werner (swerner) updated the diff for D3538: Cycles: Added Cryptomatte passes..
  • Cycles: Code styling fixes for murmurhash.
Jul 12 2018, 10:58 PM · Cycles
Stefan Werner (swerner) created D3538: Cycles: Added Cryptomatte passes..
Jul 12 2018, 10:37 PM · Cycles

Jul 11 2018

Stefan Werner (swerner) added a comment to D2106: Cycles: Proof-of-Concept Implementation of Cryptomatte Matte ID pass system.

A Cryptomatte compositing node is in this patch: D3531

Jul 11 2018, 1:14 PM
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..
  • More code styling changes in Cryptomatte compositing node.
  • Code styling and warning suppression in murmur3 hash.
  • Removed unused code.
Jul 11 2018, 12:35 PM · Compositing
Stefan Werner (swerner) committed rBd4f27b960bf8: Cycles: Switched CPU cryptomatte to use unordered_map instead of map. (authored by Stefan Werner (swerner)).
Cycles: Switched CPU cryptomatte to use unordered_map instead of map.
Jul 11 2018, 12:21 PM
Stefan Werner (swerner) committed rBc36977652aa8: Cycles: Initial addition of Cryptomatte ID writing. (authored by Stefan Werner (swerner)).
Cycles: Initial addition of Cryptomatte ID writing.
Jul 11 2018, 12:21 PM
Stefan Werner (swerner) added inline comments to D3531: Compositor: Cryptomatte compositing node..
Jul 11 2018, 10:58 AM · Compositing
Stefan Werner (swerner) updated the diff for D3531: Compositor: Cryptomatte compositing node..

x - Compositor: Addressed Brecht's comments for Cryptomatte node.

  • Compositor: Added static sizeof() checks before type punning. Currently, sizeof(float) == 4 on all of our supported platforms, but the standards don't require that. You never know...
Jul 11 2018, 10:46 AM · Compositing
Stefan Werner (swerner) added inline comments to D3531: Compositor: Cryptomatte compositing node..
Jul 11 2018, 10:37 AM · Compositing

Jul 10 2018

Stefan Werner (swerner) added a comment to D3531: Compositor: Cryptomatte compositing node..

This is a patch against the current master. Should I rather rebase this on top of the 2.8 branch?

Jul 10 2018, 2:32 PM · Compositing
Stefan Werner (swerner) added a project to D3531: Compositor: Cryptomatte compositing node.: Compositing.
Jul 10 2018, 2:30 PM · Compositing
Stefan Werner (swerner) created D3531: Compositor: Cryptomatte compositing node..
Jul 10 2018, 2:30 PM · Compositing

Jul 9 2018

Stefan Werner (swerner) committed rBdd446142e219: Merge branch 'master' of git.blender.org:blender into temp_cryptomatte (authored by Stefan Werner (swerner)).
Merge branch 'master' of git.blender.org:blender into temp_cryptomatte
Jul 9 2018, 1:19 PM
Stefan Werner (swerner) committed rB8bc1a60fb2d3: Cycles: Moved get_aov_rect method to make things easeir for git merge (authored by Stefan Werner (swerner)).
Cycles: Moved get_aov_rect method to make things easeir for git merge
Jul 9 2018, 1:19 PM

Jul 6 2018

Stefan Werner (swerner) committed rB7e503adf340e: More removal of unrelated AOV code (authored by Stefan Werner (swerner)).
More removal of unrelated AOV code
Jul 6 2018, 11:13 PM
Stefan Werner (swerner) committed rB7610395cbc4c: Cleanup: Removed unrelated AOV code, made Cryptomatte work with OpenCL (authored by Stefan Werner (swerner)).
Cleanup: Removed unrelated AOV code, made Cryptomatte work with OpenCL
Jul 6 2018, 4:42 PM
Stefan Werner (swerner) committed rBdf30b50f2f5e: Cycles: Enabled half precision textures for OpenCL devices that support the… (authored by Stefan Werner (swerner)).
Cycles: Enabled half precision textures for OpenCL devices that support the…
Jul 6 2018, 11:42 AM
Stefan Werner (swerner) accepted rBc9608047472a: Cycles Denoising: Pass tile buffers to every OpenCL kernel to conform to….

Should be fixed now in d20d2bcb7fe7

Jul 6 2018, 10:24 AM
Stefan Werner (swerner) committed rBd20d2bcb7fe7: Cycles: Fixed OpenCL kernel build, it threw a compiler error. (authored by Stefan Werner (swerner)).
Cycles: Fixed OpenCL kernel build, it threw a compiler error.
Jul 6 2018, 10:22 AM
Stefan Werner (swerner) raised a concern with rBc9608047472a: Cycles Denoising: Pass tile buffers to every OpenCL kernel to conform to….
Jul 6 2018, 9:54 AM
Stefan Werner (swerner) added inline comments to rBc9608047472a: Cycles Denoising: Pass tile buffers to every OpenCL kernel to conform to….
Jul 6 2018, 9:53 AM

Jul 5 2018

Stefan Werner (swerner) committed rB140a129f22f0: Cycles: Enabled half precision float textures for OpenCL devices that support… (authored by Stefan Werner (swerner)).
Cycles: Enabled half precision float textures for OpenCL devices that support…
Jul 5 2018, 3:18 PM
Stefan Werner (swerner) committed rB4d00e95ee3ed: Cycles: Adding native support for UINT16 textures. (authored by Stefan Werner (swerner)).
Cycles: Adding native support for UINT16 textures.
Jul 5 2018, 1:54 PM
Stefan Werner (swerner) closed D3523: Cycles: Adding native support for UINT16 textures..
Jul 5 2018, 1:53 PM · Cycles
Stefan Werner (swerner) updated the diff for D3523: Cycles: Adding native support for UINT16 textures..
  • Removed whitespace change in unrelated code - let's keep this patch to the point.
Jul 5 2018, 12:38 PM · Cycles
Stefan Werner (swerner) updated the diff for D3523: Cycles: Adding native support for UINT16 textures..
  • Addressed Sergey's comments regarding code style
Jul 5 2018, 12:35 PM · Cycles
Stefan Werner (swerner) added inline comments to D3523: Cycles: Adding native support for UINT16 textures..
Jul 5 2018, 12:32 PM · Cycles
Stefan Werner (swerner) updated the summary of D3523: Cycles: Adding native support for UINT16 textures..
Jul 5 2018, 10:52 AM · Cycles
Stefan Werner (swerner) created D3523: Cycles: Adding native support for UINT16 textures..
Jul 5 2018, 10:50 AM · Cycles

Jun 27 2018

Stefan Werner (swerner) committed rBe17430d00dae: Cycles: Fixed broken displacement (authored by Stefan Werner (swerner)).
Cycles: Fixed broken displacement
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB66e571dfadf2: Cycles: Fixed broken bump mapping (authored by Stefan Werner (swerner)).
Cycles: Fixed broken bump mapping
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rBc987f6e6e106: Cycles: improved texture differentials for bump maps, added texture… (authored by Stefan Werner (swerner)).
Cycles: improved texture differentials for bump maps, added texture…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB20825728f209: Cycles: added ray differentials to henyey-greenstein phase function (authored by Stefan Werner (swerner)).
Cycles: added ray differentials to henyey-greenstein phase function
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rBd85c76e7b998: Cycles: Moved texture coordinate differential creation to after all bump maps… (authored by Stefan Werner (swerner)).
Cycles: Moved texture coordinate differential creation to after all bump maps…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB697600e78408: Cycles: Fixes for texture caching, behavior with auto convert off was broken… (authored by Stefan Werner (swerner)).
Cycles: Fixes for texture caching, behavior with auto convert off was broken…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB92bf11548d94: Cycles: Smaller fixes for differentials, taking dNdu inot account when getting… (authored by Stefan Werner (swerner)).
Cycles: Smaller fixes for differentials, taking dNdu inot account when getting…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rBecdc2f7108b5: Ccyles: texture differentials now respect the hidden mapping node inside the… (authored by Stefan Werner (swerner)).
Ccyles: texture differentials now respect the hidden mapping node inside the…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rBf363d080caaf: Cycles: fix for mip map paths (authored by Stefan Werner (swerner)).
Cycles: fix for mip map paths
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rBbaf66bfa482e: Cycles: improved ray differentials for specular/glossy closures with DNDU/V… (authored by Stefan Werner (swerner)).
Cycles: improved ray differentials for specular/glossy closures with DNDU/V…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB3d1135385619: Cycles: Changed Mip Map names to replace, not add to suffix Added oiio_make_tx… (authored by Stefan Werner (swerner)).
Cycles: Changed Mip Map names to replace, not add to suffix Added oiio_make_tx…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rBa8e32a86e5ec: Cycles: more accurate differential approximation for glossy bounces (authored by Stefan Werner (swerner)).
Cycles: more accurate differential approximation for glossy bounces
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB15e5f06f38a0: Cycles: Don’t apply glossy blur texture filtering on singular paths (authored by Stefan Werner (swerner)).
Cycles: Don’t apply glossy blur texture filtering on singular paths
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB6d47a91220ac: Cycles: fixed normal differentials, ShaderData now contains dNdx/y instead of… (authored by Stefan Werner (swerner)).
Cycles: fixed normal differentials, ShaderData now contains dNdx/y instead of…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB443b91aebe73: Cycles: Smaller updates to texture cache, setting a few more options and… (authored by Stefan Werner (swerner)).
Cycles: Smaller updates to texture cache, setting a few more options and…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB6450e35a2f6d: Cycles: added diffuse_blur and glossy_blur parameters to texture cache (authored by Stefan Werner (swerner)).
Cycles: added diffuse_blur and glossy_blur parameters to texture cache
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB1bcad0d920ae: Cycles: fixed include statements for image cache to work on case-sensitive file… (authored by Stefan Werner (swerner)).
Cycles: fixed include statements for image cache to work on case-sensitive file…
Jun 27 2018, 2:05 PM
Stefan Werner (swerner) committed rB2925298d96c6: Cycles: Added dPdu/dPdv to area ligths so we can use filtered textures on them (authored by Stefan Werner (swerner)).
Cycles: Added dPdu/dPdv to area ligths so we can use filtered textures on them
Jun 27 2018, 2:05 PM