Sat, Jan 25
Fri, Jan 24
This is a diff from master with D6658 applied, so I'll commit this after that if you review that one too. Thanks!
If, as you say, this needs further testing and refinement, should I wait until you think it is ready? Or would you like to get this into the 2.83 beta to get users to try it out now? As far as I can tell, this should not affect existing uses of bevel (right?), so there is low risk. But we do want to make sure that this doesn't turn into a source of a large number of immediate bug reports.
- Remove two empty lines
- Update active tool UI
Thu, Jan 23
Wed, Jan 22
I agree that "Current Frame" is more intuitive than "Playhead." It's not clear what "Playhead" means if you don't already know the word, but "Current Frame" is clear based on the meaning of two simpler words.
As someone who has been through the "compile blender for the first time" process more recently than anyone commenting already, I'll give my opinion.
Mon, Jan 20
Fri, Jan 17
Thu, Jan 16
Tue, Jan 14
Mon, Jan 13
This revision was not accepted when it landed; it landed in state Needs Review.
Improved precision of multiplication, merged master
Solve compiler warnings
Sun, Jan 12
One more simplification to remove
Remove non-functional changes.
Thanks for the patch.
To simplify the review it would be nice to separate non-functional changes (cleanup) from functional changes into different patches.
Probably the cleanup will be accepted quickly.
Alright, sure! I guess I can't sneak some comments in with the patch :P
Sat, Jan 11
Fri, Jan 10
Are there plans to also support OIDN? There are still lots of non-Optix systems out there and LuxCore is working nicely with OIDN viewport denoising.
Wed, Jan 8
An alternative idea would be to make the circle tangent to the planes that the beveled edge is between. That is, use the angle between the planes to set the offset that gives a tangent circle of a given radius.
I think I tried this at one point but decided to pursue using the angle between the edges that constrain the profile. I would be happy to check it out again though. If there are two planes on both sides of the profile (i.e. a bevel chain), would you average the angles between both of the planes?
Fri, Jan 3
Tue, Dec 31
That's a known issue with the way the fill is triangulated. When there's overlap (the profile crosses over itself) it can look pretty glitchy. In that case it would create bad geometry in the bevel anyway, and for most situations it works well, so I don't think it's a huge problem.
Is there a way to save a set of custom profiles and then just choose from them to faster iterations?
@Martin Felke (scorpion81) Thanks for looking into this! In general the Python API for the CurveProfile might not have the best UX. If there are any improvements I can make to that I'd be happy to. As a more long-term goal I'd like the widget to be useful in more places in Blender. Try adding an update call after adding a point. It doesn't do that automatically because it's a relatively more expensive operation.
Mon, Dec 30
The issue is that there are thousands of open bug reports so it's important to make it clear that the bug tracker is just for bugs (code that was intended to work but doesn't).
Dec 23 2019
Thank you! That's helpful. I'm just a volunteer who's been working with bevel so I figured I would take a look.
Dec 22 2019
Thanks for the report!
Dec 21 2019
Dec 20 2019
Dec 19 2019
This looks great! It would be good to add the units to the number as well though, it could be confusing working at different scales than this.
Dec 13 2019
I can't reproduce this on rBc8d121bf352b : /
Dec 12 2019
Interesting. It looks like we need a way to give the popover some information about which UI it should draw. Maybe updating popover is the way to go. Not sure though.
Right now I'm basing this off of the commit before the overlay refactor because of T72152, but the UI commit could be merged in to have both changes together.
@Asher (ThatAsherGuy) That looks great! And the other options are in the icon dropdown?
Closed by commit rBd7a8a606889f
Forgot to add: Reviewed by Campbell Barton and WIlliam Reynish.
- The popover is generic now, and could be applied to any tool that has too many settings for the header.
- The drawing code is de-duplicated.
Could you update your report with the Blender version you're using? Thanks.
Dec 11 2019
- Remove some print statements
@William Reynish (billreynish) Do you have time to look at this before BCon2? It's a pretty small change, and sort of silly these options aren't there already.
- Added custom profile widget and option to settings
I updated the wiki page. I ran across this earlier too, so thanks for pointing it out. Hopefully that change will save some people a few minutes.