Page MenuHome
Feed Advanced Search

Sat, Jun 22

Peter Fog (tintwotin) awarded D4426: VSE movie strip previews a Love token.
Sat, Jun 22, 6:56 AM · Video Sequencer

May 9 2019

Guillaume M (mathers) added a comment to D4426: VSE movie strip previews.

I might take a look at this over the weekend - @Guillaume M (mathers) and @Richard Antalik (ISS), would you have any pointers for do's and dont's, with regards the new caching system changes?

May 9 2019, 2:42 PM · Video Sequencer

Apr 2 2019

Mal Duffin (mal_cando) awarded D4426: VSE movie strip previews a Like token.
Apr 2 2019, 12:25 PM · Video Sequencer

Mar 18 2019

Adam Bach (bachadam) awarded D4426: VSE movie strip previews a Love token.
Mar 18 2019, 4:34 PM · Video Sequencer

Mar 4 2019

Olly Funkster (Funkster) awarded D4426: VSE movie strip previews a Love token.
Mar 4 2019, 12:18 PM · Video Sequencer

Mar 1 2019

Mattias Ohlsson (mon) awarded D4426: VSE movie strip previews a Love token.
Mar 1 2019, 11:10 AM · Video Sequencer
Okavango (Okavango) awarded D4426: VSE movie strip previews a Love token.
Mar 1 2019, 10:51 AM · Video Sequencer

Feb 28 2019

Pablo Vazquez (pablovazquez) awarded D4426: VSE movie strip previews a Love token.
Feb 28 2019, 11:59 PM · Video Sequencer
Guillaume M (mathers) closed T62063: Python error on extrude as Invalid.

*facepalm* sorry for wasting your time, I forgot to run make install..... closing now

Feb 28 2019, 10:57 PM · BF Blender
Guillaume M (mathers) updated the task description for T62063: Python error on extrude.
Feb 28 2019, 10:24 PM · BF Blender
Guillaume M (mathers) created T62063: Python error on extrude.
Feb 28 2019, 10:04 PM · BF Blender
Guillaume M (mathers) updated Guillaume M (mathers).
Feb 28 2019, 3:25 PM
Guillaume M (mathers) created D4426: VSE movie strip previews.
Feb 28 2019, 2:24 PM · Video Sequencer

Feb 27 2019

Guillaume M (mathers) added a watcher for Quick Hacks: Guillaume M (mathers).
Feb 27 2019, 5:38 PM

Feb 26 2019

Guillaume M (mathers) added a comment to D4262: Cleanup sequencer proxy properties panel.

Ok @Campbell Barton (campbellbarton) @Richard Antalik (ISS) is it good for you ?

Feb 26 2019, 2:52 PM · Video Sequencer
Guillaume M (mathers) updated the diff for D4262: Cleanup sequencer proxy properties panel.

Removed the poll function for selection-based proxy tools

Feb 26 2019, 2:50 PM · Video Sequencer
Guillaume M (mathers) added a comment to D4262: Cleanup sequencer proxy properties panel.

@Campbell Barton (campbellbarton) The "enable proxies on selected strips" operates on all selected strips, therefore the poll function must iterate on all selected strips.

Feb 26 2019, 1:19 PM · Video Sequencer

Feb 24 2019

Guillaume M (mathers) created T61913: Render frames range.
Feb 24 2019, 7:53 PM · Rendering, BF Blender

Feb 14 2019

Guillaume M (mathers) added a comment to T57818: Grease Pencil: various issues.

I agree that the many types of brushes is confusing, I think we should ideally get down to three types of brushes :

  • Raster brushes : texture paint, image paint, weight paint (not sure for this one)
  • Vector brushes : grease pencil
  • Sculpt brushes : sculpt mode, but also gp sculpt
Feb 14 2019, 1:12 PM · Grease Pencil, BF Blender: 2.8

Feb 11 2019

Guillaume M (mathers) added inline comments to D4262: Cleanup sequencer proxy properties panel.
Feb 11 2019, 10:33 AM · Video Sequencer

Feb 4 2019

Guillaume M (mathers) added a comment to D3934: VSE cache with frame prefetching (WIP).

I read your updated doc, and here are a few notes :

    • I think we can keep a single thread for prefetching : rendering a single frame should already be multithreaded in many cases (renders, effects, etc...). Would doing this remove the need for error-prone scene copying, or is it inevitable ?
  • I have many issues with a simple color strip : it initially apprears black, then when I enable prefetching it turns red, but there is no prefetching... When i scrub it flickers from red to black, etc...
  • I would love to see support for scene strips, disk cache, and per-strip selection (pretty much everything you mention in "TODOs" !)
  • I would love for there to be a "Prefetch this whole strip" option, to enable pre-composition of scene or meta strips. It would have to cache to disk in this case, and prefetch even frames where the strip is not visible (when it is under another strip for instance).
Feb 4 2019, 8:38 PM · Video Sequencer

Feb 1 2019

Guillaume M (mathers) added a comment to D4288: Implemented basic pre-fetching in Sequencer.

My patch is not outdated it should apply cleanly and partial review is still pretty much possible.

Sorry I mush have confused this patch with D3597.

Feb 1 2019, 2:11 PM · Video Sequencer
Guillaume M (mathers) added a comment to D4288: Implemented basic pre-fetching in Sequencer.

By doing incremental changes, this situation can happen if we are not extremely careful. That's why in case of big rewrites we work on branches that if functional and "bug-free", they will be merged in master branch.

Feb 1 2019, 10:43 AM · Video Sequencer

Jan 31 2019

Guillaume M (mathers) added reviewers for D4288: Implemented basic pre-fetching in Sequencer: Brecht Van Lommel (brecht), Sergey Sharybin (sergey).
Jan 31 2019, 10:52 PM · Video Sequencer
Guillaume M (mathers) added a comment to D4288: Implemented basic pre-fetching in Sequencer.

Hi @Richard Antalik (ISS), I would be glad to collaborate on this, and I'm sorry your patch was not merged before it got outdated. I think one of the reasons is it was very long (4 kloc !) and hard to review.

Jan 31 2019, 10:51 PM · Video Sequencer
Guillaume M (mathers) added a comment to T60912: Sequencer proxies and cache.

I cleaned up an old unused threading api : D4289

Jan 31 2019, 5:38 PM · Video Sequencer, BF Blender
Guillaume M (mathers) created D4289: Removed dead code in sequencer API.
Jan 31 2019, 5:37 PM · Video Sequencer
Guillaume M (mathers) updated subscribers of T60912: Sequencer proxies and cache.
Jan 31 2019, 5:37 PM · Video Sequencer, BF Blender
Guillaume M (mathers) added a comment to T60912: Sequencer proxies and cache.

I implemented some pre-fetching using ImBuf's own caching system (which takes care of invalidation etc.) : D4288

Jan 31 2019, 4:49 PM · Video Sequencer, BF Blender
Guillaume M (mathers) created D4288: Implemented basic pre-fetching in Sequencer.
Jan 31 2019, 4:38 PM · Video Sequencer

Jan 29 2019

Guillaume M (mathers) added a comment to T60912: Sequencer proxies and cache.

@Richard Antalik (ISS) Disk cache would be implemented at the level of IMB right ? Is this going to be enough to cache everything we need ? Do we need to implement cache invalidation code or is it going to work natively through IMB's reference counting ? I did a simple test with a blur effect and it looks like cache invalidation works fine as it is.

Jan 29 2019, 2:32 PM · Video Sequencer, BF Blender

Jan 28 2019

Guillaume M (mathers) added a comment to T60912: Sequencer proxies and cache.

@Richard Antalik (ISS) Hmm okay, so there will be caches on several levels when compositing. A RAM cache is already implemented, right ? Is it a strip-level or global-level cache ?

Jan 28 2019, 5:05 PM · Video Sequencer, BF Blender
Guillaume M (mathers) added a comment to T60912: Sequencer proxies and cache.

@paul szajner (szap) Proxy support for scenes has been temporarily removed in the master branch, because the proxy function was originally designed only for movie strips.

Jan 28 2019, 11:19 AM · Video Sequencer, BF Blender

Jan 27 2019

Guillaume M (mathers) added a project to T60912: Sequencer proxies and cache: Video Sequencer.
Jan 27 2019, 5:03 PM · Video Sequencer, BF Blender
Guillaume M (mathers) updated the diff for D4262: Cleanup sequencer proxy properties panel.

Minor code cleanups

Jan 27 2019, 1:53 PM · Video Sequencer
Guillaume M (mathers) added a comment to T60912: Sequencer proxies and cache.

Improve the sequencer proxy UI : D4262

Jan 27 2019, 12:47 PM · Video Sequencer, BF Blender
Guillaume M (mathers) updated the diff for D4262: Cleanup sequencer proxy properties panel.

Added changes suggested by @Richard Antalik (ISS) : selection-based operators are greyed out when no compatible strips are selected, and other cosmetic changes.

Jan 27 2019, 12:45 PM · Video Sequencer
Guillaume M (mathers) added a comment to D3597: Add proxy support for all sequences.

A design task clearly detailing the goals, timeframes, scopes and functionality would be desirable, so other developers and uses can see what you have planned and what you intend to fix and work on. (Something like T46049: Assets Integration in Blender with T59540#583476)

Jan 27 2019, 10:59 AM · Video Sequencer
Guillaume M (mathers) triaged T60912: Sequencer proxies and cache as Normal priority.
Jan 27 2019, 10:58 AM · Video Sequencer, BF Blender
Guillaume M (mathers) created T60912: Sequencer proxies and cache.
Jan 27 2019, 10:57 AM · Video Sequencer, BF Blender

Jan 26 2019

Guillaume M (mathers) created D4262: Cleanup sequencer proxy properties panel.
Jan 26 2019, 11:16 PM · Video Sequencer
Guillaume M (mathers) added a comment to D3597: Add proxy support for all sequences.

If I understand correctly, the plan is to :

  • Drop proxy support for all sequences except movies (it would also be dropped for clips and image sequences right ?). All proxies would be ffmpeg-encoded avi files, no image sequences.

Not quite. Movieclips do have "own" proxy management. Builder is shared, but you can not build proxies for movieclip from sequencer

Jan 26 2019, 10:16 PM · Video Sequencer

Jan 25 2019

Guillaume M (mathers) added a comment to D3597: Add proxy support for all sequences.

Since proxies are only for movies, I think ot would make sense to add a "batch process" feature so the user can generate proxies for all his footage before even importing them in blender. I find it frustrating to wait for proxy generation each time I import a clip.

Jan 25 2019, 5:43 PM · Video Sequencer
Guillaume M (mathers) added a comment to D3597: Add proxy support for all sequences.

By the way, when generating several proxies (25%...100%) for a non-vse scene (3d render), the fastest way would be to generate the highest-res proxy first, then downscale it to obtain the other proxy resolutions, right ? How feasible would this be ?

Not applicable - as I said this will be done by cache management. *Only* movies will have proxies.

I'm not sure what you mean by that. I think it's important to separate proxies and pre-fetching.

First let's clear definitions: Proxy is close enough representation of original file, pre-processed to have required properties(fast scrubbing, scaled), so working with it is more time efficient.
Prefetching has nothing to do with dumping cache.
As cache is generated, it can be stored on disk. When cache is polled for frame, it will look first in RAM, if frame is not found, is can look at disk - still faster then re-render in most cases.
this dumped data however *have to be* stored individually, as it may be requested to be deleted/flagged as out-of-date (properties of strip has changed -> invalidate cache).

Yes I'd like to spend a bit of time on these issues, but I feel this patch is getting way too big and hard to merge/apply. I think it's important to separate proxy generation, pre-fetching and interface changes in several incremental patches (trying to keep their size to <100 lines).
I'm not sure how the blender git tree is organized, but from my perspective it would make sense to develop these features in a separate branch, and to make minimal (and documented) changes to the API, so it is easier to merge in the master branch later.

Some cleaning of old code, refactoring and updating UI to reflect reality
Small changes are good approach, but end goal should be discussed. With prefetching I changed same code number of times, because I was not familiar with basics, and therefore couldn't plan changes in detail.

Jan 25 2019, 5:20 PM · Video Sequencer
Guillaume M (mathers) added a comment to D3597: Add proxy support for all sequences.

You would have to look by date, but this patch needs to be reworked:

  • to keep things simple, code cleanup done in this patch should be dropped
Jan 25 2019, 1:03 PM · Video Sequencer
Guillaume M (mathers) added a comment to D3597: Add proxy support for all sequences.

Hi @Richard Antalik (ISS) , I'm trying to test your patch, but I am unable to apply it to the master branch. What is the base commit for this patch ?

Jan 25 2019, 2:07 AM · Video Sequencer
Guillaume M (mathers) awarded D3597: Add proxy support for all sequences a Like token.
Jan 25 2019, 1:14 AM · Video Sequencer

Jan 10 2019

Guillaume M (mathers) added a comment to D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence.

That's fine by me, you can revert rBbb98e83b99 and submit a new revision that solves T55668 without introducing T60194.

Jan 10 2019, 5:13 PM · Video Sequencer
Guillaume M (mathers) added a comment to D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence.

In the newly introduced bug, the curves are initially not functioning, but "spring into action" as soon as any kind of animation data is changed in the strip (even a cancelled move - hitting G on a keyframe and hitting ESC) .

Jan 10 2019, 11:52 AM · Video Sequencer
Guillaume M (mathers) added a task to D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence: T60370: Keyframes on Cut-ted strips.
Jan 10 2019, 11:24 AM · Video Sequencer
Guillaume M (mathers) added a revision to T60370: Keyframes on Cut-ted strips: D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence.
Jan 10 2019, 11:24 AM · BF Blender
Guillaume M (mathers) added a comment to T60194: Sequencer cut loses animation data for the right strip.

After a bit more testing, it looks like this patch indeed solves this bug, but also introduces a new minor bug T60194.

Jan 10 2019, 11:24 AM · Video Sequencer, BF Blender
Guillaume M (mathers) added a revision to T60194: Sequencer cut loses animation data for the right strip: D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence.
Jan 10 2019, 11:22 AM · Video Sequencer, BF Blender
Guillaume M (mathers) added a task to D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence: T60194: Sequencer cut loses animation data for the right strip.
Jan 10 2019, 11:22 AM · Video Sequencer
Guillaume M (mathers) added a comment to D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence.

After a bit more testing, it looks like this patch indeed solves major bug T60194, but also introduces minor bug T60194.

Jan 10 2019, 11:22 AM · Video Sequencer
Guillaume M (mathers) added a comment to T60370: Keyframes on Cut-ted strips.

Sorry about that, it looks like I introduced this bug in my local build by applying a patch I made to solve this bug : T60194

Jan 10 2019, 11:19 AM · BF Blender
Guillaume M (mathers) added a comment to T60194: Sequencer cut loses animation data for the right strip.

After applying my patch, I was unable to reproduce T55668. It looks like each strip its given a unique name properly, even with nested Meta-Strips.

Jan 10 2019, 12:12 AM · Video Sequencer, BF Blender
Guillaume M (mathers) created D4186: Set names of cut sequences properly, so that the duplicated animation data is attached to the right sequence.
Jan 10 2019, 12:09 AM · Video Sequencer
Guillaume M (mathers) created T60370: Keyframes on Cut-ted strips.
Jan 10 2019, 12:00 AM · BF Blender

Jan 6 2019

Guillaume M (mathers) added a project to T60194: Sequencer cut loses animation data for the right strip: Video Sequencer.
Jan 6 2019, 12:38 PM · Video Sequencer, BF Blender

Jan 5 2019

Guillaume M (mathers) added a comment to T60194: Sequencer cut loses animation data for the right strip.

Hi,
After investigation, I believe I can submit a patch that solves this issue. Please let me know what you think and how much testing this requires

Jan 5 2019, 12:28 PM · Video Sequencer, BF Blender
Guillaume M (mathers) created T60194: Sequencer cut loses animation data for the right strip.
Jan 5 2019, 11:25 AM · Video Sequencer, BF Blender
Guillaume M (mathers) added a comment to T54048: VSE : Mangled proxy directory for scene/meta strips.

I've been using my patch since Feb. without any issues, therefore I believe adding support for clip, sene and meta proxies is an easy task, although I'm not familiar enough with the Blender coding conventions to submit a commit myself.

Jan 5 2019, 11:14 AM · Video Sequencer, BF Blender

Feb 15 2018

Guillaume M (mathers) added a comment to T54048: VSE : Mangled proxy directory for scene/meta strips.

But are we really calling this proxy function with sound strips ? Maybe we should show a warning if we reach this point ?

Feb 15 2018, 12:41 PM · Video Sequencer, BF Blender

Feb 14 2018

Guillaume M (mathers) added a comment to T54048: VSE : Mangled proxy directory for scene/meta strips.

No, they should have a unique proxy path. I am not an expert, but for scene and meta clips, using seq->name seems to do the job.

Feb 14 2018, 11:03 AM · Video Sequencer, BF Blender

Feb 12 2018

Guillaume M (mathers) added a comment to T54048: VSE : Mangled proxy directory for scene/meta strips.

Is this what's happening in my proxy crash report? T53792 F1838958

Feb 12 2018, 11:42 AM · Video Sequencer, BF Blender

Feb 11 2018

Guillaume M (mathers) created T54048: VSE : Mangled proxy directory for scene/meta strips.
Feb 11 2018, 12:37 AM · Video Sequencer, BF Blender