I just reproduced this bug locally.
Mon, Sep 2
Fri, Aug 23
Thu, Aug 22
I know this looks indirect but the button is only left-aligned when we also want to force it to become a UI_BTYPE_MENU, via the force_menu argument. Which from my research we only need to do for popovers in panels.
Wed, Aug 21
Tue, Aug 20
I've seen other community members get their patch in by using their nickname instead of their email. Git doesn't have any rules about the Author line format needing a valid email.
git commit --amend --author="Other Person <firstname.lastname@example.org>" works in Phabricator.
@Campbell Barton (campbellbarton) I could've added the rest of the URLs as I offered, and the other edits as well.
Avoid a neverending Python tooltip on the bug reporting menu buttons.
By creating a generic way to open preset websites that have more informative tips too.
Mon, Aug 19
Thanks Brecht :)
Sun, Aug 18
I missread the review. Nesting the if is cleaner.
I initially had just chained a third clause to the if condition and then worried about readability.
Aug 17 2019
Proposed fix D5508
Aug 16 2019
This is how the snapping popover looks to me in git master. It is the same as with my patch. Not sure this is the place you are alluding to @Brecht Van Lommel (brecht)
My patch doesn't affect it but I want to make sure I'm looking at the right place.
Will work on the cleaner fix soon. Thanks @Campbell Barton (campbellbarton)
Aug 15 2019
Thanks for fixing this :)
This code has been compiled out since August 1st 2017.
Aug 14 2019
My other approach is to make sure a uiBut has text before aligning it left. If it doesn't have text it should use the default center align.
Hi Brecht, I did this approach because I thought it didn't affect adversely other menu buttons.
Aug 13 2019
@Harley Acheson (harley) Thanks for the quick and informative response. I will read the other functions that call ui_text_icon_width() and see if I can come up with a better approach.
I think I have found the problem: when we calculate the width of the UI Item (as part of setting RNA callbacks to calculate the x, y, width, height in wm_draw_window_offscreen()) we are giving it too much margin.
Aug 8 2019
Ray answered a few of my questions about the relationship between DNA, RNA and Python. Now things are much clearer to me. Including that I should look at Python files in release/scripts/startup/bl_ui.
It's been a week so I wanted to give an update.
Aug 2 2019
Sounds good. I have time tomorrow to start exploring the code around this and then I will report back.
Aug 1 2019
I was recommended in IRC to just assign it to myself. "Be bold!"