Page MenuHome
Feed Advanced Search

Feb 26 2015

Troy Sobotka (sobotka) added a comment to T25249: Option to configure ffmpeg YCbCr transform.

It can be a matrix and I have both broadcast and full range versions. I will look into this possibly after I fix the XYZ hard coded paths.

Feb 26 2015, 10:38 PM · Nodes, BF Blender

Feb 21 2015

Troy Sobotka (sobotka) added a comment to D1082: Color Managed Luminance Repair Work.

Where are we at on this?

Feb 21 2015, 3:33 AM · BF Blender

Feb 18 2015

Troy Sobotka (sobotka) added a comment to D1082: Color Managed Luminance Repair Work.

Seriously folks, it uses a global value. There is el-zippo performance issue here.

Feb 18 2015, 2:24 AM · BF Blender

Feb 17 2015

Troy Sobotka (sobotka) added inline comments to D1082: Color Managed Luminance Repair Work.
Feb 17 2015, 11:29 PM · BF Blender

Feb 13 2015

Troy Sobotka (sobotka) added inline comments to D1082: Color Managed Luminance Repair Work.
Feb 13 2015, 6:58 PM · BF Blender
Troy Sobotka (sobotka) updated the diff for D1082: Color Managed Luminance Repair Work.

Addresses Sergey's remaining concerns.

Feb 13 2015, 6:56 PM · BF Blender

Feb 11 2015

Troy Sobotka (sobotka) added a comment to D1082: Color Managed Luminance Repair Work.

Also, sorry for spam, but BLI_INLINE doesn't work according to Bishop and testing, without the luminance function being BLI_INLINEd as well.

Feb 11 2015, 4:05 PM · BF Blender
Troy Sobotka (sobotka) added a comment to D1082: Color Managed Luminance Repair Work.

Regarding legacy files, I believe the worst case weight mangling was approximately 15% for green. I am unsure how to proceed in the color cleanups regarding legacy files, and advice would be appreciated. Versioning strikes me as a potentially problematic implementation?

Feb 11 2015, 4:01 PM · BF Blender

Feb 10 2015

Troy Sobotka (sobotka) retitled D1095: Remove legacy gamma_correct() function from to Remove legacy gamma_correct() function.
Feb 10 2015, 8:51 PM · BF Blender
Troy Sobotka (sobotka) updated the diff for D1082: Color Managed Luminance Repair Work.

Hopefully fixes the oopsied last diff.

Feb 10 2015, 7:41 PM · BF Blender
Troy Sobotka (sobotka) updated the diff for D1082: Color Managed Luminance Repair Work.
Feb 10 2015, 7:30 PM · BF Blender

Feb 9 2015

Troy Sobotka (sobotka) updated the diff for D1082: Color Managed Luminance Repair Work.

Updated patch.

Feb 9 2015, 8:17 PM · BF Blender
Troy Sobotka (sobotka) added a comment to D1082: Color Managed Luminance Repair Work.

@Antony Riakiotakis (psy-fi)

I'm not 100% certain if all the operations here are in display or linear space. I think compositor is linear, but image (divers.c) and imagefile (png.c) might not be.

Feb 9 2015, 7:22 PM · BF Blender
Troy Sobotka (sobotka) updated the diff for D1082: Color Managed Luminance Repair Work.

Added and tested byte conversions as used by vertex_paint.c. Removed corresponding duplicated function.

Feb 9 2015, 1:22 AM · BF Blender
Troy Sobotka (sobotka) set the repository for D1082: Color Managed Luminance Repair Work to rB Blender.
Feb 9 2015, 1:11 AM · BF Blender
Troy Sobotka (sobotka) added a comment to D1082: Color Managed Luminance Repair Work.

Great spot @Kévin Dietrich (kevindietrich), which is exactly why I added you as a subscriber. I also saw one in Freestyle I believe, which is a Python file IIRC.

Feb 9 2015, 12:47 AM · BF Blender

Feb 8 2015

Troy Sobotka (sobotka) updated D1082: Color Managed Luminance Repair Work.
Feb 8 2015, 11:39 PM · BF Blender
Troy Sobotka (sobotka) updated D1082: Color Managed Luminance Repair Work.
Feb 8 2015, 11:38 PM · BF Blender
Troy Sobotka (sobotka) closed T43600: Repair legacy luminance / greyscale conversions as Invalid.

Marking as invalid and putting relevant data under the Differential based on @Julian Eisel (Severin)'s advice.

Feb 8 2015, 11:37 PM · BF Blender
Troy Sobotka (sobotka) claimed T43600: Repair legacy luminance / greyscale conversions.
Feb 8 2015, 11:32 PM · BF Blender
Troy Sobotka (sobotka) added a task to D1082: Color Managed Luminance Repair Work: T43600: Repair legacy luminance / greyscale conversions.
Feb 8 2015, 10:51 PM · BF Blender
Troy Sobotka (sobotka) added a revision to T43600: Repair legacy luminance / greyscale conversions: D1082: Color Managed Luminance Repair Work.
Feb 8 2015, 10:51 PM · BF Blender
Troy Sobotka (sobotka) added a reviewer for D1082: Color Managed Luminance Repair Work: Antony Riakiotakis (psy-fi).
Feb 8 2015, 10:51 PM · BF Blender
Troy Sobotka (sobotka) retitled D1082: Color Managed Luminance Repair Work from to Color Managed Luminance Repair Work.
Feb 8 2015, 10:51 PM · BF Blender
Troy Sobotka (sobotka) created T43600: Repair legacy luminance / greyscale conversions.
Feb 8 2015, 10:48 PM · BF Blender
Troy Sobotka (sobotka) added a comment to D1009: Adding bicubic sampling to the compositor..

The fuzzy is because cubic never passes through the sampled values.

Feb 8 2015, 6:04 PM · Compositing

Jan 15 2015

Troy Sobotka (sobotka) added a comment to D947: Adding a Highlight Compression tonemapper to the color management.

Sergey is 100% correct: this patch is sub-optimal as it currently exists.

Jan 15 2015, 6:32 AM · Images & Movies

Dec 30 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

A few points, and I'd prefer to cover the follow ups via email as this report is already cluttered up enough for developers that need to tackle the complex issue. You can reach me here.

Dec 30 2014, 12:20 AM · BF Blender

Dec 29 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

@Troy Sobotka (sobotka)
In general artists work in srgb space for videos and adobe rgb for paper. Then do a color conversion to match the output device. So srgb is good even if your final output is different (rec709 dci or whatever). At least this is how they recommend to work at Eizo (see page 13).

Dec 29 2014, 9:41 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

Forcing an artist to enter linear values instead of sRGB is the same as forcing someone to enter binary numbers instead of decimals. Linear values don't mean anything to artists. Artists are used to Photoshop or Painter that use sRGB space, the same as almost any graphics application around.

Dec 29 2014, 6:27 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T43025: linear color space issues (2.73 rc1).

padone, assuming any single color space for the color wheel is simply incorrect, as outlined in the other report.

Dec 29 2014, 6:08 PM · BF Blender

Oct 3 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

Apologies. You are quite right... It was never intended as harsh.

Oct 3 2014, 5:47 PM · BF Blender

Sep 28 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

@David Black (david_black) You are mixing apples and oranges when discussing Photoshop. Photoshop operates on curved non-linear display spaces by default, and I believe it only recently, if at all, color manages the wheel. So it is in no way linear, nor even belongs in this discussion.

Sep 28 2014, 4:00 AM · BF Blender

Sep 2 2014

Troy Sobotka (sobotka) added a comment to T41670: COLOR MANAGEMENT: Scene "Use Curves" Black / White Level Scaling Odd?.

I am.

Sep 2 2014, 10:55 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T41670: COLOR MANAGEMENT: Scene "Use Curves" Black / White Level Scaling Odd?.

Then the UV picker is screwed again.

Sep 2 2014, 10:33 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T41670: COLOR MANAGEMENT: Scene "Use Curves" Black / White Level Scaling Odd?.

I've tried to do a very simple example here with scaling. A simple 8 bit sRGB PNG is embedded.

Sep 2 2014, 10:05 PM · BF Blender

Sep 1 2014

Troy Sobotka (sobotka) created T41670: COLOR MANAGEMENT: Scene "Use Curves" Black / White Level Scaling Odd?.
Sep 1 2014, 4:54 AM · BF Blender

Aug 29 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.
Aug 29 2014, 4:57 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

@Antony Riakiotakis (psy-fi):

this last patch addresses the transfer curve portion issue but display interpolation is still done in a linear manner across endpoints of the triangles that make up the color wheel during display. Also you'd need to change the code in the vertical widgets to use the unmodified value for displaying the slider, see ui_draw_but_HSV_v. also would probably need to be hooked up in the update functions

Aug 29 2014, 4:37 PM · BF Blender

Aug 27 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

So as to (for example) not apply to theme colors which are sRGB always.

Aug 27 2014, 4:55 AM · BF Blender

Aug 22 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

So I have completely redone how the original HSV wheel handled color, and tested quite extensively.

Aug 22 2014, 5:59 AM · BF Blender

Aug 20 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

So an update...

Aug 20 2014, 2:06 AM · BF Blender
Troy Sobotka (sobotka) added a comment to T41498: Color Management: Implement Color Picker Role.

Aug 20 2014, 2:01 AM · BF Blender
Troy Sobotka (sobotka) created T41498: Color Management: Implement Color Picker Role.
Aug 20 2014, 2:00 AM · BF Blender

Aug 19 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

It all makes much more sense to me now. I suppose the most relevant example of this for me is when I render/composite my image on my right monitor exactly how I want, yet when I drag the image to my left monitor the color is barely different enough to be annoying. While it is annoying, it's quite minor compared to shifting a fundamental aspect of building materials.

Aug 19 2014, 8:31 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

I would add that many artists are going to likely split right down the middle on this regarding whether to display the transfer curve as perceptual (current) or display linear (previous) and there is no right or wrong, but rather expectation and experience.

Aug 19 2014, 7:07 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

At the request of Pablo, I quickly did up the explanation above to highlight the bug from a colorimetry side.

Aug 19 2014, 6:48 PM · BF Blender
Troy Sobotka (sobotka) added a comment to D517: Code cleanup: de-duplicate RGB to Grayscale conversion.

I've done a little more hunting and can only conclude that the 0.35 red, 0.58 green, and the 0.20 blue belongs to no known primaries that I can find. They appear absolutely arbitrary and entirely out of line with Blender's internally assumed reference space based on the default OpenColorIO configs.

Aug 19 2014, 12:04 AM

Aug 12 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

I tend to agree with maisef here in that language is useful.

Aug 12 2014, 7:22 PM · BF Blender

Aug 11 2014

Troy Sobotka (sobotka) added a comment to D297: Color Ramp HSV Interpolation Modes.

Sadly, all of the functions here make assumptions of the RGB reference space being sRGB / 709, which is likely unfortunate due to:

  1. Hard coded reference space assumptions are a Bad Thing(TM) and make the results entirely incorrect and / or unpredictable depending on an artist's chosen reference space.
  2. Work against and will cause bugs given a proper color managed system, especially with regard to correctly displaying color.
Aug 11 2014, 11:04 PM

Aug 4 2014

Troy Sobotka (sobotka) added a comment to T41287: Color Picker applies color management incorrectly in 2.71.

Color management on pickers and swatches goes much further than merely transfer curves.

Aug 4 2014, 8:00 PM · BF Blender

Jul 25 2014

Troy Sobotka (sobotka) added a comment to T41173: COLOR MANAGEMENT: View selection is difficult with multiple views.

With the default window size, the text is already clipping.

Jul 25 2014, 4:18 PM · BF Blender
Troy Sobotka (sobotka) created T41173: COLOR MANAGEMENT: View selection is difficult with multiple views.
Jul 25 2014, 7:21 AM · BF Blender

May 26 2014

Troy Sobotka (sobotka) added a comment to T40359: Scene / Color Management: White Point Mapping Has Limit.

Oscar Baechler's EXR HDR Repository

May 26 2014, 12:36 AM · BF Blender
Troy Sobotka (sobotka) raised the priority of T40359: Scene / Color Management: White Point Mapping Has Limit from to Needs Triage by Developer.
May 26 2014, 12:36 AM · BF Blender

May 23 2014

Troy Sobotka (sobotka) added a comment to T40131: Color ramp values limited to 4.875 maximum.

“Okay, then I say it seems the HSV<->RGB conversion used by Blender now works well only between 0 and 1. Above V=1, it is an extrapolation and goes to infinity quickly when converting from HSV to RGB.”

May 23 2014, 3:16 PM · BF Blender
Troy Sobotka (sobotka) added a comment to T40131: Color ramp values limited to 4.875 maximum.

"sRGB is correct only between 0 and 1. What if you use linear space or scaled normalized vectors above V=1?"

May 23 2014, 1:55 AM · BF Blender
Troy Sobotka (sobotka) added a comment to T39707: Color Picker Values are wrong in Gamma Corrected properties and profiled displays.

I thought that I should add some relevant information, as solving this issue isn't quite as simple as it might first appear.

May 23 2014, 1:45 AM · User Interface, BF Blender

Apr 15 2014

Troy Sobotka (sobotka) added a comment to T39707: Color Picker Values are wrong in Gamma Corrected properties and profiled displays.

This extends beyond transfer curve to primaries. This means the actual color cannot be correctly displayed ever, regardless of color space selected, including sRGB.

Apr 15 2014, 12:05 AM · User Interface, BF Blender

Apr 13 2014

Troy Sobotka (sobotka) awarded T39707: Color Picker Values are wrong in Gamma Corrected properties and profiled displays a Like token.
Apr 13 2014, 10:22 PM · User Interface, BF Blender