• revert if (!ibuf || proxy_size == IMB_PROXY_NONE) {

It should be inactive because Cache Final, but it would need to check every sequence and if Cache Final is checked of once it should be active.
I don't think this is a good idea to add because it will cause Blender to slow down having to loop through all the sequences and check if Cache Final is selected, but we can add a global Enum for all the sequences that gets updated whenever a sequence is added deleted or when Cache Final is changed.

Test files to reproduce Speed difference between using 25% proxy and proxy file added to timeline.
**Steps to reproduce

• Add Blender.mp4
• Set Frame rate to more than what your computer will be able to play at
• Turn on proxy for the Movie
• Build 25% proxy
• Set proxy render size to 25%
• Turn on prefetch frame
• Play Video and take down average FPS
• Delete the video
• Add the Proxy_25.avi file
• Set proxy render size to no proxy, full render
• Set Frame rate to more than what your computer will be able to play at
• Play Video and take down average FPS

• Merge branch 'master' of git://git.blender.org/blender into Fix-T70415

Can you look at D6171 it is a python API that would make using the same function much simpler.

• Clean up code

• revert eSpaceSeq_Proxy_RenderSize to original numbers

The reason why proxy files at 25% are slower when added to timeline is because the VSE thinks its original size and runs

• When there are encoded proxy files, and the 'Proxy Render Size' is set to 'No proxy, full render' or 'Scene render size' it is actually using the 25% proxy file - and not the source file. This means that it is currently not possible to compare the play rates of the proxy files played as proxies and as clips played directly in the time line(No proxy, full render). (When in 'No proxy, full render', use Strip > Movie Strip > Set Render Resolution to see the current resolution matches the 25% proxy files)

Here is the patch D6368

I sent the wrong diff

Can you test

In T70415#819679, @Richard Antalik (ISS) wrote:

I could reproduce this, but I haven't opened this because I wanted to confirm cause of this.
But I can confirm that this is bug and the cause is in sequencer.c

/* dirty hack to distinguish 100% render size from PROXY_100 */
if (render_size == 99) {
  render_size = 100;
}

The preview_render_size should be replaced with enums and we wont need to use this hack.

I will make this into a enum menu

I will look into it

Can someone confirm that the bug still exists

In T67579#819993, @Logan Preshaw (WickedInsignia) wrote:

@Campbell Barton (campbellbarton) Brilliant!!
Which branch/build was this? Loaded blender-2.82-4659fa547166 (built today) and orbit didn't load as default on factory reset. Using a 3D Connexion Spacemouse Wireless on Windows 10.

• Update sequencer.c
• Update sequencer.c
• Update sequencer.c

In D6314#147251, @Richard Antalik (ISS) wrote:

I guess something like this could work, will have look into this in debug.
This diff doesn't revert rB450685b15664 actually
And there may be issue, that 50% proxy of clip that is 1000 x 1000 will be 500 x 500 regardless of what your project resolution is set to.

• Working Solution

Doesn't work

I tried 100% and there is no performance loss

I haven't been able to reproduce this bug in blender 2.81 can you please confirm that it still exists.

In D6314#146878, @Peter Fog (tintwotin) wrote:

I wonder if this one is related? https://developer.blender.org/T70415

• Update sequencer.c
• Update sequencer.c

• Update sequencer.c

• Update sequencer.c

• Update sequencer.c

• clang-format

• clang-format

I found the issue.I will post the patch after I update my code to the latest master

It was the resolution

In D6171#143554, @Richard Antalik (ISS) wrote:

Not commenting on code itself, but changes like this are discouraged unless there is very good reason to do them. Reason is, that it will break existing scripts or addons.

The reason for this change is that at least in my opinion it would make the api more consistent and I world make
Having the delete proxy code in the same method a lot cleaner

I haven’t been able to get this to work with rebase after current master.I think it has to due with https://developer.blender.org/rB64f8f7db7cce0c8923afcabb523f7400f744387e but more research is needed

Corrrect diff

Nice catch

• Report proxy deletion information
• Add warnings

• Code cleanup

In D6139#141348, @Richard Antalik (ISS) wrote:

Digging through WM API, I realized, that the invoke method, was actually used as a confirmation.
It was quite poor in execution, so it would be better if we could explain to user, what is going to happen. Not quite sure if that is possible

I will look into that.
Deleting proxy in the clip editor doesn’t have a confirmation and has the invoke

• More Descriptive Variable names
• Fix Crash

• Fix bug when multiple strips sellected
• Fix bug where record_run_no_gaps.blen_tc and folders aren't deleted
• Added Option: Delete Active selected strip proxy

In D6139#141135, @Peter Fog (tintwotin) wrote:

Really great you're having a go at this!
I'm getting an error when trying to delete proxy, when no proxy has been generated for the active Movie Strip, same thing with a sound strip.
record_run_no_gaps.blen_tc is left in the folder, after deleting.
Having more strips selected makes the operator unable to work. The operator should be able to work in two modes: one delete proxies of the active strip and another one delete proxies from all selected strips(the panel suggestion is having different panels for active and for full selection), and in the Sidebar Strip panel +Alt should make the operator work on the full selection.
Maybe a report on how many proxy files has been deleted could be nice in the Statusbar?

• Clean up return

when my Delete proxy patch is committed will you add delete proxy to the panel