- User Since
- Jan 4 2017, 10:29 AM (76 w, 1 d)
May 17 2018
Oh, right. Can I put the if around the if that checks for the selection of any vert/edge/face? Maybe I am not quite understanding how this should work...
Missed a space
Now looping over all objects regardless ofwhether type is set or not. Added check for SRT_SELECTED.
I think I don't understand what you mean, I can't seem to find a difference. What exactly is it, that's not working right now?
May 16 2018
May 15 2018
Is MESH_OT_edge_face_add under "Face Menu" a duplicate of MESH_OT_edge_face_add under the "Edge Menu" ?
May 14 2018
I don't know if this has been mentioned yet, but the Knife Project tool requires you to select two objects and then enter Edit mode on one of them. This is not possible with multi-object-mode, because you will always enter edit mode on both objects. One possible way of fixing this would be to simply require the user to 'pick' the object they want to project from (e.g. using the eyedropper feature).
Didnt compile because of a missplaced bracket
Moved CTX_data_view_layer into if statement
I also moved the BKE_view_layer_array_from_objects_in_edit_mode_unique_data call inside the if statement, so that it is not called every time.
Changed the way the seed gets handled in loop over objects, so that it gives a consistent result.
I also added a "Could not connect vertices" error message.
Moved error report outside of loop over objects.
OK, thank you for the info!
May 12 2018
- Second loop not needed.
Updated as requested.
It didnt seem to update this diff but instead created a new one D3349
May 10 2018
Last one was a wrong patch ...
BMEditMesh not needed in loop.
I have created a new function bm_connect_vert_pair (other name suggestions are welcome!) that basically does the same as edbm_vert_connect_exec before multi object edit. Then I used it in the new edbm_vert_connect_exec and also edbm_vert_connect_path_exec so that each operator only loops through the objects once.
May 9 2018
I see. I'll have some time this afternoon and then I will try and see what I can do.
And yes, thinking about it, the break is unnecessary.
Requested changes have been made.
May 8 2018
No problem, didn't took that long anyways :)
You can submit a new patch for review here: https://developer.blender.org/differential/diff/create/
Getting commit rights is not so easy, see https://wiki.blender.org/index.php/Dev:Doc/Process/Commit_Rights for more Info :)
May 7 2018
Oh I think someone was faster than me - didn't check the changes in the main task :(