- User Since
- Sep 29 2016, 6:09 PM (24 w, 6 d)
Mon, Mar 13
@Alberto Mardegan (mardy) I don't think it works for multiple instances of the sub-scene.
@Germano Cavalcante (mano-wii) sorry for the delay in replying, have been AFK on holiday. I agree that the recursive search every frame is not efficient. I ended up doing it this way in order to avoid changing any structs / file data, to make sure it was compatible with as much as possible. It would be much better to record the parent / child's pointers into the scene / strip struct at the point of adding the scene, and save this into the file somehow, rather than working it out from scratch every time.
Sat, Mar 4
Huh, well this is quite odd. I started a fresh blend from scratch using your audio, and everything pitch-wise was going fine UNTIL I moved the clip (with g). Then, all hell breaks loose and there is no way that I've found to get everything back in step.
Fri, Mar 3
Of course, but that would be a feature request so we cannot create a task on here. Perhaps on rightclickselect.com ? I could make a thread on there but won't have time to do it soon.
Yes, sorry about the coding style stuff... force of habit from the style used at work and in all my home projects! I just can't stop my fingers from doing C++ style comments. If people are generally happy with the functionality I'll reformat it (and make sure the patch still works against an up-to-date master).
Hmm... can't confirm with released 2.78b, and I use the pitch control fairly often and thought I was familiar with its various foibles.
Wed, Mar 1
No crash here, Linux x64 hash d2f4900 (somewhere in between 2.78b and 2.78c)
I use proxies quite a bit and don't recall any random crashes. What format are your source videos in? If you can create a sample that crashes every time and upload it that would be great.
Thu, Feb 23
Pretty sure that's not a bug... if you want to freeze-frame at your cut point, use hard cut (shift K). Soft cut followed by a cross is used to cross with moving pictures.
Feb 14 2017
In fact, in the description of the command (hover over it), it does say "independent of selection or locked state of strips" so I guess this is intentional.
Confirmed with master hash d2f4900. Also positioning cursor over clip 2 and removing gaps also moves clip 3 - basically locking has no effect on the remove gaps command.
Feb 9 2017
Because I felt like it, I have made D2506 which introduces Ken Burns Mode to Transform strips. If you find it helps then use it, if you don't then don't! :o)
Feb 8 2017
Patch made, just have to twist the arm of one of the devs to commit it :o)
Jan 27 2017
I downloaded your phone video, and I think that it does not have a consistent framerate - as algorith noted its average framerate is 26.57fps, but even with blender set to that rate it doesn't map correctly.
I use mixed framerates a lot, so I made blender cope with it better than it does... it's not quite production ready yet as I do notice bugs when I'm using it, but I no longer rely on the "speed control" strip.
Dec 5 2016
Dec 1 2016
Huh. Confirmed using your command - I was using -f to render one frame rather than start and end frames.
I've tried a few variations, but always get the same size image as the one generated in interactive rendering.
Nov 25 2016
TBH I didn't see anything specific to text strips in the debugger - it fails trying to load proxies on the following sequences:
Found a crash while looking at a slightly dodgy file, updated the diff to fix it.
I found a crash in the form of an infinite recursion loop in calculate_evaluation_frame_offset_recursive while looking at a (somewhat dodgy) file in T50112. Fixed by making sure that we don't recurse if the scene referenced by the current sequence in the loop is the parent scene.
FWIW I've made a diff for the patch that stops it crashing.
Crash confirmed on Linux x64, it's falling over in intern/readfile.c - direct_link_scene() where it tries to set seq->strip->proxy->anim to NULL but proxy itself is NULL so it segfaults. Perhaps this file expects proxy data (do you have proxy data on disk OP, or is this someone else's file?) and this function cannot cope if it is not found?
Nov 23 2016
This appears to be a duplicate of (fixed) issue T49975
Nov 16 2016
I just tried it on the released 2.78 (not 2.78a) and the somewhat-newer build I have been hacking on, both work the same - drawing by pressing D and clicking creates strokes, and if I let go of D before LMB then I can keep drawing new strokes with the mouse.
Nov 9 2016
The frozen-end-frames behaviour is definitely related to this - the strip has its "endstill" value set as if the source was still the old length.
Oct 30 2016
Cool. I've just spotted a bug in my patch and fixed it in the diff, doesn't affect you but thought I'd mention it here in case anyone else has tried building with it.
I realised there was a bug in my linked-list traversing that meant it would never look at the last one in the list. Now fixed.
Oct 29 2016
Righto. I made a quick demo vid of how it behaves now:
Oct 28 2016
I'm not sure if this is intentional or not, but it certainly bugs me. I have fixed it in the referenced diff by searching for any matching scene strips and updating their details.
Oct 27 2016
Oct 23 2016
Heh, sneaky. Animated volume will be late by the audio buffer length, but I doubt anyone will notice unless they're using very long buffers. Might get a click at the very start of the render if the first animated value is supposed to be 0, as it'll fade down from 1.0 to 0 over the first buffer.
Oct 21 2016
Bit more info... having clicked the same button in my patched build, it now no longer crackles in preview playback.
FWIW, there is no clipping happening in the attached test file. I noticed the volume > 1.0 thing too, but the wind sample is quiet enough that the multiplied output never reaches 0dBFS. In my rendered example the sine still reaches 2.0.
Oct 19 2016
Certainly, here you go:
Proof of concept done... I had to touch more stuff than I thought, as it turns out the animation of volume isn't done where I thought it was (anyone know why there are two layers of volume animation? The m_volume.read in AUD_SequenceReader.cpp line 186 does nothing, always gives volume of 1.0!).
Oct 18 2016
f-curves / keyframes / modifiers / all the same evaluation system, at the video frame rate.
Have just tried your sample. What you are hearing is the audio level being changed with each blender frame - it does not evaluate f-curves at the audio sample rate, only at the video frame rate, so if you are changing levels that quickly you will definitely hear zipper noise.
Okay, I've undone all that nonsense I pasted last week and have come up with a solution that seems sensible. However I am happy to be told that I've done everything wrong because to be fair I have no idea what I'm doing.
Am I right in thinking that this is only a problem in preview playback? I've noticed it recently due to cranking the buffer size while CPU was high, but rendered output was fine.
Oct 14 2016
Okay, I'm very sorry for what I've just done to your source code. It's Friday afternoon, I'm about to go home and was hoping to have some kind of proof-of-concept, and this is what I ended up with:
That fix did sort out a lot of the odd stuff that was going on with scene strips, but F-Curves appear to be evaluated completely independently of that system.
Err... I don't know how to create a diff on here, sorry!
Thanks Matt. I've created a new task (https://developer.blender.org/T49658), hope that's okay!
Since I found that this applies to other strip types, I have made a blend file as an example. In the scene "sub" you can see the text count from 1 to 5. In the scene "master", "sub is inserted at 2s, and the numbers start counting from 3 instead of 1.
Oct 13 2016