Page MenuHome

Amit Sari (Hamitos)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2018, 6:55 PM (20 w, 4 d)

Recent Activity

Sat, Mar 23

Amit Sari (Hamitos) updated the diff for D4054: Add horizontal scrollbar to the Text Editor.

Added longest line length to the drawcache so we don't need to loop over all lines every draw call.

Sat, Mar 23, 9:03 PM · BF Blender: 2.8, User Interface
Amit Sari (Hamitos) commandeered D4054: Add horizontal scrollbar to the Text Editor.

Commandeering to try and update when I'm the author.

Sat, Mar 23, 9:01 PM · BF Blender: 2.8, User Interface

Mar 9 2019

Amit Sari (Hamitos) added a comment to D4054: Add horizontal scrollbar to the Text Editor.

Hmm you're right.
However I think looping over visible lines only will cause weird behavior e.g. Jumping left horizontally when scrolling away from the longest line.
I added longest_line_length to the drawcache instead.

Mar 9 2019, 2:45 PM · BF Blender: 2.8, User Interface

Dec 8 2018

Amit Sari (Hamitos) claimed T57711: Add horizontal scroll bar to Text Editor.

Hey, I have a diff ready here.
What happens now?

Dec 8 2018, 4:28 PM · User Interface, BF Blender: 2.8

Nov 24 2018

Amit Sari (Hamitos) added a comment to T57711: Add horizontal scroll bar to Text Editor.

Hey, I started on this one last weekend and I have a working version of the drawing functions - The scrollbar is correctly drawn according to line length and window size and so on.
I'll get the code to a presentable state and add mouse functionality over the next few weekends.
Just a question though:
What should the highlight be when the selection spans more than one line?
For example if "according to line length" to "I'll get the code" was selected, should there be two red line at the bottom? Should there be a red line at all?

Nov 24 2018, 7:23 PM · User Interface, BF Blender: 2.8