Page MenuHome

Richard Antalik (ISS)
User

Projects

User Details

User Since
Jun 1 2018, 3:52 AM (27 w, 4 d)

Recent Activity

Sat, Dec 8

Richard Antalik (ISS) added a comment to D3934: VSE cache with frame prefetching (WIP).
Sat, Dec 8, 9:28 PM · Video Sequencer
Richard Antalik (ISS) updated the diff for D3934: VSE cache with frame prefetching (WIP).

Status:
Functionality should be quite complete, only problem is preprocess cache, since preprocess ibufs may vary in size. But if you enable caching preprocess for some strips, prefetch may have problems (may try to fetch more, then cache capacity - wasted effort). It should be easy to detect such event and stop prefetching, which may be a way to go...

Sat, Dec 8, 8:10 PM · Video Sequencer

Wed, Dec 5

Richard Antalik (ISS) added a comment to D4031: Making ffmpeg use the maximum available threads, rather than just 1 ( default ).

@Mal Duffin (mal_cando), Thanks for patch!
Are these properties set dynamically? there may be some cases, where we would want to keep just one thread - if we utilize multiple threads for actual rendering, for example D3934 or D3597.

Wed, Dec 5, 11:47 AM · BF Blender: 2.8

Fri, Nov 30

Peter Fog (tintwotin) awarded D3934: VSE cache with frame prefetching (WIP) a Love token.
Fri, Nov 30, 5:20 AM · Video Sequencer

Mon, Nov 26

Richard Antalik (ISS) updated the diff for D3934: VSE cache with frame prefetching (WIP).

Still work in progress...
Scene copying was not modified yet.
Also haven't look at undo bug.

Mon, Nov 26, 11:50 AM · Video Sequencer

Thu, Nov 22

Richard Antalik (ISS) added a comment to D3934: VSE cache with frame prefetching (WIP).

I think the approach is generally fine. Would be nice to see a more cleaned up patch to review in more detail.

Thu, Nov 22, 11:47 AM · Video Sequencer

Fri, Nov 16

Peter Boos (PGTART) awarded D3934: VSE cache with frame prefetching (WIP) a Like token.
Fri, Nov 16, 2:16 AM · Video Sequencer

Thu, Nov 15

hudson barkley (snuq) awarded D3934: VSE cache with frame prefetching (WIP) a Love token.
Thu, Nov 15, 11:33 PM · Video Sequencer

Wed, Nov 14

Andrew Charlton (Scaredyfish) awarded D3934: VSE cache with frame prefetching (WIP) a Love token.
Wed, Nov 14, 4:48 AM · Video Sequencer

Tue, Nov 13

Pablo Vazquez (pablovazquez) awarded D3934: VSE cache with frame prefetching (WIP) a Love token.
Tue, Nov 13, 3:08 PM · Video Sequencer
Richard Antalik (ISS) added a comment to D3934: VSE cache with frame prefetching (WIP).

Here is win32 build:
https://drive.google.com/file/d/1JDzIHHNA9qWvoXvVIShf9e-7l8bm-re5/view?usp=sharing

Tue, Nov 13, 12:50 AM · Video Sequencer

Mon, Nov 12

Richard Antalik (ISS) updated subscribers of D3934: VSE cache with frame prefetching (WIP).

I forgot, @Brecht Van Lommel (brecht), you was also involved :)

Mon, Nov 12, 5:36 PM · Video Sequencer
Richard Antalik (ISS) created D3934: VSE cache with frame prefetching (WIP).
Mon, Nov 12, 12:03 PM · Video Sequencer

Nov 10 2018

Richard Antalik (ISS) added a comment to D3597: Add proxy support for all sequences.

@Richard Antalik (ISS)
I've been playing around with your 'test patch D3597'

  • The progress bar on the audio strip visually suggests that a proxy is being generated for the audio, even though it's not. (I would remove it)

This would be easy to solve.

Nov 10 2018, 3:52 PM · Video Sequencer

Nov 9 2018

Richard Antalik (ISS) added a comment to D3621: Add font selection to VSE text strips.

This has been a request for ages! Do you think you can make sure the patch works against the latest? A lot has changed since August. It will make it easier for developers to review.

Nov 9 2018, 9:59 PM · Video Sequencer
Richard Antalik (ISS) added a comment to T56950: UI Paper Cuts (Parent Task).

can this be considered?
https://blender.community/c/rightclickselect/74bbbc/increase-vse-transform-strip-rotation-limits

Nov 9 2018, 9:45 AM · User Interface, BF Blender: 2.8
Richard Antalik (ISS) added a comment to D3621: Add font selection to VSE text strips.

This has been a request for ages! Do you think you can make sure the patch works against the latest? A lot has changed since August. It will make it easier for developers to review.

Nov 9 2018, 9:04 AM · Video Sequencer

Oct 17 2018

Richard Antalik (ISS) added a comment to D3597: Add proxy support for all sequences.

I try to compile this, but the diff file no longer works (can't patch). Can anyone guide me? Is it for the master branch? Is there any chance that this can work in Blender 2.80?

Oct 17 2018, 10:34 AM · Video Sequencer

Oct 16 2018

Jens Ruda (jaker) awarded D3597: Add proxy support for all sequences a Mountain of Wealth token.
Oct 16 2018, 5:32 PM · Video Sequencer

Sep 18 2018

Peter Fog (tintwotin) awarded D3597: Add proxy support for all sequences a Like token.
Sep 18 2018, 9:57 PM · Video Sequencer

Sep 6 2018

Richard Antalik (ISS) added a comment to T56691: Footage playback issue in Blender VSE .

Can there perhaps be some clip on channel 32 unnoticed?
In python you can move strip beyond this limit, but it wont play.

Sep 6 2018, 8:51 PM · BF Blender
Richard Antalik (ISS) added a comment to T56691: Footage playback issue in Blender VSE .

This happened to me some time ago, but I don't know how I dealt with this.
either I had to redo everything from beginning, or what you can try, I changed source file to some random file, then changed it back to what it should be (should reload anims?).

Sep 6 2018, 11:50 AM · BF Blender
david mcsween (davidmcsween) awarded D3671: Fix cut behavior, with keep both sides selected option a Like token.
Sep 6 2018, 10:37 AM · Video Sequencer

Sep 5 2018

Richard Antalik (ISS) added a comment to T56691: Footage playback issue in Blender VSE .

I would try to disable proxies(before you preview strip) if you are using them.
And maybe try to recover backups - should be named *.blend1

Sep 5 2018, 5:26 PM · BF Blender

Sep 4 2018

Richard Antalik (ISS) updated the diff for D3496: Scale & stretch & cut sound waveform.

Convert old files to new format - triggered by manipulation with sequence individually.
This is done in BKE_sequence_calc_sound_disp() instead of do_versions()

Sep 4 2018, 8:38 PM · Video Sequencer

Sep 2 2018

Richard Antalik (ISS) created D3671: Fix cut behavior, with keep both sides selected option.
Sep 2 2018, 11:09 PM · Video Sequencer
Richard Antalik (ISS) updated the diff for D3597: Add proxy support for all sequences.

Add codec selection to set selected strip proxies operator

Sep 2 2018, 10:42 PM · Video Sequencer

Sep 1 2018

Mattias Ohlsson (mon) awarded D3597: Add proxy support for all sequences a Like token.
Sep 1 2018, 2:01 PM · Video Sequencer

Aug 31 2018

Richard Antalik (ISS) added a comment to T54273: Large images gets cropped when downscaled in VSE.

I would remove scaling and color grading from sequencer panel on strips and get rid of preprocessing stage. Also it seemed to me, that this stage has it's own cache - useless and waste of resources.
Use effects!

Aug 31 2018, 10:55 AM · Video Sequencer, BF Blender

Aug 30 2018

Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

Thank you for feedback!

Aug 30 2018, 4:19 PM · Rendering, Images & Movies, Video Sequencer, BF Blender

Aug 28 2018

Richard Antalik (ISS) added a watcher for Video Sequencer: Richard Antalik (ISS).
Aug 28 2018, 3:55 PM

Aug 26 2018

Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

If anyone wants to test patch D3597 here is 32bit windows build
https://drive.google.com/open?id=1Gc5lrk08hK2XsCg94JVzJDE9ZJCMseak

Aug 26 2018, 9:06 PM · Rendering, Images & Movies, Video Sequencer, BF Blender
Richard Antalik (ISS) updated the diff for D3597: Add proxy support for all sequences.

finished refactoring, movieclip still uses its own job manager, but could maybe use unified...
I don't know if there was multiview support, but now is.

Aug 26 2018, 8:12 PM · Video Sequencer

Aug 23 2018

Richard Antalik (ISS) updated the diff for D3597: Add proxy support for all sequences.

Refactor proxy API, 1st pass

Aug 23 2018, 10:21 PM · Video Sequencer

Aug 18 2018

Richard Antalik (ISS) added a comment to D3496: Scale & stretch & cut sound waveform.

My understanding of backward and forward compatibility was kinda reversed - from application point of view, to support newer files.
So if this is not the case, I will consider different approach here

Aug 18 2018, 12:55 PM · Video Sequencer

Aug 17 2018

Richard Antalik (ISS) added inline comments to D3621: Add font selection to VSE text strips.
Aug 17 2018, 10:42 PM · Video Sequencer
Richard Antalik (ISS) created D3621: Add font selection to VSE text strips.
Aug 17 2018, 10:37 PM · Video Sequencer
Richard Antalik (ISS) updated the diff for D3597: Add proxy support for all sequences.

Fix issue with not deleting original proxy file
Add dirty mutex, so it is very unlikely to crash building proxies by human interaction, but I have to look deeper, how it is usualy done in blender.
For multithreading I am using my wm_jobs "hack" but I think, that it may be useful for this kind of job manager to be able to run more than one jobs.

Aug 17 2018, 8:56 PM · Video Sequencer

Aug 15 2018

Richard Antalik (ISS) updated the diff for D3597: Add proxy support for all sequences.

Fix HUGE memory leak (still some bytes left, but not gigs of them at least :)
Add PNG / MJPEG codec selection to UI
Render smaller imbufs instead of post-scaling
Render everything to fixed size - so 25% proxy no longer means 25% of source resolution, but it is 25% of "project" resolution (scene->r.xsch)

Aug 15 2018, 12:23 AM · Video Sequencer

Aug 13 2018

Richard Antalik (ISS) added inline comments to D3549: Py_imbuf add image manipulation functions.
Aug 13 2018, 9:36 PM · BF Blender
Richard Antalik (ISS) updated the diff for D3549: Py_imbuf add image manipulation functions.

I found some quite stupid mistakes - sorry for that

Aug 13 2018, 9:20 PM · BF Blender
Richard Antalik (ISS) added a comment to D3549: Py_imbuf add image manipulation functions.

should I mark inlines as done and then update diff?

Aug 13 2018, 9:08 PM · BF Blender
Richard Antalik (ISS) added a comment to D3496: Scale & stretch & cut sound waveform.

I can "convert" old files, by adjusting offsets when loading.
When I load files blend file saved by blender compiled with this diff, it's much worse - there can be sequences with 0 length
I can "convert" offsets back when saving.

Aug 13 2018, 3:30 PM · Video Sequencer
Richard Antalik (ISS) updated the diff for D3597: Add proxy support for all sequences.

fix minor issues, that slipped

Aug 13 2018, 2:40 PM · Video Sequencer

Aug 12 2018

Richard Antalik (ISS) added a comment to D3597: Add proxy support for all sequences.

Hi, it's richardantalik at google mail

Aug 12 2018, 8:18 PM · Video Sequencer
Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

Just a notice to anyone interested:
I started working on this and will need a week or 2 to polish it

Aug 12 2018, 11:14 AM · Rendering, Images & Movies, Video Sequencer, BF Blender
Richard Antalik (ISS) created D3597: Add proxy support for all sequences.
Aug 12 2018, 10:48 AM · Video Sequencer
Richard Antalik (ISS) updated the diff for D3496: Scale & stretch & cut sound waveform.

rebase on top of latest master

Aug 12 2018, 9:37 AM · Video Sequencer

Aug 9 2018

Peter Fog (tintwotin) awarded D3496: Scale & stretch & cut sound waveform a Love token.
Aug 9 2018, 8:06 AM · Video Sequencer

Aug 6 2018

Richard Antalik (ISS) added inline comments to D3549: Py_imbuf add image manipulation functions.
Aug 6 2018, 12:12 PM · BF Blender

Aug 5 2018

filip mond (vklidu) awarded D3549: Py_imbuf add image manipulation functions a Love token.
Aug 5 2018, 11:52 PM · BF Blender
filip mond (vklidu) awarded D3496: Scale & stretch & cut sound waveform a Love token.
Aug 5 2018, 11:50 PM · Video Sequencer

Jul 28 2018

Richard Antalik (ISS) updated the diff for D3496: Scale & stretch & cut sound waveform.

Fixed audio glitching when pitch is animated, also sequence position / length is stable now. I was not able to reproduce these 1 frame offsets that I remember seeing last time.

Jul 28 2018, 6:03 PM · Video Sequencer

Jul 26 2018

david mcsween (davidmcsween) awarded D3496: Scale & stretch & cut sound waveform a Love token.
Jul 26 2018, 9:11 AM · Video Sequencer
david mcsween (davidmcsween) awarded D3549: Py_imbuf add image manipulation functions a Love token.
Jul 26 2018, 9:10 AM · BF Blender

Jul 15 2018

Richard Antalik (ISS) created D3549: Py_imbuf add image manipulation functions.
Jul 15 2018, 10:59 PM · BF Blender

Jul 11 2018

Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

Image proxies can be useful tho, what about transparent images/sequences? It would be nice if these were proxied in a way to preserve that transparency.

Jul 11 2018, 1:02 AM · Rendering, Images & Movies, Video Sequencer, BF Blender

Jul 8 2018

Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

No, we want only AVIs for proxies.
For consistency sake, I would generate AVI even for image, just 1 frame long video maybe for speed reasons.
Also if it was up to me, I would like to make it possible, so every image generating sequence could have proxy.

Jul 8 2018, 7:23 PM · Rendering, Images & Movies, Video Sequencer, BF Blender
Richard Antalik (ISS) added a comment to D3496: Scale & stretch & cut sound waveform.

Hi,
I currently know about 3 issues:
Cutting of strip leaves gaps sometimes and strip can "jump" channel when changing/animating pitch.
Now I noticed, that when I have startofs, it slowly shrinks, when changing pitch.

Jul 8 2018, 7:19 PM · Video Sequencer
Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

I have looked at the code, where the problem lies - the main problem is that we want to generate MJPEG video for proxies instead of a bunch of jpeg images. Making filename would be quite silly reason for dropping functional feature...

Jul 8 2018, 1:32 PM · Rendering, Images & Movies, Video Sequencer, BF Blender
Richard Antalik (ISS) updated the diff for D3496: Scale & stretch & cut sound waveform.

Now "strips" should be fixed to the timeline when changing pitch,
fix sequence slide operator, at least to the point that it is usable,
fix playback position when playing not from start.

Jul 8 2018, 12:26 PM · Video Sequencer

Jul 6 2018

Richard Antalik (ISS) added a comment to T54259: Scene Proxies in the Video Sequence Editor.

Hello.
I was proposing change(D3484) for VSE proxy system.

Jul 6 2018, 10:29 PM · Rendering, Images & Movies, Video Sequencer, BF Blender
Richard Antalik (ISS) added a comment to D3496: Scale & stretch & cut sound waveform.

Hello,
To disable this behavior, you can comment line 698 in rna_sequencer.c - do_sequence_frame_change_update(scene, seq);
But it is glitchy.

Jul 6 2018, 9:27 PM · Video Sequencer

Jul 4 2018

Richard Antalik (ISS) updated the diff for D3496: Scale & stretch & cut sound waveform.

added fetures discussed in T50843 with @Joerg Mueller (nexyon) :

Jul 4 2018, 9:04 PM · Video Sequencer

Jun 27 2018

Richard Antalik (ISS) added a comment to T50843: Pitched Audio renders incorrectly in VSE.

I understand what you want to do...
I was thinking that this will add a "layer of abstraction" for all functions that use sound strips. But this abstraction has to be present somewhere, so I don't really object to this variant.
I will try to make some patch during weekend.

Jun 27 2018, 10:27 PM · Video Sequencer, BF Blender

Jun 25 2018

Richard Antalik (ISS) added a comment to T50843: Pitched Audio renders incorrectly in VSE.

Thanks for quick reaction!
I will try to explain myself a bit.

Jun 25 2018, 7:24 PM · Video Sequencer, BF Blender

Jun 24 2018

Richard Antalik (ISS) added a comment to T50843: Pitched Audio renders incorrectly in VSE.

And adding a quick and dirty proof of concept: https://youtu.be/zB7wXox8VX0

Jun 24 2018, 3:26 AM · Video Sequencer, BF Blender

Jun 23 2018

Richard Antalik (ISS) added a comment to T50843: Pitched Audio renders incorrectly in VSE.

I wrote patch D3496 to stretch waveforms of seq, so if you cut it based on waveform it behaves consistently with expectation.

Jun 23 2018, 4:22 PM · Video Sequencer, BF Blender

Jun 21 2018

Richard Antalik (ISS) created D3496: Scale & stretch & cut sound waveform.
Jun 21 2018, 9:07 PM · Video Sequencer

Jun 18 2018

Richard Antalik (ISS) updated the diff for D3484: Sequence proxies by running parallel threads.
Jun 18 2018, 12:07 PM · Video Sequencer, BF Blender

Jun 17 2018

Richard Antalik (ISS) created D3484: Sequence proxies by running parallel threads.
Jun 17 2018, 4:48 AM · Video Sequencer, BF Blender

Jun 15 2018

Richard Antalik (ISS) added a comment to T55414: waveforms are reprocessed when undoing.

I tested swapping sound files - it worked OK, because another function is handling this and new waveform is at different memory address.
Undoing this action will therefore correctly swap waveforms back.

Jun 15 2018, 8:27 PM · Audio, Video Sequencer, BF Blender

Jun 9 2018

Richard Antalik (ISS) created T55414: waveforms are reprocessed when undoing.
Jun 9 2018, 2:22 AM · Audio, Video Sequencer, BF Blender

Jun 8 2018

Richard Antalik (ISS) added a member for Video Sequencer: Richard Antalik (ISS).
Jun 8 2018, 9:47 PM

Jun 3 2018

Richard Antalik (ISS) added a comment to D2424: Add font selection to VSE text strips.

I didn't want to spam, so I edited my post.
Can you please take a look at suggested modifications?

Jun 3 2018, 10:35 PM · Video Sequencer
Richard Antalik (ISS) added a comment to D2424: Add font selection to VSE text strips.

VFont linking solved this by adding newlibadr lookup in function lib_link_scene in file readfile.c

			Sequence *seq;
			SEQ_BEGIN (sce->ed, seq)
			{
				...
Jun 3 2018, 12:24 AM · Video Sequencer

Jun 1 2018

Richard Antalik (ISS) added a comment to D2424: Add font selection to VSE text strips.

I am testing this diff on 2.79.4
When I close and open blend file, VFont reference of text seq data is loaded with old memory address, but VFont block from blend file is loaded to new location. Sometimes on the "old memory address" there is random data, which will cause blender to crash.

Jun 1 2018, 2:57 PM · Video Sequencer