- User Since
- Sep 15 2020, 11:51 AM (34 w, 5 d)
Nov 19 2020
Take geometry manager and object manager required updates into consideration too.
Nov 18 2020
Brecht I know you originally mentioned that the fix should not land in Shader::tag_update but Kévin explained to me that after his change landed, the actual check of whether displacement method was modified is pretty simple. The actual fix proves that idea.
Oct 12 2020
What about adding a bool member to Mesh class "is_displaced", and then set it to TRUE for any mesh that is displaced in GeometryManager::displace() (in mesh_displace.cpp). I may be wrong but it looks to me that by doing that at least we would cover the first part: having individual geometry (at least meshes) marked as being displaced. If that works, what if we then set
Oct 10 2020
Hi @Brecht Van Lommel (brecht), as adviced on the blender-coders chat, I added "Render & Cycles" as reviewers too, given that I have seen in a recent meeting minutes that you asked for other's help on reviews.
Sep 15 2020
Did you mean something like this? I am getting familiar with the code, so I hope I am not that off
- track if geometry was displaced, and mark it for update if displace method is BUMP