Page MenuHome

Joan Bonet Orantos (LaTerreta)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 15 2020, 11:51 AM (34 w, 5 d)

Recent Activity

Nov 19 2020

Joan Bonet Orantos (LaTerreta) updated the diff for D8896: Fix T75539: Cycles. Update geometry when switching displacements.

Take geometry manager and object manager required updates into consideration too.

Nov 19 2020, 6:07 PM · Render & Cycles

Nov 18 2020

Joan Bonet Orantos (LaTerreta) added a comment to D8896: Fix T75539: Cycles. Update geometry when switching displacements.

Brecht I know you originally mentioned that the fix should not land in Shader::tag_update but Kévin explained to me that after his change landed, the actual check of whether displacement method was modified is pretty simple. The actual fix proves that idea.

Nov 18 2020, 7:36 PM · Render & Cycles
Joan Bonet Orantos (LaTerreta) updated subscribers of D8896: Fix T75539: Cycles. Update geometry when switching displacements.
Nov 18 2020, 7:34 PM · Render & Cycles
Joan Bonet Orantos (LaTerreta) updated the diff for D8896: Fix T75539: Cycles. Update geometry when switching displacements.

Fix T75539: Fix simplified after D8544 landed

Nov 18 2020, 7:25 PM · Render & Cycles

Oct 12 2020

Joan Bonet Orantos (LaTerreta) added a comment to D8896: Fix T75539: Cycles. Update geometry when switching displacements.

What about adding a bool member to Mesh class "is_displaced", and then set it to TRUE for any mesh that is displaced in GeometryManager::displace() (in mesh_displace.cpp). I may be wrong but it looks to me that by doing that at least we would cover the first part: having individual geometry (at least meshes) marked as being displaced. If that works, what if we then set

Oct 12 2020, 10:41 PM · Render & Cycles

Oct 10 2020

Joan Bonet Orantos (LaTerreta) added a reviewer for D8896: Fix T75539: Cycles. Update geometry when switching displacements: Render & Cycles.
Oct 10 2020, 4:42 PM · Render & Cycles
Joan Bonet Orantos (LaTerreta) added a comment to D8896: Fix T75539: Cycles. Update geometry when switching displacements.

Hi @Brecht Van Lommel (brecht), as adviced on the blender-coders chat, I added "Render & Cycles" as reviewers too, given that I have seen in a recent meeting minutes that you asked for other's help on reviews.

Oct 10 2020, 2:32 PM · Render & Cycles

Sep 15 2020

Joan Bonet Orantos (LaTerreta) added a comment to D8896: Fix T75539: Cycles. Update geometry when switching displacements.

Did you mean something like this? I am getting familiar with the code, so I hope I am not that off

Sep 15 2020, 2:30 PM · Render & Cycles
Joan Bonet Orantos (LaTerreta) updated the diff for D8896: Fix T75539: Cycles. Update geometry when switching displacements.
  • track if geometry was displaced, and mark it for update if displace method is BUMP
Sep 15 2020, 2:21 PM · Render & Cycles
Joan Bonet Orantos (LaTerreta) added a reviewer for D8896: Fix T75539: Cycles. Update geometry when switching displacements: Brecht Van Lommel (brecht).
Sep 15 2020, 12:10 PM · Render & Cycles
Joan Bonet Orantos (LaTerreta) added a revision to T75539: Cycles: switching from Displacement to Bump Only does not update geometry: D8896: Fix T75539: Cycles. Update geometry when switching displacements.
Sep 15 2020, 11:58 AM · Render & Cycles, Cycles, BF Blender
Joan Bonet Orantos (LaTerreta) requested review of D8896: Fix T75539: Cycles. Update geometry when switching displacements.
Sep 15 2020, 11:58 AM · Render & Cycles