Page MenuHome

Ray molenkamp (LazyDodo)
Ray

Projects (12)

User Details

User Since
Oct 2 2014, 3:13 PM (320 w, 6 d)

Recent Activity

Yesterday

Ray molenkamp (LazyDodo) created P1820 (An Untitled Masterwork).
Wed, Nov 25, 9:58 PM

Fri, Nov 20

Ray molenkamp (LazyDodo) added inline comments to D9505: support arm64, including embree-fork.
Fri, Nov 20, 10:42 PM · Platform: Linux, Platforms, Builds & Tests
Ray molenkamp (LazyDodo) requested changes to D9505: support arm64, including embree-fork.

Overall there seems to be very little consideration for other platforms and various arbitrary changes.

Fri, Nov 20, 3:29 PM · Platform: Linux, Platforms, Builds & Tests
Shrinivas (Shrinivas) awarded D2691: Add batch update to nodetree_link_api a Love token.
Fri, Nov 20, 8:15 AM

Fri, Nov 13

Ray molenkamp (LazyDodo) awarded D9555: Cycles: optimize device updates a Love token.
Fri, Nov 13, 5:57 PM
Ray molenkamp (LazyDodo) added inline comments to D9555: Cycles: optimize device updates.
Fri, Nov 13, 5:57 PM

Thu, Nov 12

Ray molenkamp (LazyDodo) created P1763 msvc asan troubles.
Thu, Nov 12, 10:56 PM
Ray molenkamp (LazyDodo) added a comment to rB94b44a5228c0: Cleanup: Clang-tidy, modernize-use-nullptr..

joining the test party

Thu, Nov 12, 4:29 PM

Wed, Nov 11

Ray molenkamp (LazyDodo) planned changes to D7794: MSVC: Preliminary ASAN support..

still not OK for general use.

Wed, Nov 11, 9:59 PM
Ray molenkamp (LazyDodo) updated the diff for D7794: MSVC: Preliminary ASAN support..

Update to 16.8.

Wed, Nov 11, 9:57 PM

Tue, Nov 10

Ray molenkamp (LazyDodo) committed rB86bdd2acc66c: Windows: Fix build issue with VCPKG (authored by Ray molenkamp (LazyDodo)).
Windows: Fix build issue with VCPKG
Tue, Nov 10, 9:24 PM
Ray molenkamp (LazyDodo) committed rB626a79204ee2: MSVC: Fix build warning (authored by Ray molenkamp (LazyDodo)).
MSVC: Fix build warning
Tue, Nov 10, 4:48 PM

Mon, Nov 9

Ray molenkamp (LazyDodo) added a comment to T81454: Cycles: enable NanoVDB by default.

I'll admit, the whole, "oh just build this random git hash, but leave the original openvdb we have alone, and just copy these headers, it'll work" is somewhat unorthodox, but given @Brecht Van Lommel (brecht) signed off on it I didn't question it.

Mon, Nov 9, 8:40 PM · BF Blender (2.90), Platforms, Builds & Tests, Cycles, Render & Cycles
Ray molenkamp (LazyDodo) added a comment to D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..

This is great. I was also looking into using libtooling to write some checks, but did not get very far yet.
It would be nice to get the necessary infrastructure in Blender.

Mon, Nov 9, 3:41 PM

Thu, Nov 5

Ray molenkamp (LazyDodo) updated the summary of D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
Thu, Nov 5, 6:03 PM
Ray molenkamp (LazyDodo) updated the summary of D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
Thu, Nov 5, 3:40 AM
Ray molenkamp (LazyDodo) retitled D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues. from Tools: new tool dnacheck which gives usefull feedback on dna padding issues. to Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
Thu, Nov 5, 3:39 AM
Ray molenkamp (LazyDodo) updated the diff for D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
  • fix error message
Thu, Nov 5, 3:11 AM
Ray molenkamp (LazyDodo) updated the summary of D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
Thu, Nov 5, 3:07 AM
Ray molenkamp (LazyDodo) updated the summary of D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
Thu, Nov 5, 3:04 AM
Ray molenkamp (LazyDodo) planned changes to D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..

Not quite ready for review yet but put it out for people to play with.

Thu, Nov 5, 3:01 AM
Ray molenkamp (LazyDodo) requested review of D9465: Tools: new tool dnacheck which gives useful feedback on DNA padding issues..
Thu, Nov 5, 3:00 AM
Ray molenkamp (LazyDodo) created P1752 (An Untitled Masterwork).
Thu, Nov 5, 2:52 AM
Ray molenkamp (LazyDodo) accepted D9464: CMake: support quotes in CFLAGS (use configue_file to avoid quote errors w/ buildinfo).

I can't seem to get master nor this patch to misbehave with msvc, but i can validate that when i have quotes they display properly and this patch doesn't break anything.

Thu, Nov 5, 2:20 AM

Wed, Nov 4

Ray molenkamp (LazyDodo) added a comment to D9253: macOS: support creating dSYM files for every executable .

Given it is seemingly only useful when asan is on, perhaps toggle this behavior with WITH_COMPILER_ASAN ?

Wed, Nov 4, 8:42 PM
Ray molenkamp (LazyDodo) added a comment to D9444: Add colormap compositor node.

Hi please fill out your patch description, the wiki has some guidelines on what to include there.

Wed, Nov 4, 3:12 PM · Compositing
Ray molenkamp (LazyDodo) requested changes to D9450: Deps_Builder: Add clang-extra-tools to clang.
Wed, Nov 4, 2:40 PM · Platform: macOS, Platforms, Builds & Tests

Sat, Oct 31

Ray molenkamp (LazyDodo) updated the task description for T81454: Cycles: enable NanoVDB by default.
Sat, Oct 31, 7:26 PM · BF Blender (2.90), Platforms, Builds & Tests, Cycles, Render & Cycles
Ray molenkamp (LazyDodo) added a comment to T81454: Cycles: enable NanoVDB by default.

Added the libs, however enabling it leads to a single failed test

Sat, Oct 31, 7:25 PM · BF Blender (2.90), Platforms, Builds & Tests, Cycles, Render & Cycles
Ray molenkamp (LazyDodo) committed rBL62507: Windows: Added nanovdb .
Windows: Added nanovdb
Sat, Oct 31, 7:24 PM

Fri, Oct 30

Ray molenkamp (LazyDodo) added a comment to D9389: Fix: DNA struct alignment on 32 bit.

Bastien Montagne (mont29) added subscribers: Campbell Barton (campbellbarton), Brecht Van Lommel (brecht), Bastien Montagne (mont29).

Fri, Oct 30, 2:40 PM
Ray molenkamp (LazyDodo) updated the diff for D9389: Fix: DNA struct alignment on 32 bit.
  • undo whitespace change.
Fri, Oct 30, 3:11 AM
Ray molenkamp (LazyDodo) updated the diff for D9389: Fix: DNA struct alignment on 32 bit.
  • fix one bad addition
Fri, Oct 30, 3:04 AM
Ray molenkamp (LazyDodo) updated the summary of D9389: Fix: DNA struct alignment on 32 bit.
Fri, Oct 30, 3:02 AM
Ray molenkamp (LazyDodo) requested review of D9389: Fix: DNA struct alignment on 32 bit.
Fri, Oct 30, 3:00 AM
Ray molenkamp (LazyDodo) updated the diff for D8628: Deps: Add pugiXML as an official dependency..
  • Merge remote-tracking branch 'origin/master' into arcpatch-D8628
Fri, Oct 30, 1:13 AM

Oct 25 2020

Ray molenkamp (LazyDodo) created P1735 tbb_config.h for clang on windows .
Oct 25 2020, 11:21 PM
Ray molenkamp (LazyDodo) planned changes to D7794: MSVC: Preliminary ASAN support..

Quick update for broader testing, not ready for review yet.

Oct 25 2020, 7:06 PM
Ray molenkamp (LazyDodo) updated the diff for D7794: MSVC: Preliminary ASAN support..
  • Merge remote-tracking branch 'origin/master' into tmp_asan_cleanup
Oct 25 2020, 7:06 PM

Oct 23 2020

Ray molenkamp (LazyDodo) abandoned D9147: Remove color console logging from the GPU module..

@Clément Foucault (fclem) has made a better fix.

Oct 23 2020, 8:46 PM

Oct 22 2020

Ray molenkamp (LazyDodo) added a comment to T80679: File browser system folders doesn't change with interface language..

You should not be calling IFACE_("Pictures") in fsmenu_read_system this will cause the msgid to be translated, and when you switch languages it will use the translated text as msgid, come up empty and stick with the previous translation.

Oct 22 2020, 3:51 PM · User Interface, BF Blender
Ray molenkamp (LazyDodo) requested changes to D7840: Wintab rewrite - high frequency events.

Taking another pass at this, there is quite a mix of comment styles, sometimes even in the same function, best to follow the style guide on this.

Oct 22 2020, 2:37 PM · Platforms, Builds & Tests, Platform: Windows, Sculpt, Paint & Texture

Oct 21 2020

Ray molenkamp (LazyDodo) created P1727 (An Untitled Masterwork).
Oct 21 2020, 8:51 PM
Ray molenkamp (LazyDodo) created P1725 (An Untitled Masterwork).
Oct 21 2020, 5:28 PM
Ray molenkamp (LazyDodo) created P1723 (An Untitled Masterwork).
Oct 21 2020, 4:34 PM

Oct 20 2020

Ray molenkamp (LazyDodo) committed rBL62498: Windows: GMP 6.2.0 - Fat build .
Windows: GMP 6.2.0 - Fat build
Oct 20 2020, 10:23 PM
Ray molenkamp (LazyDodo) committed rB43e4d6e5b142: CMake/Windows: Compile GMP library as fat library (authored by Ray molenkamp (LazyDodo)).
CMake/Windows: Compile GMP library as fat library
Oct 20 2020, 9:06 PM
Ray molenkamp (LazyDodo) created P1719 (An Untitled Masterwork).
Oct 20 2020, 6:06 PM

Oct 16 2020

Ray molenkamp (LazyDodo) committed rB00f7b572d9eb: Windows: Fix build issue on windows (authored by Ray molenkamp (LazyDodo)).
Windows: Fix build issue on windows
Oct 16 2020, 1:15 AM

Oct 15 2020

Ray molenkamp (LazyDodo) added a comment to T81722: Freezing at render kickoff.

After trying to catch it in a master build and see what is up, I cannot get it to misbehave.

Oct 15 2020, 7:43 PM · BF Blender
Ray molenkamp (LazyDodo) added a comment to T81722: Freezing at render kickoff.

I struggled to repro as well until i changed this option to match what I see in the video

Oct 15 2020, 6:43 PM · BF Blender
Ray molenkamp (LazyDodo) created P1700 (An Untitled Masterwork).
Oct 15 2020, 12:27 AM

Oct 13 2020

Ray molenkamp (LazyDodo) added a comment to D9189: Visual Studio Solution: Add user scripts from BLENDER_USER_SCRIPTS folder, if defined, otherwise default to user profile folder as before.

Thanks for the patch!

Oct 13 2020, 4:46 PM · Platforms, Builds & Tests
Ray molenkamp (LazyDodo) committed rBdd3b047f8b4d: Windows/CMake:Support BLENDER_USER_SCRIPTS in IDE (authored by Eric Cosky (eric_cosky)).
Windows/CMake:Support BLENDER_USER_SCRIPTS in IDE
Oct 13 2020, 4:45 PM
Ray molenkamp (LazyDodo) closed D9189: Visual Studio Solution: Add user scripts from BLENDER_USER_SCRIPTS folder, if defined, otherwise default to user profile folder as before.
Oct 13 2020, 4:45 PM · Platforms, Builds & Tests
Ray molenkamp (LazyDodo) added a comment to T81452: Policy for style guide: code comments.

A structure like

Oct 13 2020, 2:36 AM · BF Blender
Ray molenkamp (LazyDodo) added a comment to T81102: Blender crashing a lot randomly in the rendered viewport.

I have only repro'd with the file from T81587, have not tried any of the others.

Oct 13 2020, 12:32 AM · Render & Cycles, BF Blender

Oct 12 2020

Ray molenkamp (LazyDodo) added a comment to T81452: Policy for style guide: code comments.

Comments are comments, lets not try to give extra meaning to things that have none

Oct 12 2020, 6:34 PM · BF Blender

Oct 11 2020

stefano severi (Tetone) awarded D8864: CMake: Use Modern CMake for clog and guardedalloc a Like token.
Oct 11 2020, 9:40 AM

Oct 9 2020

Ray molenkamp (LazyDodo) added a comment to T81587: Consistent crash in Embree SSE42, SSE2 code in older Intel CPU..

I can reproduce this on AVX , it may not be architecture related.

Oct 9 2020, 10:47 PM · Render & Cycles, BF Blender
Ray molenkamp (LazyDodo) added a comment to D8864: CMake: Use Modern CMake for clog and guardedalloc.

As a result, anyone who ever had any exposure to modern CMake immediately knows what is going on without any abstraction.

Oct 9 2020, 5:00 PM

Oct 8 2020

Ray molenkamp (LazyDodo) added a comment to D8324: Multithreading Object Sync in Cycles Render.

I was a little more nuanced than that, i said as long as you can justify the changes, and the images are consistent between renders, you'll be ok, updating the ref images is not that big of a deal, however those two conditions do have to be met.

Oct 8 2020, 10:35 PM · Render & Cycles
Ray molenkamp (LazyDodo) requested changes to D9156: Use target to refer to bf_draw.

Please wait until D8864 has landed and then follow the structure it uses.

Oct 8 2020, 6:20 PM
Ray molenkamp (LazyDodo) requested review of D9147: Remove color console logging from the GPU module..
Oct 8 2020, 3:25 AM

Oct 7 2020

Ray molenkamp (LazyDodo) updated subscribers of D8864: CMake: Use Modern CMake for clog and guardedalloc.

I assumed this was only a conversation starter and didn't need to be accepted since you planned more work, but from devtalk it seems this is waiting so I'll accept it since it also seems fine as a first step to commit directly and then continue adding more libraries in master.

Oct 7 2020, 3:54 PM

Oct 6 2020

Ray molenkamp (LazyDodo) added a comment to D8864: CMake: Use Modern CMake for clog and guardedalloc.

we bumped the lower bound fairly recently, to 3.10

Oct 6 2020, 1:38 PM

Oct 2 2020

Ray molenkamp (LazyDodo) committed rB6b32de4d9fde: Cleanup: Fix build error on windows (authored by Ray molenkamp (LazyDodo)).
Cleanup: Fix build error on windows
Oct 2 2020, 7:47 PM

Oct 1 2020

Ray molenkamp (LazyDodo) committed rB84e122e38a54: Cycles: Fix broken 32 bit shift. (authored by Ray molenkamp (LazyDodo)).
Cycles: Fix broken 32 bit shift.
Oct 1 2020, 6:20 PM

Sep 30 2020

Ray molenkamp (LazyDodo) added a comment to T80383: Steam Blender doesnt open Saved Files.

I'm still convinced that exposing it in the UI is the way to go here, this is not a platform issue, the code to perform this registration is there, it's just not exposed in the UI

Sep 30 2020, 9:19 PM · Platform: Windows, BF Blender

Sep 29 2020

Ray molenkamp (LazyDodo) accepted D9051: Don't initialize Wintab if Tablet API is set to Native..

I can't test currently, but the change seems ok as a stop gap measure before we can land D7840 (target is 2.92 there) and get the sculpting guys going.

Sep 29 2020, 10:33 PM · Sculpt, Paint & Texture

Sep 26 2020

Ray molenkamp (LazyDodo) added a comment to T70313: Blender 2.80 always launches on the secondary monitor.

And that's the reason they don't bother fixing this because they feel that you can just rearrange screens (which is nonsense .... )

Sep 26 2020, 6:08 PM · Platform: Windows, BF Blender

Sep 25 2020

Ray molenkamp (LazyDodo) accepted D9002: Fluid: Use hidden symbol visibility.

I think @Brecht Van Lommel (brecht) mentioned a desire to move to -fvisibility=hidden on linux (and mac?) so for now this will do, until there is a blender wide solution in place.

Sep 25 2020, 5:27 PM

Sep 24 2020

Ray molenkamp (LazyDodo) requested changes to D9002: Fluid: Use hidden symbol visibility.

some minor nitpicking looks good otherwise.

Sep 24 2020, 5:42 PM

Sep 22 2020

Ray molenkamp (LazyDodo) added a comment to T80830: Libraries update took too long.
  • The platform maintainer who first implemented the preliminary support, puts it to master.>

@Sergey Sharybin (sergey) I assume "preliminary support" will be treated like new features, i.e. must go in in bcon1?

Sep 22 2020, 5:33 PM · BF Blender (2.91)
Ray molenkamp (LazyDodo) committed rBb21e2cfd03f0: CMake: Enable WITH_POTRACE by default (authored by Ray molenkamp (LazyDodo)).
CMake: Enable WITH_POTRACE by default
Sep 22 2020, 4:05 PM
Ray molenkamp (LazyDodo) planned changes to D8628: Deps: Add pugiXML as an official dependency..

only pugi was required for the 2.91 cycle, once we get closer to or are in bcon1 for 2.92 i'll land this.

Sep 22 2020, 3:53 PM

Sep 19 2020

Ray molenkamp (LazyDodo) committed rBL62491: Windows: OpenImageDenoise 1.2.3 .
Windows: OpenImageDenoise 1.2.3
Sep 19 2020, 7:14 PM
Ray molenkamp (LazyDodo) updated the task description for T80940: Deps: update to OpenImageDenoise 1.2.3.
Sep 19 2020, 7:14 PM · BF Blender (2.91), Platforms, Builds & Tests
Ray molenkamp (LazyDodo) added a comment to T80912: ppc64el, Debian: video sequence editor (VSE) preview corrupt.

none of those are used in the VSE, for all i know ffmpeg is delivering the frame to us like this, a developer will have to look at this, throwing random things at the wall going "could it be this?" doesn't seem like a good use of anyone's time.

Sep 19 2020, 12:50 AM · Platform: Linux, Video Sequencer, BF Blender

Sep 18 2020

Ray molenkamp (LazyDodo) added a comment to T80830: Libraries update took too long.

Code review (D8662) kind of dragged out on that one, which was weird, since it was a pretty straight forward lib with no crazy things in it, the patch was posted nearly a month before the bcon2 date and was mentioned in both the 2020-08-24 and 2020-08-31 meeting notes, complexity wise it was no different than D8384 (GMP) which sailed through in about a week.

Sep 18 2020, 10:01 PM · BF Blender (2.91)
Ray molenkamp (LazyDodo) committed rB104df2453ad2: deps: fix build issue on windows. (authored by Ray molenkamp (LazyDodo)).
deps: fix build issue on windows.
Sep 18 2020, 9:52 PM
Ray molenkamp (LazyDodo) added a comment to T80912: ppc64el, Debian: video sequence editor (VSE) preview corrupt.

Regarding endianness it seems we rely on __BIG_ENDIAN__ and __LITTLE_ENDIAN__ symbols to be defined correctly, but they are not defined in GCC. I don't build on Linux so I don't know if this has to be defined explicitly somewhere in make files. @Ray molenkamp (LazyDodo) Are you familiar with this?

Sep 18 2020, 9:37 PM · Platform: Linux, Video Sequencer, BF Blender
Ray molenkamp (LazyDodo) added a comment to D8951: GPencil: New Trace images using Potrace.

That is correct, looking at T80818 all platforms have updated, so we can turn it on by default

Sep 18 2020, 7:54 PM · Grease Pencil

Sep 17 2020

Ray molenkamp (LazyDodo) accepted D8923: CMake/Potrace: Fix capitalization, silence warning..
Sep 17 2020, 4:13 PM
Ray molenkamp (LazyDodo) added a comment to T80818: Deps: potrace 1.16.

The platform files on the blender side are included like this

Sep 17 2020, 3:46 PM · Platforms, Builds & Tests

Sep 16 2020

Ray molenkamp (LazyDodo) added a comment to D8737: WIP: Build OPENCL kernels at build time.

Of course running this already shows that baking was already broken

Sep 16 2020, 5:52 PM
Jeroen Bakker (jbakker) awarded D8737: WIP: Build OPENCL kernels at build time a Love token.
Sep 16 2020, 4:39 PM
Metin Seven (MetinSeven) awarded rB2eec6ec79338: Deps: Add potrace as a new library dependency a Like token.
Sep 16 2020, 10:06 AM

Sep 15 2020

Ray molenkamp (LazyDodo) changed the status of T80818: Deps: potrace 1.16 from Needs Triage to Confirmed.
Sep 15 2020, 9:21 PM · Platforms, Builds & Tests
Ray molenkamp (LazyDodo) committed rBL62486: Windows: potrace 1.16.
Windows: potrace 1.16
Sep 15 2020, 9:18 PM
Ray molenkamp (LazyDodo) committed rB2eec6ec79338: Deps: Add potrace as a new library dependency (authored by Ray molenkamp (LazyDodo)).
Deps: Add potrace as a new library dependency
Sep 15 2020, 9:17 PM
Ray molenkamp (LazyDodo) closed D8662: Deps: Add potrace as an external library..
Sep 15 2020, 9:17 PM
Ray molenkamp (LazyDodo) accepted D8892: Fix T79707, T79929: crashes with Cycles raytracing and denoising on older Macs.

small nit pick : all deps have this order

Sep 15 2020, 5:40 PM

Sep 14 2020

Ray molenkamp (LazyDodo) requested changes to D8892: Fix T79707, T79929: crashes with Cycles raytracing and denoising on older Macs.
Sep 14 2020, 7:28 PM

Sep 13 2020

Ray molenkamp (LazyDodo) committed rB1509d2ba7d12: Cleanup: Fix whitespace changes (authored by Ray molenkamp (LazyDodo)).
Cleanup: Fix whitespace changes
Sep 13 2020, 12:06 AM

Sep 12 2020

Ray molenkamp (LazyDodo) added a comment to D8662: Deps: Add potrace as an external library..

I'm OK with landing this in one of the GP branches (just tell me where it needs to go) so there's actually something to test against (we'll just have to wait with landing it to master until all platforms are done)

Sep 12 2020, 11:16 PM
Ray molenkamp (LazyDodo) added a comment to D8246: Use mmap() IO for reading uncompressed .blends.

it took a healthy chunk off the time it takes to run the unit tests, nice work!

Sep 12 2020, 6:09 PM

Sep 11 2020

Ray molenkamp (LazyDodo) committed rBb00820c04d2f: Cleanup: Fix build warning with MSVC (authored by Ray molenkamp (LazyDodo)).
Cleanup: Fix build warning with MSVC
Sep 11 2020, 9:38 PM
Ray molenkamp (LazyDodo) added a comment to T54576: Blender Running Laggy and Slow, Almost Unusable.

People keep pinging this thread so i'll give another rundown on what is happening here.

Sep 11 2020, 6:41 PM · Platform: Windows, BF Blender
Ray molenkamp (LazyDodo) added a comment to D8855: CMake/macOS: Remove _LIBPATH, avoid link_directories..

Urgh you're right on the boost DIR vs DIRS, this has always been "wrong" our cmake is a giant mess.

Sep 11 2020, 5:31 PM