Hi there,

In D3998#92422, @Dalai Felinto (dfelinto) wrote:

Would this fix this T59362?

Don't mix those two together, they are completely different. Edge split actually splits the mesh completely, while autosmooth only splits the normals. Thus with autosmooth there are still shared vertices and averaged vertex normals.

@Alexander Gavrilov (angavrilov)
Are you sure about the averaged normals being there when using autosmooth? I have created a simple mesh that I have autosmoothed but the mesh (struct Mesh in code) doesn't seem to have them. Am I looking at the wrong data structure? Is there another way to access per vertex information that has averaged normals?
I have attached an image to detail what the mesh looks like and the Mesh vertex data that goes with it.

In D3998#91498, @Alexander Gavrilov (angavrilov) wrote:

In D3998#91490, @Marco Alamia (Macro) wrote:

It is exactly for edge splits and autosmooth.

Don't mix those two together, they are completely different. Edge split actually splits the mesh completely, while autosmooth only splits the normals. Thus with autosmooth there are still shared vertices and averaged vertex normals.

Thank you for your time and for the review.

No changes from the previous revision - I have a feeling that I did something wrong when submitting the previous time since I have flagged some of the review as "Done" but the tool insist they are "Unsubmitted". I am not clear if it's my fault but it should be harmless to resubmit the same review.

Thanks Lukas for taking the time to code review my patch.