Page MenuHome

Kris (Metricity)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2019, 10:18 PM (108 w, 2 d)

Recent Activity

Thu, Apr 8

Kris (Metricity) updated the diff for D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.

Update to resolve feedback from previous revision and suggesions from chat

Thu, Apr 8, 10:55 PM · Geometry Nodes

Tue, Apr 6

Kris (Metricity) added inline comments to D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.
Tue, Apr 6, 6:59 PM · Geometry Nodes
Kris (Metricity) added a comment to T86838: Mesh to Volume Node.

Some other areas I encountered that may benefit from further discussion:

Tue, Apr 6, 6:03 PM · Nodes & Physics, Geometry Nodes
Kris (Metricity) updated the summary of D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.
Tue, Apr 6, 5:44 PM · Geometry Nodes

Mon, Apr 5

Kris (Metricity) added a comment to D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.

I do feel the new volume functions may have too many parameters, that is one of the reasons why I made BKE_volume_compute_voxel_size "public" so that BKE_mesh_to_volume wouldn't need the depsgraph, boundbox, resolution parameters.
Perhaps using a struct for the fill_volume, exterior & interior parameters makes sense. Then perhaps the voxel_size function can be called inside mesh_to_volume like it was originally.

Mon, Apr 5, 9:19 PM · Geometry Nodes
Kris (Metricity) added a revision to T86838: Mesh to Volume Node: D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.
Mon, Apr 5, 8:37 PM · Nodes & Physics, Geometry Nodes
Kris (Metricity) added a task to D10895: T86838 Geometry Nodes: Add Mesh To Volume Node: T86838: Mesh to Volume Node.
Mon, Apr 5, 8:37 PM · Geometry Nodes
Kris (Metricity) updated the summary of D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.
Mon, Apr 5, 8:35 PM · Geometry Nodes
Kris (Metricity) requested review of D10895: T86838 Geometry Nodes: Add Mesh To Volume Node.
Mon, Apr 5, 8:32 PM · Geometry Nodes

Sun, Apr 4

Kris (Metricity) renamed T87199: Geometry Nodes: volume output shows as cube in eevee rendered view from Geometry Nodes: volume output in shows as cube in eevee rendered view to Geometry Nodes: volume output shows as cube in eevee rendered view.
Sun, Apr 4, 8:46 PM · BF Blender (2.93), Nodes & Physics, Render & Cycles, Geometry Nodes
Kris (Metricity) renamed T87199: Geometry Nodes: volume output shows as cube in eevee rendered view from Geometry Nodes: volume output in rendered view shows as cube to Geometry Nodes: volume output in shows as cube in eevee rendered view.
Sun, Apr 4, 8:45 PM · BF Blender (2.93), Nodes & Physics, Render & Cycles, Geometry Nodes
Kris (Metricity) created T87199: Geometry Nodes: volume output shows as cube in eevee rendered view.
Sun, Apr 4, 8:44 PM · BF Blender (2.93), Nodes & Physics, Render & Cycles, Geometry Nodes
Kris (Metricity) added a comment to T86838: Mesh to Volume Node.

I have made some progress on adding a MeshToVolume node using the modifier and VolumeToMesh node as a guide. I need to review the feedback about D10506 in more detail as I have likely encountered similar issues. Hopefully I can provide my changes for feedback soon.

Sun, Apr 4, 8:09 PM · Nodes & Physics, Geometry Nodes

Fri, Apr 2

Kris (Metricity) added a comment to D10878: Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle. Add ME_EDGEDRAW, ME_EDGERENDER edge flags.

Yes @Himanshi Kalra (calra) I did do exactly what you mentioned. I placed a breakpoint on the return and viewed mesh in Watch 1 and result in Watch 2 (Visual Studio). This only showed data for the first edge but luckily that was different anyway. I then played with a natvis config so I could view all the edge data in the debugger.

Fri, Apr 2, 1:03 PM · Geometry Nodes
Kris (Metricity) updated the diff for D10878: Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle. Add ME_EDGEDRAW, ME_EDGERENDER edge flags.

No code changes, added more context to the diff

Fri, Apr 2, 2:37 AM · Geometry Nodes
Kris (Metricity) added a comment to T86874: Geometry node Plane primitive does not show wireframe in viewport.

Hi, I compared the original Mesh data with results from the earlier BMesh fix and noticed differences in the MEdge.flags. The flags were not set in the original code but adding ME_EDGEDRAW looks to resolve this issue.

Fri, Apr 2, 2:11 AM · Geometry Nodes, Nodes & Physics, BF Blender
Kris (Metricity) requested review of D10878: Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle. Add ME_EDGEDRAW, ME_EDGERENDER edge flags.
Fri, Apr 2, 1:56 AM · Geometry Nodes
Kris (Metricity) added a revision to T86874: Geometry node Plane primitive does not show wireframe in viewport: D10878: Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle. Add ME_EDGEDRAW, ME_EDGERENDER edge flags.
Fri, Apr 2, 1:56 AM · Geometry Nodes, Nodes & Physics, BF Blender

Mar 25 2019

Kris (Metricity) added a comment to T61412: Blender file explorer hard deletes data.

I was expecting feedback as this was my first time working with the blender codebase. The intention behind the separate function was if it could be used in other places and I wondered if linux or mac should have an implementation. It may also be worth reviewing if the regular delete functionality handles long paths too.

Mar 25 2019, 10:28 PM · BF Blender

Mar 24 2019

Kris (Metricity) added a comment to T61412: Blender file explorer hard deletes data.

I had a quick look at IFileOperation and was unsure regarding the single threaded/multi threaded apartment notes so went with older method, I hadn't considered the path limitation.

Mar 24 2019, 11:13 PM · BF Blender

Mar 22 2019

Kris (Metricity) added a task to D4579: Fix T61412: Blender file explorer hard deletes data: T61412: Blender file explorer hard deletes data.
Mar 22 2019, 11:24 PM · BF Blender
Kris (Metricity) added a revision to T61412: Blender file explorer hard deletes data: D4579: Fix T61412: Blender file explorer hard deletes data.
Mar 22 2019, 11:24 PM · BF Blender
Kris (Metricity) created D4579: Fix T61412: Blender file explorer hard deletes data.
Mar 22 2019, 11:23 PM · BF Blender