Page MenuHome

YimingWu (NicksBest)
User

Projects (8)

User Details

User Since
May 3 2014, 5:02 AM (384 w, 6 d)

Recent Activity

Yesterday

YimingWu (NicksBest) committed rB289f68588a7c: GPencil: Fix dash modifier reading error. (authored by YimingWu (NicksBest)).
GPencil: Fix dash modifier reading error.
Thu, Sep 16, 2:43 AM

Wed, Sep 15

YimingWu (NicksBest) closed T91421: Length Modifier "apply" ignores influence as Resolved by committing rBc420399f4da8: Fix T91421: Length modifier bake influence check..
Wed, Sep 15, 12:20 PM · Grease Pencil, Line Art, BF Blender
YimingWu (NicksBest) closed D12496: Fix T91421: Length modifier bake missing influence check..
Wed, Sep 15, 12:20 PM · Grease Pencil
YimingWu (NicksBest) committed rBc420399f4da8: Fix T91421: Length modifier bake influence check. (authored by YimingWu (NicksBest)).
Fix T91421: Length modifier bake influence check.
Wed, Sep 15, 12:20 PM
YimingWu (NicksBest) added a revision to T91421: Length Modifier "apply" ignores influence: D12496: Fix T91421: Length modifier bake missing influence check..
Wed, Sep 15, 10:12 AM · Grease Pencil, Line Art, BF Blender
YimingWu (NicksBest) added a task to D12496: Fix T91421: Length modifier bake missing influence check.: T91421: Length Modifier "apply" ignores influence.
Wed, Sep 15, 10:12 AM · Grease Pencil
YimingWu (NicksBest) requested review of D12496: Fix T91421: Length modifier bake missing influence check..
Wed, Sep 15, 10:11 AM · Grease Pencil
YimingWu (NicksBest) claimed T91421: Length Modifier "apply" ignores influence.
Wed, Sep 15, 10:09 AM · Grease Pencil, Line Art, BF Blender
ronan ducluzeau (zeauro) awarded rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces. a Like token.
Wed, Sep 15, 9:50 AM
ronan ducluzeau (zeauro) awarded rBa2c5c2b4068d: GPencil: Dot dash modifier. a Party Time token.
Wed, Sep 15, 9:49 AM
YimingWu (NicksBest) closed D11876: GPencil: Dot-dash modifier.
Wed, Sep 15, 8:39 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) committed rBa2c5c2b4068d: GPencil: Dot dash modifier. (authored by YimingWu (NicksBest)).
GPencil: Dot dash modifier.
Wed, Sep 15, 8:39 AM
YimingWu (NicksBest) closed D12051: Line Art feature update: Automatic crease with flat/smooth surfaces.
Wed, Sep 15, 8:05 AM · BF Blender (3.0)
YimingWu (NicksBest) committed rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces. (authored by YimingWu (NicksBest)).
LineArt: Automatic crease with flat/smooth faces.
Wed, Sep 15, 8:05 AM
YimingWu (NicksBest) added a comment to D12051: Line Art feature update: Automatic crease with flat/smooth surfaces.

I'm curious, is there a reason for this to be optional? Modifying the input meshes seems like a valid thing to do in this case, instead of adding yet another option to the modifier.

Wed, Sep 15, 7:45 AM · BF Blender (3.0)

Tue, Sep 14

YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

I think ultimately we go with @Henrik Dick (weasel) 's patch. Works quite nicely with my models as well.

Tue, Sep 14, 4:49 PM · Line Art, Grease Pencil
YimingWu (NicksBest) added a comment to D11876: GPencil: Dot-dash modifier.

If there's no more concern I shall push this to master.

Tue, Sep 14, 4:47 PM · Line Art, User Interface, Modifiers, Grease Pencil

Sat, Sep 11

YimingWu (NicksBest) updated the diff for D12126: Line Art feature update: Trimming edges right at the image border.

Updated to latest master.

Sat, Sep 11, 1:21 PM
YimingWu (NicksBest) added inline comments to D12126: Line Art feature update: Trimming edges right at the image border.
Sat, Sep 11, 1:19 PM
YimingWu (NicksBest) added inline comments to D12050: Line Art feature update: Smooth tolerance value for chaining..
Sat, Sep 11, 1:09 PM · BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12050: Line Art feature update: Smooth tolerance value for chaining..

Updated to latest master

Sat, Sep 11, 1:09 PM · BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12051: Line Art feature update: Automatic crease with flat/smooth surfaces.

Updated to latest master

Sat, Sep 11, 12:54 PM · BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12047: Line Art feature update: Custom Camera.

Updated to latest master.

Sat, Sep 11, 12:51 PM · Line Art, BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12046: Line Art feature update: Stroke offset function..

Updated to latest master.

Sat, Sep 11, 12:48 PM · Line Art, BF Blender (3.0)
YimingWu (NicksBest) updated the task description for T87739: Line Art further improvement list.
Sat, Sep 11, 11:18 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D11668: GPencil: Curvature support for length modifier.
  • Wrong angle step fixed.
  • Added twist toggle switch.
Sat, Sep 11, 7:01 AM · Line Art, Grease Pencil
YimingWu (NicksBest) commandeered D11668: GPencil: Curvature support for length modifier.
Sat, Sep 11, 7:00 AM · Line Art, Grease Pencil
YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

The sampled method is more robust especially when stroke quality is unknown for situations like line art. It uses the last segment's tangent as twist starting point, so existing usages with twisting needs tweaking, but for applying on line art, it's easier to get a nice effect. Maybe we could have two algorithms for the user to choose from?

Sat, Sep 11, 6:57 AM · Line Art, Grease Pencil
YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

Apparently these are obviously not right... no matter how big or small the overshoot value is, this method does not handle "hard lines" very well.

Sat, Sep 11, 5:11 AM · Line Art, Grease Pencil
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

Updated to include modifier default value assign.

Sat, Sep 11, 4:39 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) updated the summary of D11876: GPencil: Dot-dash modifier.
Sat, Sep 11, 4:37 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

Fixed stuff commented above.

Sat, Sep 11, 4:35 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) added a comment to D11876: GPencil: Dot-dash modifier.

Also fixed logic for when offset<0

Sat, Sep 11, 4:32 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) added a comment to D11876: GPencil: Dot-dash modifier.

@Hans Goudey (HooglyBoogly) Hi! Thanks for the comments

Sat, Sep 11, 3:56 AM · Line Art, User Interface, Modifiers, Grease Pencil

Thu, Sep 9

Vitalii Vlasov (Fracture128) awarded T87739: Line Art further improvement list a Like token.
Thu, Sep 9, 10:08 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) updated the task description for T87739: Line Art further improvement list.
Thu, Sep 9, 4:34 AM · Grease Pencil, BF Blender (3.0)

Mon, Sep 6

YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

About overshoot length: In my implementation the overshoot value is a ratio of stroke total length, this has a benefit of scaling the stroke doesn't change the appearance. Otherwise the curve will move around.

Mon, Sep 6, 3:38 AM · Line Art, Grease Pencil

Sat, Sep 4

YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

Great! it doesn't crash now, but after some testing I found two weird problems:

Sat, Sep 4, 4:28 AM · Line Art, Grease Pencil

Fri, Sep 3

YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

@Henrik Dick (weasel) Hello... This code crashes when gps->totpoints == 2, I suggest always create new points when curvature is turned on, otherwise the second call will have incorrect vert count. However when I removed the vert count check it still crashes with curvature off. You are most familiar with the new code path, so maybe you could give a hand. Thanks!

Fri, Sep 3, 3:33 PM · Line Art, Grease Pencil

Wed, Sep 1

YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

Do we need "angle increment" support? (Increase/decrease rotation for each segment)

Wed, Sep 1, 1:15 PM · Line Art, Grease Pencil
YimingWu (NicksBest) updated the diff for D12082: Line Art feature update: Multi thread intersection stage.

Now build triangle pairs in threads.

Wed, Sep 1, 12:16 PM
YimingWu (NicksBest) updated the summary of D11876: GPencil: Dot-dash modifier.
Wed, Sep 1, 10:24 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

Fixed stuff commented above.

Wed, Sep 1, 10:21 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) added inline comments to D11876: GPencil: Dot-dash modifier.
Wed, Sep 1, 9:55 AM · Line Art, User Interface, Modifiers, Grease Pencil

Thu, Aug 26

YimingWu (NicksBest) added a comment to D12046: Line Art feature update: Stroke offset function..

That's a good point. Maybe the modifier should not care about the "in-front" state. The reason for that is this function being mainly designed for allowing depth interaction between line art stroke and scene objects while not having z-fights, so if in-front is on, there will be no depth interaction so this extra offset step is not needed, which saves some cpu cycles.

Thu, Aug 26, 4:40 AM · Line Art, BF Blender (3.0)

Wed, Aug 25

YimingWu (NicksBest) updated the diff for D12082: Line Art feature update: Multi thread intersection stage.

Triangle based pair record, way too slow, and may need to get rid of some pairs by bound box, but that used to be handled in thread.

Wed, Aug 25, 9:33 AM
YimingWu (NicksBest) committed rB891e3e98eb6e: LineArt: Fix (Unreported) Crash when loading objects. (authored by YimingWu (NicksBest)).
LineArt: Fix (Unreported) Crash when loading objects.
Wed, Aug 25, 5:07 AM
YimingWu (NicksBest) updated the diff for D12046: Line Art feature update: Stroke offset function..
  • I removed the hard limit so it gives more freedom as of how the stroke can be moved.
  • Fixed persp/ortho bug.
  • Clamp stroke to the front plane so it's always visible.
Wed, Aug 25, 4:05 AM · Line Art, BF Blender (3.0)

Tue, Aug 24

YimingWu (NicksBest) updated the diff for D12046: Line Art feature update: Stroke offset function..
  • Updated to latest master.
  • Use "stroke_depth_offset" as prop name as suggested.
Tue, Aug 24, 1:13 PM · Line Art, BF Blender (3.0)

Mon, Aug 23

YimingWu (NicksBest) updated subscribers of D11668: GPencil: Curvature support for length modifier.

The new UI looks like this now, @Hans Goudey (HooglyBoogly) anything to add about the UI?

Mon, Aug 23, 3:26 PM · Line Art, Grease Pencil
YimingWu (NicksBest) closed D12284: GPencil: Fix memory leak in split and trim functions.
Mon, Aug 23, 2:49 PM · Grease Pencil
YimingWu (NicksBest) committed rBb4b3f518aa04: GPencil: Fix memory leak in split & trim functions (authored by YimingWu (NicksBest)).
GPencil: Fix memory leak in split & trim functions
Mon, Aug 23, 2:48 PM
YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

@Henrik Dick (weasel) Hi! Thanks for the fix! the code looks much less convoluted now.

Mon, Aug 23, 5:29 AM · Line Art, Grease Pencil
YimingWu (NicksBest) accepted D12284: GPencil: Fix memory leak in split and trim functions.

Looks good to me. @Antonio Vazquez (antoniov) Do you have anything to say about this one?

Mon, Aug 23, 4:52 AM · Grease Pencil

Fri, Aug 20

YimingWu (NicksBest) updated the summary of D11668: GPencil: Curvature support for length modifier.
Fri, Aug 20, 6:40 AM · Line Art, Grease Pencil
YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

Tested twisting, seems to be working correctly.

Fri, Aug 20, 6:39 AM · Line Art, Grease Pencil
YimingWu (NicksBest) updated the diff for D11668: GPencil: Curvature support for length modifier.

Updated for end point drift-free geometry

Fri, Aug 20, 6:31 AM · Line Art, Grease Pencil
YimingWu (NicksBest) added a comment to D11668: GPencil: Curvature support for length modifier.

I applied Δφ/2 on the first angle and it shows up nicely, with the end point nearly not drifting. But I'm not sure how to apply the segment length part...

Fri, Aug 20, 6:14 AM · Line Art, Grease Pencil
YimingWu (NicksBest) added a comment to D12046: Line Art feature update: Stroke offset function..

This option should probably called "Stroke Depth Offset" or just "Depth Offset" as Stroke offset could also mean other types of offset.

Fri, Aug 20, 5:30 AM · Line Art, BF Blender (3.0)

Thu, Aug 19

YimingWu (NicksBest) updated the diff for D12082: Line Art feature update: Multi thread intersection stage.

Updated to include tile subdiv depth limit (to the same current limit value in master)

Thu, Aug 19, 5:27 AM

Aug 18 2021

YimingWu (NicksBest) closed T90695: Adding a Scene Line Art Grease Pencil object is 20X slower in 3.0 vs 2.93 as Resolved.
Aug 18 2021, 6:47 AM · Grease Pencil, BF Blender
YimingWu (NicksBest) closed D12236: Line Art Bug Fix: Lower tile splitting limit.
Aug 18 2021, 6:06 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) committed rBf41beca97787: Fix T90695: Lower tile splitting limit for lineart (authored by YimingWu (NicksBest)).
Fix T90695: Lower tile splitting limit for lineart
Aug 18 2021, 6:05 AM
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

Fixed problems pointed above.

Aug 18 2021, 5:57 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) added a comment to D12236: Line Art Bug Fix: Lower tile splitting limit.

@Sebastian Parborg (zeddb) some times pixel size is not quite enough, for example when your output size is small but the scene is complex, that would lead to inadequate splitting, although in that case the details can hardly be seen, but line art can't really simplify the model if the user set it up that way. Because it's geometry based, output speed is unlikely to be proportional to image size. (Freestyle does ray trace, so if you have a large output size, in a complex model, it often leads to a very lengthy calculation)

Aug 18 2021, 5:48 AM · Grease Pencil, BF Blender (3.0)

Aug 17 2021

YimingWu (NicksBest) added a comment to D11876: GPencil: Dot-dash modifier.

Is this(manual sampling) the preferred design, or is the sampling done this way for technical reasons?

Aug 17 2021, 10:42 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) requested review of D12236: Line Art Bug Fix: Lower tile splitting limit.
Aug 17 2021, 10:36 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) added a comment to T90695: Adding a Scene Line Art Grease Pencil object is 20X slower in 3.0 vs 2.93.

After a fix, now runs fine now somewhere near 25s on my surface, should be close to your 2.93 performance on your machine. I'll attach a patch here shortly.

Aug 17 2021, 10:29 AM · Grease Pencil, BF Blender
YimingWu (NicksBest) added a comment to T90695: Adding a Scene Line Art Grease Pencil object is 20X slower in 3.0 vs 2.93.

sure... let me check.

Aug 17 2021, 5:46 AM · Grease Pencil, BF Blender

Aug 10 2021

YimingWu (NicksBest) updated subscribers of T71079: Blender bug throws error on LANPR RENDER.

I'm working with @Sebastian Parborg (zeddb) for threading the most part of line art, so the current version should already be faster than the older undedr-gp branch. And also comes with a lot of bug fixed in terms of math and other stuff for better accuracy.

Aug 10 2021, 4:32 AM · Add-ons (Community)
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

This should apply to master now.

Aug 10 2021, 4:26 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D12082: Line Art feature update: Multi thread intersection stage.

Use grid+sort/merge method to avoid all locks in add_triangles stage, indeed much more improvement there.

Aug 10 2021, 4:12 AM
YimingWu (NicksBest) added a comment to T71079: Blender bug throws error on LANPR RENDER.

Hi, you guys should use temp-lineart-contained instead of other branches, only this one is up-to-date.

Aug 10 2021, 3:30 AM · Add-ons (Community)
YimingWu (NicksBest) added a comment to D11876: GPencil: Dot-dash modifier.

I'll do it :)

Aug 10 2021, 3:29 AM · Line Art, User Interface, Modifiers, Grease Pencil

Aug 4 2021

YimingWu (NicksBest) added a revision to T87739: Line Art further improvement list: D12126: Line Art feature update: Trimming edges right at the image border.
Aug 4 2021, 10:45 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) added a task to D12126: Line Art feature update: Trimming edges right at the image border: T87739: Line Art further improvement list.
Aug 4 2021, 10:45 AM
YimingWu (NicksBest) requested review of D12126: Line Art feature update: Trimming edges right at the image border.
Aug 4 2021, 10:45 AM
YimingWu (NicksBest) updated the task description for T87739: Line Art further improvement list.
Aug 4 2021, 4:44 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) added a comment to T90414: GPencil: New icons.

I'll provide my proposal here:

Aug 4 2021, 4:42 AM · Line Art, Grease Pencil, BF Blender

Aug 3 2021

Paul Larson (GeorgiaPacific) awarded T87739: Line Art further improvement list a Like token.
Aug 3 2021, 5:42 PM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12050: Line Art feature update: Smooth tolerance value for chaining..

Updated to include ui range changes.

Aug 3 2021, 2:30 PM · BF Blender (3.0)
YimingWu (NicksBest) updated the task description for T87739: Line Art further improvement list.
Aug 3 2021, 2:22 PM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) added a comment to D12047: Line Art feature update: Custom Camera.

Actually this function is pretty crucial if we want panorama camera emulation. In which cases there will be 6 cameras rendering the same scene for the same frame for anything >180 deg (like sky box, though rare, but very likely 2 or 4 camera stitching for this kind of use)

Aug 3 2021, 2:19 PM · Line Art, BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

Turns out that part is updated automatically by script, and the icon_geom part failed. Fixed now.

Aug 3 2021, 1:06 PM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) added inline comments to D11876: GPencil: Dot-dash modifier.
Aug 3 2021, 12:52 PM · Line Art, User Interface, Modifiers, Grease Pencil
Gavriel Lavi (Gavriel5578) awarded D11876: GPencil: Dot-dash modifier a Pterodactyl token.
Aug 3 2021, 12:48 PM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D11876: GPencil: Dot-dash modifier.

I added my proposed icon.

Aug 3 2021, 10:49 AM · Line Art, User Interface, Modifiers, Grease Pencil
YimingWu (NicksBest) requested review of D12111: Line Art clean up: UI style and range..
Aug 3 2021, 9:44 AM · BF Blender (3.0), Grease Pencil
YimingWu (NicksBest) added a comment to D12049: Line Art feature update: Camera Overscan.

Thanks for the reminder :D. I'll make it more consistent.

Aug 3 2021, 1:48 AM · BF Blender (3.0)

Aug 2 2021

YimingWu (NicksBest) updated the summary of D12083: Line Art feature update: Shadow Projection.
Aug 2 2021, 9:05 AM · BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12083: Line Art feature update: Shadow Projection.

Got reversed

Aug 2 2021, 8:40 AM · BF Blender (3.0)
YimingWu (NicksBest) updated the diff for D12083: Line Art feature update: Shadow Projection.

Updated UI for better clarity

Aug 2 2021, 8:28 AM · BF Blender (3.0)
YimingWu (NicksBest) committed rB48722e897113: LineArt: Prevent depsgraph warning when camera is NULL. (authored by YimingWu (NicksBest)).
LineArt: Prevent depsgraph warning when camera is NULL.
Aug 2 2021, 7:46 AM

Jul 31 2021

YimingWu (NicksBest) updated the diff for D12051: Line Art feature update: Automatic crease with flat/smooth surfaces.

Mesh auto smooth supported.

Jul 31 2021, 5:42 AM · BF Blender (3.0)
YimingWu (NicksBest) committed rB7c961e716db6: LineArt: Fix(unreported): Child object respect collection visibility. (authored by YimingWu (NicksBest)).
LineArt: Fix(unreported): Child object respect collection visibility.
Jul 31 2021, 4:03 AM
YimingWu (NicksBest) committed rBd91c266986de: LineArt: Material flag versioning correction. (authored by YimingWu (NicksBest)).
LineArt: Material flag versioning correction.
Jul 31 2021, 3:30 AM

Jul 30 2021

YimingWu (NicksBest) added a comment to D12083: Line Art feature update: Shadow Projection.

After some struggle today I get the occlusion right for the front/back facing shadow receiving surface. Due to occlusion function precision issue, light contour will sometimes be a bit problematic as they are essentially "overlapping edges" in that context. This needs to have an architectural solution as current shadow is algorithmetically correct, we do not have a way to share "this is the matching edge that we tested in the shadow computation" between two runs of line art. Due to different culling, we might not be able to use a set of loaded geometry again which enables shadow and occlusion calculation in one go, so there needs to be a data passage. This will also enable us to select edges that are in the occluded region differently as stated before.

Jul 30 2021, 12:48 PM · BF Blender (3.0)
Yuro (Yuro) awarded D12082: Line Art feature update: Multi thread intersection stage a Love token.
Jul 30 2021, 3:03 AM
Yuro (Yuro) awarded T87739: Line Art further improvement list a Love token.
Jul 30 2021, 3:03 AM · Grease Pencil, BF Blender (3.0)
YimingWu (NicksBest) added a comment to D12083: Line Art feature update: Shadow Projection.

The problem at the moment is that we need to pass info between 2 line art calculations so we know "if the edge is projected onto this exact triangle".

Jul 30 2021, 2:10 AM · BF Blender (3.0)