Page MenuHome

YimingWu (NicksBest)
User

Projects

User Details

User Since
May 3 2014, 5:02 AM (302 w, 1 d)

Recent Activity

Jan 17 2020

Romain Guimbal (captGuimbal) awarded D5442: LANPR line rendering (summer of code) a Love token.
Jan 17 2020, 6:04 PM · EEVEE & Viewport

Jan 11 2020

Taiwo Folu (Taiwofolu) awarded D5442: LANPR line rendering (summer of code) a Love token.
Jan 11 2020, 2:45 PM · EEVEE & Viewport

Dec 26 2019

Vyacheslav (hitrpr) awarded D5442: LANPR line rendering (summer of code) a Love token.
Dec 26 2019, 1:16 PM · EEVEE & Viewport

Dec 17 2019

YimingWu (NicksBest) updated the summary of D5442: LANPR line rendering (summer of code).
Dec 17 2019, 6:10 AM · EEVEE & Viewport

Dec 4 2019

YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Don't know why but I'm able to push and pull on remote branch temp-lanpr-review. Maybe try git pull once and see? I'm not quite sure about how the script works. You can apply this patch to master and compile. the older branches are not used as of now.

Dec 4 2019, 1:22 PM · EEVEE & Viewport

Dec 3 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Warning message for GPU cache size overflow. Useful in big scenes that could hint the user to use bigger sized cache.

Dec 3 2019, 6:50 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Up to date with latest origin/master

Dec 3 2019, 6:47 AM · EEVEE & Viewport

Nov 30 2019

Fran Marz (franMarz) awarded D5442: LANPR line rendering (summer of code) a Yellow Medal token.
Nov 30 2019, 2:56 PM · EEVEE & Viewport

Nov 28 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Missing a bracket. Fixed.

Nov 28 2019, 2:57 PM · EEVEE & Viewport
Gustavo (gaonirico) awarded D5442: LANPR line rendering (summer of code) a Love token.
Nov 28 2019, 10:38 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Cleaned up thread lock execution path, making LANPR internal state is predictable.
  • Use locked scene loading for LANPR, lock is released when LANPR finishes loading the scene, this avoids accessing potentially deleted scene data from depsgraph when it's running in background thread.
  • Removed camera and scene reference in LANPR_RenderBuffer for the same reason as above.
Nov 28 2019, 7:59 AM · EEVEE & Viewport

Nov 27 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • CollectionLANPR changed to pointer.
Nov 27 2019, 3:33 PM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Just checked the runtime cache of LANPR data, the computation intermediate result can't be saved into DNA because it could easily go beyond Gigs of data. Other parts of LANPR data is already in SceneLANPR and CollectionLANPR.

Nov 27 2019, 3:30 PM · EEVEE & Viewport

Nov 22 2019

YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Right. So it's better to use pointers and to only initialize for LANPR configured collection. That might be a better idea. Thank you!

Nov 22 2019, 4:39 PM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

I checked the data structure of existing LANPR stuff, I think the idea of how to save/load LANPR data is doable. I'll do a following update on this.

Nov 22 2019, 12:26 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Fixed some comments pointed above. I'm looking into the rest.

Nov 22 2019, 12:21 PM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 22 2019, 12:17 PM · EEVEE & Viewport

Nov 20 2019

YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Fixed multisample texture calls due to DRW_ to GPU_ call changes.

Nov 20 2019, 1:59 PM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 20 2019, 1:45 PM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Cleaned up, Now use temp-lanpr-review branch.

Nov 20 2019, 10:26 AM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 20 2019, 10:21 AM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 20 2019, 9:19 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Fixed stuff commented as above.

Nov 20 2019, 9:15 AM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 20 2019, 9:12 AM · EEVEE & Viewport

Nov 18 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Clean up code, including data types, variables and function definitions.

Nov 18 2019, 3:18 PM · EEVEE & Viewport

Nov 17 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Fixed the comments above.

Nov 17 2019, 1:34 PM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 17 2019, 1:28 PM · EEVEE & Viewport

Nov 15 2019

YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 15 2019, 3:43 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Fix assertion errors when scene is removed and re-created.
  • Fix assertion errors in render view.
  • Material marking errors fixed.
Nov 15 2019, 1:34 PM · EEVEE & Viewport
YimingWu (NicksBest) commandeered D6257: GPencil Length modifier.
Nov 15 2019, 2:33 AM · Grease Pencil

Nov 14 2019

YimingWu (NicksBest) commandeered D5795: GPencil MultiStroke modifier.
Nov 14 2019, 2:55 PM · Modifiers, Grease Pencil
YimingWu (NicksBest) accepted D5795: GPencil MultiStroke modifier.
Nov 14 2019, 2:50 PM · Modifiers, Grease Pencil
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

A description of how LANPR store it's global and cache data:

Nov 14 2019, 10:31 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Ortho view now works in viewport.
  • Fixed float/double format matrix thing.
  • Added the missing compiler flag in blenkernel, which fixes the memory leak when deleting scene on quit.
Nov 14 2019, 5:27 AM · EEVEE & Viewport

Nov 13 2019

YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 13 2019, 11:03 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Cleanup the unused property and float value format.
  • Removed chaining threshold value in LANPR engine. That value is only effective in grease pencil conversion.
Nov 13 2019, 6:45 AM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 13 2019, 6:10 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Ortho view in the viewport now displays correctly.

Nov 13 2019, 6:10 AM · EEVEE & Viewport

Nov 8 2019

Okavango (Okavango) awarded D5442: LANPR line rendering (summer of code) a Love token.
Nov 8 2019, 8:14 AM · EEVEE & Viewport

Nov 6 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Fixed memory leak when using auto update in the viewport.

Nov 6 2019, 2:09 PM · EEVEE & Viewport

Nov 4 2019

Julien Leménicier (mistajuliax) awarded D5442: LANPR line rendering (summer of code) a Love token.
Nov 4 2019, 9:37 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Added compiler switch in the space_api folder.

Nov 4 2019, 3:53 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • More clear statement for endpoint flag value in chain drawing.
  • Removed redundant snake mode file. Cleaned up header defines.
Nov 4 2019, 3:42 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Removed redundant code in readfile.c
  • Fixed the bracket issue.
Nov 4 2019, 3:31 PM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Nov 4 2019, 2:32 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Reverted the changes in smoke.c to origin/master

Nov 4 2019, 2:31 PM · EEVEE & Viewport

Nov 3 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Added build options for LANPR in python scripts.

Nov 3 2019, 2:18 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Added compiler options for LANPR in various places. Now you will be able to compile with or without LANPR.

Nov 3 2019, 1:51 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Added freestyle option back for the edge mark UI.

Nov 3 2019, 12:58 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Cleaned up lanpr conditions in space_view3d.py.

Nov 3 2019, 11:39 AM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Fixed the comment

Nov 3 2019, 4:24 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Reverted "lanpr" to "freestyle" for edge mark operators.
Nov 3 2019, 4:24 AM · EEVEE & Viewport

Nov 2 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Removed the redundant is_unit_transformation() script.
Nov 2 2019, 5:10 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.

Uploaded a wrong diff. Fixed.

Nov 2 2019, 5:08 PM · Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.
Nov 2 2019, 5:07 PM · Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.
  • "MultiStroke" -> "Multiple Strokes" naming change.
  • Length modifier now has another tip length value to avoid end-point jittering.
  • For Multiple Strokes modifier: When duplications==0 then disable, don't use the checkbox for it.
Nov 2 2019, 7:05 AM · Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Sorry, the file was probably merged back from anther temp branch. Now fixed.

Nov 2 2019, 5:41 AM · EEVEE & Viewport

Oct 30 2019

YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

2 Fixes:

Oct 30 2019, 3:11 PM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Deleted temp-lanpr-cleanup, use temp-lanpr-cleanup2 instead.

Oct 30 2019, 12:35 PM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.

Changes made in this diff:

Oct 30 2019, 9:54 AM · Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).

Removed "reset object transformations" script for grease pencil target.

Oct 30 2019, 9:51 AM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Looks like after some diff operations I've managed to make temp-lanpr-cleanup working again. Let me check if I the second branch can be deleted.

Oct 30 2019, 9:44 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the diff for D5442: LANPR line rendering (summer of code).
  • Shader variables naming now consistent.
  • There used to be another merge problem from long time ago in one of the eevee shaders now fixed.
  • Included camera and object UI panels for easy debugging. (other UI changes in separate child patch)
  • Fixed reportedly wrong edge flags for intersection and material separator lines.
Oct 30 2019, 9:39 AM · EEVEE & Viewport

Oct 17 2019

Nahuel Belich (belich) awarded D5442: LANPR line rendering (summer of code) a Love token.
Oct 17 2019, 1:12 AM · EEVEE & Viewport

Oct 10 2019

YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.

Reverted the DEG_id_tag_update() line.

Oct 10 2019, 12:14 PM · Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.

Fixed code styles and discarded BLI_map.h changes.

Oct 10 2019, 11:15 AM · Modifiers, Grease Pencil
YimingWu (NicksBest) updated the diff for D5795: GPencil MultiStroke modifier.

Code style fixes.

Oct 10 2019, 10:57 AM · Modifiers, Grease Pencil

Sep 27 2019

YimingWu (NicksBest) added a comment to T36350: Freestyle renders extra lines.

This problem of random appearing/disappearing lines is due to freestyle's occlusion algorithm. Upcoming LANPR patch will include a smooth contour modifier that deals with freestyle's line problems on subdivided models. We may not be fixing freestyle at the moment and will be focused on LANPR.

Sep 27 2019, 2:51 AM · Render & Cycles, Freestyle, Rendering, BF Blender

Sep 21 2019

YimingWu (NicksBest) added a comment to D5835: UI panel fixes for adding LANPR engine..

Thanks. I'll take a look. Looks like that we don't really need many of those flags. But that's how blender's existing scripts are done....

Sep 21 2019, 4:54 AM

Sep 18 2019

tonton (samytichadou) awarded D5442: LANPR line rendering (summer of code) a Love token.
Sep 18 2019, 12:17 PM · EEVEE & Viewport
YimingWu (NicksBest) created D5835: UI panel fixes for adding LANPR engine..
Sep 18 2019, 8:50 AM

Sep 15 2019

YimingWu (NicksBest) added a comment to D5795: GPencil MultiStroke modifier.

Added layer/material selector for UI/functionality consistency with other GPencil modifiers. Works after simple test.

Sep 15 2019, 4:07 PM · Modifiers, Grease Pencil
YimingWu (NicksBest) added a comment to D5795: GPencil MultiStroke modifier.

Fixed stroke shrinking function for correct length handling. Now Length modifier in both relative and absolute mode works correctly, and they handles 0 length situations correctly.

Sep 15 2019, 3:42 PM · Modifiers, Grease Pencil

Sep 14 2019

YimingWu (NicksBest) added a comment to D5795: GPencil MultiStroke modifier.

No, this is stand-alone and don't need LANPR patch to run. I'll remove this from gp-object branch later.

Sep 14 2019, 11:44 AM · Modifiers, Grease Pencil
YimingWu (NicksBest) created D5795: GPencil MultiStroke modifier.
Sep 14 2019, 10:28 AM · Modifiers, Grease Pencil

Sep 13 2019

Way awarded D5442: LANPR line rendering (summer of code) a Love token.
Sep 13 2019, 8:37 PM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5785: GPencil simplify modifier sample mode fixes.

Committed into master.

Sep 13 2019, 3:44 PM · Grease Pencil
Antonio Vazquez (antoniov) awarded T69829: Grease pencil simplify modifier crashes blender in sample mode a Like token.
Sep 13 2019, 3:44 PM · Grease Pencil, BF Blender
YimingWu (NicksBest) committed rBd4fb85036640: Fix T69829: Gpencil sample memory leaks. (authored by YimingWu (NicksBest)).
Fix T69829: Gpencil sample memory leaks.
Sep 13 2019, 3:44 PM
YimingWu (NicksBest) changed the status of T69829: Grease pencil simplify modifier crashes blender in sample mode from Unknown Status to Resolved by committing rBd4fb85036640: Fix T69829: Gpencil sample memory leaks..
Sep 13 2019, 3:44 PM · Grease Pencil, BF Blender
YimingWu (NicksBest) added a comment to T69829: Grease pencil simplify modifier crashes blender in sample mode.

It doesn't crash for my tests, If you had more complex scene, a example file would help to check if the fix really worked. Thanks!

Sep 13 2019, 3:17 PM · Grease Pencil, BF Blender
YimingWu (NicksBest) claimed T69829: Grease pencil simplify modifier crashes blender in sample mode.
Sep 13 2019, 3:11 PM · Grease Pencil, BF Blender
YimingWu (NicksBest) added a comment to T69829: Grease pencil simplify modifier crashes blender in sample mode.

Here I provide a diff for the fix, After using blender -d, doesn't appear to have any moew memory leaks from my tests including multiple sample operations.

Sep 13 2019, 3:10 PM · Grease Pencil, BF Blender
YimingWu (NicksBest) added a task to D5785: GPencil simplify modifier sample mode fixes: T69829: Grease pencil simplify modifier crashes blender in sample mode.
Sep 13 2019, 3:09 PM · Grease Pencil
YimingWu (NicksBest) added a revision to T69829: Grease pencil simplify modifier crashes blender in sample mode: D5785: GPencil simplify modifier sample mode fixes.
Sep 13 2019, 3:09 PM · Grease Pencil, BF Blender
YimingWu (NicksBest) created D5785: GPencil simplify modifier sample mode fixes.
Sep 13 2019, 3:09 PM · Grease Pencil

Sep 12 2019

YimingWu (NicksBest) created T69796: Deferred deletion of depsgraph copied data.
Sep 12 2019, 1:20 PM · Dependency Graph, BF Blender
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Removed MOD_Featureline.c. No longer needed.

Sep 12 2019, 10:37 AM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

A symbol problem in one of the python script. Fixed. Sorry...

Sep 12 2019, 10:23 AM · EEVEE & Viewport
David Kozma (kynu) awarded D5442: LANPR line rendering (summer of code) a Love token.
Sep 12 2019, 10:18 AM · EEVEE & Viewport
YimingWu (NicksBest) updated the summary of D5442: LANPR line rendering (summer of code).

Undone Freestyle changes.

Sep 12 2019, 9:37 AM · EEVEE & Viewport
YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Changed target material and layer selector from number into string selector.

Sep 12 2019, 9:02 AM · EEVEE & Viewport

Sep 8 2019

Hardnax EMP (HARDNAX) awarded D5442: LANPR line rendering (summer of code) a Like token.
Sep 8 2019, 4:27 PM · EEVEE & Viewport

Sep 5 2019

YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

Update on the fixes. This is still the LANPR bulk.

Sep 5 2019, 3:59 PM · EEVEE & Viewport

Sep 4 2019

YimingWu (NicksBest) added a comment to D5442: LANPR line rendering (summer of code).

I'm posting the updated patch for Smooth Contour and some GP modifiers as sub tasks here. (Tomorrow) They do not directly interact with LANPR but they will be included anyway. Main part is still being fixing, hopefully be ready before the end of the week.

Sep 4 2019, 4:54 PM · EEVEE & Viewport
momotron2000 (momotron2000) awarded D5442: LANPR line rendering (summer of code) a Manufacturing Defect? token.
Sep 4 2019, 12:25 PM · EEVEE & Viewport
johan tri handoyo (johantri) awarded D5442: LANPR line rendering (summer of code) a Love token.
Sep 4 2019, 12:23 PM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Sep 4 2019, 9:15 AM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Sep 4 2019, 9:11 AM · EEVEE & Viewport
YimingWu (NicksBest) added inline comments to D5442: LANPR line rendering (summer of code).
Sep 4 2019, 8:22 AM · EEVEE & Viewport