- User Since
- Oct 8 2017, 3:15 AM (40 w, 3 d)
Nov 25 2017
Updated Diff with the changes requested by @Sybren A. Stüvel (sybren) .
Nov 20 2017
Nov 15 2017
Changed to BLI_INLINE.
Nov 14 2017
Nov 9 2017
IMHO It seems to me that building in a higher gcc version would be a feasible solution addressing the code readability problem and performance at same time. If its not the case, maybe opening an exception to use macros here would be the less of two evils.
Nov 5 2017
Nov 1 2017
Just updated the code to also add the last two effects from BLI_math_color_blend.h (difference and exclusion), also fixed a bug: the ColorMix effect wasn't being serialized on saving.
Oct 30 2017
Oct 29 2017
I appreciate the tests you have made, thanks a lot. I was afraid if it would be optimized for all possible compilers (like for windows, mac, etc), so I went the hard way of explicit calling all the inline functions.
Oct 13 2017
Fixed the layout for the Color Mix effect Blend Mode property. And added linear burn, pin light, linear light, and vivid light. Thanks again for all the feedbacks!!!
Adjusted the label to Blend Mode as Aaron Carlisle suggested.
Oct 12 2017
Fixed a little bug in do_screen_effect.
Hi szap, thanks for the support! Blender is a great software, I believe that it deserves to have this basic blend modes in VSE. I work with video editing in my spare time and all other professional editing softwares have those, but I do like blender and decided to add them myself. I really hope it gets accepted!
Oct 11 2017
I just updated the diff with changes concerning the code style and the 'BLI_math_color_blend.h' functions.
I removed the Eak define directives and replaced them for inline functions as requested, concerning the SET_TYPE indentation, they are as the other ones (gaussian blur and text are the ones that are off).
Oct 10 2017
I tried to modify the code accordingly to the blender code style.
Oct 9 2017
It is very important to follow the code style. I will read the link you sent and adjust the patch accordingly as soon as I get back from work.
That should be very nice, thanks a lot! I shall work on more effects in the future.
Oct 8 2017
Hi, thanks for your review.