Maikon Araujo (Nokiam)
Analysis

Projects

User does not belong to any projects.

User Details

User Since
Oct 8 2017, 3:15 AM (27 w, 4 d)

Recent Activity

Nov 25 2017

Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

Updated Diff with the changes requested by @Sybren A. Stüvel (sybren) .

Nov 25 2017, 1:39 AM · Video Sequencer
Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Diff updated.

Nov 25 2017, 1:37 AM · Video Sequencer

Nov 20 2017

Maikon Araujo (Nokiam) updated the summary of D2925: Proposed fix for some math_color_blend functions.
Nov 20 2017, 6:32 PM
Maikon Araujo (Nokiam) created D2925: Proposed fix for some math_color_blend functions.
Nov 20 2017, 6:22 PM

Nov 15 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Changed to BLI_INLINE.

Nov 15 2017, 2:36 AM · Video Sequencer

Nov 14 2017

Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

Hi guys,

Nov 14 2017, 12:19 PM · Video Sequencer

Nov 9 2017

Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

IMHO It seems to me that building in a higher gcc version would be a feasible solution addressing the code readability problem and performance at same time. If its not the case, maybe opening an exception to use macros here would be the less of two evils.

Nov 9 2017, 2:58 AM · Video Sequencer

Nov 5 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Hi guys,

Nov 5 2017, 8:38 PM · Video Sequencer

Nov 1 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Just updated the code to also add the last two effects from BLI_math_color_blend.h (difference and exclusion), also fixed a bug: the ColorMix effect wasn't being serialized on saving.

Nov 1 2017, 1:21 PM · Video Sequencer

Oct 30 2017

Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

... like code path number 3 in the new version:

which does the trick in GCC 4.7 (as well as current versions).

Oct 30 2017, 12:09 AM · Video Sequencer

Oct 29 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

I appreciate the tests you have made, thanks a lot. I was afraid if it would be optimized for all possible compilers (like for windows, mac, etc), so I went the hard way of explicit calling all the inline functions.

Oct 29 2017, 10:01 PM · Video Sequencer

Oct 13 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Fixed the layout for the Color Mix effect Blend Mode property. And added linear burn, pin light, linear light, and vivid light. Thanks again for all the feedbacks!!!

Oct 13 2017, 8:26 PM · Video Sequencer
Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Adjusted the label to Blend Mode as Aaron Carlisle suggested.

Oct 13 2017, 3:47 PM · Video Sequencer
Maikon Araujo (Nokiam) added inline comments to D2872: Add Screen and Overlay blend mode to VSE.
Oct 13 2017, 3:44 PM · Video Sequencer
Maikon Araujo (Nokiam) added inline comments to D2872: Add Screen and Overlay blend mode to VSE.
Oct 13 2017, 7:03 AM · Video Sequencer
Konstantin (Ko) awarded D2872: Add Screen and Overlay blend mode to VSE a Like token.
Oct 13 2017, 6:05 AM · Video Sequencer
Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Hi guys,

Oct 13 2017, 5:43 AM · Video Sequencer

Oct 12 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Fixed a little bug in do_screen_effect.

Oct 12 2017, 8:40 PM · Video Sequencer
Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

Hi szap, thanks for the support! Blender is a great software, I believe that it deserves to have this basic blend modes in VSE. I work with video editing in my spare time and all other professional editing softwares have those, but I do like blender and decided to add them myself. I really hope it gets accepted!

Oct 12 2017, 3:01 AM · Video Sequencer
paul szajner (szap) awarded D2872: Add Screen and Overlay blend mode to VSE a Love token.
Oct 12 2017, 1:37 AM · Video Sequencer

Oct 11 2017

Maikon Araujo (Nokiam) added a watcher for Video Sequencer: Maikon Araujo (Nokiam).
Oct 11 2017, 10:37 PM
Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

I just updated the diff with changes concerning the code style and the 'BLI_math_color_blend.h' functions.

Oct 11 2017, 3:19 PM · Video Sequencer
Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

Is it really needed as two different effects? To me it seems more like a "blend" effect, which will support any of blending modes from BLI_math_color_blend.h. Even if we currently only will support two blend modes, still don't see why it's beneficial to have different effect type for those.

Oct 11 2017, 12:50 PM · Video Sequencer
Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

I removed the Eak define directives and replaced them for inline functions as requested, concerning the SET_TYPE indentation, they are as the other ones (gaussian blur and text are the ones that are off).

Oct 11 2017, 5:16 AM · Video Sequencer

Oct 10 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

I tried to modify the code accordingly to the blender code style.

Oct 10 2017, 7:07 AM · Video Sequencer

Oct 9 2017

Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

It is very important to follow the code style. I will read the link you sent and adjust the patch accordingly as soon as I get back from work.

Oct 9 2017, 3:26 PM · Video Sequencer
Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.

That should be very nice, thanks a lot! I shall work on more effects in the future.

Oct 9 2017, 1:25 AM · Video Sequencer

Oct 8 2017

Maikon Araujo (Nokiam) updated the diff for D2872: Add Screen and Overlay blend mode to VSE.

Hi, thanks for your review.

Oct 8 2017, 6:06 PM · Video Sequencer
Maikon Araujo (Nokiam) added a comment to D2872: Add Screen and Overlay blend mode to VSE.
Oct 8 2017, 5:55 PM · Video Sequencer
Maikon Araujo (Nokiam) created D2872: Add Screen and Overlay blend mode to VSE.
Oct 8 2017, 6:44 AM · Video Sequencer