Page MenuHome

Omar Ahmad (OmarSquircleArt)
User

Projects

User Details

User Since
Jan 28 2017, 8:06 AM (125 w, 3 d)

Recent Activity

Sat, Jun 22

Omar Ahmad (OmarSquircleArt) added a comment to D5123: Make sure output is enabled before connecting in node wrangler.
  • Add a utilitie function is_visible_socket
Sat, Jun 22, 4:11 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5123: Make sure output is enabled before connecting in node wrangler.

@Jacques Lucke (JacquesLucke) Sorry, never mind, will do that.

Sat, Jun 22, 4:03 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5123: Make sure output is enabled before connecting in node wrangler.

@Jacques Lucke (JacquesLucke) A disabled socket can still be visible. Perhaps is_valid_socket(socket) would be a better name?

Sat, Jun 22, 4:01 PM
Omar Ahmad (OmarSquircleArt) updated the summary of D5123: Make sure output is enabled before connecting in node wrangler.
Sat, Jun 22, 3:01 PM
Omar Ahmad (OmarSquircleArt) created D5123: Make sure output is enabled before connecting in node wrangler.
Sat, Jun 22, 2:57 PM

Wed, Jun 12

Omar Ahmad (OmarSquircleArt) committed rB66a23ef8331c: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Wed, Jun 12, 3:05 PM
Omar Ahmad (OmarSquircleArt) committed rB167d871d15ca: Initial implementation of White Noise node (authored by Omar Ahmad (OmarSquircleArt)).
Initial implementation of White Noise node
Wed, Jun 12, 1:56 PM

Tue, Jun 11

Omar Ahmad (OmarSquircleArt) added a comment to D3743: Tiled Voronoi Noise : Cycles, Eevee and OSL.

@Eneko Castresana Vara (ecv) thanks for the diff. I've left the patch waiting for review. I think that this will be looked at after 2.80 is released. I've also contacted @Omar Ahmad (OmarSquircleArt) to see if he can incorporate this into his new GSOC procedural branch.

Tue, Jun 11, 2:06 PM · Cycles, Eevee, BF Blender: 2.8

Sat, Jun 8

Omar Ahmad (OmarSquircleArt) committed rB61ea4f8d6665: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Sat, Jun 8, 8:26 PM

Thu, Jun 6

Omar Ahmad (OmarSquircleArt) committed rB88540c566410: Omit use_clamp in math node. Replaced by clamp node (authored by Omar Ahmad (OmarSquircleArt)).
Omit use_clamp in math node. Replaced by clamp node
Thu, Jun 6, 8:58 PM
Omar Ahmad (OmarSquircleArt) committed rBd1579b4824c6: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Thu, Jun 6, 7:19 PM
Omar Ahmad (OmarSquircleArt) committed rB1b7a46a0769f: Add shading clamp node (authored by Omar Ahmad (OmarSquircleArt)).
Add shading clamp node
Thu, Jun 6, 7:19 PM
Omar Ahmad (OmarSquircleArt) committed rB7e0a0fd5c9c8: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Thu, Jun 6, 1:31 PM
Omar Ahmad (OmarSquircleArt) committed rBf9787ea484c2: Clean up map range node (authored by Omar Ahmad (OmarSquircleArt)).
Clean up map range node
Thu, Jun 6, 12:54 PM

Wed, Jun 5

Omar Ahmad (OmarSquircleArt) committed rB6e3ae36a987d: Added Shader Map Range node. (authored by Omar Ahmad (OmarSquircleArt)).
Added Shader Map Range node.
Wed, Jun 5, 7:15 PM
Omar Ahmad (OmarSquircleArt) committed rBfc6d8fe7af02: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Wed, Jun 5, 1:20 PM
Omar Ahmad (OmarSquircleArt) added a comment to rB94a28c98f9e0: Clean up vector math node..

As it turned out, we can't arbitrary filter the GPUNodeStack in/out array because it will be enumerated against the node inputs themselves regardless of their availability, so a shift in input mapping will happen if the removed GPUNodeStack is not at the end of the array. That's why it seemed to work sometimes and other times not, because in the cases where it worked, we were removing the inputs at the ends.

Wed, Jun 5, 1:05 PM
Omar Ahmad (OmarSquircleArt) committed rB94a28c98f9e0: Clean up vector math node. (authored by Omar Ahmad (OmarSquircleArt)).
Clean up vector math node.
Wed, Jun 5, 12:57 PM

Tue, Jun 4

Omar Ahmad (OmarSquircleArt) committed rB7bd95ae57309: Implement constant folding for mapping node. (authored by Omar Ahmad (OmarSquircleArt)).
Implement constant folding for mapping node.
Tue, Jun 4, 1:24 PM
Fin O'Riordan (fin.eskimo) awarded rBab18171fdf4a: Initial implementation of the new Mapping node. a Love token.
Tue, Jun 4, 12:55 AM

Mon, Jun 3

Omar Ahmad (OmarSquircleArt) committed rBee2a4dd398f7: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Mon, Jun 3, 6:02 PM
Omar Ahmad (OmarSquircleArt) committed rBab18171fdf4a: Initial implementation of the new Mapping node. (authored by Omar Ahmad (OmarSquircleArt)).
Initial implementation of the new Mapping node.
Mon, Jun 3, 6:02 PM

Sat, Jun 1

Bartosz Moniewski (monio) awarded rB18be4b8866d3: Changed default vector socket drawing method. Introduce compact socket. a Love token.
Sat, Jun 1, 6:18 PM
Omar Ahmad (OmarSquircleArt) added a comment to rB80edd6205110: Fix Mapping node..

Not sure how this should have been handled. We could have used stack_load_float_default or stack_valid in the kernel and pass SVM_STACK_INVALID, but the original code seem to reuse offset_out in case input/output is not used, so I just followed this convention. This is the only case that the NODE_VECTOR_MATH is used outside of its abstract node, so it doesn't matter much.

Sat, Jun 1, 12:32 PM
Omar Ahmad (OmarSquircleArt) committed rB80edd6205110: Fix Mapping node. (authored by Omar Ahmad (OmarSquircleArt)).
Fix Mapping node.
Sat, Jun 1, 12:27 PM
Omar Ahmad (OmarSquircleArt) committed rBfbc507353af2: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Sat, Jun 1, 12:27 PM

Fri, May 31

Omar Ahmad (OmarSquircleArt) committed rB686e4d609bf3: GLSL reflect function needs normalized normal. (authored by Omar Ahmad (OmarSquircleArt)).
GLSL reflect function needs normalized normal.
Fri, May 31, 9:28 PM
Omar Ahmad (OmarSquircleArt) committed rBff1244dac720: Fixed CUDA and OpenCL kernels for reflect and project functions. (authored by Omar Ahmad (OmarSquircleArt)).
Fixed CUDA and OpenCL kernels for reflect and project functions.
Fri, May 31, 9:23 PM
Brecht Van Lommel (brecht) awarded rB18be4b8866d3: Changed default vector socket drawing method. Introduce compact socket. a Love token.
Fri, May 31, 2:16 PM
Omar Ahmad (OmarSquircleArt) committed rBed17d2500819: Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge remote-tracking branch 'origin/master' into soc-2019-cycles-procedural
Fri, May 31, 2:11 PM
Omar Ahmad (OmarSquircleArt) added a comment to rB18be4b8866d3: Changed default vector socket drawing method. Introduce compact socket..

This commit changes the default drawing method of vector sockets to use a column layout. This encourages more interactive use of nodes and avoid the one or two clicks needed to edit vectors in the old default component layout.

Fri, May 31, 2:04 PM
Omar Ahmad (OmarSquircleArt) committed rB18be4b8866d3: Changed default vector socket drawing method. Introduce compact socket. (authored by Omar Ahmad (OmarSquircleArt)).
Changed default vector socket drawing method. Introduce compact socket.
Fri, May 31, 1:53 PM

Thu, May 30

Omar Ahmad (OmarSquircleArt) abandoned D4625: Dynamic socket hiding for single-operand math functions..

Since this wasn't accepted in time, I will close this as it will be implemented in my GSoC project. fac13b10a256

Thu, May 30, 11:12 PM
Omar Ahmad (OmarSquircleArt) committed rBfac13b10a256: Make second input in math node unavailable for single operand operations. (authored by Omar Ahmad (OmarSquircleArt)).
Make second input in math node unavailable for single operand operations.
Thu, May 30, 11:08 PM
Omar Ahmad (OmarSquircleArt) added a comment to rBa52006c2fe87: Initial implementation of new vector math node..

@LazyDodo (LazyDodo) Are we to create a branch for the project in the blender manual repository?

Thu, May 30, 6:01 PM
Omar Ahmad (OmarSquircleArt) added a comment to rBa52006c2fe87: Initial implementation of new vector math node..

This commit adds more operations to the vector math node. We will have to fix compatibility with old blends by some versioning code. In particular, old operations no longer have two outputs, but only their default output. For instance, dot product operation now only returns a scalar.

Thu, May 30, 4:27 PM
Omar Ahmad (OmarSquircleArt) committed rBb904c16f94d8: Fixed vector math node SVM compile function (authored by Omar Ahmad (OmarSquircleArt)).
Fixed vector math node SVM compile function
Thu, May 30, 4:15 PM
Omar Ahmad (OmarSquircleArt) committed rB77fed8156dc8: Merge master to soc-cycles-procedural (authored by Omar Ahmad (OmarSquircleArt)).
Merge master to soc-cycles-procedural
Thu, May 30, 1:34 PM
Omar Ahmad (OmarSquircleArt) committed rBa52006c2fe87: Initial implementation of new vector math node. (authored by Omar Ahmad (OmarSquircleArt)).
Initial implementation of new vector math node.
Thu, May 30, 1:34 PM

Apr 7 2019

Omar Ahmad (OmarSquircleArt) created D4658: Fix Float Math Sin operator.
Apr 7 2019, 4:47 PM

Apr 3 2019

Omar Ahmad (OmarSquircleArt) added a comment to D4625: Dynamic socket hiding for single-operand math functions..

The versioning code still doesn't work when the math node is connected to a Group Input node. This is because the link to the Group Input node have a null fromnode member for some reason. @Brecht Van Lommel (brecht) Why does links to Group Input nodes have null fromnode members?

Apr 3 2019, 9:17 PM
Omar Ahmad (OmarSquircleArt) updated the diff for D4625: Dynamic socket hiding for single-operand math functions..
  • Refactor math node versioning code.
Apr 3 2019, 9:13 PM

Apr 2 2019

Omar Ahmad (OmarSquircleArt) planned changes to D4625: Dynamic socket hiding for single-operand math functions..

It seems the versioning code doesn't work when the nodes are inside node groups. So I will fix that and refactor the code based on suggestions by Jacques.

Apr 2 2019, 10:42 PM
Omar Ahmad (OmarSquircleArt) updated the diff for D4625: Dynamic socket hiding for single-operand math functions..
  • Added versioning code to math node.
Apr 2 2019, 10:16 PM
Omar Ahmad (OmarSquircleArt) added a comment to D4625: Dynamic socket hiding for single-operand math functions..

I want to learn about the process. So I think I will take the versioning approach if you don't mind.

Apr 2 2019, 7:24 PM
Omar Ahmad (OmarSquircleArt) added a comment to D4625: Dynamic socket hiding for single-operand math functions..

This breaks backwards compatible for cases where links were connected to the second socket. In general we always try to preserve compatibility unless there is a good reason to break it.
A solution could be to hide the first socket if there is a link to the second socket, and keep node_shader_exec_math and gpu_shader_math unchanged?

Apr 2 2019, 7:19 PM

Apr 1 2019

Christian Friedrich (rbx775) awarded D4625: Dynamic socket hiding for single-operand math functions. a Love token.
Apr 1 2019, 8:31 PM
Omar Ahmad (OmarSquircleArt) added a comment to D4625: Dynamic socket hiding for single-operand math functions..

@Christian Friedrich (rbx775) Yes, the link will get disconnected if the operation became a single operand one. And it will get reconnected again if the operation became two operand. See this gif:

Apr 1 2019, 8:22 PM
Omar Ahmad (OmarSquircleArt) added a comment to T63156: Animation nodes: crash clicking on update separate text object node.

This isn't a crash, please report such issues to the Animation Nodes issue's page. Moreover, this error was fixed in the latest build. Can you update to the latest Animation Nodes build and see if the error still persists?

Apr 1 2019, 8:19 PM · Addons
Omar Ahmad (OmarSquircleArt) added a comment to T63156: Animation nodes: crash clicking on update separate text object node.

Can't reproduce this either.

Apr 1 2019, 1:40 PM · Addons

Mar 31 2019

Benjamin Meyer (Anvilarion) awarded D4625: Dynamic socket hiding for single-operand math functions. a Like token.
Mar 31 2019, 10:01 PM

Mar 30 2019

Tomas (Rusculleda) awarded D4625: Dynamic socket hiding for single-operand math functions. a Love token.
Mar 30 2019, 9:47 PM
Omar Ahmad (OmarSquircleArt) updated the summary of D4625: Dynamic socket hiding for single-operand math functions..
Mar 30 2019, 9:26 PM
Omar Ahmad (OmarSquircleArt) created D4625: Dynamic socket hiding for single-operand math functions..
Mar 30 2019, 9:21 PM

Mar 4 2019

Omar Ahmad (OmarSquircleArt) added a comment to T62074: 2.8: Python API: Access violation calling bpy.ops.object.mode_set in Application timer.

@Jacques Lucke (JacquesLucke) Yes, the following script works as expected:

Mar 4 2019, 6:55 PM · BF Blender

Mar 2 2019

Omar Ahmad (OmarSquircleArt) added a comment to T62074: 2.8: Python API: Access violation calling bpy.ops.object.mode_set in Application timer.

System Information:
OS: Arch Linux with Xorg.

Mar 2 2019, 4:05 PM · BF Blender

Feb 8 2019

Omar Ahmad (OmarSquircleArt) created T61309: mesh_utils.triangle_random_points fails with a TypeError..
Feb 8 2019, 8:58 AM · Addons

Dec 3 2018

Omar Ahmad (OmarSquircleArt) created T58641: Identifier resulted from prop_search is prefixed by three spaces..
Dec 3 2018, 8:51 PM · Python, BF Blender

Dec 2 2018

Omar Ahmad (OmarSquircleArt) awarded rB8d4da34883b2: Fix T58267: node socket grabbing not working well with box select tool. a Like token.
Dec 2 2018, 8:35 AM

Feb 2 2017

Omar Ahmad (OmarSquircleArt) created T50581: Blender won't start on arch linux pacman's build.
Feb 2 2017, 3:58 PM · Platform: Linux, BF Blender