Page MenuHome

Omar Emara (OmarSquircleArt)
User

Projects (8)

User Details

User Since
Jan 28 2017, 8:06 AM (191 w, 5 h)

Recent Activity

Thu, Sep 17

Omar Emara (OmarSquircleArt) updated the diff for D8389: Modifiers: Add material offsets for Array modifier.
  • Merge branch 'master' into array_cap_material_index
  • Update UI.
Thu, Sep 17, 3:27 PM

Thu, Sep 3

Omar Emara (OmarSquircleArt) committed rB340cbc7f1537: Fix T79803: Wrong Distance To Edge 1D Voronoi (authored by Omar Emara (OmarSquircleArt)).
Fix T79803: Wrong Distance To Edge 1D Voronoi
Thu, Sep 3, 6:55 PM
Omar Emara (OmarSquircleArt) closed D8634: Fix T79803: Wrong Distance To Edge 1D Voronoi.
Thu, Sep 3, 6:55 PM
Omar Emara (OmarSquircleArt) added inline comments to D8389: Modifiers: Add material offsets for Array modifier.
Thu, Sep 3, 1:55 PM
Omar Emara (OmarSquircleArt) added a comment to D8389: Modifiers: Add material offsets for Array modifier.

@Hans Goudey (HooglyBoogly) It is supposed to be an offset, as can be seen in mp->mat_nr += material_offset;. Taking a look at the use of material indices in modifiers, it seems Material Index is only used once in the bevel modifier while the other modifiers all use Material Offset. Moreover, Material Index require special attention to the automatic case, which is signaled by passing -1 which seems less intuitive. That's why I opted for Material Offset. What do you think?

Thu, Sep 3, 10:27 AM

Aug 24 2020

Omar Emara (OmarSquircleArt) accepted D8697: Fix T79915: Crash when changing to White Noise Texture.
Aug 24 2020, 8:03 PM

Aug 19 2020

Omar Emara (OmarSquircleArt) added a comment to D8634: Fix T79803: Wrong Distance To Edge 1D Voronoi.

@Jacques Lucke (JacquesLucke) Left is the old result. Right is the new result.

Aug 19 2020, 6:31 PM
Omar Emara (OmarSquircleArt) requested review of D8634: Fix T79803: Wrong Distance To Edge 1D Voronoi.
Aug 19 2020, 6:25 PM

Aug 17 2020

Omar Emara (OmarSquircleArt) committed rBe14de692fc99: UI: Only draw node menu search if categories exist (authored by Omar Emara (OmarSquircleArt)).
UI: Only draw node menu search if categories exist
Aug 17 2020, 1:42 PM
Omar Emara (OmarSquircleArt) closed D8576: UI: Only draw node menu search if categories exist.
Aug 17 2020, 1:42 PM

Aug 14 2020

Joao Morgado (MrJomo) awarded D8576: UI: Only draw node menu search if categories exist a Like token.
Aug 14 2020, 9:37 PM
Omar Emara (OmarSquircleArt) requested review of D8576: UI: Only draw node menu search if categories exist.
Aug 14 2020, 9:11 PM

Jul 31 2020

Omar Emara (OmarSquircleArt) added a comment to T78803: UI drawing artifacts on Mesa after recent commit..

Apparently the SB backend is no longer maintained and will be superseded by an NIR backend. Mesa developers suggested we disable the SB backend R600_DEBUG=nosb as a workaround until the NIR path is mature enough to be used. Since this only affects the R600/SB path that is not officially supported by Blender, I guess we can close this and maybe mention the workaround somewhere.

Jul 31 2020, 1:43 PM · EEVEE & Viewport
Omar Emara (OmarSquircleArt) added a comment to D8389: Modifiers: Add material offsets for Array modifier.

@Brecht Van Lommel (brecht) Isn't this how the rest of the modifiers do it. The solidify and wireframe modifiers come to mind, they specify an offset rather than an explicit index or material.

Jul 31 2020, 1:17 PM
Alex Strand (astrand130) awarded D8389: Modifiers: Add material offsets for Array modifier a Love token.
Jul 31 2020, 9:57 AM

Jul 28 2020

Omar Emara (OmarSquircleArt) added a comment to D8387: Modifiers: Add count offset option to Array modifier.

Ah, you were talking about the minimum, sorry. I am not sure, this is how the rest of the code sets the minimum.

Jul 28 2020, 3:12 PM
Omar Emara (OmarSquircleArt) added a comment to D8387: Modifiers: Add count offset option to Array modifier.

@Jacques Lucke (JacquesLucke) The old behavior was an offset of 1, see line 502 in the original. So that's why I set the default to 1 as well, though I think a default of zero would be a better idea. I will add versioning once I get an initial approval.

Jul 28 2020, 3:10 PM

Jul 27 2020

Omar Emara (OmarSquircleArt) added a comment to D8388: Modifiers: Consider Array caps when fitting length.

@Jesse Y (deadpin) The modifiers test fails. How do we adjust that? Where is the expected output stored?

Jul 27 2020, 6:17 PM
Omar Emara (OmarSquircleArt) added a comment to D8388: Modifiers: Consider Array caps when fitting length.

@Jesse Y (deadpin) Thanks for notifying! I am having a bit of trouble with tests, I will check as soon as I get them working.

Jul 27 2020, 8:50 AM
Aaron Carlisle (Blendify) awarded D8389: Modifiers: Add material offsets for Array modifier a Like token.
Jul 27 2020, 3:27 AM

Jul 26 2020

Omar Emara (OmarSquircleArt) added a comment to D8389: Modifiers: Add material offsets for Array modifier.

Example:

Jul 26 2020, 11:21 PM
Omar Emara (OmarSquircleArt) requested review of D8389: Modifiers: Add material offsets for Array modifier.
Jul 26 2020, 11:20 PM
Omar Emara (OmarSquircleArt) added a comment to D8388: Modifiers: Consider Array caps when fitting length.

Old method:

Jul 26 2020, 11:11 PM
Omar Emara (OmarSquircleArt) requested review of D8388: Modifiers: Consider Array caps when fitting length.
Jul 26 2020, 11:01 PM
Omar Emara (OmarSquircleArt) added a comment to D8387: Modifiers: Add count offset option to Array modifier.

The old behavior is equivalent to a count offset = 1, which is the default behavior now. A count offset of 0 is equivalent to a "flooring" of a non-round length while a count of 1 is equivalent to a "ceiling" of a non-round length.

Jul 26 2020, 10:52 PM
Omar Emara (OmarSquircleArt) requested review of D8387: Modifiers: Add count offset option to Array modifier.
Jul 26 2020, 10:44 PM
Omar Emara (OmarSquircleArt) added a comment to T78803: UI drawing artifacts on Mesa after recent commit..

Disabling the back-end SB shader optimizer fixes the issue. So perhaps the best option would be to report that to Mesa. Gert Wollny of the R600 team have the same GPU I have, so maybe he can help fix this upstream. What do you think?

Jul 26 2020, 1:51 PM · EEVEE & Viewport

Jul 25 2020

Omar Emara (OmarSquircleArt) added a comment to T78803: UI drawing artifacts on Mesa after recent commit..

@Ankit Meel (ankitm) The problem is still there. Compiled at 1e999c7bdb63576fd66815c1770d096d165b8281.

Jul 25 2020, 8:58 PM · EEVEE & Viewport

Jul 12 2020

Omar Emara (OmarSquircleArt) created T78866: Writing to the body of an animated text object in a frame_change_post handler suppress animation during rendering..
Jul 12 2020, 9:17 PM · BF Blender

Jul 10 2020

Omar Emara (OmarSquircleArt) added a comment to T78803: UI drawing artifacts on Mesa after recent commit..

Jul 10 2020, 9:49 PM · EEVEE & Viewport
Omar Emara (OmarSquircleArt) created T78803: UI drawing artifacts on Mesa after recent commit..
Jul 10 2020, 7:04 PM · EEVEE & Viewport

May 23 2020

Antonio Javier Torralba Moreno (corpse) awarded D6143: Shading: Add Seamless option to the Voronoi texture. a Love token.
May 23 2020, 12:28 PM

May 4 2020

Gabriel Moro (gabrielmoro) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
May 4 2020, 7:30 PM

Apr 7 2020

Omar Emara (OmarSquircleArt) added a comment to D6154: Cycles: Add Random Per Island attribute..

@Patrick (patnard) This what the White Noise is for:

Apr 7 2020, 10:27 AM

Apr 2 2020

Charlie Jolly (charlie) awarded D6680: Cycles: AVX implantation of Perlin noise. a Love token.
Apr 2 2020, 3:44 PM

Apr 1 2020

Omar Emara (OmarSquircleArt) committed rBf047d47e24fc: Cycles: AVX implantation of Perlin noise. (authored by Omar Emara (OmarSquircleArt)).
Cycles: AVX implantation of Perlin noise.
Apr 1 2020, 2:48 PM
Omar Emara (OmarSquircleArt) closed D6680: Cycles: AVX implantation of Perlin noise..
Apr 1 2020, 2:48 PM

Mar 4 2020

Omar Emara (OmarSquircleArt) added a comment to T73211: mathnode socket doesn't restore when voronoi signal is turned to .

Unfortunately, I was wrong. This does break versioning.

Mar 4 2020, 6:54 PM · Nodes, User Interface, BF Blender
Omar Emara (OmarSquircleArt) added a comment to T73211: mathnode socket doesn't restore when voronoi signal is turned to .

@Jacques Lucke (JacquesLucke) Taking a quick look at the versioning code. It seems versioning is done before any update take place. So it doesn't seem like this change will affect versioning. I will take a closer look later.

Mar 4 2020, 4:09 PM · Nodes, User Interface, BF Blender

Feb 22 2020

vas (Alumx) awarded D6143: Shading: Add Seamless option to the Voronoi texture. a Burninate token.
Feb 22 2020, 4:39 PM

Feb 17 2020

Vladislav Macíček (Aeraglyx) awarded rB1c2f7b022a56: Cycles: Add Random Per Island attribute. a Like token.
Feb 17 2020, 9:23 PM
Omar Emara (OmarSquircleArt) committed rB5231d06d4cd4: Cleanup: Remove period from RNA description. (authored by Omar Emara (OmarSquircleArt)).
Cleanup: Remove period from RNA description.
Feb 17 2020, 3:37 PM
Omar Emara (OmarSquircleArt) committed rBae9bbb4d0360: Python: Expose WM is_interface_locked to python. (authored by Omar Emara (OmarSquircleArt)).
Python: Expose WM is_interface_locked to python.
Feb 17 2020, 1:07 PM
Omar Emara (OmarSquircleArt) closed D6749: Python: Expose WM is_interface_locked to python..
Feb 17 2020, 1:06 PM

Feb 15 2020

Omar Emara (OmarSquircleArt) updated the diff for D6680: Cycles: AVX implantation of Perlin noise..
  • Move CCL_NAMESPACE_END inside ifndef block in util_avx{b, f, i}.h.
Feb 15 2020, 1:16 PM

Feb 14 2020

Omar Emara (OmarSquircleArt) updated the diff for D6749: Python: Expose WM is_interface_locked to python..
  • Add description to the Is Interface Locked property.
Feb 14 2020, 8:43 PM

Feb 12 2020

Bernhard Engstler (B_Engstler) awarded D6143: Shading: Add Seamless option to the Voronoi texture. a Love token.
Feb 12 2020, 10:15 PM

Feb 5 2020

Omar Emara (OmarSquircleArt) added inline comments to D6680: Cycles: AVX implantation of Perlin noise..
Feb 5 2020, 4:18 PM
Omar Emara (OmarSquircleArt) added a comment to D6680: Cycles: AVX implantation of Perlin noise..

One question though. In the util files, we have:

Feb 5 2020, 11:10 AM
Omar Emara (OmarSquircleArt) added a comment to D6680: Cycles: AVX implantation of Perlin noise..

@Sergey Sharybin (sergey) It seems I can measure similar performance gains on my setup as well. I can also measure about 23% performance gain in 4D noise.

Feb 5 2020, 11:06 AM

Feb 4 2020

Omar Emara (OmarSquircleArt) added a comment to D6749: Python: Expose WM is_interface_locked to python..

D6703 contains an extended discussion of the reasoning behind this patch. Let me recap.

Feb 4 2020, 1:29 PM
Omar Emara (OmarSquircleArt) abandoned D6703: Python Handlers: Add export events..

Abandoned in favor of D6749.

Feb 4 2020, 12:35 PM
Omar Emara (OmarSquircleArt) created D6749: Python: Expose WM is_interface_locked to python..
Feb 4 2020, 12:34 PM
Omar Emara (OmarSquircleArt) added inline comments to D6680: Cycles: AVX implantation of Perlin noise..
Feb 4 2020, 11:14 AM

Feb 3 2020

Omar Emara (OmarSquircleArt) added inline comments to D6680: Cycles: AVX implantation of Perlin noise..
Feb 3 2020, 5:19 PM
Omar Emara (OmarSquircleArt) added inline comments to D6680: Cycles: AVX implantation of Perlin noise..
Feb 3 2020, 4:46 PM
Omar Emara (OmarSquircleArt) added inline comments to D6680: Cycles: AVX implantation of Perlin noise..
Feb 3 2020, 4:02 PM
Omar Emara (OmarSquircleArt) added a comment to D6680: Cycles: AVX implantation of Perlin noise..

@Max (maxim_d33) Does it compile now?

Feb 3 2020, 2:26 PM
Omar Emara (OmarSquircleArt) updated the diff for D6680: Cycles: AVX implantation of Perlin noise..
  • Merge branch 'master' into avx-perlin-noise
  • Fix avxi for AVX platforms.
Feb 3 2020, 1:14 PM
Omar Emara (OmarSquircleArt) added a comment to D6680: Cycles: AVX implantation of Perlin noise..

Ok. My bad, it turned out I was compiling with WITH_CYCLES_NATIVE_ONLY. Will update the patch.

Feb 3 2020, 12:17 PM
Omar Emara (OmarSquircleArt) added a comment to D6680: Cycles: AVX implantation of Perlin noise..

@Max (maxim_d33) No. I compile with clang 9. I will investigate.

Feb 3 2020, 11:55 AM

Jan 30 2020

Omar Emara (OmarSquircleArt) added a comment to D6703: Python Handlers: Add export events..

This is a choice that I would leave to the script writers. I wouldn't want Blender to make that choice for you.

Jan 30 2020, 12:59 PM
Omar Emara (OmarSquircleArt) added a comment to D6703: Python Handlers: Add export events..

@Campbell Barton (campbellbarton) This won't be much of a problem for us because we already store an is_rendering state using the render handlers. While it is not an ideal solution, it is very clean and works nicely.

Jan 30 2020, 9:17 AM

Jan 29 2020

Omar Emara (OmarSquircleArt) added a comment to D6703: Python Handlers: Add export events..

@Campbell Barton (campbellbarton) Alternatively, how about exposing the is_interface_locked value of wmWindowManager as an RNA property so we can access it from python? It seems to be properly set where it matters.

Jan 29 2020, 9:49 AM
Omar Emara (OmarSquircleArt) added a comment to D6703: Python Handlers: Add export events..

@Campbell Barton (campbellbarton) Sounds reasonable.

Jan 29 2020, 6:52 AM

Jan 28 2020

Omar Emara (OmarSquircleArt) created D6703: Python Handlers: Add export events..
Jan 28 2020, 5:45 PM
Omar Emara (OmarSquircleArt) added a comment to D6680: Cycles: AVX implantation of Perlin noise..

I am not sure if there is a better way to measure this. But I use the following scene. About 40% of the CPU cycles are spent in the noise code.


I also used the Class Room scene Blender demo as a production test.

Jan 28 2020, 9:00 AM

Jan 27 2020

Omar Emara (OmarSquircleArt) created D6680: Cycles: AVX implantation of Perlin noise..
Jan 27 2020, 9:49 AM

Jan 25 2020

Omar Emara (OmarSquircleArt) added a comment to D6672: Shading: Add color output option to White Noise node..

I don't know the technical details behind those kind of optimizations, unfortunately. I just know they happen. 😄

Jan 25 2020, 6:40 PM
Omar Emara (OmarSquircleArt) added a comment to D6672: Shading: Add color output option to White Noise node..

Notice that OSL and GLSL optimize this on their own. If the color output is not used, it will not be computed. This is not the case for SVM, so we have to add the optimization manually.

Jan 25 2020, 6:06 PM

Jan 18 2020

Omar Emara (OmarSquircleArt) committed rB6dc979e2f96c: Cycles: Suppress OSL normalize function warnings. (authored by Omar Emara (OmarSquircleArt)).
Cycles: Suppress OSL normalize function warnings.
Jan 18 2020, 8:18 PM
Omar Emara (OmarSquircleArt) closed D6621: Cycles: Suppress OSL normalize function warnings..
Jan 18 2020, 8:18 PM
Omar Emara (OmarSquircleArt) created D6621: Cycles: Suppress OSL normalize function warnings..
Jan 18 2020, 5:58 PM

Jan 7 2020

Mike Erwin (merwin) awarded D5616: GPU: Split gpu_shader_material into multiple files. a Doubloon token.
Jan 7 2020, 10:41 AM
Mike Erwin (merwin) awarded rB8cd0da88e55a: GPU: Split gpu_shader_material into multiple files. a Doubloon token.
Jan 7 2020, 10:28 AM

Jan 5 2020

Mike Erwin (merwin) awarded rBe5618725fd1e: Shading: Refactor Math node and use dynamic inputs. a Doubloon token.
Jan 5 2020, 10:41 AM

Dec 29 2019

Omar Emara (OmarSquircleArt) added a comment to T72284: Random Per Island working incorrectly with sharp edges and volumes.

I am not sure, I haven't seen anything in the code that indicates that.

Dec 29 2019, 6:27 PM · Render & Cycles, Cycles, BF Blender

Dec 25 2019

Omar Emara (OmarSquircleArt) added a comment to D6304: Shading: Truchet Texture Node.

I am not sure about smoothstep(0.02f, 0.00f, -(d - width));. I think we should either allow the user to control the width of the gradient, or make it a binary value. What do you think?

Dec 25 2019, 11:03 AM
Omar Emara (OmarSquircleArt) added inline comments to D6304: Shading: Truchet Texture Node.
Dec 25 2019, 8:57 AM

Dec 23 2019

Omar Emara (OmarSquircleArt) requested changes to D6304: Shading: Truchet Texture Node.

I would try to make GLSL, SVM, and OSL as similar to each other as possibly, to make future refactoring easier.

Dec 23 2019, 8:52 PM

Dec 18 2019

Omar Emara (OmarSquircleArt) changed the status of T71141: 2.81 Voronoi node stuck between two states with specific settings in EEVEE from Unknown Status to Resolved.

A warning was added to the manual in rBM6006.

Dec 18 2019, 3:30 PM · BF Blender
Omar Emara (OmarSquircleArt) committed rBM6006: Cycles: Warn about artifacts in Voronoi Texture..
Cycles: Warn about artifacts in Voronoi Texture.
Dec 18 2019, 3:28 PM
Omar Emara (OmarSquircleArt) committed rBM6005: Cycles: Update White Noise Texture node..
Cycles: Update White Noise Texture node.
Dec 18 2019, 3:02 PM
Omar Emara (OmarSquircleArt) changed the status of T72537: Documentation: Random Per Island not working on Eevee/Material Preview not mentioned from Unknown Status to Resolved.

Documentation updated in rBM6004: Cycles: Add Random Per Island input..

Dec 18 2019, 2:57 PM · Documentation, EEVEE & Viewport, BF Blender
Omar Emara (OmarSquircleArt) committed rBM6004: Cycles: Add Random Per Island input..
Cycles: Add Random Per Island input.
Dec 18 2019, 2:54 PM
Omar Emara (OmarSquircleArt) added a comment to T72537: Documentation: Random Per Island not working on Eevee/Material Preview not mentioned.

Should I add the documentation now?

Dec 18 2019, 12:43 PM · Documentation, EEVEE & Viewport, BF Blender

Dec 6 2019

Omar Emara (OmarSquircleArt) committed rBAc4519cc9a85d: Pie Menus: Update sculpt icons. (authored by Omar Emara (OmarSquircleArt)).
Pie Menus: Update sculpt icons.
Dec 6 2019, 4:42 PM
Omar Emara (OmarSquircleArt) closed D6373: Pie Menus: Update sculpt icons..
Dec 6 2019, 4:42 PM
Omar Emara (OmarSquircleArt) created D6373: Pie Menus: Update sculpt icons..
Dec 6 2019, 1:27 PM

Dec 5 2019

Omar Emara (OmarSquircleArt) added a comment to T71860: Mapping Node Issue. Translation and reading of mapping node data is broken between 2.80 - 2.81.

@Ivaylo Gogov (ivaydesign) The fix should be in 2.82. Can you produce a simple blend file that fails the versioning?

Dec 5 2019, 12:00 PM · Nodes, BF Blender

Dec 1 2019

Omar Emara (OmarSquircleArt) added a comment to D6336: Mandelbrot texture node.

Your patch seems to be missing most of the code, new files are not included.

Dec 1 2019, 7:08 AM

Nov 29 2019

Omar Emara (OmarSquircleArt) requested changes to D6304: Shading: Truchet Texture Node.

Texture mapping is still missing. Looking at other textures' OSL files, you will notice two extra inputs:

Nov 29 2019, 9:55 AM

Nov 28 2019

Omar Emara (OmarSquircleArt) requested changes to D6304: Shading: Truchet Texture Node.

General review:

Nov 28 2019, 10:41 AM

Nov 27 2019

André Savik (klutz) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
Nov 27 2019, 8:31 PM
Steffen Dünner (SteffenD) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
Nov 27 2019, 3:43 PM
Janne Aliu (Jaydead) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
Nov 27 2019, 3:01 PM
Dealga McArdle (zeffii) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
Nov 27 2019, 2:43 PM
Vitalii Vlasov (Fracture128) awarded D6154: Cycles: Add Random Per Island attribute. a Like token.
Nov 27 2019, 2:39 PM
Bruno Ortolland (Noss) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
Nov 27 2019, 1:20 PM
Marco (nacioss) awarded D6154: Cycles: Add Random Per Island attribute. a Love token.
Nov 27 2019, 1:07 PM