Page MenuHome

Omar Emara (OmarSquircleArt)
User

Projects

User Details

User Since
Jan 28 2017, 8:06 AM (142 w, 13 h)

Recent Activity

Yesterday

Omar Emara (OmarSquircleArt) added a comment to rBe5618725fd1e: Shading: Refactor Math node and use dynamic inputs..

I don't see how they won't be in sync in the future. But even if it was the case, how would you do the check? Your method is not valid because (1) you are doing a possible out-of-bound access and (2) what ever you are reading can be a non zero.

Fri, Oct 18, 8:18 PM
Omar Emara (OmarSquircleArt) added a comment to rBe5618725fd1e: Shading: Refactor Math node and use dynamic inputs..

@Charlie Jolly (charlie) I don't think this is a viable fix. You probably just want to check if custom1 is between zero and the length of the names array, and if not, return zero. Not sure if this is the behavior that should be implemented though.

Fri, Oct 18, 6:28 PM

Mon, Oct 14

Joseph Brandenburg (TheAngerSpecialist) awarded rB2ea82e86ca60: Shading: Add Vertex Color node. a Mountain of Wealth token.
Mon, Oct 14, 6:49 AM
Joseph Brandenburg (TheAngerSpecialist) awarded rB7f4a2fc437cf: Shading: Add more operators to Vector Math node. a Mountain of Wealth token.
Mon, Oct 14, 6:49 AM

Fri, Oct 4

Omar Emara (OmarSquircleArt) committed rB45745f7862be: Fix: Gain socket is not available in ridged multifractal. (authored by Omar Emara (OmarSquircleArt)).
Fix: Gain socket is not available in ridged multifractal.
Fri, Oct 4, 4:09 PM
Omar Emara (OmarSquircleArt) closed D5989: Fix: Gain socket is not available in ridged multifractal..
Fri, Oct 4, 4:09 PM
Omar Emara (OmarSquircleArt) created D5989: Fix: Gain socket is not available in ridged multifractal..
Fri, Oct 4, 3:49 PM
Omar Emara (OmarSquircleArt) committed rB8afa93d82d7d: Fix: Clamping in Map Range node works incorrectly. (authored by Omar Emara (OmarSquircleArt)).
Fix: Clamping in Map Range node works incorrectly.
Fri, Oct 4, 3:20 PM
Omar Emara (OmarSquircleArt) closed D5987: Fix: Clamping in Map Range node works incorrectly..
Fri, Oct 4, 3:20 PM
Omar Emara (OmarSquircleArt) created D5987: Fix: Clamping in Map Range node works incorrectly..
Fri, Oct 4, 2:52 PM

Thu, Oct 3

Kenn Nyström (Frozen_Death_Knight) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Party Time token.
Thu, Oct 3, 10:47 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) committed rBM5838: Update Voronoi Texture node..
Update Voronoi Texture node.
Thu, Oct 3, 8:10 PM
Zino Guerr (Zino) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Yellow Medal token.
Thu, Oct 3, 6:00 PM · BF Blender (2.81), Nodes, Rendering, Cycles

Wed, Oct 2

Omar Emara (OmarSquircleArt) committed rBM5832: Add Vertex Color node..
Add Vertex Color node.
Wed, Oct 2, 3:10 PM
Omar Emara (OmarSquircleArt) committed rBM5831: Add Volume Info node..
Add Volume Info node.
Wed, Oct 2, 2:34 PM
Omar Emara (OmarSquircleArt) committed rBM5830: Update Object Info node..
Update Object Info node.
Wed, Oct 2, 1:42 PM
Omar Emara (OmarSquircleArt) committed rBM5829: Update Musgrave Texture node..
Update Musgrave Texture node.
Wed, Oct 2, 1:10 PM

Mon, Sep 30

Omar Emara (OmarSquircleArt) committed rBM5826: Update Noise node..
Update Noise node.
Mon, Sep 30, 5:57 PM
Omar Emara (OmarSquircleArt) committed rBM5825: Add White Noise node..
Add White Noise node.
Mon, Sep 30, 3:12 PM

Sat, Sep 28

Omar Emara (OmarSquircleArt) committed rBM5823: Updated Mapping node..
Updated Mapping node.
Sat, Sep 28, 7:13 PM

Tue, Sep 24

Omar Emara (OmarSquircleArt) committed rBM5818: Update Vector Math node..
Update Vector Math node.
Tue, Sep 24, 9:39 PM

Mon, Sep 23

Omar Emara (OmarSquircleArt) added a comment to D5767: Shading: Add Vertex Color node..

@Metin Seven (MetinSeven) Yes, this is provided by the Node Wrangler add-on. I will create a patch as soon as I have the time.

Mon, Sep 23, 12:25 PM

Fri, Sep 20

Omar Emara (OmarSquircleArt) added a comment to T69776: Eevee noise texture bug when there are 4 or more other noise textures being used in the bump node.

It appears ffd5e1e6acd296a187e7af016f9d7f8a9f209f87 is the commit that introduced this behavior. Perhaps due to the instruction limit described in the commit message.

Fri, Sep 20, 7:00 PM · EEVEE & Viewport, BF Blender
Omar Emara (OmarSquircleArt) added a comment to T69776: Eevee noise texture bug when there are 4 or more other noise textures being used in the bump node.

It is not immediately clear to me why this is happening. I will try to debug that now.

Fri, Sep 20, 5:20 PM · EEVEE & Viewport, BF Blender

Sep 18 2019

Omar Emara (OmarSquircleArt) updated Omar Emara (OmarSquircleArt).
Sep 18 2019, 8:49 PM
Omar Emara (OmarSquircleArt) added inline comments to D5827: Shading: Interpolation node.
Sep 18 2019, 1:43 PM

Sep 17 2019

Omar Emara (OmarSquircleArt) committed rB9609840b5ea1: Fix T69989: Correct Mapping node min/max versioning. (authored by Omar Emara (OmarSquircleArt)).
Fix T69989: Correct Mapping node min/max versioning.
Sep 17 2019, 9:53 PM
Omar Emara (OmarSquircleArt) closed T69989: New Mapping Node -> Min and Max Vector Math Nodes don't work as they should compared to previous state as Resolved by committing rB9609840b5ea1: Fix T69989: Correct Mapping node min/max versioning..
Sep 17 2019, 9:53 PM · BF Blender
Omar Emara (OmarSquircleArt) closed D5828: Fix T69989: Correct Mapping node min/max versioning..
Sep 17 2019, 9:53 PM
Omar Emara (OmarSquircleArt) created D5828: Fix T69989: Correct Mapping node min/max versioning..
Sep 17 2019, 8:48 PM
Omar Emara (OmarSquircleArt) added a comment to T69989: New Mapping Node -> Min and Max Vector Math Nodes don't work as they should compared to previous state.

Looks like you are correct, I will create a patch to fix this.

Sep 17 2019, 7:55 PM · BF Blender
Omar Emara (OmarSquircleArt) added a comment to D5827: Shading: Interpolation node.

Looks good, here is my initial review.

Sep 17 2019, 7:34 PM
Omar Emara (OmarSquircleArt) committed rBM5814: Add documentation for Clamp node..
Add documentation for Clamp node.
Sep 17 2019, 6:27 PM
Omar Emara (OmarSquircleArt) committed rBM5813: Update Map Range node example..
Update Map Range node example.
Sep 17 2019, 3:08 PM
Omar Emara (OmarSquircleArt) added a comment to rBM5812: Added documentation for Map Range node..

Thanks for working on the docs! For screenshots like these, please hide or crop out the headers, timeline and status bar. Then the focus is fully on the nodes and the resulting render.

Sep 17 2019, 2:37 PM
Brecht Van Lommel (brecht) awarded rBM5812: Added documentation for Map Range node. a Like token.
Sep 17 2019, 11:43 AM

Sep 16 2019

Omar Emara (OmarSquircleArt) committed rBM5812: Added documentation for Map Range node..
Added documentation for Map Range node.
Sep 16 2019, 4:20 PM

Sep 13 2019

Martin Capitanio (capnm) awarded D5767: Shading: Add Vertex Color node. a Like token.
Sep 13 2019, 4:25 PM
Metin Seven (MetinSeven) awarded rB2ea82e86ca60: Shading: Add Vertex Color node. a Love token.
Sep 13 2019, 10:54 AM
noki paike (amonpaike) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Like token.
Sep 13 2019, 7:04 AM · BF Blender (2.81), Nodes, Rendering, Cycles
Craig Dolphin (craigdolphin) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Like token.
Sep 13 2019, 6:15 AM · BF Blender (2.81), Nodes, Rendering, Cycles
Way awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Party Time token.
Sep 13 2019, 4:04 AM · BF Blender (2.81), Nodes, Rendering, Cycles
Duarte Farrajota Ramos (duarteframos) awarded D5743: Shading: Add More Features To The Voronoi Node. a Love token.
Sep 13 2019, 1:13 AM

Sep 12 2019

heini (ogonek) awarded rB613b37bc2c81: Shading: Add More Features To The Voronoi Node. a Love token.
Sep 12 2019, 11:44 PM
Bartosz Moniewski (monio) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Love token.
Sep 12 2019, 11:24 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Jacob Merrill (blueprintrandom) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Party Time token.
Sep 12 2019, 10:50 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Johannes Kollmer (Lumpengnom) awarded rB613b37bc2c81: Shading: Add More Features To The Voronoi Node. a Love token.
Sep 12 2019, 9:44 PM
Craig Jones (craig_jones) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Mountain of Wealth token.
Sep 12 2019, 9:43 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Hans Goudey (HooglyBoogly) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Party Time token.
Sep 12 2019, 9:27 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Eitan (EitanSomething) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Party Time token.
Sep 12 2019, 7:45 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Brecht Van Lommel (brecht) awarded T68823: GSoC 2019 - Cycles/EEVEE Improvements a Party Time token.
Sep 12 2019, 7:37 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Way awarded rB2ea82e86ca60: Shading: Add Vertex Color node. a Love token.
Sep 12 2019, 6:15 PM
Way awarded rB613b37bc2c81: Shading: Add More Features To The Voronoi Node. a Love token.
Sep 12 2019, 6:14 PM
Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 12 2019, 5:57 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) committed rB2ea82e86ca60: Shading: Add Vertex Color node. (authored by Omar Emara (OmarSquircleArt)).
Shading: Add Vertex Color node.
Sep 12 2019, 5:42 PM
Omar Emara (OmarSquircleArt) closed D5767: Shading: Add Vertex Color node..
Sep 12 2019, 5:42 PM
Omar Emara (OmarSquircleArt) created T69808: Python-defined nodes implementing a draw_label function causes a segmentation fault when drawn..
Sep 12 2019, 5:20 PM · BF Blender
Omar Emara (OmarSquircleArt) added a comment to D5767: Shading: Add Vertex Color node..

A file to test the Vertex Color node. Two of the vertices have an alpha of zero and the other two have an alpha of one. So the output alpha should be a gradient.

Sep 12 2019, 1:46 PM
Omar Emara (OmarSquircleArt) added a comment to D5767: Shading: Add Vertex Color node..
  • Merge master and make sure Cycles match with EEVEE.
Sep 12 2019, 1:44 PM
Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 12 2019, 1:14 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) committed rB613b37bc2c81: Shading: Add More Features To The Voronoi Node. (authored by Omar Emara (OmarSquircleArt)).
Shading: Add More Features To The Voronoi Node.
Sep 12 2019, 1:12 PM
Omar Emara (OmarSquircleArt) closed D5743: Shading: Add More Features To The Voronoi Node..
Sep 12 2019, 1:12 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..
  • Define the floor and mix functions in CUDA.
Sep 12 2019, 12:03 PM

Sep 11 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 11 2019, 9:49 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) created D5767: Shading: Add Vertex Color node..
Sep 11 2019, 9:46 PM
Omar Emara (OmarSquircleArt) committed rB003802db83b5: Cycles: Ignore links with unavailable sockets. (authored by Omar Emara (OmarSquircleArt)).
Cycles: Ignore links with unavailable sockets.
Sep 11 2019, 6:32 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..

@Brecht Van Lommel (brecht) That's because Cycles doesn't take into account unavailable sockets while generating the shader graph from the BL nodetree. In my branch, I fixed that in this commit 228edc58. But this is not really related to Voronoi.

Sep 11 2019, 6:11 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..

The tests looks like this now.

Sep 11 2019, 1:02 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..
  • Add versioning code for squared euclidean distance.
Sep 11 2019, 12:58 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..

@Brecht Van Lommel (brecht) It appears the distance output should be the squared distance, not the actual distance, will add versioning code for that.

Sep 11 2019, 12:32 PM

Sep 10 2019

Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..

A file to test versioning code:

Sep 10 2019, 11:09 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..
  • Add versioning code for coloring.
Sep 10 2019, 11:09 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..
  • Clean up. Remove unused functions.
Sep 10 2019, 9:31 PM
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..
  • Add versioning code. Versioning for coloring is still missing.
  • Follow coding style.
Sep 10 2019, 9:18 PM
Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 10 2019, 6:15 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) added a comment to D5743: Shading: Add More Features To The Voronoi Node..

@Brecht Van Lommel (brecht) Pretty sure this is due to missing versioning, probably due to the fact that the dimensions property is set to zero, so the appropriate function is not called and what ever in memory is displayed.

Sep 10 2019, 5:27 PM
Omar Emara (OmarSquircleArt) created D5743: Shading: Add More Features To The Voronoi Node..
Sep 10 2019, 4:21 PM

Sep 9 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 9 2019, 9:15 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) committed rBf2176b3ff3c5: Shading: Extend Musgrave node to other dimensions. (authored by Omar Emara (OmarSquircleArt)).
Shading: Extend Musgrave node to other dimensions.
Sep 9 2019, 9:10 PM
Omar Emara (OmarSquircleArt) closed D5566: Shading: Extend Musgrave node to other dimensions..
Sep 9 2019, 9:10 PM
Omar Emara (OmarSquircleArt) added a comment to D5399: Cycles: Add bump-map shadow terminator softening term.

This breaks OpenCL with the following error:

Sep 9 2019, 8:28 PM
Omar Emara (OmarSquircleArt) added a comment to D5566: Shading: Extend Musgrave node to other dimensions..
Sep 9 2019, 8:03 PM
Omar Emara (OmarSquircleArt) added a comment to D5566: Shading: Extend Musgrave node to other dimensions..
  • Update patch and merge master.
Sep 9 2019, 7:54 PM
Omar Emara (OmarSquircleArt) created D5733: Fix T69664: Update add-ons for Mapping node changes..
Sep 9 2019, 5:19 PM
Omar Emara (OmarSquircleArt) created D5732: Fix T69664: Update add-ons for Mapping node changes..
Sep 9 2019, 5:15 PM
Omar Emara (OmarSquircleArt) added a comment to T69663: 2.81 Cant open/append/link a blend file but 2.8 can.

@Philipp Oeser (lichtwerk) I see. Do we maintain forward compatibility in Blender?

Sep 9 2019, 12:02 PM · Cycles, Data, Assets & I/O, BF Blender
Omar Emara (OmarSquircleArt) added a comment to D5723: Fix T69663: 2.81 Cant open/append/link a blend file but 2.8 can.

hmm, ok. I still think the bug is somewhere else, I don't see how node->storage could be null in this case.

Sep 9 2019, 11:56 AM
Omar Emara (OmarSquircleArt) updated subscribers of D5723: Fix T69663: 2.81 Cant open/append/link a blend file but 2.8 can.

According to @Marcus Papathoma (machieb) , the file was saved in rB4c4a8bf588c5, the new mapping node was already in this build. So the check for the subversion if (!MAIN_VERSION_ATLEAST(bmain, 281, 8)) { is probably the root of the issue. I will debug the build info in the attached file and get back to you.

Sep 9 2019, 11:32 AM
Omar Emara (OmarSquircleArt) added a comment to T69663: 2.81 Cant open/append/link a blend file but 2.8 can.

@Marcus Papathoma (machieb) Ok, thanks!

Sep 9 2019, 11:28 AM · Cycles, Data, Assets & I/O, BF Blender
Omar Emara (OmarSquircleArt) added a comment to D5723: Fix T69663: 2.81 Cant open/append/link a blend file but 2.8 can.

Why would the TexMapping struct be freed? Previously, the mapping info was stored in this struct, so after library linking, this should never be null.

Sep 9 2019, 11:22 AM
Omar Emara (OmarSquircleArt) added a comment to T69663: 2.81 Cant open/append/link a blend file but 2.8 can.

@Marcus Papathoma (machieb) You saved the file with last friday's build and Blender crashes when you open it with today's build?

Sep 9 2019, 11:05 AM · Cycles, Data, Assets & I/O, BF Blender

Sep 6 2019

Omar Emara (OmarSquircleArt) committed rB61cc604da705: Fix: Rename the dimensions property in Noise nodes. (authored by Omar Emara (OmarSquircleArt)).
Fix: Rename the dimensions property in Noise nodes.
Sep 6 2019, 4:06 PM
Omar Emara (OmarSquircleArt) closed D5705: Fix: Rename the dimensions property in Noise nodes..
Sep 6 2019, 4:05 PM
Omar Emara (OmarSquircleArt) created D5705: Fix: Rename the dimensions property in Noise nodes..
Sep 6 2019, 3:22 PM

Sep 5 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 5 2019, 9:02 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) added a comment to T68823: GSoC 2019 - Cycles/EEVEE Improvements.

Hi @Dalai Felinto (dfelinto) , I can create patches for both task in the next two days.

Sep 5 2019, 9:02 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) added a comment to rBbaaa89a0bc54: Shading: Rewrite Mapping node with dynamic inputs..

@Philipp Oeser (lichtwerk) Checking on what?

Sep 5 2019, 8:23 PM
Omar Emara (OmarSquircleArt) added a comment to rBbaaa89a0bc54: Shading: Rewrite Mapping node with dynamic inputs..

@Philipp Oeser (lichtwerk) As per our discussion, the min/max option will not be added back to the mapping node. The addons will have to be updated, either by relying on the internal mapping of the textures nodes or by adding new nodes if necessary.

Sep 5 2019, 4:29 PM
Omar Emara (OmarSquircleArt) added a comment to rBbaaa89a0bc54: Shading: Rewrite Mapping node with dynamic inputs..

@Philipp Oeser (lichtwerk) Ok, thanks! I will try to wrap my head around it now.

Sep 5 2019, 2:45 PM
Omar Emara (OmarSquircleArt) added a comment to rBbaaa89a0bc54: Shading: Rewrite Mapping node with dynamic inputs..

@Bastien Montagne (mont29) Yes, sorry, I didn't realize there were such a thing. Can you tell me what the purpose of this wrapper is?

Sep 5 2019, 2:31 PM