Page MenuHome

Omar Ahmad (OmarSquircleArt)
User

Projects

User Details

User Since
Jan 28 2017, 8:06 AM (133 w, 5 d)

Recent Activity

Today

Omar Ahmad (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Thu, Aug 22, 2:28 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) committed rB08ab3cbcce1e: Shading: Add object color to Object Info node. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add object color to Object Info node.
Thu, Aug 22, 2:26 PM
Omar Ahmad (OmarSquircleArt) closed D5554: Shading: Add object color to Object Info node..
Thu, Aug 22, 2:26 PM
Omar Ahmad (OmarSquircleArt) created D5554: Shading: Add object color to Object Info node..
Thu, Aug 22, 2:06 PM
Omar Ahmad (OmarSquircleArt) committed rBc6f8ea7b45af: Fix T69044: OpenCL fail due to bad fract function. (authored by Omar Ahmad (OmarSquircleArt)).
Fix T69044: OpenCL fail due to bad fract function.
Thu, Aug 22, 1:51 PM
Omar Ahmad (OmarSquircleArt) closed T69044: Split kernel error: failed to load kernel_path_init as Resolved by committing rBc6f8ea7b45af: Fix T69044: OpenCL fail due to bad fract function..
Thu, Aug 22, 1:51 PM · Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) closed D5553: Fix T69044: OpenCL fail due to bad fract function..
Thu, Aug 22, 1:50 PM
Omar Ahmad (OmarSquircleArt) created D5553: Fix T69044: OpenCL fail due to bad fract function..
Thu, Aug 22, 1:36 PM
Charlie Jolly (charlie) awarded D5551: Shading: Add Volume Info node. a Love token.
Thu, Aug 22, 12:02 AM
Charlie Jolly (charlie) awarded D5550: Shading: Add White Noise node. a Love token.
Thu, Aug 22, 12:02 AM

Yesterday

Omar Ahmad (OmarSquircleArt) added a comment to D5541: Shading: Rewrite Mapping node with dynamic inputs..

As @Charlie Jolly (charlie) noted, the mapping node rotation doesn't match the texture mapping rotation for some reason. Our Euler to matrix conversion follow the same order XYZ, and the functions are implemented based on the matrix from the wikipedia page on the topic, that is:


Not sure where the problem is, are the BLI eul_to_mat functions implemented wrongfully?

Wed, Aug 21, 11:39 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5541: Shading: Rewrite Mapping node with dynamic inputs..

A file to test backward compatibility:

Wed, Aug 21, 11:05 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5541: Shading: Rewrite Mapping node with dynamic inputs..
  • Add versioning code to mapping node.
Wed, Aug 21, 11:03 PM
Omar Ahmad (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Wed, Aug 21, 8:33 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) committed rBe83f09220112: Shading: Add Volume Info node. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add Volume Info node.
Wed, Aug 21, 8:31 PM
Omar Ahmad (OmarSquircleArt) closed D5551: Shading: Add Volume Info node..
Wed, Aug 21, 8:30 PM
Omar Ahmad (OmarSquircleArt) committed rB133dfdd704b6: Shading: Add White Noise node. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add White Noise node.
Wed, Aug 21, 8:13 PM
Omar Ahmad (OmarSquircleArt) closed D5550: Shading: Add White Noise node..
Wed, Aug 21, 8:13 PM
Omar Ahmad (OmarSquircleArt) committed rB7f4a2fc437cf: Shading: Add more operators to Vector Math node. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add more operators to Vector Math node.
Wed, Aug 21, 7:48 PM
Omar Ahmad (OmarSquircleArt) closed D5523: Shading: Add more operators to Vector Math node..
Wed, Aug 21, 7:48 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5550: Shading: Add White Noise node..
  • Use hash_uint2 instead of hash_uint in Cycles code.
Wed, Aug 21, 7:22 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..

@Brecht Van Lommel (brecht) Ok, I will create a patch for those. But I need a bit more details, in particular:

  • Shouldn't we normalize the input vectors in the Average operator if we want to compute the "Average Normal"? Or is it meant to be a weighted average of some sort?
  • The Cross Product wasn't removed, are you talking about the fact that it is no longer normalized? I just thought that it makes sense not to normalize the output, the cross product operator should just do a cross product, nothing more.
  • The problem is that the output value is used by more than one operator. I wounder if we can dynamically rename sockets somehow. Would that mess something up?
Wed, Aug 21, 7:04 PM
Omar Ahmad (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Wed, Aug 21, 5:34 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) created D5551: Shading: Add Volume Info node..
Wed, Aug 21, 5:27 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5550: Shading: Add White Noise node..
  • Fix typo.
Wed, Aug 21, 4:42 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5550: Shading: Add White Noise node..
  • Add tool tips.
Wed, Aug 21, 3:04 PM
Omar Ahmad (OmarSquircleArt) added inline comments to D5550: Shading: Add White Noise node..
Wed, Aug 21, 2:46 PM
Omar Ahmad (OmarSquircleArt) added inline comments to D5550: Shading: Add White Noise node..
Wed, Aug 21, 2:13 PM
Omar Ahmad (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Wed, Aug 21, 1:57 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) created D5550: Shading: Add White Noise node..
Wed, Aug 21, 1:49 PM

Tue, Aug 20

Omar Ahmad (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Tue, Aug 20, 6:35 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) committed rBbe002bb57fbd: Cycles Tests: Fix Math tests when use_clamp is true. (authored by Omar Ahmad (OmarSquircleArt)).
Cycles Tests: Fix Math tests when use_clamp is true.
Tue, Aug 20, 5:20 PM
Omar Ahmad (OmarSquircleArt) closed D5540: Cycles Tests: Fix Math tests when use_clamp is true..
Tue, Aug 20, 5:20 PM
Omar Ahmad (OmarSquircleArt) added inline comments to D5541: Shading: Rewrite Mapping node with dynamic inputs..
Tue, Aug 20, 3:47 PM
Omar Ahmad (OmarSquircleArt) created D5541: Shading: Rewrite Mapping node with dynamic inputs..
Tue, Aug 20, 3:27 PM
Omar Ahmad (OmarSquircleArt) created D5540: Cycles Tests: Fix Math tests when use_clamp is true..
Tue, Aug 20, 3:04 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..

@Brecht Van Lommel (brecht) I will fix those regression tests in a separate patch as they are related to the Math node.

Tue, Aug 20, 2:16 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..
  • Clean Up: Follow code style.
Tue, Aug 20, 2:14 PM
Charlie Jolly (charlie) awarded D5523: Shading: Add more operators to Vector Math node. a Love token.
Tue, Aug 20, 10:34 AM

Mon, Aug 19

Omar Ahmad (OmarSquircleArt) added inline comments to D3789: Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets..
Mon, Aug 19, 6:01 PM · Nodes, Eevee, Cycles
Omar Ahmad (OmarSquircleArt) added inline comments to D5523: Shading: Add more operators to Vector Math node..
Mon, Aug 19, 3:46 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..
  • Refactor reflect function.
Mon, Aug 19, 3:45 PM
Omar Ahmad (OmarSquircleArt) added inline comments to D5523: Shading: Add more operators to Vector Math node..
Mon, Aug 19, 3:31 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..
  • Refactor the safe_divide_float3_float function.
Mon, Aug 19, 3:26 PM
Omar Ahmad (OmarSquircleArt) added inline comments to D5523: Shading: Add more operators to Vector Math node..
Mon, Aug 19, 3:01 PM
Omar Ahmad (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Mon, Aug 19, 2:34 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..

A file to test versioning code:

Mon, Aug 19, 1:57 PM
Omar Ahmad (OmarSquircleArt) created T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Mon, Aug 19, 1:35 PM · Nodes, Rendering, Cycles, BF Blender
Omar Ahmad (OmarSquircleArt) retitled D5123: Node Wrangler: Correct handling of disabled sockets. from Make sure output is enabled before connecting in node wrangler to Node Wrangler: Correct handling of disabled sockets..
Mon, Aug 19, 12:55 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5523: Shading: Add more operators to Vector Math node..
  • Add custom loop macros to the clang format dot file.
Mon, Aug 19, 11:22 AM

Sun, Aug 18

Omar Ahmad (OmarSquircleArt) created D5523: Shading: Add more operators to Vector Math node..
Sun, Aug 18, 10:25 PM
Omar Ahmad (OmarSquircleArt) committed rBe5618725fd1e: Shading: Refactor Math node and use dynamic inputs. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Refactor Math node and use dynamic inputs.
Sun, Aug 18, 11:18 AM
Omar Ahmad (OmarSquircleArt) closed D5481: Shading: Refactor Math node and use dynamic inputs..
Sun, Aug 18, 11:18 AM

Sat, Aug 17

Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..
  • Fix misnamed enum.
Sat, Aug 17, 1:20 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..
  • Bump subversion.
Sat, Aug 17, 1:02 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..
  • Revert more renamming.
Sat, Aug 17, 12:50 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..
  • Revert socket renamming and removal of the clamp option.
Sat, Aug 17, 12:06 PM

Fri, Aug 16

Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..

@Brecht Van Lommel (brecht) Just to make sure. Do you object to using A and B in the code base everywhere or are you talking about sockets only? In other words, can I use A and B internally in the Cycles /OSL/GLSL code?

Fri, Aug 16, 9:47 PM
Omar Ahmad (OmarSquircleArt) closed T68702: Normal Node is not working after SOCK_COMPAT flag was added for vector values as Resolved by committing rB25f1783673de: Fix T68702: Input socket in the Normal node isn't drawn properly..
Fri, Aug 16, 5:59 PM · User Interface, Nodes, BF Blender
Omar Ahmad (OmarSquircleArt) committed rB25f1783673de: Fix T68702: Input socket in the Normal node isn't drawn properly. (authored by Omar Ahmad (OmarSquircleArt)).
Fix T68702: Input socket in the Normal node isn't drawn properly.
Fri, Aug 16, 5:59 PM
Omar Ahmad (OmarSquircleArt) closed D5503: Fix T68702: Input socket in the Normal node isn't drawn properly..
Fri, Aug 16, 5:59 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..

@Brecht Van Lommel (brecht) Regarding the removal of the clamp option, let me explain my reasoning.

Fri, Aug 16, 5:23 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..

@Brecht Van Lommel (brecht) I also changed the socket names to A and B in the Vector Math node, and could do the same for the Mix RGB node. Sorry if I am wasting your time, but let me explain the reasoning behind this change:

  • The identifiers of the sockets will be unique by default. This has many advantages:
    • In C code, we can get sockets more readily by their unique identifiers using something like nodeFindSocket(node, SOCK_IN, "B"). If you look at the patch, you will see that this makes the code much more readable than before. Before we had to index the socket blindly in the listbase.
    • Socket names will be the same for Blender and Cycles. Before, Cycles used the names Value1 and Value2. Had we used A and B, the socket names would be consistent and the functions calls to get the sockets would be similar nodeFindSocket(node, SOCK_IN, "B") -> input("B").
    • The python path to a specific socket becomes more readable and easier to write. To me, inputs["B"] is better than inputs["Value_001"] or inputs[1].
    • You get the point, other areas of the code benefit from the distinction.
  • Tool tips become clearer.
  • Node labels can be more expressive, especially when the node is hidden. I plan to implement a better label function in a separate patch.
  • Animation Nodes uses this same naming convention and has a better label function. So this convention was tried by a lot of users already.
Fri, Aug 16, 4:56 PM
Omar Ahmad (OmarSquircleArt) created D5503: Fix T68702: Input socket in the Normal node isn't drawn properly..
Fri, Aug 16, 4:10 PM

Wed, Aug 14

Omar Ahmad (OmarSquircleArt) added inline comments to D3789: Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets..
Wed, Aug 14, 8:46 PM · Nodes, Eevee, Cycles
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..

The following file includes a node tree with math nodes in different settings. This blend file was created before this patch so that it can be used to test backward compatibility.

Wed, Aug 14, 6:36 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..
  • Cycles: Fix tests.
  • Cycles Versioning: Update link iterator.
Wed, Aug 14, 6:33 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5481: Shading: Refactor Math node and use dynamic inputs..

@Brecht Van Lommel (brecht) Sorry, I didn't realize tests had to be enabled. Will fix that now.

Wed, Aug 14, 6:13 PM
Omar Ahmad (OmarSquircleArt) planned changes to D5481: Shading: Refactor Math node and use dynamic inputs..
Wed, Aug 14, 4:48 PM
Omar Ahmad (OmarSquircleArt) updated the summary of D5481: Shading: Refactor Math node and use dynamic inputs..
Wed, Aug 14, 4:35 PM
Omar Ahmad (OmarSquircleArt) created D5481: Shading: Refactor Math node and use dynamic inputs..
Wed, Aug 14, 4:33 PM
Omar Ahmad (OmarSquircleArt) added a comment to D3789: Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets..

This wouldn't work with the mapping node as this exposes rotation values as socket inputs.

Wed, Aug 14, 3:48 PM · Nodes, Eevee, Cycles
Omar Ahmad (OmarSquircleArt) added a comment to D3789: Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets..

I wounder if we can implement this using graph expansion. It would expand to two nodes I think, a Vector Math node and a Mapping node. I used expansion before and it was very nice and easy to use. Maybe you should give it a try. Check the following commit for reference rB7a7eadaf.

Wed, Aug 14, 3:30 PM · Nodes, Eevee, Cycles
Omar Ahmad (OmarSquircleArt) added a comment to D3789: Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets..

Other minor remarks.

Wed, Aug 14, 3:23 PM · Nodes, Eevee, Cycles
Omar Ahmad (OmarSquircleArt) added a comment to D3789: Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets..

I think you should take care of those remarks first.

Wed, Aug 14, 3:06 PM · Nodes, Eevee, Cycles
Omar Ahmad (OmarSquircleArt) committed rB7a7eadaf7f6b: Shading: Add a clamp option to the Map Range node. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add a clamp option to the Map Range node.
Wed, Aug 14, 10:54 AM
Omar Ahmad (OmarSquircleArt) closed D5477: Shading: Add a clamp option to the Map Range node..
Wed, Aug 14, 10:54 AM

Tue, Aug 13

Omar Ahmad (OmarSquircleArt) created D5477: Shading: Add a clamp option to the Map Range node..
Tue, Aug 13, 11:05 PM
Omar Ahmad (OmarSquircleArt) committed rB313b78928970: Shading: Add Clamp node to Cycles and EEVEE. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add Clamp node to Cycles and EEVEE.
Tue, Aug 13, 10:25 PM
Omar Ahmad (OmarSquircleArt) closed D5476: Shading: Add Clamp node to Cycles and EEVEE..
Tue, Aug 13, 10:24 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5476: Shading: Add Clamp node to Cycles and EEVEE..

@Brecht Van Lommel (brecht) It is an additional node. A Clamp node has always been in my proposal and was already created months ago in the GSoC branch.

Tue, Aug 13, 10:02 PM
Omar Ahmad (OmarSquircleArt) created D5476: Shading: Add Clamp node to Cycles and EEVEE..
Tue, Aug 13, 7:22 PM
Omar Ahmad (OmarSquircleArt) committed rB71641ab56d0f: Shading: Add Map Range node to Cycles and EEVEE. (authored by Omar Ahmad (OmarSquircleArt)).
Shading: Add Map Range node to Cycles and EEVEE.
Tue, Aug 13, 4:38 PM
Omar Ahmad (OmarSquircleArt) closed D5471: Shading: Add Map Range node to Cycles and EEVEE..
Tue, Aug 13, 4:38 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5471: Shading: Add Map Range node to Cycles and EEVEE..

I guess to clamp to To Min and To Max. I agree, it makes sense to have this option in this node (at least it makes much more sense than in the math node).

Tue, Aug 13, 4:29 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5471: Shading: Add Map Range node to Cycles and EEVEE..

This can go into master.
From a suggestion by @LazyDodo (LazyDodo), I think it would be important to add a Clamp option for this node.
It doesn't have to be done as part of this patch, but would be good to add after since it's probably what you want at least half the time.

Tue, Aug 13, 4:24 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5471: Shading: Add Map Range node to Cycles and EEVEE..
  • Use standard naming convention.
Tue, Aug 13, 3:40 PM
Omar Ahmad (OmarSquircleArt) created D5471: Shading: Add Map Range node to Cycles and EEVEE..
Tue, Aug 13, 2:45 PM

Sat, Aug 10

Omar Ahmad (OmarSquircleArt) committed rB26911ba1e26b: Nodes: Display vector values expanded, except when specified as compact. (authored by Omar Ahmad (OmarSquircleArt)).
Nodes: Display vector values expanded, except when specified as compact.
Sat, Aug 10, 5:57 PM
Omar Ahmad (OmarSquircleArt) closed D5458: Nodes: Display vector values expanded, except when specified as compact..
Sat, Aug 10, 5:57 PM
Omar Ahmad (OmarSquircleArt) retitled D5458: Nodes: Display vector values expanded, except when specified as compact. from GSoC: Change the default vector socket drawing method and introduce compact sockets. to Nodes: Display vector values expanded, except when specified as compact..
Sat, Aug 10, 5:12 PM
Omar Ahmad (OmarSquircleArt) updated the summary of D5458: Nodes: Display vector values expanded, except when specified as compact..
Sat, Aug 10, 4:33 PM
Omar Ahmad (OmarSquircleArt) created D5458: Nodes: Display vector values expanded, except when specified as compact..
Sat, Aug 10, 4:31 PM

Sun, Aug 4

Alex Strand (astrand130) awarded rBebd26aaee427: Remove Average vector meth operator. a Y So Serious token.
Sun, Aug 4, 10:25 PM

Sun, Jul 28

Omar Ahmad (OmarSquircleArt) created T67857: Segmentation fault on assigning None to the data of an empty object using python..
Sun, Jul 28, 10:26 PM · Python, BF Blender

Jul 19 2019

Alex Strand (astrand130) awarded rBf06620f82f84: Add Alpha output to the Vertex Color node. EEVEE only. a Love token.
Jul 19 2019, 1:55 AM

Jul 17 2019

Alex Strand (astrand130) awarded rBef1e09abaaef: Added Vertex Color node. a Love token.
Jul 17 2019, 2:38 AM

Jul 16 2019

ronan ducluzeau (zeauro) awarded rB6fef86569726: Add Volume Info node. a 100 token.
Jul 16 2019, 9:11 AM

Jun 22 2019

Omar Ahmad (OmarSquircleArt) added a comment to D5123: Node Wrangler: Correct handling of disabled sockets..
  • Add a utilitie function is_visible_socket
Jun 22 2019, 4:11 PM
Omar Ahmad (OmarSquircleArt) added a comment to D5123: Node Wrangler: Correct handling of disabled sockets..

@Jacques Lucke (JacquesLucke) Sorry, never mind, will do that.

Jun 22 2019, 4:03 PM