Page MenuHome

Sem Mulder (SemMulder)
User

Projects

User Details

User Since
Sep 17 2019, 10:23 AM (42 w, 10 h)

Recent Activity

Mar 31 2020

Sem Mulder (SemMulder) added inline comments to D7244: Update the views.
Mar 31 2020, 3:53 PM
Sem Mulder (SemMulder) committed rL2e7abe73a225: Fix tests due to changes in previous Differentials (authored by Sem Mulder (SemMulder)).
Fix tests due to changes in previous Differentials
Mar 31 2020, 3:49 PM
Sem Mulder (SemMulder) committed rL3390a8353d6e: Address raised concerns (authored by Sem Mulder (SemMulder)).
Address raised concerns
Mar 31 2020, 3:49 PM
Sem Mulder (SemMulder) committed rL53a3e2173d0d: Fix tests (authored by Sem Mulder (SemMulder)).
Fix tests
Mar 31 2020, 3:49 PM
Sem Mulder (SemMulder) committed rL147b4a4f8922: Render AddressForm as list (authored by Sem Mulder (SemMulder)).
Render AddressForm as list
Mar 31 2020, 3:49 PM
Sem Mulder (SemMulder) committed rL349ecec67ecc: Do not derive from a class in a Mixin (authored by Sem Mulder (SemMulder)).
Do not derive from a class in a Mixin
Mar 31 2020, 3:49 PM
Sem Mulder (SemMulder) committed rLf9c85681f766: Remove dead code (authored by Sem Mulder (SemMulder)).
Remove dead code
Mar 31 2020, 3:48 PM
Sem Mulder (SemMulder) closed D7245: Fix the tests and other minor cleanup.
Mar 31 2020, 3:48 PM
Sem Mulder (SemMulder) updated the diff for D7245: Fix the tests and other minor cleanup.
  • Fix tests due to changes in previous Differentials
Mar 31 2020, 3:48 PM
Sem Mulder (SemMulder) updated the diff for D7244: Update the views.
  • Naming and docs for the "finished payment" and the "new subscription when the user is anonymous" views
Mar 31 2020, 3:31 PM
Sem Mulder (SemMulder) committed rL9c7312f0d03c: Naming and docs for the "finished payment" and the "new subscription when the… (authored by Sem Mulder (SemMulder)).
Naming and docs for the "finished payment" and the "new subscription when the…
Mar 31 2020, 3:31 PM
Sem Mulder (SemMulder) added inline comments to D7244: Update the views.
Mar 31 2020, 3:16 PM
Sem Mulder (SemMulder) updated the diff for D7244: Update the views.
  • Handle falsy client_token
Mar 31 2020, 3:11 PM
Sem Mulder (SemMulder) committed rL27b15f87729f: Handle falsy client_token (authored by Sem Mulder (SemMulder)).
Handle falsy client_token
Mar 31 2020, 3:11 PM
Sem Mulder (SemMulder) updated the diff for D7244: Update the views.
  • Only use path from next parameter
Mar 31 2020, 3:01 PM
Sem Mulder (SemMulder) committed rL126b5df2a855: Only use path from `next` parameter (authored by Sem Mulder (SemMulder)).
Only use path from `next` parameter
Mar 31 2020, 3:01 PM
Sem Mulder (SemMulder) updated the diff for D7244: Update the views.
  • Rename can_change_customer to is_authorized_for_customer
Mar 31 2020, 2:46 PM
Sem Mulder (SemMulder) committed rLdf8e8a7ff33d: Rename `can_change_customer` to `is_authorized_for_customer` (authored by Sem Mulder (SemMulder)).
Rename `can_change_customer` to `is_authorized_for_customer`
Mar 31 2020, 2:46 PM
Sem Mulder (SemMulder) added inline comments to D7245: Fix the tests and other minor cleanup.
Mar 31 2020, 1:24 PM
Sem Mulder (SemMulder) updated the diff for D7245: Fix the tests and other minor cleanup.
  • Address raised concerns
Mar 31 2020, 1:24 PM
Sem Mulder (SemMulder) committed rLb589502cd0b4: Address raised concerns (authored by Sem Mulder (SemMulder)).
Address raised concerns
Mar 31 2020, 1:23 PM
Sem Mulder (SemMulder) committed rL0061f04987b1: Fix tests (authored by Sem Mulder (SemMulder)).
Fix tests
Mar 31 2020, 12:51 PM
Sem Mulder (SemMulder) committed rL4fce08a51f69: Render AddressForm as list (authored by Sem Mulder (SemMulder)).
Render AddressForm as list
Mar 31 2020, 12:50 PM
Sem Mulder (SemMulder) committed rL6dad025479a0: Do not derive from a class in a Mixin (authored by Sem Mulder (SemMulder)).
Do not derive from a class in a Mixin
Mar 31 2020, 12:49 PM
Sem Mulder (SemMulder) committed rLc02a11792956: Remove dead code (authored by Sem Mulder (SemMulder)).
Remove dead code
Mar 31 2020, 12:49 PM
Sem Mulder (SemMulder) added inline comments to D7244: Update the views.
Mar 31 2020, 12:31 PM
Sem Mulder (SemMulder) added a comment to D7244: Update the views.

I don't understand. I was thinking about something like this, I don't see how that's so tricky to do: ...

Mar 31 2020, 12:22 PM
Sem Mulder (SemMulder) added inline comments to D7244: Update the views.
Mar 31 2020, 11:42 AM
Sem Mulder (SemMulder) added inline comments to D7244: Update the views.
Mar 31 2020, 11:15 AM
Sem Mulder (SemMulder) updated the diff for D7244: Update the views.
  • Remove the IpAddress NewType
  • Address some of the raised concerns
Mar 31 2020, 11:14 AM
Sem Mulder (SemMulder) committed rL89fd67edb346: Address some of the raised concerns (authored by Sem Mulder (SemMulder)).
Address some of the raised concerns
Mar 31 2020, 11:13 AM
Sem Mulder (SemMulder) committed rL9e67df397207: Remove the IpAddress NewType (authored by Sem Mulder (SemMulder)).
Remove the IpAddress NewType
Mar 31 2020, 10:39 AM
Sem Mulder (SemMulder) committed rL3ce62af325c8: Remove the IpAddress NewType (authored by Sem Mulder (SemMulder)).
Remove the IpAddress NewType
Mar 31 2020, 10:37 AM
Sem Mulder (SemMulder) committed rLc6d2dcded7a9: Add checkout/existing_order view (authored by Sem Mulder (SemMulder)).
Add checkout/existing_order view
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rLffbd59d1af41: Add add_payment_method view (authored by Sem Mulder (SemMulder)).
Add add_payment_method view
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL687182cbeb77: Add new_subscription view (authored by Sem Mulder (SemMulder)).
Add new_subscription view
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rLa61121d8d4be: Implement checkout logic (authored by Sem Mulder (SemMulder)).
Implement checkout logic
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rLbdfc7fcc6f5c: Remove GatewayRadioSelect since we now define the structure in the… (authored by Sem Mulder (SemMulder)).
Remove GatewayRadioSelect since we now define the structure in the…
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rLfcceedb29a34: Rework the forms. (authored by Sem Mulder (SemMulder)).
Rework the forms.
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL38ee0830d393: Add functions for dealing with Braintree tokens (authored by Sem Mulder (SemMulder)).
Add functions for dealing with Braintree tokens
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL2fc2a74b9921: Add a function to check ReCAPTCHAs (authored by Sem Mulder (SemMulder)).
Add a function to check ReCAPTCHAs
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL858946597ccb: Preparation for splitting up views/checkout.py (authored by Sem Mulder (SemMulder)).
Preparation for splitting up views/checkout.py
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL9384416f84c5: Remove support for GET from preferred_currency (authored by Sem Mulder (SemMulder)).
Remove support for GET from preferred_currency
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rLb2f11a3cc940: Remove all settings views (authored by Sem Mulder (SemMulder)).
Remove all settings views
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL8790911d3b1f: Update urls.py with the new views (authored by Sem Mulder (SemMulder)).
Update urls.py with the new views
Mar 31 2020, 10:32 AM
Sem Mulder (SemMulder) committed rL1b51123fcdf8: Remove TODO about using Exceptions (authored by Sem Mulder (SemMulder)).
Remove TODO about using Exceptions
Mar 31 2020, 10:31 AM
Sem Mulder (SemMulder) updated the diff for D7243: Update the models for all the new stuff.
  • Make can_change_customer PEP257 compliant
  • Remove TODO about using Exceptions
Mar 31 2020, 10:30 AM
Sem Mulder (SemMulder) committed rLf6094f3349cf: Make can_change_customer PEP257 compliant (authored by Sem Mulder (SemMulder)).
Make can_change_customer PEP257 compliant
Mar 31 2020, 10:30 AM
Sem Mulder (SemMulder) updated the diff for D7243: Update the models for all the new stuff.
  • Revert "Add IpAddress newtype"
Mar 31 2020, 10:22 AM
Sem Mulder (SemMulder) added a reverting change for rLdc437d6bcb08: Add IpAddress newtype: rLf400c809e8ae: Revert "Add IpAddress newtype".
Mar 31 2020, 10:21 AM
Sem Mulder (SemMulder) committed rLf400c809e8ae: Revert "Add IpAddress newtype" (authored by Sem Mulder (SemMulder)).
Revert "Add IpAddress newtype"
Mar 31 2020, 10:21 AM
Sem Mulder (SemMulder) committed rLd49dddcdd08f: Return str from get_client_ip instead of Optional[IpAddress] (authored by Sem Mulder (SemMulder)).
Return str from get_client_ip instead of Optional[IpAddress]
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rL545b5f788aa0: Add an active() method to the SubscriptionManager (authored by Sem Mulder (SemMulder)).
Add an active() method to the SubscriptionManager
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rLd08ce2c0ce92: Minor cleanups (authored by Sem Mulder (SemMulder)).
Minor cleanups
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rLfadc6daea8c3: Use Customer instead of User (authored by Sem Mulder (SemMulder)).
Use Customer instead of User
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rL1dd34b25784b: Remove Customer.billing_address_as_text and add Address.as_text instead (authored by Sem Mulder (SemMulder)).
Remove Customer.billing_address_as_text and add Address.as_text instead
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rL17e66aba2dd6: Remove the pricing template tag and make it a method instead (authored by Sem Mulder (SemMulder)).
Remove the pricing template tag and make it a method instead
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rL2ab5f8710f87: Move TODO inside function for clarity (authored by Sem Mulder (SemMulder)).
Move TODO inside function for clarity
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rL9cc4fc94b127: Add assert_cast utility function for runtime type checking (authored by Sem Mulder (SemMulder)).
Add assert_cast utility function for runtime type checking
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rLdc437d6bcb08: Add IpAddress newtype (authored by Sem Mulder (SemMulder)).
Add IpAddress newtype
Mar 31 2020, 10:20 AM
Sem Mulder (SemMulder) committed rL8fb02a130205: Address some of the raised concerns (authored by Sem Mulder (SemMulder)).
Address some of the raised concerns
Mar 31 2020, 9:59 AM
Sem Mulder (SemMulder) closed D7242: Update the documentation.
Mar 31 2020, 9:59 AM
Sem Mulder (SemMulder) added inline comments to D7242: Update the documentation.
Mar 31 2020, 9:57 AM
Sem Mulder (SemMulder) updated the diff for D7242: Update the documentation.

Address some of the raised concerns

Mar 31 2020, 9:57 AM

Mar 27 2020

Sem Mulder (SemMulder) added a comment to D7242: Update the documentation.

and one really big one.

Mar 27 2020, 3:54 PM
Sem Mulder (SemMulder) updated the diff for D7245: Fix the tests and other minor cleanup.

Revert the lookup of the PaymentMethod on the Customer

Mar 27 2020, 3:31 PM
Sem Mulder (SemMulder) updated the diff for D7244: Update the views.

Revert the lookup of the PaymentMethod on the Customer

Mar 27 2020, 3:30 PM
Sem Mulder (SemMulder) committed rL44aff9ff0003: Fix tests (authored by Sem Mulder (SemMulder)).
Fix tests
Mar 27 2020, 3:29 PM
Sem Mulder (SemMulder) committed rL8d984f810b8f: Render AddressForm as list (authored by Sem Mulder (SemMulder)).
Render AddressForm as list
Mar 27 2020, 3:29 PM
Sem Mulder (SemMulder) committed rL863add7b2cac: Do not derive from a class in a Mixin (authored by Sem Mulder (SemMulder)).
Do not derive from a class in a Mixin
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL2360ff7cae2f: Remove dead code (authored by Sem Mulder (SemMulder)).
Remove dead code
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL1ed039f8134f: Add checkout/existing_order view (authored by Sem Mulder (SemMulder)).
Add checkout/existing_order view
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL38535fd69bd7: Add new_subscription view (authored by Sem Mulder (SemMulder)).
Add new_subscription view
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rLf0a71e160fc6: Add add_payment_method view (authored by Sem Mulder (SemMulder)).
Add add_payment_method view
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL45e5a80ba9ac: Implement checkout logic (authored by Sem Mulder (SemMulder)).
Implement checkout logic
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL6b851f46778d: Remove GatewayRadioSelect since we now define the structure in the… (authored by Sem Mulder (SemMulder)).
Remove GatewayRadioSelect since we now define the structure in the…
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL3594a1e9c07c: Rework the forms. (authored by Sem Mulder (SemMulder)).
Rework the forms.
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL329283d9123c: Add a function to check ReCAPTCHAs (authored by Sem Mulder (SemMulder)).
Add a function to check ReCAPTCHAs
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL3f3f5b39fd60: Add functions for dealing with Braintree tokens (authored by Sem Mulder (SemMulder)).
Add functions for dealing with Braintree tokens
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL13f27d34a9e6: Preparation for splitting up views/checkout.py (authored by Sem Mulder (SemMulder)).
Preparation for splitting up views/checkout.py
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) committed rL092f5d861433: Remove support for GET from preferred_currency (authored by Sem Mulder (SemMulder)).
Remove support for GET from preferred_currency
Mar 27 2020, 3:28 PM
Sem Mulder (SemMulder) updated the diff for D7243: Update the models for all the new stuff.

Revert the lookup of the PaymentMethod on the Customer

Mar 27 2020, 3:25 PM
Sem Mulder (SemMulder) updated the diff for D7242: Update the documentation.

Revert the lookup of the PaymentMethod on the Customer

Mar 27 2020, 3:24 PM
Sem Mulder (SemMulder) updated the diff for D7240: Add basic project files.

Revert the lookup of the PaymentMethod on the Customer

Mar 27 2020, 3:21 PM
Sem Mulder (SemMulder) committed rL3c2ebaf935cb: Fix tests (authored by Sem Mulder (SemMulder)).
Fix tests
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rLf5991eeccea1: Do not derive from a class in a Mixin (authored by Sem Mulder (SemMulder)).
Do not derive from a class in a Mixin
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rLb516b94ce406: Render AddressForm as list (authored by Sem Mulder (SemMulder)).
Render AddressForm as list
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rLfe8053b33ab7: Remove dead code (authored by Sem Mulder (SemMulder)).
Remove dead code
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rL4603a74443b6: Add checkout/existing_order view (authored by Sem Mulder (SemMulder)).
Add checkout/existing_order view
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rLd7d6be71f5fa: Add add_payment_method view (authored by Sem Mulder (SemMulder)).
Add add_payment_method view
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rL4a2825ad56ad: Add new_subscription view (authored by Sem Mulder (SemMulder)).
Add new_subscription view
Mar 27 2020, 3:16 PM
Sem Mulder (SemMulder) committed rLf09288ce3c86: Implement checkout logic (authored by Sem Mulder (SemMulder)).
Implement checkout logic
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rL8c8978c841b7: Remove GatewayRadioSelect since we now define the structure in the… (authored by Sem Mulder (SemMulder)).
Remove GatewayRadioSelect since we now define the structure in the…
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rLf3fe8cef97ed: Rework the forms. (authored by Sem Mulder (SemMulder)).
Rework the forms.
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rLed0e53d95277: Add functions for dealing with Braintree tokens (authored by Sem Mulder (SemMulder)).
Add functions for dealing with Braintree tokens
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rL0768c837571c: Preparation for splitting up views/checkout.py (authored by Sem Mulder (SemMulder)).
Preparation for splitting up views/checkout.py
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rL5a62db2958ca: Add a function to check ReCAPTCHAs (authored by Sem Mulder (SemMulder)).
Add a function to check ReCAPTCHAs
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rLc01a9845afd5: Remove support for POST from preferred_currency (authored by Sem Mulder (SemMulder)).
Remove support for POST from preferred_currency
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rLe4714314fb29: Update urls.py with the new views (authored by Sem Mulder (SemMulder)).
Update urls.py with the new views
Mar 27 2020, 3:15 PM
Sem Mulder (SemMulder) committed rL37c20b7faa55: Remove all settings views (authored by Sem Mulder (SemMulder)).
Remove all settings views
Mar 27 2020, 3:15 PM