Page MenuHome

Alexander Gavrilov (angavrilov)
User

Projects

User Details

User Since
Aug 20 2015, 12:17 PM (192 w, 20 h)

Recent Activity

Yesterday

Alexander Gavrilov (angavrilov) added a comment to D4739: Fix T61296: Crash with animated b-bone segments.

To me it's more like on-demand initialization of "interesting" things once they are being queried.

Thu, Apr 25, 6:07 PM
Alexander Gavrilov (angavrilov) added a comment to D4739: Fix T61296: Crash with animated b-bone segments.

Why wouldn't rna_get_fcurve work? It has "Special case for NLA Control Curves".

Thu, Apr 25, 5:44 PM
Alexander Gavrilov (angavrilov) added inline comments to D4739: Fix T61296: Crash with animated b-bone segments.
Thu, Apr 25, 5:20 PM
Joseph Brandenburg (TheAngerSpecialist) awarded rBad9275ed4e60: Spline IK: support changing individual bone length via Y scaling. a Love token.
Thu, Apr 25, 5:19 PM
Alexander Gavrilov (angavrilov) added a comment to D4739: Fix T61296: Crash with animated b-bone segments.

This is awful in a multitude of ways:

Thu, Apr 25, 5:12 PM
Alexander Gavrilov (angavrilov) added a comment to D4715: Fix T59848: precisely represent the dependencies of Armature modifier..

So, I tried an experiment by changing the patch to add both the new individual bone relations, and the whole pose link - this basically adds all of the overhead without actually changing the scheduling.

Thu, Apr 25, 10:44 AM

Wed, Apr 24

Alexander Gavrilov (angavrilov) added a comment to D4715: Fix T59848: precisely represent the dependencies of Armature modifier..

Is worth testing whether there is a performance impact when running with --debug-depsgraph-no-threads, just to see if it's scheduling/threading related, or due to more overhead in general.

Wed, Apr 24, 6:59 PM
Alexander Gavrilov (angavrilov) added a comment to D4715: Fix T59848: precisely represent the dependencies of Armature modifier..

Do we understand why it has such a big performance impact?

Wed, Apr 24, 4:57 PM
Alexander Gavrilov (angavrilov) added a comment to D4715: Fix T59848: precisely represent the dependencies of Armature modifier..

So on 02_055_A from Spring this seems to reduce fps from around 12 to 11.3, so maybe worth making this an option in the modifier? This is really needed only on certain specially used meshes in certain kind of rigs.

Wed, Apr 24, 4:20 PM
Alexander Gavrilov (angavrilov) added inline comments to D4715: Fix T59848: precisely represent the dependencies of Armature modifier..
Wed, Apr 24, 2:37 PM
Alexander Gavrilov (angavrilov) updated the diff for D4730: Depsgraph: display a dependency cycle warning in the UI..

Moved the button to the status bar, because I agree that putting it in the Timeline is sort of random.

Wed, Apr 24, 2:25 PM
Alexander Gavrilov (angavrilov) added a comment to D4730: Depsgraph: display a dependency cycle warning in the UI..

It should be possible to add some flag in the dependency graph when a new cycle is detected, and pick that up in the main event loop. We don't need to show this warning for every dependency graph, just the one that matches what the user is currently editing. Otherwise it's not very clear anyway.

Wed, Apr 24, 2:12 PM
Alexander Gavrilov (angavrilov) added a comment to D4730: Depsgraph: display a dependency cycle warning in the UI..
  • Report a warning message (WM_report).
    • Loading a file with dependency cycles should not show a warning message, this seems too annoying.
    • If during editing a new cycle is detected, show a warning message.
Wed, Apr 24, 1:41 PM
Alexander Gavrilov (angavrilov) added a comment to D4730: Depsgraph: display a dependency cycle warning in the UI..

We could have a type of persistent report.

If you don't notice warning reports for some reason, we really need to fix that rather than finding a different place.

Wed, Apr 24, 1:25 PM
Alexander Gavrilov (angavrilov) added a comment to D4730: Depsgraph: display a dependency cycle warning in the UI..

I don't think the timeline is the right place for this, it's not guaranteed to be visible and also not specifically related to the dependency graph.

Wed, Apr 24, 1:17 PM
Alexander Gavrilov (angavrilov) added a comment to D4730: Depsgraph: display a dependency cycle warning in the UI..

So, the UI part is a bit of a hack (using a menu and all), and has some issues:

Wed, Apr 24, 12:58 PM
Alexander Gavrilov (angavrilov) created D4730: Depsgraph: display a dependency cycle warning in the UI..
Wed, Apr 24, 12:55 PM
Alexander Gavrilov (angavrilov) added a comment to D4726: Fix T63794: Duplicating an armature clears B-Bones' custom handle references.

Looks ok overall, but I have some performance concerns.

Wed, Apr 24, 9:37 AM

Tue, Apr 23

Alexander Gavrilov (angavrilov) committed rB80b036afab8c: Depsgraph: make the dependency cycle report more readable. (authored by Alexander Gavrilov (angavrilov)).
Depsgraph: make the dependency cycle report more readable.
Tue, Apr 23, 5:30 PM
Alexander Gavrilov (angavrilov) committed rB58a1eb9a0029: Depsgraph: fix standard IK target dependencies. (authored by Alexander Gavrilov (angavrilov)).
Depsgraph: fix standard IK target dependencies.
Tue, Apr 23, 4:55 PM
Alexander Gavrilov (angavrilov) committed rB7625fad9e915: B-Bones: remove hard limits on curve/roll/scale/ease properties. (authored by Alexander Gavrilov (angavrilov)).
B-Bones: remove hard limits on curve/roll/scale/ease properties.
Tue, Apr 23, 12:45 PM
Alexander Gavrilov (angavrilov) committed rBae054af14f99: Cleanup: rename the curveInX etc bbone DNA fields to curve_in_x etc. (authored by Alexander Gavrilov (angavrilov)).
Cleanup: rename the curveInX etc bbone DNA fields to curve_in_x etc.
Tue, Apr 23, 12:45 PM
Alexander Gavrilov (angavrilov) committed rB624e93bbef8a: B-Bones: split the Scale In/Out properties into X and Y values. (authored by Alexander Gavrilov (angavrilov)).
B-Bones: split the Scale In/Out properties into X and Y values.
Tue, Apr 23, 12:45 PM
Alexander Gavrilov (angavrilov) closed D4716: B-Bones: split the Scale In/Out properties into X and Y values..
Tue, Apr 23, 12:45 PM
Alexander Gavrilov (angavrilov) updated the diff for D4716: B-Bones: split the Scale In/Out properties into X and Y values..

Clang-format re-applied.

Tue, Apr 23, 10:33 AM

Sun, Apr 21

Alexander Gavrilov (angavrilov) added inline comments to rBM4636: some fixes.
Sun, Apr 21, 5:23 AM

Sat, Apr 20

Alexander Gavrilov (angavrilov) created D4716: B-Bones: split the Scale In/Out properties into X and Y values..
Sat, Apr 20, 5:44 PM
Alexander Gavrilov (angavrilov) added a task to D4715: Fix T59848: precisely represent the dependencies of Armature modifier.: T59848: Bone won't deform mesh.
Sat, Apr 20, 2:53 PM
Alexander Gavrilov (angavrilov) added a revision to T59848: Bone won't deform mesh: D4715: Fix T59848: precisely represent the dependencies of Armature modifier..
Sat, Apr 20, 2:53 PM · BF Blender
Alexander Gavrilov (angavrilov) created D4715: Fix T59848: precisely represent the dependencies of Armature modifier..
Sat, Apr 20, 2:11 PM
Alexander Gavrilov (angavrilov) committed rBf22397206f4d: NLA: check that properties are animatable. (authored by Alexander Gavrilov (angavrilov)).
NLA: check that properties are animatable.
Sat, Apr 20, 2:07 PM
Alexander Gavrilov (angavrilov) committed rBM4642: Fix T63720: document the Parent Inverse matrix better..
Fix T63720: document the Parent Inverse matrix better.
Sat, Apr 20, 10:20 AM
Alexander Gavrilov (angavrilov) changed the status of T63720: Parent Inverse is insufficiently explained in documentation from Archived to Resolved by committing rBM4642: Fix T63720: document the Parent Inverse matrix better..
Sat, Apr 20, 10:20 AM · Documentation
Alexander Gavrilov (angavrilov) added inline comments to rBM4636: some fixes.
Sat, Apr 20, 9:44 AM

Fri, Apr 19

Alexander Gavrilov (angavrilov) renamed T63720: Parent Inverse is insufficiently explained in documentation from hidden factor of transformation with from parent deformed objects to Parent Inverse is insufficiently explained in documentation.
Fri, Apr 19, 12:57 PM · Documentation
Alexander Gavrilov (angavrilov) claimed T63720: Parent Inverse is insufficiently explained in documentation.
Fri, Apr 19, 12:56 PM · Documentation
Alexander Gavrilov (angavrilov) added a comment to T63720: Parent Inverse is insufficiently explained in documentation.

That's not a bug, it's what's called the Parent Inverse Matrix. In python that's called object.matrix_parent_inverse. Alt-P -> Clear Parent Inverse clears it.

Fri, Apr 19, 12:48 PM · Documentation

Thu, Apr 18

Tema Lavrov (shader) awarded rB638938e5a8c3: Armature: remove remains of the object-level deformation data cache. a Love token.
Thu, Apr 18, 10:30 PM
Alexander Gavrilov (angavrilov) committed rB638938e5a8c3: Armature: remove remains of the object-level deformation data cache. (authored by Alexander Gavrilov (angavrilov)).
Armature: remove remains of the object-level deformation data cache.
Thu, Apr 18, 10:23 PM
Alexander Gavrilov (angavrilov) committed rB7ec6bca92fd0: Fix T63332: backup and restore bPoseChannel_Runtime data during COW. (authored by Alexander Gavrilov (angavrilov)).
Fix T63332: backup and restore bPoseChannel_Runtime data during COW.
Thu, Apr 18, 8:32 PM
Alexander Gavrilov (angavrilov) closed T63332: Cached B-Bone segment transform data is lost when mode is toggled. as Resolved by committing rB7ec6bca92fd0: Fix T63332: backup and restore bPoseChannel_Runtime data during COW..
Thu, Apr 18, 8:32 PM · BF Blender
Alexander Gavrilov (angavrilov) added a comment to rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation..

This is fantastic, mad props. :) Does it also apply to copy rotate constraint ?

Thu, Apr 18, 10:39 AM
Alexander Gavrilov (angavrilov) added a comment to T59848: Bone won't deform mesh.

Nobody is going to like having to explicitly connect all bones in a rig to their mesh, if that's what you are trying to say. The Armature modifier with vertex weights already knows exactly which bones it actually needs from the vertex group list, but for coding convenience and depsgraph building efficiency it depends on the whole armature. There's also the cache thing, which is built at the armature level, but by this point only caches the double quats for non-bbones.

Thu, Apr 18, 10:31 AM · BF Blender
Tema Lavrov (shader) awarded rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation. a Y So Serious token.
Thu, Apr 18, 8:00 AM

Wed, Apr 17

Alexander Gavrilov (angavrilov) accepted D4701: Refactor storage usage during fcurve modifier evaluation.
Wed, Apr 17, 6:00 PM
Alexander Gavrilov (angavrilov) added a comment to D4701: Refactor storage usage during fcurve modifier evaluation.

Seems OK overall, just some nitpicks about naming and blank lines :)

Wed, Apr 17, 5:01 PM
Alexander Gavrilov (angavrilov) committed rB6770f76bd49f: Fix T60982: don't allow editing group properties in linked actions. (authored by Alexander Gavrilov (angavrilov)).
Fix T60982: don't allow editing group properties in linked actions.
Wed, Apr 17, 1:47 PM
Alexander Gavrilov (angavrilov) closed T60982: Disabled channels in linked action as Resolved by committing rB6770f76bd49f: Fix T60982: don't allow editing group properties in linked actions..
Wed, Apr 17, 1:47 PM · BF Blender
Alexander Gavrilov (angavrilov) claimed T60982: Disabled channels in linked action.
Wed, Apr 17, 1:42 PM · BF Blender

Tue, Apr 16

Alexander Gavrilov (angavrilov) committed rBM4626: Document the new Spline IK Y scale option..
Document the new Spline IK Y scale option.
Tue, Apr 16, 8:05 PM
Alexander Gavrilov (angavrilov) committed rBad9275ed4e60: Spline IK: support changing individual bone length via Y scaling. (authored by Alexander Gavrilov (angavrilov)).
Spline IK: support changing individual bone length via Y scaling.
Tue, Apr 16, 5:43 PM
Alexander Gavrilov (angavrilov) closed D4687: Spline IK: support changing individual bone length via Y scaling..
Tue, Apr 16, 5:43 PM
Joseph Brandenburg (TheAngerSpecialist) awarded rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation. a Mountain of Wealth token.
Tue, Apr 16, 4:56 PM
Alexander Gavrilov (angavrilov) committed rBAbc1ac160b3ba: Rigify: change make_property to wrap the official rna_idprop_ui_create. (authored by Alexander Gavrilov (angavrilov)).
Rigify: change make_property to wrap the official rna_idprop_ui_create.
Tue, Apr 16, 4:36 PM
Alexander Gavrilov (angavrilov) committed rB40dd91561d46: Python: add a utility function for creating custom properties. (authored by Alexander Gavrilov (angavrilov)).
Python: add a utility function for creating custom properties.
Tue, Apr 16, 3:49 PM
Alexander Gavrilov (angavrilov) closed D4620: Python: add a utility function for creating custom properties..
Tue, Apr 16, 3:49 PM
Konstantins Visnevskis (kivig) awarded rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation. a Like token.
Tue, Apr 16, 3:46 PM
Alexander Gavrilov (angavrilov) placed T63548: animated custom property does not change value when animation is rendered up for grabs.

By all looks this seems to be a depsgraph / COW / Python API issue, not related to animation as such.

Tue, Apr 16, 1:53 PM · BF Blender: 2.8, BF Blender, Animation
Alexander Gavrilov (angavrilov) added a parent task for T63548: animated custom property does not change value when animation is rendered: T60094: Render crash when using Python API to modify object data in frame_change_pre handler.
Tue, Apr 16, 1:52 PM · BF Blender: 2.8, BF Blender, Animation
Alexander Gavrilov (angavrilov) added a subtask for T60094: Render crash when using Python API to modify object data in frame_change_pre handler: T63548: animated custom property does not change value when animation is rendered.
Tue, Apr 16, 1:52 PM · BF Blender

Mon, Apr 15

Alexander Gavrilov (angavrilov) created D4687: Spline IK: support changing individual bone length via Y scaling..
Mon, Apr 15, 9:09 PM
Alexander Gavrilov (angavrilov) committed rBe2102e991764: Spline IK: fix continuity issues with influence and curve end rolloff. (authored by Alexander Gavrilov (angavrilov)).
Spline IK: fix continuity issues with influence and curve end rolloff.
Mon, Apr 15, 9:01 PM
lucas veber (lucky3) awarded rB2f2ba04c6053: Fix T63574: missing implicit parent bone dependency in proxies. a Like token.
Mon, Apr 15, 7:15 PM
Alexander Gavrilov (angavrilov) committed rB2f2ba04c6053: Fix T63574: missing implicit parent bone dependency in proxies. (authored by Alexander Gavrilov (angavrilov)).
Fix T63574: missing implicit parent bone dependency in proxies.
Mon, Apr 15, 7:12 PM
Alexander Gavrilov (angavrilov) closed T63574: Linking 2 armatures that depends on each other leads to jiggle artefacts as Resolved by committing rB2f2ba04c6053: Fix T63574: missing implicit parent bone dependency in proxies..
Mon, Apr 15, 7:12 PM · BF Blender
Alexander Gavrilov (angavrilov) added a comment to T63574: Linking 2 armatures that depends on each other leads to jiggle artefacts.

So, when it's not a cycle, another likely cause of unstable evaluation is a missing dependency, and that is the case here.

Mon, Apr 15, 6:58 PM · BF Blender
Alexander Gavrilov (angavrilov) added a comment to T63582: 2.79 Modified Rigs to 2.80 Crash To Desktop.

So is there a 100% reliable simple procedure to reproduce?

Mon, Apr 15, 9:42 AM · BF Blender
Konstantins Visnevskis (kivig) awarded rBM4619: Document Local With Parent in a way that actually makes sense. a Like token.
Mon, Apr 15, 12:14 AM

Sun, Apr 14

Alexander Gavrilov (angavrilov) committed rB860a9f979d60: Fix copy & paste mistake in assert. (authored by Alexander Gavrilov (angavrilov)).
Fix copy & paste mistake in assert.
Sun, Apr 14, 9:22 PM
Alexander Gavrilov (angavrilov) added a comment to T63582: 2.79 Modified Rigs to 2.80 Crash To Desktop.

Well, I think I fixed the crash itself - is this done then? I haven't actually checked if the cycles themselves make sense, or anything.

Sun, Apr 14, 9:02 PM · BF Blender
Alexander Gavrilov (angavrilov) committed rB3731729b96fa: Depsgraph: fix hard CTD on dependency cycles through POSE_INIT. (authored by Alexander Gavrilov (angavrilov)).
Depsgraph: fix hard CTD on dependency cycles through POSE_INIT.
Sun, Apr 14, 8:56 PM
Alexander Gavrilov (angavrilov) added a comment to T63599: Rigify glitches.

Well, it was me who broke it too, so I had a pretty good idea.

Sun, Apr 14, 7:42 PM · BF Blender
Alexander Gavrilov (angavrilov) committed rBf73b3178f766: Fix T63599: fix the zero ease hack for the B-Bone end matrix. (authored by Alexander Gavrilov (angavrilov)).
Fix T63599: fix the zero ease hack for the B-Bone end matrix.
Sun, Apr 14, 7:30 PM
Alexander Gavrilov (angavrilov) closed T63599: Rigify glitches as Resolved by committing rBf73b3178f766: Fix T63599: fix the zero ease hack for the B-Bone end matrix..
Sun, Apr 14, 7:30 PM · BF Blender
Alexander Gavrilov (angavrilov) claimed T63599: Rigify glitches.
Sun, Apr 14, 7:12 PM · BF Blender
Alexander Gavrilov (angavrilov) committed rB6a59e1236491: Fix T59622: dependency problems with Spline IK. (authored by Alexander Gavrilov (angavrilov)).
Fix T59622: dependency problems with Spline IK.
Sun, Apr 14, 7:01 PM
Alexander Gavrilov (angavrilov) closed T59622: Spline Ik not Working correctly as Resolved by committing rB6a59e1236491: Fix T59622: dependency problems with Spline IK..
Sun, Apr 14, 7:01 PM · BF Blender
Alexander Gavrilov (angavrilov) committed rB3380fb364677: Complete the set of matrix multiplication functions. (authored by Alexander Gavrilov (angavrilov)).
Complete the set of matrix multiplication functions.
Sun, Apr 14, 5:16 PM
Alexander Gavrilov (angavrilov) claimed T59622: Spline Ik not Working correctly.

There is something of a mess in depsgraph relations here. It will require some refactoring of Spline IK evaluation to make it work well.

Sun, Apr 14, 4:31 PM · BF Blender
Alexander Gavrilov (angavrilov) committed rBM4619: Document Local With Parent in a way that actually makes sense..
Document Local With Parent in a way that actually makes sense.
Sun, Apr 14, 3:52 PM
Alexander Gavrilov (angavrilov) committed rBeee5a880f186: Dopesheet: enable Show Keyframes and Interpolation by default. (authored by Alexander Gavrilov (angavrilov)).
Dopesheet: enable Show Keyframes and Interpolation by default.
Sun, Apr 14, 3:37 PM
Alexander Gavrilov (angavrilov) closed D4678: Dopesheet: enable Show Keyframes and Interpolation by default..
Sun, Apr 14, 3:37 PM
Alexander Gavrilov (angavrilov) committed rB00b966b83ac6: Explain the Local With Parent coordinate space better. (authored by Alexander Gavrilov (angavrilov)).
Explain the Local With Parent coordinate space better.
Sun, Apr 14, 3:29 PM
Alexander Gavrilov (angavrilov) added a comment to T63574: Linking 2 armatures that depends on each other leads to jiggle artefacts.

Such stuff sounds like a dependency problem - are there no messages about cycles in the console?

Sun, Apr 14, 3:23 PM · BF Blender
Alexander Gavrilov (angavrilov) committed rBb42ae4b972a6: Fix T61981: Local With Parent broken as constraint own space. (authored by Alexander Gavrilov (angavrilov)).
Fix T61981: Local With Parent broken as constraint own space.
Sun, Apr 14, 3:06 PM
Alexander Gavrilov (angavrilov) closed T61981: Floor (World->Loc.w.par.) Bone Constraint transforms bone axes? as Resolved by committing rBb42ae4b972a6: Fix T61981: Local With Parent broken as constraint own space..
Sun, Apr 14, 3:06 PM · BF Blender
Alexander Gavrilov (angavrilov) claimed T61981: Floor (World->Loc.w.par.) Bone Constraint transforms bone axes?.

There seems to be incorrect matrix multiplication order in LWP to Pose space conversion.

Sun, Apr 14, 2:49 PM · BF Blender
Alexander Gavrilov (angavrilov) added a comment to D4678: Dopesheet: enable Show Keyframes and Interpolation by default..

@Brecht Van Lommel (brecht): any comments on the code side?

Sun, Apr 14, 2:01 PM
Alexander Gavrilov (angavrilov) committed rB90e760270aac: Depsgraph: fix debug print crash on IK constraint without target. (authored by Alexander Gavrilov (angavrilov)).
Depsgraph: fix debug print crash on IK constraint without target.
Sun, Apr 14, 12:50 PM

Sat, Apr 13

Alexander Gavrilov (angavrilov) committed rB3d8790faf17b: Fix T62048: crash when turning off curve path animation with Spline IK. (authored by Alexander Gavrilov (angavrilov)).
Fix T62048: crash when turning off curve path animation with Spline IK.
Sat, Apr 13, 7:04 PM
Alexander Gavrilov (angavrilov) closed T62048: Crash when turning of path animation while Spline IK is active. as Resolved by committing rB3d8790faf17b: Fix T62048: crash when turning off curve path animation with Spline IK..
Sat, Apr 13, 7:04 PM · BF Blender
Alexander Gavrilov (angavrilov) claimed T62048: Crash when turning of path animation while Spline IK is active..
Sat, Apr 13, 4:34 PM · BF Blender
Alexander Gavrilov (angavrilov) closed T53700: Bendy bones and shape keys cause vertices to pop as Resolved.
Sat, Apr 13, 3:37 PM · Animation, BF Blender
Alexander Gavrilov (angavrilov) added a commit to T53700: Bendy bones and shape keys cause vertices to pop: rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation..
Sat, Apr 13, 3:37 PM · Animation, BF Blender
Alexander Gavrilov (angavrilov) added a task to rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation.: T53700: Bendy bones and shape keys cause vertices to pop.
Sat, Apr 13, 3:37 PM
Alexander Gavrilov (angavrilov) committed rB51c8a6f491d3: Fix T37500: implement Bendy bone segment deformation interpolation. (authored by Alexander Gavrilov (angavrilov)).
Fix T37500: implement Bendy bone segment deformation interpolation.
Sat, Apr 13, 3:28 PM
Alexander Gavrilov (angavrilov) closed D4635: Bendy bone segment deformation interpolation.
Sat, Apr 13, 3:28 PM
Alexander Gavrilov (angavrilov) claimed T53700: Bendy bones and shape keys cause vertices to pop.
Sat, Apr 13, 3:19 PM · Animation, BF Blender
Alexander Gavrilov (angavrilov) added a reviewer for D4635: Bendy bone segment deformation interpolation: Brecht Van Lommel (brecht).

@Brecht Van Lommel (brecht): So, what is the plan about this? This would technically be a backward compatibility breaking change (slightly different transformation from B-Bones), so possibly it should go in asap, if breaking compatibility is to be avoided after 2.80?

Sat, Apr 13, 11:06 AM

Fri, Apr 12

Alexander Gavrilov (angavrilov) committed rBM4615: Document Dopesheet handle type and extreme display features..
Document Dopesheet handle type and extreme display features.
Fri, Apr 12, 7:46 PM