Page MenuHome

Alexander Gavrilov (angavrilov)
User

Projects

User Details

User Since
Aug 20 2015, 12:17 PM (182 w, 5 d)

Recent Activity

Yesterday

Alexander Gavrilov (angavrilov) added a comment to D4364: Rigify: add support for user-defined rig packages and related utilities..

I made a github branch specifically for this specific diff: https://github.com/angavrilov/rigify/tree/upstream-D4364

Tue, Feb 19, 8:42 PM
Alexander Gavrilov (angavrilov) claimed T61711: Basic Rigify Spine 2.8 won't successfully generate.
Tue, Feb 19, 7:59 PM · BF Blender: 2.8, Animation, Addons
Alexander Gavrilov (angavrilov) updated the diff for D4364: Rigify: add support for user-defined rig packages and related utilities..

Fixed broken Add Sample UI.

Tue, Feb 19, 7:55 PM
Alexander Gavrilov (angavrilov) added a comment to T61711: Basic Rigify Spine 2.8 won't successfully generate.

Fixed the reported exception, but noticed another issue (it fails if the Widgets collection is selected)

Tue, Feb 19, 7:54 PM · BF Blender: 2.8, Animation, Addons
Alexander Gavrilov (angavrilov) committed rBA29a359840ea7: Fix T61711: Rigify fails to complete generate if no rigs create drivers. (authored by Alexander Gavrilov (angavrilov)).
Fix T61711: Rigify fails to complete generate if no rigs create drivers.
Tue, Feb 19, 7:44 PM
Alexander Gavrilov (angavrilov) added a comment to T59848: Bone won't deform mesh.

How are nodes relevant? The problem here is the armature modifier depends on evaluation of the whole armature, instead of just the relevant bones (i.e. the set based on vertex group names). In the majority of cases that is correct, and probably more efficient (fewer graph links to process), but in some specific use cases it is a problem.

Tue, Feb 19, 2:56 PM · BF Blender
Alexander Gavrilov (angavrilov) added a comment to D4364: Rigify: add support for user-defined rig packages and related utilities..

@Alexander Gavrilov (angavrilov)
still no luck with your repo and 2.79 same os as above:

    legacy_mode: BoolProperty(
               ^
SyntaxError: invalid syntax
Tue, Feb 19, 9:43 AM

Mon, Feb 18

Alexander Gavrilov (angavrilov) added a comment to D4364: Rigify: add support for user-defined rig packages and related utilities..

I can’t test on Mac OS, but it works for me on Linux when applied upon the latest commit.

@Damien Picard (pioverfour) please download the 2.6 beta and test it. Should be updated to your recent pulls (except for pantins related commits). If it works then it's os-related, if not, you probably did some modification to without stashing the related commit, so in that case we need to pull that too (without pantins related commits).

Mon, Feb 18, 5:59 PM
Alexander Gavrilov (angavrilov) updated the diff for D4364: Rigify: add support for user-defined rig packages and related utilities..

Removed another big chunk of unrelated code from MAD.

Mon, Feb 18, 5:55 PM

Sat, Feb 16

William Reynish (billreynish) awarded D4364: Rigify: add support for user-defined rig packages and related utilities. a Love token.
Sat, Feb 16, 12:38 PM
Alexander Gavrilov (angavrilov) updated the summary of D4364: Rigify: add support for user-defined rig packages and related utilities..
Sat, Feb 16, 12:36 PM
Alexander Gavrilov (angavrilov) created D4364: Rigify: add support for user-defined rig packages and related utilities..
Sat, Feb 16, 12:35 PM

Wed, Feb 13

Alexander Gavrilov (angavrilov) closed T61396: Bendy bone animation, remove a group of keyframes and get unexpected results as Invalid.

There are no keys for object Z beyond 20.

Wed, Feb 13, 8:14 AM · BF Blender

Tue, Feb 12

Alexander Gavrilov (angavrilov) closed T61396: Bendy bone animation, remove a group of keyframes and get unexpected results as Invalid.

I don't see anything wrong here. If you delete the last keyframe updating the object Z position, it will obviously reset to the previous key that is now the last one.

Tue, Feb 12, 8:15 AM · BF Blender

Mon, Feb 11

Alexander Gavrilov (angavrilov) added a comment to T52758: Rigify: feature proposal: allow registration of custom rig types.

Hi guys!

Mon, Feb 11, 9:40 PM · Addons
Alexander Gavrilov (angavrilov) added a comment to T52758: Rigify: feature proposal: allow registration of custom rig types.

Btw anyway, what is the precise status of this repository, and the branches in it? https://github.com/eigen-value/rigify

Mon, Feb 11, 5:59 PM · Addons
Alexander Gavrilov (angavrilov) added a comment to T52758: Rigify: feature proposal: allow registration of custom rig types.

Do as all other contributors do (and we did) make a redesign proposal, make it public, make people involved. Making a pull request and complaining to have it approved without respecting design and code guidelines from the author is not a clear way to go. You got answers in that, just decided your code is good and can override guidelines. So you are assuming you approve yourself the code and its design and we are only here to say yes. That's not how i intend a collaboration basically because "you are not the only person involved there".

Mon, Feb 11, 5:42 PM · Addons
Alexander Gavrilov (angavrilov) added a comment to T52758: Rigify: feature proposal: allow registration of custom rig types.

I don't honestly know if there's such implication in mantaining a module, but i am sure it implies bug fixing, keep the add-on working, design, discuss and manage features implementations and request.

Mon, Feb 11, 5:14 PM · Addons
Alexander Gavrilov (angavrilov) added a comment to T52758: Rigify: feature proposal: allow registration of custom rig types.

about rigify updates, there are lots of new features in the working. Mostly a new set of tools/samples/utility for a modular cartoony face rig. Unfortunately we have to work on it in the spare time between a production and another and bug-fixing maintenance. The 2.8 migration process is not helping in that way too. So i can't tell when those updates will be stable enough to go in master. If you have suggestions the best thing should be creating a feature request thread where you explain it in detail, keep me @Lucio Rossi (luciorossi) and @Paolo Acampora (pkrime) as subscribers and i'll try to give a look at what can be done in a reasonable time.

Mon, Feb 11, 9:57 AM · Addons

Mon, Jan 28

Alexander Gavrilov (angavrilov) added a comment to D4274: Depsgraph: remove features incompatible with new system..

How about nuking the AnimData->recalc field completely? With COW it is totally broken anyway because it's never cleared once set in the main instance.

Mon, Jan 28, 7:21 PM
Alexander Gavrilov (angavrilov) added a comment to T59848: Bone won't deform mesh.

It could be useful to e.g. have a checkbox in the modifier to specifically limit the dependencies to relevant bones (it would be more expensive performance wise than depending on everything, but nowhere as much as a separate armature), but supporting that would likely require some careful refactoring of the modifier code.

Mon, Jan 28, 6:57 PM · BF Blender
Alexander Gavrilov (angavrilov) added a comment to T59848: Bone won't deform mesh.

Well, the problem here is that Armature modifier always depends on all bones, without taking the vertex groups into consideration at all. Thus to support this (very realistic and useful) use case, it is necessary to use a workaround:

Mon, Jan 28, 6:52 PM · BF Blender

Fri, Jan 25

Alexander Gavrilov (angavrilov) added a comment to T59178: Insert and modify keyframes on evaluation time for path animation with linear interpolation impossible.

@Sergey Sharybin (sergey) IIRC the problem here is that there is a magic recalc flag that makes that call to evaluate drivers also update keyed animation, and that flag is never cleared once set - so presumably the solution is to get rid of adt->recalc?

Fri, Jan 25, 12:59 PM · Animation, BF Blender

Wed, Jan 23

Tema Lavrov (shader) awarded rBde1d3e5f5f40: NLA: implement a new blending mode that intelligently combines actions. a Like token.
Wed, Jan 23, 11:14 AM

Mon, Jan 21

Alexander Gavrilov (angavrilov) added a reviewer for D4232: Fix T60689: Flip Active/Selected bone does not work in weight paint mode: Campbell Barton (campbellbarton).
Mon, Jan 21, 12:50 PM
Alexander Gavrilov (angavrilov) added a comment to D4232: Fix T60689: Flip Active/Selected bone does not work in weight paint mode.

The reason for the default is because the original code used the type of the active object, and this default specifically implements it. I'd suggest not changing it without consulting with whoever actually wrote the actual original code.

Mon, Jan 21, 12:45 PM

Jan 14 2019

Alexander Gavrilov (angavrilov) committed rBde1d3e5f5f40: NLA: implement a new blending mode that intelligently combines actions. (authored by Alexander Gavrilov (angavrilov)).
NLA: implement a new blending mode that intelligently combines actions.
Jan 14 2019, 5:36 PM
Alexander Gavrilov (angavrilov) closed D4190: NLA: implement a new blending mode that intelligently overlays actions..
Jan 14 2019, 5:36 PM
Alexander Gavrilov (angavrilov) committed rB9c1a961dc423: Keyframing: refactor insertion code to allow property-global NLA tweaks. (authored by Alexander Gavrilov (angavrilov)).
Keyframing: refactor insertion code to allow property-global NLA tweaks.
Jan 14 2019, 5:36 PM

Jan 13 2019

Alexander Gavrilov (angavrilov) reassigned T60461: Rigify: Fix displaying multiple rig layer panel with older blend file. Blender 2.8 from Campbell Barton (campbellbarton) to Lucio Rossi (luciorossi).

Month-long delays in reviewing and accepting major changes to the core systems, as well as keeping things in a relatively unknown separate repository, get in the way of fixing issues the longer that goes on. This patch will be impossible to merge with the refactorings that are going on, and has to be rejected. However, the issue also can't be fixed in the new branch, because reviews are completely stalled.

Jan 13 2019, 10:09 AM · Addons
Alexander Gavrilov (angavrilov) added a comment to T60461: Rigify: Fix displaying multiple rig layer panel with older blend file. Blender 2.8.

Don't touch that code, it's going to be rewritten in the next version of rigify, whenever it happens.

Jan 13 2019, 9:59 AM · Addons

Jan 12 2019

Alexander Gavrilov (angavrilov) updated the diff for D4190: NLA: implement a new blending mode that intelligently overlays actions..

Renamed to Combine, plus some tweaks.

Jan 12 2019, 3:53 PM
Alexander Gavrilov (angavrilov) committed rB2826c2be545e: NLA: ignore time range when evaluating a raw action. (authored by Alexander Gavrilov (angavrilov)).
NLA: ignore time range when evaluating a raw action.
Jan 12 2019, 12:25 PM

Jan 11 2019

Alexander Gavrilov (angavrilov) added inline comments to D4190: NLA: implement a new blending mode that intelligently overlays actions..
Jan 11 2019, 2:19 PM
Alexander Gavrilov (angavrilov) added a comment to D4190: NLA: implement a new blending mode that intelligently overlays actions..

I thought all rotation types would use quaternion blending? Isn't that required to get good results for Euler and axis-angle values?

Jan 11 2019, 2:17 PM
noki paike (amonpaike) awarded D4190: NLA: implement a new blending mode that intelligently overlays actions. a Love token.
Jan 11 2019, 10:16 AM
Alexander Gavrilov (angavrilov) updated subscribers of D4190: NLA: implement a new blending mode that intelligently overlays actions..

I wonder if @Brecht Van Lommel (brecht) or @Campbell Barton (campbellbarton) have any opinion on naming.

Jan 11 2019, 10:01 AM
Alexander Gavrilov (angavrilov) added a comment to D4190: NLA: implement a new blending mode that intelligently overlays actions..

As for the name of this blend mode, which is called Overlay here, I have a slight preference towards the name 'Layer' rather than 'Overlay' - I simply think it would be slightly clearer what it is for. But that is a minor detail.

Jan 11 2019, 8:24 AM

Jan 10 2019

Alexander Gavrilov (angavrilov) created D4190: NLA: implement a new blending mode that intelligently overlays actions..
Jan 10 2019, 6:24 PM
Alexander Gavrilov (angavrilov) committed rB80ffa73b3f87: Fix T60285: allow negative offsets in shrinkwrap (worked in 2.79). (authored by Alexander Gavrilov (angavrilov)).
Fix T60285: allow negative offsets in shrinkwrap (worked in 2.79).
Jan 10 2019, 10:15 AM
Alexander Gavrilov (angavrilov) closed T60285: Shrinkwrap modifier ignores negative offsets as Resolved by committing rB80ffa73b3f87: Fix T60285: allow negative offsets in shrinkwrap (worked in 2.79)..
Jan 10 2019, 10:15 AM · BF Blender
Alexander Gavrilov (angavrilov) claimed T60285: Shrinkwrap modifier ignores negative offsets.
Jan 10 2019, 9:54 AM · BF Blender

Jan 7 2019

Alexander Gavrilov (angavrilov) committed rB43a2a73fdba0: Fix missing updates when muting/soloing/reordering NLA tracks. (authored by Alexander Gavrilov (angavrilov)).
Fix missing updates when muting/soloing/reordering NLA tracks.
Jan 7 2019, 3:38 PM

Jan 5 2019

Alexander Gavrilov (angavrilov) committed rB57d4b869be38: NLA: rewrite evaluation channel data structures. (authored by Alexander Gavrilov (angavrilov)).
NLA: rewrite evaluation channel data structures.
Jan 5 2019, 8:52 AM
Alexander Gavrilov (angavrilov) closed D4120: NLA: rewrite evaluation channel data structures..
Jan 5 2019, 8:52 AM

Dec 31 2018

Alexander Gavrilov (angavrilov) added inline comments to D4120: NLA: rewrite evaluation channel data structures..
Dec 31 2018, 6:10 PM
Alexander Gavrilov (angavrilov) updated the diff for D4120: NLA: rewrite evaluation channel data structures..

Renamings and tweaks.

Dec 31 2018, 6:05 PM

Dec 27 2018

Alexander Gavrilov (angavrilov) added inline comments to D4120: NLA: rewrite evaluation channel data structures..
Dec 27 2018, 6:51 PM
Alexander Gavrilov (angavrilov) added inline comments to D4120: NLA: rewrite evaluation channel data structures..
Dec 27 2018, 5:55 PM

Dec 23 2018

Alexander Gavrilov (angavrilov) added inline comments to D4120: NLA: rewrite evaluation channel data structures..
Dec 23 2018, 6:48 PM
Alexander Gavrilov (angavrilov) created D4120: NLA: rewrite evaluation channel data structures..
Dec 23 2018, 6:40 PM
Alexander Gavrilov (angavrilov) committed rBa5cfeaba9ee2: Fix missing update when deleting animation channels. (authored by Alexander Gavrilov (angavrilov)).
Fix missing update when deleting animation channels.
Dec 23 2018, 3:34 PM
Alexander Gavrilov (angavrilov) committed rBc3650e496b6f: Fix missing update when toggling NLA solo mode. (authored by Alexander Gavrilov (angavrilov)).
Fix missing update when toggling NLA solo mode.
Dec 23 2018, 3:33 PM
Alexander Gavrilov (angavrilov) committed rB02f083cdcecf: BLI_math_rotation: properly name the quaternion power function. (authored by Alexander Gavrilov (angavrilov)).
BLI_math_rotation: properly name the quaternion power function.
Dec 23 2018, 1:52 PM

Dec 21 2018

lucas veber (lucky3) awarded rBafa3aec45d95: Fix T59734: cyclic dependency with drivers on PoseBone.bbone_*. a Love token.
Dec 21 2018, 9:56 PM
Alexander Gavrilov (angavrilov) closed T59734: Cyclic dependency when b-bones parameters are driven by a child bone as Resolved by committing rBafa3aec45d95: Fix T59734: cyclic dependency with drivers on PoseBone.bbone_*..
Dec 21 2018, 9:12 PM · BF Blender: 2.8, BF Blender
Alexander Gavrilov (angavrilov) committed rBafa3aec45d95: Fix T59734: cyclic dependency with drivers on PoseBone.bbone_*. (authored by Alexander Gavrilov (angavrilov)).
Fix T59734: cyclic dependency with drivers on PoseBone.bbone_*.
Dec 21 2018, 9:11 PM
Alexander Gavrilov (angavrilov) claimed T59734: Cyclic dependency when b-bones parameters are driven by a child bone.
Dec 21 2018, 8:28 PM · BF Blender: 2.8, BF Blender
Alexander Gavrilov (angavrilov) committed rB8cbadde1a52f: Fix T59673: wrong B-Bone handle references when duplicating bones. (authored by Alexander Gavrilov (angavrilov)).
Fix T59673: wrong B-Bone handle references when duplicating bones.
Dec 21 2018, 10:11 AM
Alexander Gavrilov (angavrilov) closed T59673: Duplicating bendy bone setup works, but references for Start/End options gets inverted in both source and target as Resolved by committing rB8cbadde1a52f: Fix T59673: wrong B-Bone handle references when duplicating bones..
Dec 21 2018, 10:11 AM · BF Blender

Dec 19 2018

Alexander Gavrilov (angavrilov) committed rBd211c9aa0aaa: BLI_bitmap: add functions operating on the whole bitmask. (authored by Alexander Gavrilov (angavrilov)).
BLI_bitmap: add functions operating on the whole bitmask.
Dec 19 2018, 1:59 PM
Alexander Gavrilov (angavrilov) closed D4101: BLI_bitmap: add functions operating on the whole bitmask..
Dec 19 2018, 1:59 PM
Alexander Gavrilov (angavrilov) created D4101: BLI_bitmap: add functions operating on the whole bitmask..
Dec 19 2018, 1:40 PM
Alexander Gavrilov (angavrilov) committed rB61c941f040d3: RNA: support setting default values for custom properties. (authored by Alexander Gavrilov (angavrilov)).
RNA: support setting default values for custom properties.
Dec 19 2018, 12:21 PM
Alexander Gavrilov (angavrilov) closed D4084: RNA: support setting default values for custom properties..
Dec 19 2018, 12:21 PM
Alexander Gavrilov (angavrilov) updated the diff for D4084: RNA: support setting default values for custom properties..

Naming changes; removed the assign all defaults operator from the Object mode Ctrl-A menu.

Dec 19 2018, 11:45 AM

Dec 18 2018

Alexander Gavrilov (angavrilov) committed rB1ca7b6ca858d: Fix T59569: crashes when generate rig. (authored by Alexander Gavrilov (angavrilov)).
Fix T59569: crashes when generate rig.
Dec 18 2018, 5:59 PM
Alexander Gavrilov (angavrilov) closed T59569: Blender 2.8 crashes when generate rig as Resolved by committing rB1ca7b6ca858d: Fix T59569: crashes when generate rig..
Dec 18 2018, 5:59 PM · BF Blender

Dec 17 2018

Alexander Gavrilov (angavrilov) updated subscribers of D4084: RNA: support setting default values for custom properties..

To elaborate on the NLA design concerns that motivate this a bit more:

Dec 17 2018, 10:36 AM

Dec 16 2018

Alexander Gavrilov (angavrilov) created D4084: RNA: support setting default values for custom properties..
Dec 16 2018, 3:16 PM
Alexander Gavrilov (angavrilov) committed rBcfa46ddf6c22: UI: initialize Overridable Static checkbox for custom properties. (authored by Alexander Gavrilov (angavrilov)).
UI: initialize Overridable Static checkbox for custom properties.
Dec 16 2018, 3:14 PM

Dec 14 2018

Alexander Gavrilov (angavrilov) committed rBde662e7cd3b3: NLA: insert keyframes correctly for strips with non-Replace mode. (authored by Alexander Gavrilov (angavrilov)).
NLA: insert keyframes correctly for strips with non-Replace mode.
Dec 14 2018, 8:59 PM
Alexander Gavrilov (angavrilov) closed D3927: NLA: insert keyframes correctly for strips with non-Replace mode..
Dec 14 2018, 8:59 PM

Dec 11 2018

Alexander Gavrilov (angavrilov) added a comment to D3998: Cycle Bake - Average Normals for projection.

My new Target Normal Projection mode in the shrinkwrap modifier (basically intended to address a vaguely similar mapping continuity problem to this) simply uses the vertex normals and thus won't be smooth with edge split either.

Dec 11 2018, 9:19 PM · Cycles, BF Blender
Alexander Gavrilov (angavrilov) committed rB48a3f97b2350: RNA: provide access to bone parent transform math from Python. (authored by Alexander Gavrilov (angavrilov)).
RNA: provide access to bone parent transform math from Python.
Dec 11 2018, 7:36 PM
Alexander Gavrilov (angavrilov) closed D4053: RNA: provide access to bone parent transform math from Python..
Dec 11 2018, 7:36 PM
Alexander Gavrilov (angavrilov) added a comment to D4053: RNA: provide access to bone parent transform math from Python..

And then initialize matrix_local, parent_matrix and parent_matrix_local to the matrices from the bone and its parent, if not provided? The descriptions of these parameters can then explain what they override.

Dec 11 2018, 5:57 PM

Dec 10 2018

Alexander Gavrilov (angavrilov) added a comment to D4057: Fix T59112: bone pinning error.

(and cannot get PoseBone from Bone...)?

Dec 10 2018, 2:01 PM
Alexander Gavrilov (angavrilov) accepted D4057: Fix T59112: bone pinning error.

Didn't test, but if it works I guess it should be fine now.

Dec 10 2018, 1:05 PM
Alexander Gavrilov (angavrilov) requested changes to D4057: Fix T59112: bone pinning error.

I have also removed the usage of bbone (as opposed to just bone), as these were the same anyways? [unless I am misunderstanding something here...]

Dec 10 2018, 11:54 AM

Dec 8 2018

Alexander Gavrilov (angavrilov) added a comment to rBde491abf9962: Fix modifiers evaluation outside of depsgraph/CoW context..

@Alexander Gavrilov (angavrilov), evaluation of modifiers outside of dependency graph is not really a violation.

Dec 8 2018, 11:51 AM
Alexander Gavrilov (angavrilov) created D4053: RNA: provide access to bone parent transform math from Python..
Dec 8 2018, 8:19 AM
Alexander Gavrilov (angavrilov) committed rBb4b224dc083c: Shrinkwrap: use polygon normals for flat faces in Align To Normal. (authored by Alexander Gavrilov (angavrilov)).
Shrinkwrap: use polygon normals for flat faces in Align To Normal.
Dec 8 2018, 7:11 AM
Alexander Gavrilov (angavrilov) updated subscribers of rBde491abf9962: Fix modifiers evaluation outside of depsgraph/CoW context..

@Sergey Sharybin (sergey), I wonder if this is fundamentally the right approach? It feels that the whole thing of calling modifiers outside of depsgraph context in the first place is going against the design (e.g. if the object was invisible, the dependencies aren't guaranteed to be up to date, and so on).

Dec 8 2018, 5:43 AM

Dec 7 2018

Alexander Gavrilov (angavrilov) added a comment to D3998: Cycle Bake - Average Normals for projection.

It is exactly for edge splits and autosmooth.

Dec 7 2018, 7:43 AM · Cycles, BF Blender

Dec 5 2018

Alexander Gavrilov (angavrilov) added a comment to D3998: Cycle Bake - Average Normals for projection.

To me it seems odd that we are using binary search to figure out which face corners share a vertex, when that information is already defined in the mesh. Or is this for modifiers like edge split that split the mesh, where that connectivity information is lost?

Dec 5 2018, 6:34 PM · Cycles, BF Blender
Alexander Gavrilov (angavrilov) committed rB16aa7dfa196d: Fix T58391: correctly handle Curve Shape Key layout in Python API. (authored by Alexander Gavrilov (angavrilov)).
Fix T58391: correctly handle Curve Shape Key layout in Python API.
Dec 5 2018, 4:37 PM
Alexander Gavrilov (angavrilov) closed T58391: Curve shape keys python data gets mixed up and extra points added as Resolved by committing rB16aa7dfa196d: Fix T58391: correctly handle Curve Shape Key layout in Python API..
Dec 5 2018, 4:37 PM · Python, BF Blender: 2.8
Alexander Gavrilov (angavrilov) claimed T58391: Curve shape keys python data gets mixed up and extra points added.

Curve shapekey data is more complicated than coordinates, and even more so in 2.8 after rB12788906. I suspect python API wrappers don't take that into account.

Dec 5 2018, 12:57 PM · Python, BF Blender: 2.8

Dec 4 2018

Alexander Gavrilov (angavrilov) committed rB34b73cb11ce5: Fix T57620: display custom normals in Edit Mode. (authored by Alexander Gavrilov (angavrilov)).
Fix T57620: display custom normals in Edit Mode.
Dec 4 2018, 6:23 PM
Alexander Gavrilov (angavrilov) closed T57620: Loop normals display not working if have custom split normals as Resolved by committing rB34b73cb11ce5: Fix T57620: display custom normals in Edit Mode..
Dec 4 2018, 6:23 PM · BF Blender: 2.8
Alexander Gavrilov (angavrilov) claimed T57620: Loop normals display not working if have custom split normals.
Dec 4 2018, 6:23 PM · BF Blender: 2.8
Alexander Gavrilov (angavrilov) added a comment to T57620: Loop normals display not working if have custom split normals.

No idea about bmesh stuff, but with regular meshes the ORIGINDEX layer doesn't exist if the object only has deform modifiers and thus the topology is unchanged from base, and you have to account for that.

Dec 4 2018, 2:58 PM · BF Blender: 2.8
Alexander Gavrilov (angavrilov) committed rBb97cd0e6908b: Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage. (authored by Alexander Gavrilov (angavrilov)).
Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage.
Dec 4 2018, 12:09 PM
Alexander Gavrilov (angavrilov) closed D4027: Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage..
Dec 4 2018, 12:09 PM
Alexander Gavrilov (angavrilov) committed rB01581d4a1eb5: BLI_task: fix queue in work_and_wait, and support resetting. (authored by Alexander Gavrilov (angavrilov)).
BLI_task: fix queue in work_and_wait, and support resetting.
Dec 4 2018, 12:09 PM
Alexander Gavrilov (angavrilov) updated the diff for D4027: Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage..

Moved do_work = false to main function.

Dec 4 2018, 10:25 AM
Alexander Gavrilov (angavrilov) added a comment to D4027: Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage..

The scheduling is really simple: during COW phase it skips actually scheduling any tasks for non-COW nodes, and then at the start of next phase it goes through all nodes again with schedule_graph and schedules everything that is now ready.

Dec 4 2018, 10:24 AM
Alexander Gavrilov (angavrilov) updated the diff for D4027: Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage..

Fixes.

Dec 4 2018, 10:24 AM

Dec 3 2018

Alexander Gavrilov (angavrilov) created D4027: Depsgraph: execute all COPY_ON_WRITE nodes first as a separate stage..
Dec 3 2018, 8:55 PM