Tom Edwards (artfunkel)
User

Projects

User Details

User Since
Jan 10 2010, 2:45 PM (413 w, 12 h)

Recent Activity

Aug 19 2017

Tom Edwards (artfunkel) created T52454: Crash in DEG_graph_on_visible_update when activating scene layer.
Aug 19 2017, 5:13 PM · BF Blender

May 7 2017

Tom Edwards (artfunkel) added a comment to T23135: context.scene not updating correctly.

Wow, a bug report from seven years ago! Since then I've discovered how to wait for the next event loop:

May 7 2017, 10:35 AM · BF Blender, Python

Apr 13 2017

Tom Edwards (artfunkel) added a comment to rBa7b3047cefcb: Datablock ID Properties.

Congratulations!

Apr 13 2017, 8:29 PM

Mar 21 2017

Tom Edwards (artfunkel) awarded rBa3f48d65df19: Datablock ID Properties a Like token.
Mar 21 2017, 9:38 PM

Dec 16 2016

Tom Edwards (artfunkel) added a comment to D113: Datablock ID Properties.

So, besides bunch of comments below, I have two 'high-level' questions.

I) Why IDProp ID usages are not user-counted?
==================================

Can’t see any pros for that, and at least a big cons: if user only uses a given data-block in IDProps, then said data-block won't be saved and will vanish in thin air…

II) Why do we need the ID register (IDP_IDHashTable) at all?
============================================

Afaict, it’s only their to allow finding all IDProp using a given ID. But do we need that? BKE_library_foreach_ID_link and friends should be everything we need here, why make exceptions for IDProps ID usages?

And imho, getting rid of this ghash would seriously simplify handling of ID IDProps, you could get rid of IDP_RelinkProperty, IDP_UnlinkIDProperty, etc.

Dec 16 2016, 6:33 PM

Apr 27 2016

Valiant Valentine (Ikyuv) awarded D113: Datablock ID Properties a Love token.
Apr 27 2016, 6:57 AM

Mar 21 2016

Frank Paul (cardboard) awarded D113: Datablock ID Properties a The World Burns token.
Mar 21 2016, 7:19 PM

Mar 15 2016

Simon Wendsche (BYOB) awarded D113: Datablock ID Properties a Like token.
Mar 15 2016, 11:44 AM

Mar 14 2016

Alexander Romanov (a.romanov) awarded D113: Datablock ID Properties a Love token.
Mar 14 2016, 4:23 PM

Feb 5 2016

Vaclav Cermak (disnel) awarded D113: Datablock ID Properties a Like token.
Feb 5 2016, 11:48 AM

Jan 9 2016

Tom Edwards (artfunkel) added a comment to D113: Datablock ID Properties.

I've been stalked! :D

Jan 9 2016, 6:21 PM
mathieu menuet (bliblubli) awarded D113: Datablock ID Properties a Love token.
Jan 9 2016, 4:40 PM

Dec 18 2015

Tom Edwards (artfunkel) closed T46966: WITH_PYTHON_MODULE builds crash on `import bpy` as Invalid.

Thanks Campbell, it did. I must have forgotten to run the "install" project.

Dec 18 2015, 9:59 PM · BF Blender

Dec 13 2015

Tom Edwards (artfunkel) created T46966: WITH_PYTHON_MODULE builds crash on `import bpy`.
Dec 13 2015, 9:27 PM · BF Blender

Mar 29 2015

Tom Edwards (artfunkel) created T44173: Remove Doubles damages meshes with custom split normal data.
Mar 29 2015, 1:40 PM · BF Blender

Aug 10 2014

Tom Edwards (artfunkel) created T41388: Apply Rotation moves mesh when Rigid Body World is active.
Aug 10 2014, 7:45 PM · BF Blender

Jun 6 2014

Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

Check D113 for the latest on this patch. It does seem to have stalled, unfortunately. I can't do much more on it as I'm now employed as a Modo developer. :-/

Jun 6 2014, 10:31 AM · BF Blender, Python

Mar 22 2014

Tom Edwards (artfunkel) added a comment to T36168: FCurve update method for scripts.

Thanks for the commit!

Mar 22 2014, 7:28 PM · Animation, BF Blender, Python

Feb 7 2014

Tom Edwards (artfunkel) reopened T38541: When built as a Python module, Blender overwrites sys.exit() codes with its own exit code as "Open".
Feb 7 2014, 6:53 PM · Python, BF Blender

Feb 6 2014

Tom Edwards (artfunkel) added a comment to T38364: Patch to Python uuid module to avoid CRT warning on Windows.

Since I added Python 3.3 to the list of affected platforms the bug has been getting a bit of attention, but seeing as it was reported two years ago let's not hold our breath...

Feb 6 2014, 11:05 PM · BF Blender, Python

Jan 29 2014

Tom Edwards (artfunkel) reopened T38400: Crash in image_listener as "Open".
Jan 29 2014, 7:55 PM · User Interface, BF Blender

Jan 28 2014

Tom Edwards (artfunkel) reopened T38386: Alterations to TextLine.body are not added to the text undo buffer as "Open".
Jan 28 2014, 5:35 PM · Text Editor, BF Blender

Jan 25 2014

Tom Edwards (artfunkel) updated the task description for T38364: Patch to Python uuid module to avoid CRT warning on Windows.
Jan 25 2014, 7:07 PM · BF Blender, Python
Tom Edwards (artfunkel) reopened T38364: Patch to Python uuid module to avoid CRT warning on Windows as "Open".
Jan 25 2014, 7:07 PM · BF Blender, Python

Jan 24 2014

Tom Edwards (artfunkel) reopened T38356: Crash when UIList.filter_items returns too few items as "Open".
Jan 24 2014, 9:03 PM · User Interface, BF Blender

Jan 23 2014

Tom Edwards (artfunkel) closed T38146: bpy.data.groups.is_updated non-functional as Resolved.

Closed by commit 1f2136b3.

Jan 23 2014, 7:41 PM · BF Blender, Python
Tom Edwards (artfunkel) reopened T38146: bpy.data.groups.is_updated non-functional as "Open".
Jan 23 2014, 7:41 PM · BF Blender, Python
Tom Edwards (artfunkel) reopened T38337: Depsgraph crash when calling to_mesh() on a Curve object after clearing its parent as "Open".
Jan 23 2014, 3:55 PM · Dependency Graph, BF Blender

Jan 19 2014

Tom Edwards (artfunkel) reopened T38285: Keymap crash when addon has a shortcut as "Open".
Jan 19 2014, 1:22 PM · User Interface, BF Blender

Jan 12 2014

Tom Edwards (artfunkel) added a comment to T38165: Mesh editor does not account for stacked shape keys.

Only one shape key is being edited. My add-on exports to a format that requires corrective shape keys to be relative to the shape combinations they correct, so this is a major issue for my users.

Jan 12 2014, 9:36 PM · BF Blender, Mesh Modeling

Jan 11 2014

Tom Edwards (artfunkel) reopened T38165: Mesh editor does not account for stacked shape keys as "Open".
Jan 11 2014, 4:48 PM · BF Blender, Mesh Modeling

Jan 10 2014

Tom Edwards (artfunkel) reopened T38146: bpy.data.groups.is_updated non-functional as "Open".
Jan 10 2014, 12:18 AM · BF Blender, Python

Jan 1 2014

Tom Edwards (artfunkel) reopened T38016: Object.matrix_world does not account for bone parents as "Open".
Jan 1 2014, 5:41 PM · BF Blender, Python

Dec 17 2013

Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.
Instead of creating an smd_export_list collection, you can create a python set or map to do a quick lookup from the poll callback.
Dec 17 2013, 11:04 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

I'm going to take that last sentence back. There is zero infrastructure for Python callbacks when setting a value from a button; the RNA property is definitely the correct place for it. Anyone writing a cast function will just have to do this:

Dec 17 2013, 7:53 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

The case for cast is subtle: you don't need to cast an ID, but you do need to cast other types provided by UILayout.prop_search. In existing C code the job is done in the set function (more about that in the patch description above).

Dec 17 2013, 2:15 PM · BF Blender, Python

Dec 16 2013

Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

So I prefer option 2, and this can be set at the moment you define the property. The PropertyGroup being a special case is a bit strange, but follows the convention that all data is owned by Blender, there's no loose data, it's either an ID block owned by BlendData or owned by an ID block.

Dec 16 2013, 9:03 PM · BF Blender, Python
Tom Edwards (artfunkel) edited this Maniphest Task.
Dec 16 2013, 7:41 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

I initially went to create a diff, but the diff page suggests that sizeable changes are submitted as patches instead. I've made one now: D113.

Dec 16 2013, 7:32 PM · BF Blender, Python
Tom Edwards (artfunkel) attached 0 file(s) of 1: F41746: idprop_datablock3.patch

Attaching a third version which adds support for copying, linking, and appending.

Dec 16 2013, 5:33 PM · BF Blender, Python

Dec 11 2013

Tom Edwards (artfunkel) attached 0 file(s) of 1: F38443: idprop_datablock2.patch

Attaching an updated patch which keeps a hash set of ID Prop references.

Dec 11 2013, 7:40 PM · BF Blender, Python

Dec 10 2013

Tom Edwards (artfunkel) reopened T37771: Crash when an operator returns PASS_THROUGH instead of RUNNING_MODAL as "Open".
Dec 10 2013, 6:47 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

Sound good, where can I download one? It looks like they are only distributed on DVD?

Dec 10 2013, 12:59 PM · BF Blender, Python

Dec 9 2013

Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

I've run some benchmarks with this script, which creates 9999 empties with 3 DatablockVectorProperties containing two references, all to the same object. It then deletes the pointed-to object.

Dec 9 2013, 11:14 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

The trouble with PointerProperty is that it doesn't currently support assignment, which I presume is because scripters aren't supposed to be creating their own PropertyGroup objects? CollectionProperty is the same.

Dec 9 2013, 7:59 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37754: Patch: DatablockProperty and DatablockVectorProperty.

It's handled on line 191. I'll have to test performance, but I would be surprised to see much of a difference unless loads of datablocks actually have datablock ID-props set.

Dec 9 2013, 4:27 PM · BF Blender, Python
Tom Edwards (artfunkel) reopened T37754: Patch: DatablockProperty and DatablockVectorProperty as "Open".
Dec 9 2013, 3:18 PM · BF Blender, Python
Tom Edwards (artfunkel) added a comment to T37739: template_list UI elements on Nodes don't resize correctly.

Makes sense, but I've found that the overreaction happens to exactly the same extent even when there is only one node in the whole blend. If this is about the resize operation being re-applied for each node then the bug should only appear when there is more than one node, right? I'm also seeing the bug in my current node tree even though each list ID includes the node's name.

Dec 9 2013, 12:58 PM · User Interface, BF Blender

Dec 8 2013

Tom Edwards (artfunkel) reopened T37741: When splitting a Node Editor area containing Python nodes, the new area shows nodes but does not have an active nodetree as "Open".
Dec 8 2013, 10:42 PM · BF Blender, Nodes
Tom Edwards (artfunkel) closed T37738: Active Node is not changed when the user clicks a node UI element as Invalid.

Whoops, I was editing the poll function!

Dec 8 2013, 10:10 PM · Nodes, BF Blender
Tom Edwards (artfunkel) reopened T37738: Active Node is not changed when the user clicks a node UI element as "Open".

context.node is the same as context.active_node. Sounds like that's the bug!

Dec 8 2013, 10:01 PM · Nodes, BF Blender
Tom Edwards (artfunkel) added a comment to T37739: template_list UI elements on Nodes don't resize correctly.

I was going to report a bug about the list heights being shared between nodes, but that can fixed by making using the node's name as the template_list list_id value. :)

Dec 8 2013, 6:10 PM · User Interface, BF Blender
Tom Edwards (artfunkel) reopened T37739: template_list UI elements on Nodes don't resize correctly as "Open".
Dec 8 2013, 6:09 PM · User Interface, BF Blender
Tom Edwards (artfunkel) added a project to T37738: Active Node is not changed when the user clicks a node UI element: Nodes.
Dec 8 2013, 6:04 PM · Nodes, BF Blender
Tom Edwards (artfunkel) reopened T37738: Active Node is not changed when the user clicks a node UI element as "Open".
Dec 8 2013, 6:03 PM · Nodes, BF Blender
Tom Edwards (artfunkel) reopened T37733: Node trees report incorrect Python path as "Open".
Dec 8 2013, 11:23 AM · Nodes, BF Blender

Dec 6 2013

Tom Edwards (artfunkel) reopened T37719: NodeTrees lose users on undo as "Open".
Dec 6 2013, 6:49 PM · Nodes, BF Blender
Tom Edwards (artfunkel) updated the task description for T37709: Memory corruption when freeing custom bone shape objects.
Dec 6 2013, 5:20 PM · BF Blender, Animation
Tom Edwards (artfunkel) added a comment to T37709: Memory corruption when freeing custom bone shape objects.

It turns out that the appearance of console errors differs between builds, but the bug remains. Add a breakpoint at action.c:720 (the id_us_min call in BKE_pose_channel_free) and you'll see that pchan->custom has already been freed.

Dec 6 2013, 2:12 PM · BF Blender, Animation
Tom Edwards (artfunkel) added a comment to T37709: Memory corruption when freeing custom bone shape objects.

Removing the scene won't repro, you need to unload the whole blend file.

Dec 6 2013, 1:07 PM · BF Blender, Animation

Dec 5 2013

Tom Edwards (artfunkel) added a comment to T37709: Memory corruption when freeing custom bone shape objects.

Weird that it's not in Datablocks too, it's right there for me.

Dec 5 2013, 6:19 PM · BF Blender, Animation
Tom Edwards (artfunkel) added a comment to T37709: Memory corruption when freeing custom bone shape objects.

By "freeing custom bone object" I mean that the error occurs while freeing the scene if there are custom bones present. I missed out the all-important repro step #2 of opening a new file, sorry!

Dec 5 2013, 6:03 PM · BF Blender, Animation
Tom Edwards (artfunkel) reopened T37710: Crash when browsing to invalid index with compact template_list as "Open".
Dec 5 2013, 5:56 PM · User Interface, BF Blender
Tom Edwards (artfunkel) attached 0 file(s) of 1: F36579: bone_shape_crash.blend
Dec 5 2013, 4:43 PM · BF Blender, Animation
Tom Edwards (artfunkel) reopened T37709: Memory corruption when freeing custom bone shape objects as "Open".
Dec 5 2013, 4:22 PM · BF Blender, Animation
Tom Edwards (artfunkel) closed T30587: Maximised startup.blend as Invalid.
Dec 5 2013, 3:22 PM · User Interface, BF Blender
Tom Edwards (artfunkel) added a comment to T37698: Crash on .blend unload if it contains Python nodes.

I just tried with a release build and couldn't repro, but it happens 100% with a MSVC debug build.

Dec 5 2013, 2:55 PM · Nodes, BF Blender, Python

Dec 4 2013

Tom Edwards (artfunkel) attached 0 file(s) of 1: F36429: node_crash.blend
Dec 4 2013, 3:13 PM · Nodes, BF Blender, Python
Tom Edwards (artfunkel) reopened T37698: Crash on .blend unload if it contains Python nodes as "Open".
Dec 4 2013, 2:20 PM · Nodes, BF Blender, Python

Nov 25 2013

Tom Edwards (artfunkel) attached 0 file(s) of 1: F32972: audio_sleep2.patch

Here's what I've got so far. It uses some C++11 features, but I read on the mailing list that Audaspace is going to require that soon anyway. :)

Nov 25 2013, 10:48 PM · Platform: Windows, Audio, BF Blender

Nov 21 2013

Tom Edwards (artfunkel) added a comment to T37432: When sound is enabled, Blender prevents Windows from automatically sleeping.

Thanks for getting back!

Nov 21 2013, 4:02 PM · Platform: Windows, Audio, BF Blender

Nov 19 2013

Tom Edwards (artfunkel) attached 0 file(s) of 1: F28765: audio_sleep.patch

Here's a patch that makes context creation and destruction dynamic.

Nov 19 2013, 11:21 AM · Platform: Windows, Audio, BF Blender

Nov 14 2013

Tom Edwards (artfunkel) added a comment to T37432: When sound is enabled, Blender prevents Windows from automatically sleeping.

I agree that shutting the context down after inactivity isn't amazing, but that doesn't seem like much of an argument for not doing it. If it's difficult then could context creation be delayed until required instead?

Nov 14 2013, 2:48 PM · Platform: Windows, Audio, BF Blender
Tom Edwards (artfunkel) reopened T37432: When sound is enabled, Blender prevents Windows from automatically sleeping as "Open".
Nov 14 2013, 1:07 PM · Platform: Windows, Audio, BF Blender