Page MenuHome

Brian Savery (bsavery)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 16 2016, 1:34 AM (223 w, 4 d)

Recent Activity

Tue, Feb 23

Brian Savery (bsavery) added a comment to D10153: AMD Radeon Image Filter denoiser support.

I tried to test this but could not get it working. What I did:

  • Ensured I had a recent enough driver.
  • Got the latest release from here: https://github.com/GPUOpen-LibrariesAndSDKs/RadeonImageFilter
  • Hacked getRadeonSoftwareInstallLocation() to point to a custom location, since I don't have the registry entries. Is there already an installer that sets these? We'll also need a URL for that when we commit this, to mention in the release notes.

I got "Failed to load RadeonImageFilters.dll". The dll exists at the specified location and GetLastError() returns 0, so I'm not immediately sure what to try next, how to get a proper error message.

Tue, Feb 23, 12:29 AM · Render & Cycles

Tue, Feb 9

Brian Savery (bsavery) updated the diff for D10153: AMD Radeon Image Filter denoiser support.

Update based on review.

Tue, Feb 9, 5:59 PM · Render & Cycles

Thu, Feb 4

Effi (BlenderEffi) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Thu, Feb 4, 9:50 AM · Cycles, BF Blender

Tue, Feb 2

silex (silex) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Tue, Feb 2, 3:17 PM · Cycles, BF Blender
silex (silex) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Tue, Feb 2, 3:17 PM · BF Blender (2.90), Render & Cycles, Cycles
Alaska (Alaska) awarded D10153: AMD Radeon Image Filter denoiser support a Love token.
Tue, Feb 2, 7:34 AM · Render & Cycles

Jan 22 2021

Brian Savery (bsavery) added a comment to D10153: AMD Radeon Image Filter denoiser support.

Can we get some more info on the impact on the build system, limitations, etc.

  • The code appear to be Windows only, but the build option exists on all platforms.
Jan 22 2021, 2:22 AM · Render & Cycles

Jan 21 2021

Rafael (DrkCrb) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Like token.
Jan 21 2021, 5:23 PM · Cycles, BF Blender

Jan 20 2021

Brian Savery (bsavery) updated the diff for D10153: AMD Radeon Image Filter denoiser support.

Fixes based on feedback.

Jan 20 2021, 8:24 PM · Render & Cycles
Brian Savery (bsavery) updated the summary of D10153: AMD Radeon Image Filter denoiser support.
Jan 20 2021, 12:25 AM · Render & Cycles
Brian Savery (bsavery) updated the summary of D10153: AMD Radeon Image Filter denoiser support.
Jan 20 2021, 12:15 AM · Render & Cycles
Brian Savery (bsavery) requested review of D10153: AMD Radeon Image Filter denoiser support.
Jan 20 2021, 12:14 AM · Render & Cycles
Brian Savery (bsavery) added a revision to T82559: AMD GPU Denoising via "Radeon Image Filters" library.: D10153: AMD Radeon Image Filter denoiser support.
Jan 20 2021, 12:14 AM · Cycles, BF Blender

Jan 19 2021

Brian Savery (bsavery) changed the subtype of T82559: AMD GPU Denoising via "Radeon Image Filters" library. from "Patch" to "Design".
Jan 19 2021, 8:10 PM · Cycles, BF Blender
Brian Savery (bsavery) changed the subtype of T82559: AMD GPU Denoising via "Radeon Image Filters" library. from "Design" to "Patch".
Jan 19 2021, 8:08 PM · Cycles, BF Blender

Dec 2 2020

Felix Kütt (fkytt) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Grey Medal token.
Dec 2 2020, 6:46 PM · BF Blender (2.90), Render & Cycles, Cycles

Nov 26 2020

Mindinsomnia (mindinsomnia) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Nov 26 2020, 3:17 PM · BF Blender (2.90), Render & Cycles, Cycles

Nov 22 2020

Gilberto Rodrigues (gilberto_rodrigues) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 22 2020, 2:29 AM · Cycles, BF Blender

Nov 18 2020

Andrea Monzini (Andrea_Monzini) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Nov 18 2020, 4:32 PM · BF Blender (2.90), Render & Cycles, Cycles

Nov 13 2020

Deen (Bit) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 13 2020, 6:05 AM · Cycles, BF Blender
Deen (Bit) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Nov 13 2020, 6:04 AM · BF Blender (2.90), Render & Cycles, Cycles

Nov 12 2020

Hadrien Brissaud (hadrien) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 12 2020, 7:46 AM · Cycles, BF Blender
Hadrien Brissaud (hadrien) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Nov 12 2020, 7:45 AM · BF Blender (2.90), Render & Cycles, Cycles

Nov 11 2020

Brian Savery (bsavery) updated the task description for T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series.
Nov 11 2020, 5:12 PM · BF Blender (2.90), Render & Cycles, Cycles
Mindinsomnia (mindinsomnia) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 11 2020, 4:29 AM · Cycles, BF Blender

Nov 10 2020

Brian Savery (bsavery) awarded T82583: Cycles split kernel optimizations a Like token.
Nov 10 2020, 4:05 PM · Cycles, Render & Cycles
Christian Friedrich (rbx775) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 10 2020, 2:30 PM · Cycles, BF Blender
Petr (PetrT) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Like token.
Nov 10 2020, 12:51 PM · BF Blender (2.90), Render & Cycles, Cycles
Paul Larson (GeorgiaPacific) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Nov 10 2020, 5:58 AM · BF Blender (2.90), Render & Cycles, Cycles
Paul Larson (GeorgiaPacific) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 10 2020, 5:56 AM · Cycles, BF Blender
Alaska (Alaska) awarded T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series a Love token.
Nov 10 2020, 4:35 AM · BF Blender (2.90), Render & Cycles, Cycles
Alaska (Alaska) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Love token.
Nov 10 2020, 3:30 AM · Cycles, BF Blender
YAFU (YAFU) awarded T82559: AMD GPU Denoising via "Radeon Image Filters" library. a Like token.
Nov 10 2020, 3:03 AM · Cycles, BF Blender
Brian Savery (bsavery) added a comment to T82559: AMD GPU Denoising via "Radeon Image Filters" library..

Looking for feedback on licensing approach. But as we see it, this is directly in line with the current usage of Optix Denoising library.

Nov 10 2020, 2:44 AM · Cycles, BF Blender
Brian Savery (bsavery) changed the status of T82559: AMD GPU Denoising via "Radeon Image Filters" library. from Needs Triage to Confirmed.
Nov 10 2020, 2:07 AM · Cycles, BF Blender
Brian Savery (bsavery) changed the status of T82557: Cycles OpenCL hardware raytracing intersection for AMD Rx 6000 series from Needs Triage to Confirmed.
Nov 10 2020, 1:58 AM · BF Blender (2.90), Render & Cycles, Cycles

Sep 9 2020

Brian Savery (bsavery) added a comment to T77837: Removing Addon with compiled modules(e.g. cython) on Windows will cause PermissionError: [WinError 5] Access is denied.

Also adding this being an issue with Radeon ProRender addon (only windows). I've tried forcefully unloading DLL but so far unsuccessfully.

Sep 9 2020, 12:54 AM · Python API, BF Blender

May 8 2020

Brian Savery (bsavery) added a comment to T76490: Included USD libraries cause symbol conflict with addons using USD binding.

Yep will test. Here's what I've done so far:

May 8 2020, 3:34 PM · Pipeline, Assets & I/O, BF Blender
Brian Savery (bsavery) added a comment to T76490: Included USD libraries cause symbol conflict with addons using USD binding.

Might this be related to https://developer.blender.org/T76442 ?

May 8 2020, 4:13 AM · Pipeline, Assets & I/O, BF Blender

May 7 2020

Brian Savery (bsavery) changed the status of T76490: Included USD libraries cause symbol conflict with addons using USD binding from Resolved to Invalid.

Not sure about status how that got changed. Sybren marked it in valid, which I think is erroneous.

May 7 2020, 3:04 PM · Pipeline, Assets & I/O, BF Blender
Brian Savery (bsavery) added a comment to T76490: Included USD libraries cause symbol conflict with addons using USD binding.

Furthermore. After filing this I am able to work around this by building blender from source without USD support (which obviously removes the symbol conflict), but I would claim that's not a valid workaround for most users

May 7 2020, 3:02 PM · Pipeline, Assets & I/O, BF Blender
Brian Savery (bsavery) changed the status of T76490: Included USD libraries cause symbol conflict with addons using USD binding from Invalid to Resolved.

You're mistaken about the python3 compatibility:
https://github.com/PixarAnimationStudios/USD/blob/master/CHANGELOG.md#build
USD 20.05 supports Python 3:
"Added support for Python 3. This may be enabled by specifying PXR_USE_PYTHON_3=TRUE when running cmake or by running build_usd.py with Python 3."

May 7 2020, 2:58 PM · Pipeline, Assets & I/O, BF Blender
Brian Savery (bsavery) updated the task description for T76490: Included USD libraries cause symbol conflict with addons using USD binding.
May 7 2020, 4:19 AM · Pipeline, Assets & I/O, BF Blender
Brian Savery (bsavery) updated the task description for T76490: Included USD libraries cause symbol conflict with addons using USD binding.
May 7 2020, 4:05 AM · Pipeline, Assets & I/O, BF Blender
Brian Savery (bsavery) created T76490: Included USD libraries cause symbol conflict with addons using USD binding.
May 7 2020, 4:04 AM · Pipeline, Assets & I/O, BF Blender

Mar 6 2020

Brian Savery (bsavery) added a comment to D7053: Add methods foreach_get() and foreach_set() to pyrna_prop_array class for fast access to array data..

Fyi @Campbell Barton (campbellbarton) and @Bastien Montagne (mont29) Bogdan works on the ProRender plugin with us at AMD. But this should be useful for most plugins/users of the Python api.

Mar 6 2020, 8:47 PM

Jan 21 2020

Brian Savery (bsavery) added a comment to T68774: VFX Reference Platform 2020 Compatibility.

PyQt has been used for many tools within Tangent since Next Gen. The Blender UI toolkit is too limiting for certain kinds of interfaces that PyQt makes trivial.
The main loop of PyQt was fixed specifically to allow for this kind of foreign embedding many, many versions ago and requires very little code to get going. The main issues tends to be around uncaught exceptions and some threading shenanigans but it’s very doable.

Jan 21 2020, 5:02 PM · Platforms, Builds, Tests & Devices, BF Blender (2.82)

Nov 20 2019

Brian Savery (bsavery) added a comment to T68774: VFX Reference Platform 2020 Compatibility.

Strictly speaking about the Python 3.8 decision, I think this comment hit it on the head.

Nov 20 2019, 6:37 PM · Platforms, Builds, Tests & Devices, BF Blender (2.82)

Jul 17 2019

Brian Savery (bsavery) added a comment to T66848: Blender 2.8 crash with AMD RX 5700 Series GPU's.

https://www.amd.com/en/support/kb/release-notes/rn-rad-win-19-7-2 should fix it I am told.

Jul 17 2019, 2:01 AM · BF Blender

Jul 15 2019

Brian Savery (bsavery) added a comment to T66986: macOS code signed release errors with Python ctypes.

Thanks @Brecht Van Lommel (brecht) That seems to do the trick.

Jul 15 2019, 11:36 PM · Platform: macOS, BF Blender
Brian Savery (bsavery) added a comment to T66986: macOS code signed release errors with Python ctypes.

Hi @Brecht Van Lommel (brecht) . I'm still seeing an issue with that link you sent.

Jul 15 2019, 9:49 PM · Platform: macOS, BF Blender

Jun 21 2017

Brian Savery (bsavery) added a comment to T51859: PxrProjectionLayer node added instead of the Image Texture node in Cycles.

Why should it be creating it own? We use the native nodetree for various reasons:

Jun 21 2017, 5:40 PM · BF Blender
Brian Savery (bsavery) added a comment to T51849: Principled Roughness & Clearcoat Gloss are opposites of each other?.

I can buy Brecht's argument. There is however something to be said for keeping to the original paper for compatibility with other renderers that implement it, and wanting to keep the settings the same.

Jun 21 2017, 6:57 AM · Cycles, User Interface, BF Blender

Jun 20 2017

Brian Savery (bsavery) added a comment to T51849: Principled Roughness & Clearcoat Gloss are opposites of each other?.

@Brecht Van Lommel (brecht) Isn't compatibility with other renderers THE reason for leaving it as it now? I.e, many other renderers have a Disney/principled shader, so if you want to match look you have to do a 1 - n to on this one setting.

Jun 20 2017, 6:25 PM · Cycles, User Interface, BF Blender

Dec 21 2016

Brian Savery (bsavery) added a comment to T47811: Blender 2.8x / Python, Proposed Changes.

1/ "Use Python 3.6 Literal String Interpolation for all string formatting."
Q1/ Will the move to Python 3.6 Break many addons?

Very unlikely, I don't think Python upgrades caused many problems previously?

Dec 21 2016, 11:31 PM · BF Blender: 2.8, Add-ons (BF-Blender)

Nov 16 2016

Brian Savery (bsavery) added a comment to T50042: "Install Addon from File" Fail on Windows if zip file has "." in name.

Ok sorry for the duplicate, I couldn't find another report of this. The one thing I will say is that releases from github that have a version tag on them will automatically get a "." in them, which is why this came up. I changed the release to delimit with _ in the tag.

Nov 16 2016, 2:22 PM · Add-ons (Community), Platform: Windows, BF Blender
Brian Savery (bsavery) added a comment to T50042: "Install Addon from File" Fail on Windows if zip file has "." in name.

Error is <!> event has invalid window.

Nov 16 2016, 1:44 AM · Add-ons (Community), Platform: Windows, BF Blender
Brian Savery (bsavery) created T50042: "Install Addon from File" Fail on Windows if zip file has "." in name.
Nov 16 2016, 1:43 AM · Add-ons (Community), Platform: Windows, BF Blender