Page MenuHome

Laurent Noel (c2ba)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2019, 11:53 AM (79 w, 5 d)

Recent Activity

Jul 30 2020

Laurent Noel (c2ba) added a comment to T71486: Support for keeping preferences of disabled add-ons.

I think this task might be important for a production context.

Jul 30 2020, 12:54 PM · Restricted Project, User Interface, Python API

Jul 21 2020

Laurent Noel (c2ba) awarded T71486: Support for keeping preferences of disabled add-ons a Love token.
Jul 21 2020, 5:17 PM · Restricted Project, User Interface, Python API

Jul 16 2020

Laurent Noel (c2ba) added a comment to T78999: Segmentation fault when setting `D.scenes[0].sequence_editor.proxy_storage` with a second scene selected having no sequence editor.

It also happen for the proxy_dir property.

Jul 16 2020, 7:24 PM · Video Sequencer, Python API, BF Blender
Laurent Noel (c2ba) created T78999: Segmentation fault when setting `D.scenes[0].sequence_editor.proxy_storage` with a second scene selected having no sequence editor.
Jul 16 2020, 6:41 PM · Video Sequencer, Python API, BF Blender

May 26 2020

Laurent Noel (c2ba) removed a watcher for BF Blender (2.82): Laurent Noel (c2ba).
May 26 2020, 12:14 PM
Laurent Noel (c2ba) removed a watcher for BF Blender (2.83): Laurent Noel (c2ba).
May 26 2020, 12:14 PM
Laurent Noel (c2ba) removed a watcher for Blender Cloud: Laurent Noel (c2ba).
May 26 2020, 12:13 PM
Laurent Noel (c2ba) removed a watcher for Cycles: Laurent Noel (c2ba).
May 26 2020, 12:12 PM

May 6 2020

Laurent Noel (c2ba) awarded D7635: Fixed the openxr state freeze when removing and then putting back on the oculus helmet. a Love token.
May 6 2020, 12:02 PM

Apr 17 2020

Laurent Noel (c2ba) added a comment to T71420: Using PyPI from Blender.

I think it would be great if the addon system of Blender could handle pip dependencies of addons in a pythonic way, from a requirements.txt file or setup.py file (would be great to support both). When an addon is loaded by the system, Blender could detect if one of these file exists and:

  • Check if dependencies are already installed
  • If not, notify the user that some dependencies needs to be installed, tell him where they will be installed and ask for confirmation
  • Call pip to install dependencies, and report errors with advices if some occur
Apr 17 2020, 10:35 AM · Python API

Feb 11 2020

Laurent Noel (c2ba) awarded D6250: Fix T43835, T54284: Cycles with no ray offsetting a Love token.
Feb 11 2020, 9:57 AM · Render & Cycles, BF Blender (2.83), Cycles

Feb 9 2020

Laurent Noel (c2ba) added a comment to D6776: Cleanup: File Naming Use "utils" instead of "util".

Please don't.
Refactors like this are a huge annoyance for people maintaining branches and patches that haven't been merged yet. I don't see how replacing "util" with "utils" is supposed to be an improvement, the only thing it does is create a lot of unnecessary work and noise in the git history.

Feb 9 2020, 2:50 PM · BF Blender

Feb 7 2020

Laurent Noel (c2ba) updated the diff for D6776: Cleanup: File Naming Use "utils" instead of "util".

Update header guards to match file names

Feb 7 2020, 7:48 PM · BF Blender
Laurent Noel (c2ba) added a reviewer for D6776: Cleanup: File Naming Use "utils" instead of "util": Brecht Van Lommel (brecht).
Feb 7 2020, 6:19 PM · BF Blender
Laurent Noel (c2ba) updated the diff for D6776: Cleanup: File Naming Use "utils" instead of "util".

Rebase on master

Feb 7 2020, 6:12 PM · BF Blender
Laurent Noel (c2ba) updated the diff for D6776: Cleanup: File Naming Use "utils" instead of "util".

Revert changes on extern/ files

Feb 7 2020, 6:05 PM · BF Blender
Pipeliner (Pipeliner) awarded D6776: Cleanup: File Naming Use "utils" instead of "util" a Hungry Hippo token.
Feb 7 2020, 5:40 PM · BF Blender
Hans Goudey (HooglyBoogly) awarded D6776: Cleanup: File Naming Use "utils" instead of "util" a Love token.
Feb 7 2020, 5:31 PM · BF Blender
Laurent Noel (c2ba) created D6776: Cleanup: File Naming Use "utils" instead of "util".
Feb 7 2020, 5:28 PM · BF Blender
Laurent Noel (c2ba) awarded T73586: Code Quality Day Tasks a Love token.
Feb 7 2020, 3:23 PM · Development Management, BF Blender
Laurent Noel (c2ba) added a comment to T73586: Code Quality Day Tasks.

Not 100% sure, but after reading math_geom.c, I find no issue related to "Disambiguate term "Line" in BLI_math.h"
The example given:

closest_to_line_v2 clamps between the two points, where line_point_factor_v3_ex doesn't.

does not apply here: line_point_factor_v3_ex actually returns a signed factor x such that the projection c of p on the line (l1,l2) can be obtained with c = l1 + x * (l2 - l1), but it's not clamped at all by the function so it is indeed a line that the function acts on.
The functions that clamp the projection are closest_to_line_segment_v and are called by functions dist_*_to_line_segment_v*, so everything is correctly named here.
So maybe I'm missing something, but I think this task can be removed from the description.

Feb 7 2020, 2:52 PM · Development Management, BF Blender

Jan 18 2020

Laurent Noel (c2ba) added a watcher for Cycles: Laurent Noel (c2ba).
Jan 18 2020, 10:08 AM

Dec 17 2019

Laurent Noel (c2ba) added a comment to D6412: Improve naming coherency for FileOutput Node inputs..
  • Do we support relative paths that does not fit as layer name. eg do the naming convention match.
Dec 17 2019, 11:34 AM
Laurent Noel (c2ba) updated subscribers of D6412: Improve naming coherency for FileOutput Node inputs..

Hi Jeroen :)

  • Why don't we merge the sockdata->path and sockdata->layer to a single structure? The original developer was CPP oriented, but perhaps a more C-approach would help.
  • Should we then remove the whole path and layer and just use sock->name? I do beleive we should not store the same value multiple times as that leads to more maintenance.

Agree, I was wondering why it was needed to have two list of names (even three if we consider names of the sockets). I can work on that.

  • Do we support relative paths that does not fit as layer name. eg do the naming convention match.

I will check that today.

Dec 17 2019, 9:26 AM
Laurent Noel (c2ba) added a comment to D6423: File Output Node in compositing, all socket inputs have the same name in Python.

Done the same fix as part of https://developer.blender.org/D6412

Dec 17 2019, 9:16 AM

Dec 16 2019

Laurent Noel (c2ba) edited projects for T72433: Colored outline artifacts in diffuse direct pass (Cycles), added: Cycles; removed BF Blender.
Dec 16 2019, 10:31 AM · Render & Cycles, BF Blender, Cycles

Dec 14 2019

Niko Maisuradze (BlackRainbow) awarded D6412: Improve naming coherency for FileOutput Node inputs. a Love token.
Dec 14 2019, 11:58 AM

Dec 13 2019

Laurent Noel (c2ba) created T72433: Colored outline artifacts in diffuse direct pass (Cycles).
Dec 13 2019, 9:37 PM · Render & Cycles, BF Blender, Cycles
Laurent Noel (c2ba) added a reviewer for D6412: Improve naming coherency for FileOutput Node inputs.: Jeroen Bakker (jbakker).
Dec 13 2019, 9:08 PM
Laurent Noel (c2ba) created D6412: Improve naming coherency for FileOutput Node inputs..
Dec 13 2019, 9:06 PM

Dec 4 2019

Laurent Noel (c2ba) awarded D6352: UI: Add tooltips for modifiers a Like token.
Dec 4 2019, 10:46 AM · User Interface

Nov 27 2019

Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

I quickly tried your fix on a sphere. The parameter is animated from 0 to 1 over 100 frames. It seems to work well but need to be fine tuned to get rid of artifacts while not loosing too much lighting. I also get funny results starting from shadow_terminator_offset = 0.67 approximately :p

Nov 27 2019, 8:28 PM · Render & Cycles, Cycles, BF Blender

Nov 26 2019

Laurent Noel (c2ba) added a watcher for BF Blender (2.82): Laurent Noel (c2ba).
Nov 26 2019, 11:46 AM
Laurent Noel (c2ba) added a watcher for BF Blender (2.83): Laurent Noel (c2ba).
Nov 26 2019, 11:46 AM

Oct 21 2019

Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

RedShift: Shadow ray bias derived from triangle size and the deviation between geometric and shading normal
https://docs.redshift3d.com/display/RSDOCS/Shadow+Ray+Biasing

Oct 21 2019, 11:07 AM · Render & Cycles, Cycles, BF Blender

Oct 18 2019

Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

It seems strongly influenced by the normal adjustment that was introduced in: https://developer.blender.org/D2574
For example by removing the line https://developer.blender.org/differential/changeset/?ref=147520 I get the following image:


For comparison, I have this without remove the line:

Oct 18 2019, 3:55 PM · Render & Cycles, Cycles, BF Blender
Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

Tried with Luxrender, it does not have the problem:

  • Lux:

  • Cycles:

Oct 18 2019, 2:58 AM · Render & Cycles, Cycles, BF Blender
Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

The test you suggested of adding extra subdivisions in edit mode should result in the shading artefacts because there's more geometry between the original edges. The same way you would intentionally add a hard edge by putting two edges close together.

Oct 18 2019, 2:24 AM · Render & Cycles, Cycles, BF Blender

Oct 17 2019

Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

I'm not really sure but I think it might be related to the linear interpolation of the vertex normals on the face, that does not match the true normals a circle would have (correct me if I'm wrong). So each face get a set of interpolated normals that is slightly wrong, and since the interpolated normal is used to build the shading normal with the tangent normal map, correlation artifacts appear.
Try the following: build a cylinder in blender, remove the top and bottom faces, then in edit mode select all faces and subdivide them multiple time. Put your cylinder in smooth shading and you will see the the individual original low res faces appear, even with opengl rendering.
I guess this is because the new vertices created with subdivision have a normal computed from linear interpolation, but I'm not familiar with subdivision algorithms in general and the one used by blender in edit mode so I can only guess. Try to display the normals on edit mode with the overlay, you will see that the normals of the newly created vertices do not create a perfect circular pattern.

Oct 17 2019, 7:19 PM · Render & Cycles, Cycles, BF Blender
Laurent Noel (c2ba) updated subscribers of T68920: Reduce shadow terminator artifacts.

Yeah the problem of shadow terminator for normal maps seems to be fixed thanks to https://developer.blender.org/D5399

Oct 17 2019, 3:10 PM · Render & Cycles, Cycles, BF Blender

Oct 16 2019

Laurent Noel (c2ba) added a watcher for Blender Cloud: Laurent Noel (c2ba).
Oct 16 2019, 3:18 PM

Oct 11 2019

Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

I'd prefer us to first try a better solution, like ignoring backfaces, which may not be all that complicated.

Also as described in T37814#773025, this needs changes in BSDF evaluation too.

Oct 11 2019, 6:24 PM · Render & Cycles, Cycles, BF Blender

Oct 10 2019

Laurent Noel (c2ba) awarded D6039: Ignore this diff a Love token.
Oct 10 2019, 2:01 PM

Oct 2 2019

Laurent Noel (c2ba) added a comment to T68920: Reduce shadow terminator artifacts.

To address this issue, what do you think about adding a "shadow bias" parameter to control an offset from the surface along the geometric normal ? I know its not a perfect solution but at least it would allow users to avoid a lot of rendering artifacts that are due to shadow termination.

Oct 2 2019, 5:41 PM · Render & Cycles, Cycles, BF Blender

Sep 25 2019

Laurent Noel (c2ba) added a reviewer for D5896: Fill ProductVersion of blender executable on Windows: BF Blender.
Sep 25 2019, 7:05 PM · BF Blender (2.81)
Laurent Noel (c2ba) created D5896: Fill ProductVersion of blender executable on Windows.
Sep 25 2019, 7:04 PM · BF Blender (2.81)

Sep 4 2019

Laurent Noel (c2ba) added a comment to D4837: Cycles: Add support for adding custom AOV render passes.

I was wondering if the addition of OSL AOVs enables Light Path Expressions in Cycles and if not how complicated would that be to impliment?
LPE's are invaluable in production and used widely in path tracers for a range of custom AOVs and light select passes.

Sep 4 2019, 5:03 PM · BF Blender (2.82), Render & Cycles

May 13 2019

Laurent Noel (c2ba) changed the status of T64391: Adding a "generate" modifier to a curve object leads to a crash from Unknown Status to Resolved.

Hi, It seems the issue is solved in the build "version: 2.80 (sub 61), branch: blender2.7, commit date: 2019-05-12 22:25, hash: rB05f1451d7248", thank you for looking at this :)

May 13 2019, 11:25 AM · BF Blender

May 9 2019

Laurent Noel (c2ba) created T64394: "Weight paint" interaction mode provides no feedback on painting.
May 9 2019, 4:40 PM · BF Blender
Laurent Noel (c2ba) updated the task description for T64391: Adding a "generate" modifier to a curve object leads to a crash.
May 9 2019, 4:32 PM · BF Blender
Laurent Noel (c2ba) created T64393: Crash when selecting "UV Editing" or "Texture Paint" workspaces.
May 9 2019, 4:31 PM · BF Blender
Laurent Noel (c2ba) created T64391: Adding a "generate" modifier to a curve object leads to a crash.
May 9 2019, 3:10 PM · BF Blender