Page MenuHome

Charlie Jolly (charlie)
User

Projects

User Details

User Since
Jul 29 2008, 1:46 AM (540 w, 6 d)

Recent Activity

Yesterday

Charlie Jolly (charlie) committed rB8582a432a597: GP: Add support for drawing control points [wip] (authored by Charlie Jolly (charlie)).
GP: Add support for drawing control points [wip]
Sun, Dec 9, 2:00 AM

Sat, Dec 8

Charlie Jolly (charlie) committed rB71f8d998c407: GP: Allocate stroke memory only when required (authored by Charlie Jolly (charlie)).
GP: Allocate stroke memory only when required
Sat, Dec 8, 12:18 PM

Fri, Dec 7

Charlie Jolly (charlie) committed rBd778b0cc00ee: Merge branch 'greasepencil-object' of git.blender.org:blender into greasepencil… (authored by Charlie Jolly (charlie)).
Merge branch 'greasepencil-object' of git.blender.org:blender into greasepencil…
Fri, Dec 7, 11:12 PM
Charlie Jolly (charlie) committed rB9b429d721c98: GP: Changes to bezier curve tool (authored by Charlie Jolly (charlie)).
GP: Changes to bezier curve tool
Fri, Dec 7, 11:12 PM
Charlie Jolly (charlie) committed rB7690ab09ad8e: add 'Control Points' and 'Segments' editmode menus for Surfaces (authored by Philipp Oeser (lichtwerk)).
add 'Control Points' and 'Segments' editmode menus for Surfaces
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB4685cb6885fc: GP: Fix merge errors (authored by Charlie Jolly (charlie)).
GP: Fix merge errors
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBa01ccd09a87b: Update BVHTree.FromObject API, remove render argument (authored by Dalai Felinto (dfelinto)).
Update BVHTree.FromObject API, remove render argument
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBe03fd3c44694: Cycles: Do more user-friendly indication that GPU devices are not found (authored by Sergey Sharybin (sergey)).
Cycles: Do more user-friendly indication that GPU devices are not found
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBfbeae890718e: Cycles: Disable OpenCL on macOS (authored by Sergey Sharybin (sergey)).
Cycles: Disable OpenCL on macOS
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBa17abec24bcc: Fix T58902: error getting tools for Image Editor (modes Paint and Mask) (authored by Philipp Oeser (lichtwerk)).
Fix T58902: error getting tools for Image Editor (modes Paint and Mask)
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB9c509d6b51e7: Fix T57640: UV unwrap packing not working without sync selection. (authored by Brecht Van Lommel (brecht)).
Fix T57640: UV unwrap packing not working without sync selection.
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB4c41f8e9ad30: Partial fix to T58917 - No valid cage (authored by Dalai Felinto (dfelinto)).
Partial fix to T58917 - No valid cage
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBe7b9d49e916b: Fix/workaround crash opening almost any Spring file (authored by Sergey Sharybin (sergey)).
Fix/workaround crash opening almost any Spring file
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB1b1b28f4bd36: GP: Refactor coordinates to float (authored by Charlie Jolly (charlie)).
GP: Refactor coordinates to float
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBf6a0a8b89eed: Depsgraph: Make data allocation dependency more robust (authored by Sergey Sharybin (sergey)).
Depsgraph: Make data allocation dependency more robust
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB6646d1a8c648: Depsgraph: Use shorter relation name (authored by Sergey Sharybin (sergey)).
Depsgraph: Use shorter relation name
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB5ee8111f159b: Depsgraph: Cleanup, line length (authored by Sergey Sharybin (sergey)).
Depsgraph: Cleanup, line length
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rBc11cfa80726a: Depsgraph: Remove duplicated sets of recalc/update flags (authored by Sergey Sharybin (sergey)).
Depsgraph: Remove duplicated sets of recalc/update flags
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB3323693ea0b3: Fix T58046: Crash when changing Particle type, when Hair has dynamics (authored by Philipp Oeser (lichtwerk)).
Fix T58046: Crash when changing Particle type, when Hair has dynamics
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB0e906278616e: Cleanup/refactor binding code for MeshDeform modifier. (authored by Bastien Montagne (mont29)).
Cleanup/refactor binding code for MeshDeform modifier.
Fri, Dec 7, 5:16 PM
Charlie Jolly (charlie) committed rB4ff30177addb: Cleanup: split mixed_bones_object_selectbuffer (authored by Campbell Barton (campbellbarton)).
Cleanup: split mixed_bones_object_selectbuffer
Fri, Dec 7, 5:15 PM
Charlie Jolly (charlie) committed rB16ae5375fd25: Cleanup: style (authored by Campbell Barton (campbellbarton)).
Cleanup: style
Fri, Dec 7, 5:15 PM
Charlie Jolly (charlie) committed rBa2201c870e23: Fix T58913 Won't focus on Grease Pencil (authored by Antonio Vazquez (antoniov)).
Fix T58913 Won't focus on Grease Pencil
Fri, Dec 7, 5:15 PM
Charlie Jolly (charlie) committed rBdf1066932147: Fix T58911: Picking objects fails in pose mode (authored by Campbell Barton (campbellbarton)).
Fix T58911: Picking objects fails in pose mode
Fri, Dec 7, 5:15 PM
Charlie Jolly (charlie) committed rBcc41bfb65c75: Fix T58811: Scale bezier handle uses tip as origin (authored by Campbell Barton (campbellbarton)).
Fix T58811: Scale bezier handle uses tip as origin
Fri, Dec 7, 5:15 PM
Charlie Jolly (charlie) committed rB8cfc8e634754: GP: Fix multi-segment curve (authored by Charlie Jolly (charlie)).
GP: Fix multi-segment curve
Fri, Dec 7, 3:18 PM
Charlie Jolly (charlie) committed rBf23bd736de8f: GP: Curve edit mode is now default after initial line (authored by Charlie Jolly (charlie)).
GP: Curve edit mode is now default after initial line
Fri, Dec 7, 1:27 PM
Charlie Jolly (charlie) committed rBad47b0236e32: GP: Refactor coordinates to float (authored by Charlie Jolly (charlie)).
GP: Refactor coordinates to float
Fri, Dec 7, 12:46 PM
Charlie Jolly (charlie) closed D4036: GP: Refactor coordinates to float.
Fri, Dec 7, 12:46 PM
Charlie Jolly (charlie) updated the diff for D4036: GP: Refactor coordinates to float.

Fixed issue with cursor, was customdata cast as int

Fri, Dec 7, 12:20 PM

Thu, Dec 6

Charlie Jolly (charlie) added a comment to rB454563ffac60: GP: Add bezier tool [wip].

The AKEY was working in main branch, see gif. I'll need to look into why that has broken in this branch.

Thu, Dec 6, 7:28 PM
Charlie Jolly (charlie) added a comment to rB454563ffac60: GP: Add bezier tool [wip].

With Akey, you can create a new curve starting at the end of the previous curve.

Thu, Dec 6, 7:21 PM
Charlie Jolly (charlie) committed rBfec794bd3e4a: GP: Bezier tidy (authored by Charlie Jolly (charlie)).
GP: Bezier tidy
Thu, Dec 6, 7:18 PM
Charlie Jolly (charlie) updated subscribers of rB454563ffac60: GP: Add bezier tool [wip].

@Antonio Vazquez (antoniov) The AKEY behaviour is currently broken in this branch but that might have something to do with the changes you made to real drawing. I've left the option in. The AKEY works but the previous stroke is not rendered until the modal is finished.

Thu, Dec 6, 6:18 PM
Charlie Jolly (charlie) committed rB454563ffac60: GP: Add bezier tool [wip] (authored by Charlie Jolly (charlie)).
GP: Add bezier tool [wip]
Thu, Dec 6, 6:12 PM
Charlie Jolly (charlie) updated the diff for D4036: GP: Refactor coordinates to float.

Git issue, lost some changes

Thu, Dec 6, 4:32 PM
Charlie Jolly (charlie) updated the diff for D4036: GP: Refactor coordinates to float.

Fix GPU format and address comments

Thu, Dec 6, 4:22 PM
Charlie Jolly (charlie) added a comment to T58777: [WIP] GP Bezier Tool Design.

@Antonio Vazquez (antoniov) Ok, I'll get setup on the greasepencil-object branch.

Thu, Dec 6, 11:29 AM · Grease Pencil
chris stagg (toranzufajinzu) awarded T58777: [WIP] GP Bezier Tool Design a Love token.
Thu, Dec 6, 12:21 AM · Grease Pencil

Wed, Dec 5

Mohamed El Hamd (elbox01) awarded T58777: [WIP] GP Bezier Tool Design a Love token.
Wed, Dec 5, 11:35 PM · Grease Pencil
Charlie Jolly (charlie) added reviewers for D4036: GP: Refactor coordinates to float: Antonio Vazquez (antoniov), Grease Pencil.

This patch changes the point storage to floats. The changes are limited to GP only. Not touched ED_ or BLI_ functions. This does mean that there are quite a few casts but from my limited testing I've not had any issues so far.

Wed, Dec 5, 7:55 PM
Charlie Jolly (charlie) created D4036: GP: Refactor coordinates to float.
Wed, Dec 5, 7:48 PM
Charlie Jolly (charlie) committed rB21de12565706: GP: Add icon for Arc primitive (authored by Charlie Jolly (charlie)).
GP: Add icon for Arc primitive
Wed, Dec 5, 5:04 PM
Charlie Jolly (charlie) committed rB94503efb1265: GP: Fix precision issue with Circle and Arc tools (authored by Charlie Jolly (charlie)).
GP: Fix precision issue with Circle and Arc tools
Wed, Dec 5, 4:59 PM
Charlie Jolly (charlie) closed D4030: GP: Fix precision issue with Circle and Arc tools.
Wed, Dec 5, 4:59 PM
Charlie Jolly (charlie) updated the diff for D4030: GP: Fix precision issue with Circle and Arc tools.

Remove unused variable

Wed, Dec 5, 4:58 PM
Charlie Jolly (charlie) added a comment to D4030: GP: Fix precision issue with Circle and Arc tools.

@Brecht Van Lommel (brecht) I've noted your comment.

Wed, Dec 5, 4:31 PM
Charlie Jolly (charlie) added a comment to T58777: [WIP] GP Bezier Tool Design.

I suppose there are two aspects, one from artists and one from a technical point of view.

Wed, Dec 5, 4:09 PM · Grease Pencil
Charlie Jolly (charlie) added a comment to T58777: [WIP] GP Bezier Tool Design.

Polyline using AKEY to add a new line.
New ring cursor for moving line ends,

Wed, Dec 5, 3:23 PM · Grease Pencil
Charlie Jolly (charlie) added a project to T58777: [WIP] GP Bezier Tool Design: Grease Pencil.
Wed, Dec 5, 12:20 PM · Grease Pencil
Charlie Jolly (charlie) added a comment to D4024: GP: Draw Mode: Add Arc Primitive.

Charlie Jolly. Oh, I can see. Sorry for the misunderstanding and thanks to all of you.

I am testing the patch and it looks very good. Thank you.
I do not know if you know MyPaint and Lines and Curves tool (or continuous lines and curves tool). I am missing here the possibility of changing the position and curvature of the curve, as Shift key works in MyPaint. I'm not sure if I can put the link here, but MyPaint wiki explains it well. Perhaps those modifications are planned to do it in Edit or Sculpt mode with GP, and not while curve is drawn? It would be nice to be able to modify these things of the curve while you draw in Draw mode, but anyway it looks good as it is now.

Yes, I love this maypaint feature, in fact are in my wish list and I have some ideas to improve this but as Antonio said is too much for beta stage, need a good desing and testing.

Daniel

Wed, Dec 5, 11:16 AM
Charlie Jolly (charlie) added a comment to T58777: [WIP] GP Bezier Tool Design.

I've got a patch for adding a gp bezier tool based on the MyPaint curve tool.

Wed, Dec 5, 11:04 AM · Grease Pencil
Charlie Jolly (charlie) created T58777: [WIP] GP Bezier Tool Design.
Wed, Dec 5, 10:54 AM · Grease Pencil

Tue, Dec 4

Charlie Jolly (charlie) updated the diff for D4030: GP: Fix precision issue with Circle and Arc tools.

Tidier fix for consideration.

Tue, Dec 4, 8:37 PM
Charlie Jolly (charlie) updated the diff for D4030: GP: Fix precision issue with Circle and Arc tools.
Tue, Dec 4, 8:35 PM
Charlie Jolly (charlie) added a comment to D4030: GP: Fix precision issue with Circle and Arc tools.

@Brecht Van Lommel (brecht)
@Antonio Vazquez (antoniov)
Reverting D4024 is understandable but that still leaves the issue with the circle tool unresolved for 2.80.
I'll upload a new diff for consideration which is less hacky :P and isolates the code from the other GP areas.

Tue, Dec 4, 8:30 PM
Charlie Jolly (charlie) added a comment to D4030: GP: Fix precision issue with Circle and Arc tools.

Why not replace the integer coordinates by float coordinates?

Tue, Dec 4, 6:16 PM
Charlie Jolly (charlie) added a comment to D4024: GP: Draw Mode: Add Arc Primitive.

See D4030 for proposed fix to precision issue.

Tue, Dec 4, 4:52 PM
Charlie Jolly (charlie) added reviewers for D4030: GP: Fix precision issue with Circle and Arc tools: Antonio Vazquez (antoniov), Grease Pencil.

@Antonio Vazquez (antoniov)
Here is a proposed fix. I've extended the tGPspoint struct and gp_stroke_convertcoords_tpoint function to accept float coordinates.
This is used by the fill tool too but I've not looked into that area.

Tue, Dec 4, 4:26 PM
Charlie Jolly (charlie) created D4030: GP: Fix precision issue with Circle and Arc tools.
Tue, Dec 4, 4:21 PM
Charlie Jolly (charlie) added a comment to D4024: GP: Draw Mode: Add Arc Primitive.

@William Reynish (billreynish) thank you, assuming I just add it as a commit

Tue, Dec 4, 10:49 AM
Charlie Jolly (charlie) added a comment to D4024: GP: Draw Mode: Add Arc Primitive.

They’re drawn in the same way as the circle, as a series of points. It might be a limitation of the way gp strokes are drawn. I’ll investigate.

Tue, Dec 4, 10:23 AM
Takahiro Komatsu (Allosteric) awarded rB2c19c9b2f646: GP: Draw Mode: Add Arc Primitive a Like token.
Tue, Dec 4, 1:33 AM

Mon, Dec 3

Charlie Jolly (charlie) committed rB2c19c9b2f646: GP: Draw Mode: Add Arc Primitive (authored by Charlie Jolly (charlie)).
GP: Draw Mode: Add Arc Primitive
Mon, Dec 3, 11:15 PM
Charlie Jolly (charlie) closed D4024: GP: Draw Mode: Add Arc Primitive.
Mon, Dec 3, 11:15 PM
Charlie Jolly (charlie) updated the diff for D4024: GP: Draw Mode: Add Arc Primitive.

Fix issue with flip and wheelmouse.

Mon, Dec 3, 6:19 PM
Charlie Jolly (charlie) added a comment to D4024: GP: Draw Mode: Add Arc Primitive.

@YAFU (YAFU)
I checked the MyPaint curve tool and I see what you mean, That's a bezier curve which remains active after creation. This is an arc which is a different sort of curve.

Mon, Dec 3, 5:33 PM
Charlie Jolly (charlie) added reviewers for D4024: GP: Draw Mode: Add Arc Primitive: Antonio Vazquez (antoniov), Grease Pencil.

Mon, Dec 3, 3:57 PM
Charlie Jolly (charlie) created D4024: GP: Draw Mode: Add Arc Primitive.
Mon, Dec 3, 3:56 PM
Charlie Jolly (charlie) added a comment to T58600: Adjust for OSL 1.10.x changes.

Is it worth mentioning this too? Changes to quick_floor?
https://github.com/imageworks/OpenShadingLanguage/pull/912

Mon, Dec 3, 12:47 PM · Cycles, BF Blender

Sun, Dec 2

Antonio Vazquez (antoniov) awarded rB4ee29d3fdfff: GP: Fix line primitive when using to square behaviour a Like token.
Sun, Dec 2, 4:43 PM
Charlie Jolly (charlie) committed rB4ee29d3fdfff: GP: Fix line primitive when using to square behaviour (authored by Charlie Jolly (charlie)).
GP: Fix line primitive when using to square behaviour
Sun, Dec 2, 3:52 PM
Charlie Jolly (charlie) closed D4012: GP: Fix line primitive when using to square behaviour.
Sun, Dec 2, 3:52 PM
Bartosz Moniewski (monio) awarded D3495: Cycles Gabor Noise Texture Node a Love token.
Sun, Dec 2, 2:16 AM · Cycles, BF Blender: 2.8, BF Blender
Bartosz Moniewski (monio) awarded D3673: Cycles Noise, Voronoi Edge Along Surface Normal a Love token.
Sun, Dec 2, 2:13 AM · Cycles, BF Blender: 2.8
Bartosz Moniewski (monio) awarded D3786: Cycles & Eevee Material Nodes: Add Multiply function to Vector Math Node a Love token.
Sun, Dec 2, 2:12 AM

Fri, Nov 30

Diego Gangl (januz) awarded D3743: Tiled Voronoi Noise : Cycles, Eevee and OSL a 100 token.
Fri, Nov 30, 4:04 PM · Cycles, Eevee, BF Blender: 2.8
Charlie Jolly (charlie) updated the diff for D4012: GP: Fix line primitive when using to square behaviour.

Simplify logic, remove unneeded comparisons

Fri, Nov 30, 3:52 PM
Charlie Jolly (charlie) updated the diff for D4012: GP: Fix line primitive when using to square behaviour.
Fri, Nov 30, 3:51 PM
Charlie Jolly (charlie) added a comment to T58308: When connecting nodes in material editor, mousepointer gets in rectangular selection mode .

Duplicate bug: T58267

Fri, Nov 30, 2:58 PM · BF Blender
Charlie Jolly (charlie) added a comment to T58304: Metaballs appended as orphan.

Confirmed but it does work if you Append -> Object -> Mball, this might be undefined behaviour as it works the same as 2.79

Fri, Nov 30, 2:36 PM · BF Blender: 2.8
Charlie Jolly (charlie) added a comment to T58188: Extreme FPS loss (24x) between 2.79 and 2.8 with particle systems.

Confirm here, 2.8 is unworkable on my laptop but 2.79 works fine. Looks like a good test file!

Fri, Nov 30, 1:58 PM · BF Blender: 2.8
Charlie Jolly (charlie) added a comment to T58296: Blender 2.8.0 beta crashes when applying Textures. (eevee & lookdev in cycles).

Cannot reproduce here (Windows 10, HD520, 23.20.16.5018 drivers)

Fri, Nov 30, 1:50 PM · BF Blender: 2.8, BF Blender
Charlie Jolly (charlie) added reviewers for D4012: GP: Fix line primitive when using to square behaviour: Grease Pencil, Antonio Vazquez (antoniov).

@Antonio Vazquez (antoniov) the keyboard shortcuts for these primitives work the same as Illustrator. For GP drawing, the alt key is used for straight lines. What do you think? Or maybe discuss with UI team?

Fri, Nov 30, 1:10 PM
Charlie Jolly (charlie) created D4012: GP: Fix line primitive when using to square behaviour.
Fri, Nov 30, 1:06 PM

Thu, Nov 29

Antonio Vazquez (antoniov) awarded rB1f5216c57ae2: GP: Add option to draw primatives from center a Like token.
Thu, Nov 29, 7:48 PM
Charlie Jolly (charlie) committed rB1f5216c57ae2: GP: Add option to draw primatives from center (authored by Charlie Jolly (charlie)).
GP: Add option to draw primatives from center
Thu, Nov 29, 4:45 PM
Charlie Jolly (charlie) closed D4009: GP: Add option to draw primatives from center.
Thu, Nov 29, 4:45 PM
Charlie Jolly (charlie) updated the diff for D4009: GP: Add option to draw primatives from center.

Typo

Thu, Nov 29, 4:31 PM
Charlie Jolly (charlie) added a comment to D4002: Active Curves UI point should stand out.

Agree with changing the Cureve map. However, the Color Ramp colors should remain neutral here as the handles are colored to reflect the actual color of the stop,

Thu, Nov 29, 1:02 PM · User Interface, BF Blender: 2.8
Charlie Jolly (charlie) updated the diff for D4009: GP: Add option to draw primatives from center.

Missing status bar tips

Thu, Nov 29, 12:04 PM
Charlie Jolly (charlie) added reviewers for D4009: GP: Add option to draw primatives from center: Grease Pencil, Antonio Vazquez (antoniov).

Thu, Nov 29, 12:02 PM
Charlie Jolly (charlie) created D4009: GP: Add option to draw primatives from center.
Thu, Nov 29, 11:50 AM

Sat, Nov 24

Charlie Jolly (charlie) added a reviewer for D3984: UI: Fix color ramp eyedropper button from drop down tools menu: Brecht Van Lommel (brecht).

This fixes the bug where the UI_OT_eyedropper_colorband button is not clickable or active in the color ramp tools popup menu.

Sat, Nov 24, 8:41 PM
Charlie Jolly (charlie) created D3984: UI: Fix color ramp eyedropper button from drop down tools menu.
Sat, Nov 24, 8:28 PM

Thu, Nov 22

Charlie Jolly (charlie) added a comment to T57987: Content Structure for the Developer Wiki.

This is great, anything to make it easier for people to download the source code, build and develop blender is a big win.

Thu, Nov 22, 11:01 AM · Infrastructure: Websites
Charlie Jolly (charlie) added a comment to D3965: UI: Color Ramp: Add tools menu.

@Christopher Marcel Beumont (windex) thanks for your suggestions but they would be better placed on rightclickselect where more users will be able to discuss your ideas see: https://blender.community/c/rightclickselect

Thu, Nov 22, 10:44 AM

Wed, Nov 21

Charlie Jolly (charlie) added a comment to rBa62185022404: Fix T53550: E hotkey not working after the color-band picker commit.

The eyedropper button still does not work.

Wed, Nov 21, 4:03 PM

Tue, Nov 20

Duarte Farrajota Ramos (duarteframos) awarded rB53d9ddf772be: UI: Color Ramp: Add menu and functions to distribute color stops a Like token.
Tue, Nov 20, 6:11 PM
Charlie Jolly (charlie) committed rB53d9ddf772be: UI: Color Ramp: Add menu and functions to distribute color stops (authored by Charlie Jolly (charlie)).
UI: Color Ramp: Add menu and functions to distribute color stops
Tue, Nov 20, 6:03 PM