Page MenuHome

Christian Rauch (christian.rauch)
User

Projects (7)

User Details

User Since
Jan 13 2020, 1:29 AM (59 w, 6 d)

Recent Activity

Jan 26 2021

Christian Rauch (christian.rauch) added a comment to D7989: Wayland client-side window decorations.

I have very mixed feelings about this. First of all, I find the GNOME idea to require client side decorations... questionable, to say it in the nicest possible way.

I understand you. I was at this point when first using Wayland and discovered that I have to implement decorations myself.

Jan 26 2021, 1:00 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.
  • update libdecoration
  • remove demo
  • rebase master
Jan 26 2021, 12:27 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Sep 12 2020

Christian Rauch (christian.rauch) added a comment to D7989: Wayland client-side window decorations.

@Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Is this ready to be merged? This finalises the Wayland implementation as it should now support all the expected features.

Sep 12 2020, 3:44 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) updated the summary of D7989: Wayland client-side window decorations.
Sep 12 2020, 3:40 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

rebase

Sep 12 2020, 3:38 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Aug 5 2020

Christian Rauch (christian.rauch) added a comment to T79491: GL_BLEND ignores texture alpha channel.

Maybe I can clear up some misconceptions around the UI alpha channel to avoid confusion for future issues referring to this.

Aug 5 2020, 12:16 PM · Python API, EEVEE & Viewport, BF Blender

Jul 30 2020

Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

support HiDPI

Jul 30 2020, 1:14 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jul 22 2020

Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

rebase

Jul 22 2020, 2:19 AM

Jul 14 2020

Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

get cursor theme and size via D-Bus

Jul 14 2020, 1:44 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jul 10 2020

Christian Rauch (christian.rauch) added a comment to T77311: Mouse cursor stays in-place with Ghost/Wayland for operators that grab cursor input.

As far as I know, a proper pointer wrapping-around is currently not possible with the protocols that are available.

Jul 10 2020, 1:52 AM · User Interface, Platform: Linux
Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

fix surface access

Jul 10 2020, 1:01 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jul 8 2020

Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

fix libdecoration dependency tracking in CMake

Jul 8 2020, 3:32 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jul 4 2020

Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

rebase

Jul 4 2020, 12:25 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jun 23 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

@Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Is this ready to go now?

Jun 23 2020, 3:18 AM

Jun 18 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

The current changes without the 3D viewport fix look good to me though.

Jun 18 2020, 11:24 AM

Jun 16 2020

Christian Rauch (christian.rauch) added a comment to D7989: Wayland client-side window decorations.

It's not obvious to me that these are installed by default on all important Linux distributions that have X11 / Wayland, maybe they are? But probably not on headless machines for render farms?

Jun 16 2020, 10:06 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) added a comment to D7989: Wayland client-side window decorations.

But this seems like it adds dependencies on meson, ninja, dbus? And also cairo I think (though it's not in the meson build file)? Can you clarify this?

Jun 16 2020, 12:36 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) added a comment to D7989: Wayland client-side window decorations.

There's a few possibilities:

  • Ideally libdecoration is widely installed along with other Wayland packages, and there is no need to build it as part of Blender at all.
  • Linux distributes have packages for libdecoration that their Blender packages can depend on, and for official releases we build it as part of our precompiled libraries in build_files/build_environment/CMakeLists.txt
Jun 16 2020, 12:06 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jun 15 2020

Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

add libdecoration to external source tree

Jun 15 2020, 11:47 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

remove 3D Viewport colour, set alpha as 1.0f

Jun 15 2020, 9:29 PM
Christian Rauch (christian.rauch) added inline comments to D7599: correctly draw UI with enabled alpha channel.
Jun 15 2020, 7:41 PM

Jun 14 2020

Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

rebase

Jun 14 2020, 12:59 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

I removed the actual workaround since Mesa 20.0.8 will soon be released to Ubuntu 20.04 (https://bugs.launchpad.net/mpv/+bug/1868520). This should fix the buffer format selection from the drier side.

Jun 14 2020, 12:40 PM
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

remove workaround

Jun 14 2020, 12:32 PM

Jun 12 2020

Christian Rauch (christian.rauch) added a comment to D7989: Wayland client-side window decorations.

It seemed to get further in the process of setting up libdecoration each time I started compilation but never finished.

Jun 12 2020, 1:24 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface
Christian Rauch (christian.rauch) updated the diff for D7989: Wayland client-side window decorations.

detect own toplevel surfaces

Jun 12 2020, 12:23 AM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jun 10 2020

Christian Rauch (christian.rauch) requested review of D7989: Wayland client-side window decorations.
Jun 10 2020, 11:50 PM · Platform: Linux, Platforms, Builds, Tests & Devices, User Interface

Jun 4 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

I added the colour setting for the 3D viewport again. Empirically, I determined that the 3D viewport background colour on X11+master is close to the square of the values in TH_BACK (57 vs 63). I could not figure out how to truly set the alpha channel to 1 for the viewport.

Jun 4 2020, 9:26 PM
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

use 'TH_BACK' colour for 3D Viewport background

Jun 4 2020, 9:15 PM
Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

While I follow your reasoning, I don't see that checking the GPU for a workaround would cause code-paths likely to cause a lot of maintenance overhead we. Could get third opinion from someone else who worked on this area.

If there is no drawback from using this with Wayland on other GPUs (like performance issues or UI glitches), then I don't see why one would have this extra GPU driver detection :-)

Jun 4 2020, 6:51 PM

Jun 1 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

I am really against having different code branches for this and rather make sure that the behaviour is consistent over all GPUs and drivers. I think there is no downside of having this transparent+opaque setting for all GPUs.
Also, keep in mind that this issue is fixed upstream with Mesa 20.0.7, which eventually will make its way into Ubuntu.

Jun 1 2020, 12:30 PM

May 30 2020

Christian Rauch (christian.rauch) committed rB63bcee81f624: GHOST/wayland: use 'is_dialog' flag to prevent drawing into same window (authored by Christian Rauch (christian.rauch)).
GHOST/wayland: use 'is_dialog' flag to prevent drawing into same window
May 30 2020, 1:26 PM

May 29 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

The original issue (wrong buffer format selection on Intel Iris) has been fixed in Mesa 20.0.7 (https://www.mesa3d.org/relnotes/20.0.7.html). Ubuntu 20.04.2 will probably use this or a newer version. Do you want to wait until the fix has been released into Ubuntu, or do you want to merge this workaround now and revert later?

May 29 2020, 12:03 AM

May 27 2020

Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

rebase

May 27 2020, 12:03 AM

May 26 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

@Campbell Barton (campbellbarton) Would you insist on the GPU driver detection for enabling the workaround or can this go as is?

May 26 2020, 6:53 PM

May 25 2020

Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

As for ghost/wayland, could this be isolated to the GPU causing the problem?

May 25 2020, 12:29 PM
Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

In fullscreen mode (Window > Toggle Window Fullscreen) Blender doesn't take up the entire screen. This doesn't happen with X11.

May 25 2020, 1:31 AM · Platform: Linux, BF Blender

May 24 2020

Christian Rauch (christian.rauch) added a comment to T76720: GHOST/Wayland WM Timer Problems.

@Hans Goudey (HooglyBoogly) This should be solved by https://developer.blender.org/D7658. Can you confirm and close this if applicable?

May 24 2020, 8:35 PM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

set opaque window only if alpha channel is used

May 24 2020, 7:42 PM
Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

Instead of painting the 3D view with a specific non-transparent colour, I now just made the entire Wayland window opaque.

May 24 2020, 7:32 PM
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

opaque window

May 24 2020, 7:30 PM

May 21 2020

Christian Rauch (christian.rauch) added a comment to D7658: wayland: repeat key on key press and hold.

@Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Can you have a look at the key repeat timer again?

May 21 2020, 4:27 PM

May 20 2020

Christian Rauch (christian.rauch) updated the summary of D7658: wayland: repeat key on key press and hold.
May 20 2020, 1:41 AM
Christian Rauch (christian.rauch) updated the diff for D7658: wayland: repeat key on key press and hold.

rebase

May 20 2020, 1:38 AM

May 18 2020

Christian Rauch (christian.rauch) added a comment to D7658: wayland: repeat key on key press and hold.

I changed this back to a single timer that is reseted whenever a key, that can repeat, is pressed.

May 18 2020, 10:36 PM
Christian Rauch (christian.rauch) updated the diff for D7658: wayland: repeat key on key press and hold.

single timer

May 18 2020, 10:34 PM

May 15 2020

Christian Rauch (christian.rauch) added a comment to D7658: wayland: repeat key on key press and hold.

@Campbell Barton (campbellbarton) Is this viable as is (independent key repeats) or do you need to have the X11 behaviour where only the last pressed key can repeat?

May 15 2020, 4:15 PM
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

set square of TH_BACK values

May 15 2020, 12:51 AM

May 14 2020

Hans Goudey (HooglyBoogly) awarded D7658: wayland: repeat key on key press and hold a Love token.
May 14 2020, 5:16 PM
Christian Rauch (christian.rauch) added inline comments to D7658: wayland: repeat key on key press and hold.
May 14 2020, 12:31 PM
Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

All 2D UI elements in the general editor types (Shift + F1..F12) should be opaque now.

May 14 2020, 3:38 AM
Christian Rauch (christian.rauch) updated the diff for D7599: correctly draw UI with enabled alpha channel.

fix remaining UI elements, except 3D view

May 14 2020, 3:30 AM
Christian Rauch (christian.rauch) added a comment to D7658: wayland: repeat key on key press and hold.

This is now implemented via a GHOST_TimerTask. For this, I also had to change to a non-blocking loop, which as a side effect solves the animation issue in https://developer.blender.org/T76720.

May 14 2020, 1:21 AM
Christian Rauch (christian.rauch) added a revision to T76720: GHOST/Wayland WM Timer Problems: D7658: wayland: repeat key on key press and hold.
May 14 2020, 1:01 AM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) added a task to D7658: wayland: repeat key on key press and hold: T76720: GHOST/Wayland WM Timer Problems.
May 14 2020, 1:01 AM
Christian Rauch (christian.rauch) updated the diff for D7658: wayland: repeat key on key press and hold.

implement key repeat via timer

May 14 2020, 1:00 AM
Christian Rauch (christian.rauch) committed rBc8060a78fdf3: GHOST/wayland: style fix (authored by Christian Rauch (christian.rauch)).
GHOST/wayland: style fix
May 14 2020, 12:54 AM
Christian Rauch (christian.rauch) committed rBa53917152eb0: GHOST/wayland: fix cursor buffer deallocation (authored by Christian Rauch (christian.rauch)).
GHOST/wayland: fix cursor buffer deallocation
May 14 2020, 12:27 AM
Christian Rauch (christian.rauch) committed rBbd3c842c5693: GHOST/wayland: remove unused 'registry' (authored by Christian Rauch (christian.rauch)).
GHOST/wayland: remove unused 'registry'
May 14 2020, 12:27 AM

May 13 2020

Christian Rauch (christian.rauch) added a comment to T76720: GHOST/Wayland WM Timer Problems.

The problem is basically that the event handling in GHOST_SystemWayland::processEvents by wl_display_dispatch blocks until new events have been received from the compositor. This is fine and efficient of the UI only has to respond to input events etc. but obviously does not work with animations or other input independent UI events.

May 13 2020, 4:57 PM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) committed rB75e989dab6c7: GHOST: fix cursor buffer handling when toggling visibility (authored by Christian Rauch (christian.rauch)).
GHOST: fix cursor buffer handling when toggling visibility
May 13 2020, 12:10 AM

May 12 2020

Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

Besides window decoration and HiDPI, the main thing I noticed was that the panel animations were very slow when running with Wayland.
For example, when dragging a panel and letting it animate back to its original position, the animation seemed to only have a couple frames total.
Maybe GHOST_kEventTimer events aren't added properly? The panels use TIMER events to update.

Can you open a dedicated "Task" with a list to reproduce this? I have a hunch of what is missing for that. At the moment, the process loop blocks until a new event has been received from the compositor.

May 12 2020, 9:58 PM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) added a comment to D7599: correctly draw UI with enabled alpha channel.

@Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Can you give me a hint where to change the background colour such that the UI will render with the alpha channel enabled?

May 12 2020, 12:02 PM
Christian Rauch (christian.rauch) added a reviewer for D7658: wayland: repeat key on key press and hold: Brecht Van Lommel (brecht).
May 12 2020, 12:00 PM
Christian Rauch (christian.rauch) added a comment to D7658: wayland: repeat key on key press and hold.

@Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Can you have a look at this, especially since it introduces a mutex in the event handler?

May 12 2020, 11:59 AM
Christian Rauch (christian.rauch) updated the diff for D7658: wayland: repeat key on key press and hold.

rebase

May 12 2020, 11:57 AM

May 10 2020

Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

How much feedback are you looking for at this point? I don't want to tell you stuff you already know.

May 10 2020, 9:42 PM · Platform: Linux, BF Blender

May 9 2020

Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

Alright, those dependencies worked, although I had to add #include <stdexcept> in GHOST_SystemWayland.cpp to get it to compile on my machine.

May 9 2020, 7:18 PM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) added a comment to D7658: wayland: repeat key on key press and hold.

I added a mutex to the GHOST_EventManager to synchronise the access to the event queue. This solves the issue with the NULL access.

May 9 2020, 3:20 PM
Christian Rauch (christian.rauch) updated the summary of D7658: wayland: repeat key on key press and hold.
May 9 2020, 3:18 PM
Christian Rauch (christian.rauch) updated the summary of D7658: wayland: repeat key on key press and hold.
May 9 2020, 3:17 PM
Christian Rauch (christian.rauch) updated the diff for D7658: wayland: repeat key on key press and hold.

mutex for event queue access

May 9 2020, 3:16 PM

May 8 2020

Christian Rauch (christian.rauch) retitled D7658: wayland: repeat key on key press and hold from repeat key on key press and hold to wayland: repeat key on key press and hold.
May 8 2020, 1:22 AM
Christian Rauch (christian.rauch) added a revision to T76428: GHOST/Wayland Support: D7658: wayland: repeat key on key press and hold.
May 8 2020, 1:17 AM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) added a task to D7658: wayland: repeat key on key press and hold: T76428: GHOST/Wayland Support.
May 8 2020, 1:17 AM
Christian Rauch (christian.rauch) requested review of D7658: wayland: repeat key on key press and hold.
May 8 2020, 1:14 AM

May 7 2020

Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

I tried testing this on my Intel GPU (running wayland) Fedora 32 laptop and I ran into compile errors when I turned WITH_GHOST_WAYLAND on. Otherwise this is standard make default settings.

--   Package 'wayland-client', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:467 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPkgConfig.cmake:647 (_pkg_check_modules_internal)
  build_files/cmake/platform/platform_unix.cmake:510 (pkg_check_modules)
  CMakeLists.txt:839 (include)

Am I missing something? Is another dependency required to build this?

Package libwayland-client-1.18.0-1.fc32.x86_64 is already installed.
May 7 2020, 2:45 PM · Platform: Linux, BF Blender

May 6 2020

Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

Currently I don't have a very good setup for testing wayland, regular Blender doesn't run, only the animation player.

May 6 2020, 6:19 PM · Platform: Linux, BF Blender
Christian Rauch (christian.rauch) updated the diff for D7632: Send key symbols on Wayland without modifier..

fix code format

May 6 2020, 1:08 AM
Christian Rauch (christian.rauch) added a comment to T76429: GHOST/Wayland event's don't correspond to physical keys.

Yes, this is what's expected, there is the ascii and utf8 members which are used at any time where text value needs to be read from the key.

May 6 2020, 1:04 AM · BF Blender
Christian Rauch (christian.rauch) added a revision to T76429: GHOST/Wayland event's don't correspond to physical keys: D7632: Send key symbols on Wayland without modifier..
May 6 2020, 12:53 AM · BF Blender
Christian Rauch (christian.rauch) added a task to D7632: Send key symbols on Wayland without modifier.: T76429: GHOST/Wayland event's don't correspond to physical keys.
May 6 2020, 12:53 AM
Christian Rauch (christian.rauch) requested review of D7632: Send key symbols on Wayland without modifier..
May 6 2020, 12:52 AM

May 5 2020

Christian Rauch (christian.rauch) added a comment to T76429: GHOST/Wayland event's don't correspond to physical keys.

I can reproduce this. The function xkb_map_gkey receives the XKB_KEY_exclam key, but there is no corresponding GHOST_TKey. It will, therefore, print unhandled key: 33 (XKB_KEY_exclam).

May 5 2020, 6:21 PM · BF Blender
Christian Rauch (christian.rauch) added a comment to T76428: GHOST/Wayland Support.

Regarding the modal/dialog windows: What is the semantic difference between being a child window and a dialog window?

May 5 2020, 12:07 PM · Platform: Linux, BF Blender
noki paike (amonpaike) awarded rB66e70fe299e1: GHOST: initial Wayland support a Love token.
May 5 2020, 9:38 AM

May 4 2020

Christian Rauch (christian.rauch) added a comment to D6567: Wayland frontend.
May 4 2020, 1:13 PM · User Interface, Platform: Linux
Alaska (Alaska) awarded rB66e70fe299e1: GHOST: initial Wayland support a Love token.
May 4 2020, 3:48 AM

May 2 2020

Telmo Silva (nottelmo) awarded rB66e70fe299e1: GHOST: initial Wayland support a Love token.
May 2 2020, 12:04 AM

May 1 2020

Christian Rauch (christian.rauch) updated the summary of D7599: correctly draw UI with enabled alpha channel.
May 1 2020, 10:28 PM
Christian Rauch (christian.rauch) requested review of D7599: correctly draw UI with enabled alpha channel.
May 1 2020, 9:40 PM
Christian Rauch (christian.rauch) retitled D7585: properly fill the initial maximised window from Properly fill the maximised initial window with the "nice gray" colour. to properly fill the initial maximised window.
May 1 2020, 3:17 AM
Christian Rauch (christian.rauch) requested review of D7585: properly fill the initial maximised window.
May 1 2020, 3:09 AM

Apr 30 2020

Christian Rauch (christian.rauch) updated the diff for D6567: Wayland frontend.

style fix, rebase

Apr 30 2020, 12:33 AM · User Interface, Platform: Linux

Apr 29 2020

Christian Rauch (christian.rauch) added a comment to D6567: Wayland frontend.

I removed the usage of STR_String and documented the unimplemented event handlers by citing from the official Wayland protocol documentation. This should provide enough information if this functionality needs to be added later.

Apr 29 2020, 9:53 PM · User Interface, Platform: Linux
Bataev Artem (shader) awarded D6567: Wayland frontend a Burninate token.
Apr 29 2020, 9:40 PM · User Interface, Platform: Linux
Christian Rauch (christian.rauch) updated the diff for D6567: Wayland frontend.

update API, document event handlers

Apr 29 2020, 9:38 PM · User Interface, Platform: Linux

Apr 27 2020

Christian Rauch (christian.rauch) added a comment to D6567: Wayland frontend.

@Christian Rauch (christian.rauch) could you address the remaining TODO's, then I think this will be ready to go into master.

Apr 27 2020, 12:13 PM · User Interface, Platform: Linux
Christian Rauch (christian.rauch) updated the diff for D6567: Wayland frontend.

fix linking

Apr 27 2020, 1:28 AM · User Interface, Platform: Linux

Apr 25 2020

Christian Rauch (christian.rauch) added a comment to D6567: Wayland frontend.

I addressed the comments about the C-style comments and the GHOST_TABLET_DATA_NONE.

Apr 25 2020, 4:10 PM · User Interface, Platform: Linux