Page MenuHome

Corbin Dunn (corbin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2021, 3:59 PM (8 w, 6 d)

Recent Activity

Mar 9 2021

Julian Eisel (Severin) awarded D10616: Update to @autorelease and stop checking for null on non-nullable return results. a Like token.
Mar 9 2021, 11:20 AM · Platform: macOS

Mar 4 2021

Corbin Dunn (corbin) added a comment to D10616: Update to @autorelease and stop checking for null on non-nullable return results..

+1 for the cleanup
I'll break it into two commits to separate the pasteboard and nil check changes from the autoreleasepool ones.

Mar 4 2021, 9:23 PM · Platform: macOS
Corbin Dunn (corbin) added inline comments to D10606: Opt out of AppKit’s default automatic window tabbing.
Mar 4 2021, 9:22 PM · Platform: macOS
Corbin Dunn (corbin) updated the summary of D10616: Update to @autorelease and stop checking for null on non-nullable return results..
Mar 4 2021, 3:12 PM · Platform: macOS
Corbin Dunn (corbin) retitled D10616: Update to @autorelease and stop checking for null on non-nullable return results. from ≈Update to @autorelease and stop checking for null on non-nullable return results. to Update to @autorelease and stop checking for null on non-nullable return results..
Mar 4 2021, 3:07 PM · Platform: macOS
Corbin Dunn (corbin) requested review of D10616: Update to @autorelease and stop checking for null on non-nullable return results..
Mar 4 2021, 3:05 PM · Platform: macOS

Mar 3 2021

Corbin Dunn (corbin) added a comment to D10606: Opt out of AppKit’s default automatic window tabbing.

Okay; formatting fixed.

Mar 3 2021, 11:13 PM · Platform: macOS
Corbin Dunn (corbin) updated the diff for D10606: Opt out of AppKit’s default automatic window tabbing.

Trying again to update...

Mar 3 2021, 11:12 PM · Platform: macOS
Corbin Dunn (corbin) updated the diff for D10606: Opt out of AppKit’s default automatic window tabbing.

Accidentally pushed more changes than I meant.

Mar 3 2021, 11:11 PM · Platform: macOS
Corbin Dunn (corbin) added a comment to D10606: Opt out of AppKit’s default automatic window tabbing.

Ugh..pushed some extra changes. Let me try again..I'm learning "arc"

Mar 3 2021, 11:09 PM · Platform: macOS
Corbin Dunn (corbin) updated the diff for D10606: Opt out of AppKit’s default automatic window tabbing.

Fix whitespace and code formatting.

Mar 3 2021, 11:07 PM · Platform: macOS
Corbin Dunn (corbin) added a comment to D10606: Opt out of AppKit’s default automatic window tabbing.

For more complete info on this API, you can read the release notes from 10.12 (which I wrote ;)

Mar 3 2021, 11:02 PM · Platform: macOS
Corbin Dunn (corbin) added a comment to D10606: Opt out of AppKit’s default automatic window tabbing.

I'm curious about the upsides of opt-out and/or downsides of leaving it be.
Is it a doing-the-right-thing change ?

Mar 3 2021, 10:55 PM · Platform: macOS
Corbin Dunn (corbin) updated the summary of D10606: Opt out of AppKit’s default automatic window tabbing.
Mar 3 2021, 5:24 PM · Platform: macOS
Corbin Dunn (corbin) requested review of D10606: Opt out of AppKit’s default automatic window tabbing.
Mar 3 2021, 5:22 PM · Platform: macOS
Corbin Dunn (corbin) added reviewers for D10603: NSWindow’s initWithContentRect never returns nil; so don’t check for nil after calling it: Sebastián Barschkis (sebbas), Ankit Meel (ankitm).
Mar 3 2021, 4:15 PM · Platform: macOS
Corbin Dunn (corbin) added a comment to T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.

I quickly typed that code...it would have to be reworked to re-enable the old code as it was. I can easily do this change if people like it.

Mar 3 2021, 4:14 PM · BF Blender
Corbin Dunn (corbin) added a comment to T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.

Thanks; I read the report and history. It looks like "Logitech Performance MX mouse" is sending hasPreciseScrollingDeltas too. There is no way to differentiate them and the touch input on a Wacom tablet as not enough information is packed into NSEvent or the underlying CGEvent. We *could* get the source process that generated the event via CGEventRef/kCGEventSourceUnixProcessID; and then identify the process by string...but this would likely be too slow to do on each mouse event.

Mar 3 2021, 4:13 PM · BF Blender
Corbin Dunn (corbin) added a reviewer for D10603: NSWindow’s initWithContentRect never returns nil; so don’t check for nil after calling it: Platform: macOS.
Mar 3 2021, 4:01 PM · Platform: macOS
Corbin Dunn (corbin) requested review of D10603: NSWindow’s initWithContentRect never returns nil; so don’t check for nil after calling it.
Mar 3 2021, 4:00 PM · Platform: macOS
Corbin Dunn (corbin) abandoned D10602: Fix scrolling with wacom tablets using them as a touch device..
Mar 3 2021, 3:50 PM
Corbin Dunn (corbin) requested review of D10602: Fix scrolling with wacom tablets using them as a touch device..
Mar 3 2021, 3:50 PM
Corbin Dunn (corbin) added inline comments to D10370: Removing Carbon from GHOST Cocoa (MacOS) System.
Mar 3 2021, 3:35 PM · Platform: macOS
Corbin Dunn (corbin) added a task to D8797: Fix for handing the NSEventTypeScrollWheel events: T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.
Mar 3 2021, 2:42 PM · Platform: macOS, User Interface
Corbin Dunn (corbin) added a revision to T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet: D8797: Fix for handing the NSEventTypeScrollWheel events.
Mar 3 2021, 2:42 PM · BF Blender
Corbin Dunn (corbin) added a comment to D8797: Fix for handing the NSEventTypeScrollWheel events.

Related/similar: T86223

Mar 3 2021, 2:42 PM · Platform: macOS, User Interface
Corbin Dunn (corbin) added a comment to T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.

@Corbin Dunn (corbin) - One note, some of the regular computer mice have hasPreciseScrollingDeltas see D8797 for details.

Mar 3 2021, 2:41 PM · BF Blender
Corbin Dunn (corbin) added a comment to T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.

Sorry...learning how to format stuff.

Mar 3 2021, 3:59 AM · BF Blender
Corbin Dunn (corbin) updated the task description for T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.
Mar 3 2021, 3:58 AM · BF Blender
Corbin Dunn (corbin) updated the task description for T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.
Mar 3 2021, 3:58 AM · BF Blender
Corbin Dunn (corbin) updated the task description for T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.
Mar 3 2021, 3:57 AM · BF Blender
Corbin Dunn (corbin) created T86223: macOS: touch input fails to work on a Wacom Intuos Pro tablet.
Mar 3 2021, 3:55 AM · BF Blender
Corbin Dunn (corbin) added reviewers for D10597: Ghost/macOS: Fix memory leak.: Sebastián Barschkis (sebbas), Ankit Meel (ankitm).
Mar 3 2021, 3:43 AM · Platform: macOS
Corbin Dunn (corbin) added a reviewer for D10597: Ghost/macOS: Fix memory leak.: Platform: macOS.
Mar 3 2021, 3:25 AM · Platform: macOS
Corbin Dunn (corbin) added a project to D10597: Ghost/macOS: Fix memory leak.: Platform: macOS.
Mar 3 2021, 3:25 AM · Platform: macOS
Corbin Dunn (corbin) added a comment to D10597: Ghost/macOS: Fix memory leak..

I created a bug report to track this issue: https://developer.blender.org/T86222

Mar 3 2021, 3:21 AM · Platform: macOS
Corbin Dunn (corbin) created T86222: macOS: attributedSubstringFromRange in GHOST_WindowViewCocoa.h leaks memory..
Mar 3 2021, 3:20 AM · Platform: macOS, BF Blender
Corbin Dunn (corbin) added a comment to D10597: Ghost/macOS: Fix memory leak..

FWIW, I worked on AppKit / Cocoa for 13 years at Apple.

Mar 3 2021, 3:14 AM · Platform: macOS
Corbin Dunn (corbin) requested review of D10597: Ghost/macOS: Fix memory leak..
Mar 3 2021, 3:14 AM · Platform: macOS

Mar 2 2021

Corbin Dunn (corbin) abandoned D10589: Fix scrolling with wacom tablets using them as a touch device..
Mar 2 2021, 11:47 PM
Corbin Dunn (corbin) added a comment to D10589: Fix scrolling with wacom tablets using them as a touch device..

Sorry... didn’t mean to push this fix yet. I’m testing...

Mar 2 2021, 11:46 PM
Corbin Dunn (corbin) requested review of D10589: Fix scrolling with wacom tablets using them as a touch device..
Mar 2 2021, 11:11 PM

Feb 25 2021

Corbin Dunn (corbin) added a comment to T85903: Blender 2.91.2 consistently crashes re-opening an auto-save backup file in OpenSubdiv::...

I do see now that the main bug report page says

Feb 25 2021, 2:30 PM · BF Blender
Corbin Dunn (corbin) added a comment to T85903: Blender 2.91.2 consistently crashes re-opening an auto-save backup file in OpenSubdiv::...

Thanks for the report. The mesh named "MErockA_v001" is corrupted.

Unfortunately unless there are clear instructions on how to reproduce it from scratch we cannot debug this any further.

Things that may cause mesh corruption: Importers, development versions of Blender, modeling tools.

Here the file "fixed":

Feb 25 2021, 2:28 PM · BF Blender

Feb 23 2021

Corbin Dunn (corbin) added a comment to T85903: Blender 2.91.2 consistently crashes re-opening an auto-save backup file in OpenSubdiv::...

Seems related to the split-view. When I close the second split it becomes more stable. I'll have to test more though..

Feb 23 2021, 4:15 AM · BF Blender
Corbin Dunn (corbin) added a comment to T79186: When returning to an open instance of Blender from other application, Blender (often) crashes immediately..

I opened the attached file in Blender 2.92.0 Release Candidate, switched to another application, and switched back to Blender. I toyed around with it a bit, but could not get it to crash. macOS 11.1 (20C69), iMac (Retina 5K, 27-inch, Late 2014).

Feb 23 2021, 4:11 AM · Platform: macOS, BF Blender

Feb 22 2021

Corbin Dunn (corbin) added a comment to T85903: Blender 2.91.2 consistently crashes re-opening an auto-save backup file in OpenSubdiv::...

Tested in 2.92.0 (2.92.0 2021-02-21); still crashes. Blender has been "crashy" for me, and I bet the autosave file is corrupted.

Feb 22 2021, 10:36 PM · BF Blender
Corbin Dunn (corbin) created T85903: Blender 2.91.2 consistently crashes re-opening an auto-save backup file in OpenSubdiv::...
Feb 22 2021, 9:38 PM · BF Blender