Page MenuHome

Daniel Santana (dgsantana)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2019, 3:18 PM (18 w, 2 d)

Recent Activity

Fri, Aug 9

Daniel Santana (dgsantana) awarded T57936: Performance regressions a Love token.
Fri, Aug 9, 11:37 PM · BF Blender

Sat, Aug 3

Daniel Santana (dgsantana) awarded D5375: UI Demonstration: File Manager Thumbnail View a Like token.
Sat, Aug 3, 3:48 PM · User Interface
Daniel Santana (dgsantana) awarded D5388: GSoC Outliner Branch a Yellow Medal token.
Sat, Aug 3, 3:35 PM
Daniel Santana (dgsantana) awarded D5407: OpenVDB Voxel Remesher a Love token.
Sat, Aug 3, 2:52 PM

Mon, Jul 29

Daniel Santana (dgsantana) awarded D5363: Add OptiX device implementation to Cycles a Love token.
Mon, Jul 29, 6:07 PM · Cycles

Jun 15 2019

Daniel Santana (dgsantana) awarded D5078: Fix for the T53581 a Love token.
Jun 15 2019, 9:01 PM

Jun 12 2019

Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

Dan, can you review your fix (F1442978), so it uses the 0.1 tolerance? It should be that one that gets committed ;).

Jun 12 2019, 5:02 PM
Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

Results with the F1442978 applied. (all good at 0.1, 0.01 still gives artefacts)

Jun 12 2019, 1:05 PM
Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

Looking into F1442978, that should be the one accepted, since it solves all the proposed problems with a simple enough fix.

Jun 12 2019, 12:54 PM
Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

I do believe that the pseudo-inverse, since is only used in this case, could use statically sized matrix. I already implement this algorithm in Rust, and hand converted the original paper code. Maybe reducing the use of Eigen library with handwritten versions could improve compiler performance (no template instancing), and probably to some extent the overall function speed. But I think for now that is a bit out of scope, to fix this trivial error. I will change this to 0.1 and make the function static typed.

Jun 12 2019, 12:36 PM
Daniel Santana (dgsantana) updated the diff for D5062: Fix for the T53581.

Lower the epsilon to 0.0001 with no visible side effects on tests done.

Jun 12 2019, 9:39 AM

Jun 11 2019

Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

Default Torus, SubMod: 3, Remesh: Depth: 9 (0.01f epsilon) - Good

Jun 11 2019, 4:08 PM
Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

I will do some tests. I upped the remesh voxel up to 9 with and no problems with 0.01 on a default torus with subd mod of 4.

Jun 11 2019, 3:54 PM
Daniel Santana (dgsantana) added a comment to D5062: Fix for the T53581.

This should give the same result as the F1442978, since the template function will expand at compile time to the Matrix3f version, which is the what is proposed in the diff, there should be no difference in speed between the 2.

Jun 11 2019, 3:44 PM
Daniel Santana (dgsantana) created D5062: Fix for the T53581.
Jun 11 2019, 3:03 PM

Jun 5 2019

Daniel Santana (dgsantana) awarded T60695: Optimized per-datablock global undo a Love token.
Jun 5 2019, 9:44 PM · Datablocks and Libraries

Jun 1 2019

Abid Maqbool (cto.abid) awarded T65328: Offset on Outliner when Outliner header gains focus a Love token.
Jun 1 2019, 4:48 AM · BF Blender

May 31 2019

Daniel Santana (dgsantana) added a comment to T65328: Offset on Outliner when Outliner header gains focus.

And another video, showing when you go over the "icons" of the outliner. In the previous video, the cursor wasn't captured, due to my HDPI display. I capture this one on the HD screen so it now shows the cursor.

May 31 2019, 6:16 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T65328: Offset on Outliner when Outliner header gains focus.

Just to confirm this is not only on Windows, but it also happens on my Linux Laptop.
Details below.

May 31 2019, 1:11 PM · BF Blender

May 30 2019

Daniel Santana (dgsantana) created T65328: Offset on Outliner when Outliner header gains focus.
May 30 2019, 10:51 PM · BF Blender

May 14 2019

Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

It a bit weird, now it happened when zooming out on the layout workspace with Solid Texture mode. Spend an hour doing decimate on highpoly to low poly people, switching from Wire to Solid Texture, and done tons of zoom in/out. When I was about to call it a day, and zooming out to see the an overview, puff :D.
No work lost thanks to great the autoback ;).

May 14 2019, 5:03 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

Call stack for the latest commit (3db4284 - Fix T64601 Error division by zero in GPUVertexFormat) :

May 14 2019, 4:53 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64601: Error division by zero on commit "016fc7f - GPUVertexFormat: Reduce size of structs".

Here you go, this was a build with the latest commit (c66a782 - Interface: Free argument callback for popups):

blender.exe!padding(unsigned int offset, unsigned int alignment) Line 221 (d:\dev\blender\blender\source\blender\gpu\intern\gpu_vertex_format.c:221)
blender.exe!VertexFormat_pack(GPUVertFormat * format) Line 259 (d:\dev\blender\blender\source\blender\gpu\intern\gpu_vertex_format.c:259)
blender.exe!GPU_vertbuf_create_with_format_ex(const GPUVertFormat * format, GPUUsageType usage) Line 68 (d:\dev\blender\blender\source\blender\gpu\intern\gpu_vertex_buffer.c:68)
blender.exe!gpu_batch_sphere(int lat_res, int lon_res) Line 129 (d:\dev\blender\blender\source\blender\gpu\intern\gpu_batch_presets.c:129)
blender.exe!gpu_batch_presets_init() Line 202 (d:\dev\blender\blender\source\blender\gpu\intern\gpu_batch_presets.c:202)
blender.exe!GPU_init() Line 62 (d:\dev\blender\blender\source\blender\gpu\intern\gpu_init_exit.c:62)
blender.exe!wm_window_ghostwindow_add(wmWindowManager * wm, const unsigned char * title, wmWindow * win) Line 739 (d:\dev\blender\blender\source\blender\windowmanager\intern\wm_window.c:739)
blender.exe!wm_window_ghostwindows_ensure(wmWindowManager * wm) Line 861 (d:\dev\blender\blender\source\blender\windowmanager\intern\wm_window.c:861)
blender.exe!WM_check(bContext * C) Line 290 (d:\dev\blender\blender\source\blender\windowmanager\intern\wm.c:290)
blender.exe!wm_homefile_read(bContext * C, ReportList * reports, bool use_factory_settings, bool use_empty_data, bool use_data, bool use_userdef, const unsigned char * filepath_startup_override, const unsigned char * app_template_override, bool * r_is_factory_startup) Line 1038 (d:\dev\blender\blender\source\blender\windowmanager\intern\wm_files.c:1038)
blender.exe!WM_init(bContext * C, int argc, const unsigned char * * argv) Line 272 (d:\dev\blender\blender\source\blender\windowmanager\intern\wm_init_exit.c:272)
blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 427 (d:\dev\blender\blender\source\creator\creator.c:427)
[Inline Frame] blender.exe!invoke_main() Line 78 (d:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78)
blender.exe!__scrt_common_main_seh() Line 288 (d:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
kernel32.dll!00007ff8358d7974() (Unknown Source:0)
ntdll.dll!00007ff836caa271() (Unknown Source:0)
May 14 2019, 3:56 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64601: Error division by zero on commit "016fc7f - GPUVertexFormat: Reduce size of structs".

I believe this has to do with some changes on the way the GPU attributes are read or stored. The call stack ends up on file: gpu_format_format.c, function *uint padding* called by *VertexFormat_pack*.

May 14 2019, 3:47 PM · BF Blender
Daniel Santana (dgsantana) created T64601: Error division by zero on commit "016fc7f - GPUVertexFormat: Reduce size of structs".
May 14 2019, 3:10 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

If you guys guide me a little, since I don't know the blender code (I used to create plugins for 3dsmax, houdini and maya in the past), maybe I can help track the problem. @Clément Foucault (fclem) Where should I look for the garbage collection, I quite savvy on C/C++, have about 20 years of developer experience in all kinds of languages including C/C++.

May 14 2019, 1:21 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

And diving a little further, the MEM_lockfree_callocN makes no assumption on the request memory block asked, so if we ask a 0 block it will create one because it always has some memory used by MemHead. But I don't see a problem with this, and of course maybe its by design.

May 14 2019, 1:02 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

I was looking into the code where surf_per_mat_tris is inited, and there may be a corner case that could cause this, I have some objects without materials and the allocation takes in account the material count, well if the material count is zero, the new array pointer will be effectively zero in length.
This happens on draw_cache_impl_mesh.c line 2105.

May 14 2019, 12:48 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

Just for the record the fix is just this:

May 14 2019, 12:39 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

And it still crashed. Left blender rendering a Diffuse bake map, and went to take care of my garden. Come back and it crashed in the same line. Going to put back the null check again.
State of blender at crash.

May 14 2019, 12:38 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

Unfortunately, I can't share the file. This happens after working for a while. I was doing complex baking of some meshes, in the Shading workspace. This happened twice until I added the null pointer check, one of the time was while leaving the Local View (/ Numpad), the other was whne moving from the Shading to the Layout workspace. I will make a build without my patch to see if I get any crash during the day.

May 14 2019, 9:50 AM · BF Blender

May 13 2019

Daniel Santana (dgsantana) added a comment to T64550: Material tab crash in Blender 2.8.

I think it may be related to this bug: https://developer.blender.org/T64551

May 13 2019, 4:14 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64551: Crash on leaving local view on the shading tab..

As a workaround I added a null check to my local build just to avoid this, mostly because I don't know where the cache is populated, still "learning" my way around the blender source code.

May 13 2019, 3:30 PM · BF Blender
Daniel Santana (dgsantana) created T64551: Crash on leaving local view on the shading tab..
May 13 2019, 2:09 PM · BF Blender

May 11 2019

Daniel Santana (dgsantana) added a comment to rB688e3fed4c25: Preferences: write preferences on exit.

Right, but my understanding is that none of them allow you to be in a state where you have modified preferences, closed the preferences window, without those preferences being saved (or reverted). Which is what this commit is about.

May 11 2019, 4:05 PM
Daniel Santana (dgsantana) added a comment to rB688e3fed4c25: Preferences: write preferences on exit.

In most apps out there, things like keymap settings, addons/plugins, sometimes even themes, they usually have a separate editor each, and you save those settings separately. Usually those things are not part of the main preferences, that's why they can afford to have that preferences autosaving feature, because their preferences is not that complex, which is not the case in blender.

Can you give examples of such apps? I couldn't find any looking at the apps I have installed here, or ones that I can think of off the top of head.

  • Maya, Modo
  • Visual Studio
  • Chrome, Firefox
  • MS Office

As far as I know, most applications either autosave, or are modal and have save and cancel (i.e. revert). If they use separate editors is also not relevant as far as I can see, the point is that other apps don't typically let you to edit preferences without saving them. If they are saved separately or not makes no functional difference.

May 11 2019, 3:54 PM
Daniel Santana (dgsantana) added a comment to rB688e3fed4c25: Preferences: write preferences on exit.

I would avoid the revert also. Makes much more sense to have an option to auto-save preferences, that should be off by default. It would probably be much easier to just save the ´Quick Favorites` in some other file, just a list of operators, than duplicating a lot of the internal structures just to accommodate an Undo for the preferences.

May 11 2019, 3:24 PM
Daniel Santana (dgsantana) added a comment to T64474: FBX broken with the latest visibility changes commit 'b1af682 - Outliner Visibility Update'.

To save some time, maybe this could help you guys:
blender/master

diff --git a/release/scripts/startup/bl_ui/space_view3d.py b/release/scripts/startup/bl_ui/space_view3d.py
index f05cdc8f5f8..8c803973fe1 100644
--- a/release/scripts/startup/bl_ui/space_view3d.py
+++ b/release/scripts/startup/bl_ui/space_view3d.py
@@ -4847,7 +4847,7 @@ class VIEW3D_PT_collections(Panel):
             if child.exclude:
                 continue
May 11 2019, 2:01 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64474: FBX broken with the latest visibility changes commit 'b1af682 - Outliner Visibility Update'.

Setting line 987 of fbx_utils.by to

May 11 2019, 11:07 AM · BF Blender
Daniel Santana (dgsantana) created T64474: FBX broken with the latest visibility changes commit 'b1af682 - Outliner Visibility Update'.
May 11 2019, 10:17 AM · BF Blender

May 8 2019

Daniel Santana (dgsantana) added a comment to T64313: Wrong add selection to active collection operator description.

Not much confusion and I come from 3dsmax. Active Collection acts like the "active" layer, where all new stuff is added, like adding a new object, duplicates, and probably some more stuff.


The highlighted collection () in the outliner is the active collection.

May 8 2019, 11:22 PM · BF Blender

May 6 2019

Daniel Santana (dgsantana) added a comment to T64183: Crash on BKE_sound_scene_playing due to Scene NULL.

The bug was introduced in this commit: https://developer.blender.org/rBc5fe16e121eefe5dd02cc9f9ba572053c383ccfa

May 6 2019, 1:58 AM · BF Blender

May 5 2019

Daniel Santana (dgsantana) added a comment to T64183: Crash on BKE_sound_scene_playing due to Scene NULL.

I was able to "fix" with this patch. It's hacky, and there may some other problem lurking somewhere else, but at least this avoids crashing.

May 5 2019, 11:15 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64181: Blender 2.80 crashes when opening save file.

Hi, you can recover the scene, by using append and selecting the scene datablock. I also reported the same bug ;).

May 5 2019, 10:51 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64183: Crash on BKE_sound_scene_playing due to Scene NULL.

Using the provided scene in https://developer.blender.org/T64181 causes the same assertion, with the same stack trace.

May 5 2019, 10:50 PM · BF Blender
Daniel Santana (dgsantana) added a comment to T64183: Crash on BKE_sound_scene_playing due to Scene NULL.

Just some extra info, running a debug build an assert is triggered that confirms that the scene is in some invalid state.
Trigger at line 3096 on "source\blender\windowmanager\intern\wm_event_system.c" during DEG_get_evaluated_scene. It's possible to recover the scene with a simple Append of the scene datablock in a new scene.
If I get this to reproduce on a simple scene, I will post it here.

May 5 2019, 10:38 PM · BF Blender
Daniel Santana (dgsantana) updated the task description for T64183: Crash on BKE_sound_scene_playing due to Scene NULL.
May 5 2019, 10:16 PM · BF Blender
Daniel Santana (dgsantana) created T64183: Crash on BKE_sound_scene_playing due to Scene NULL.
May 5 2019, 10:08 PM · BF Blender

Apr 29 2019

Daniel Santana (dgsantana) created T64001: Support dragging to change tabs in the side-bar.
Apr 29 2019, 11:05 PM · BF Blender

Apr 13 2019

Daniel Santana (dgsantana) awarded T63518: Per viewport transform gizmo settings for select tools, remove transform tool a Love token.
Apr 13 2019, 3:20 PM · User Interface, BF Blender