Thomas Dinges (dingto)
Cycles developer

Projects (7)

User Details

User Since
Aug 31 2008, 5:42 PM (519 w, 5 d)

Recent Activity

Jul 5 2018

Thomas Dinges (dingto) added a comment to D3523: Cycles: Adding native support for UINT16 textures..

Nice Work, gread to see this being implemented, I was missing that in my 2016 GSoC, when I added half float support.

Jul 5 2018, 11:03 AM · Cycles

May 26 2018

Thomas Dinges (dingto) accepted D1543: Cycles: Add Support for IES files as textures for light strength.

Looks good to me. Thanks for updating this patch!

May 26 2018, 6:13 PM

Apr 9 2018

Thomas Dinges (dingto) added a comment to D3138: fix T54549: Vector Transform node in wrong nodeclass.

Don't worry about an emoji! :) I am just quite busy these days, so couldn't push it immediately myself. So you got commit access? Congrats and have fun pushing it! Thanks for the fix again!

Apr 9 2018, 10:27 PM
Thomas Dinges (dingto) accepted D3138: fix T54549: Vector Transform node in wrong nodeclass.

Good catch!

Apr 9 2018, 1:26 PM

Mar 14 2018

Thomas Dinges (dingto) added a comment to D3104: Cycles: make OpenImageIO optional (part 3).

Not sure why you uploaded several patches, this should all be in 1 single patch imho.

Mar 14 2018, 12:21 PM · Cycles

Mar 2 2018

Thomas Dinges (dingto) added a comment to D3089: Add Alembic loader to cycles standalone.

Interesting indeed! Having basic Alembic support for meshes would ne a nice addition to the standalone program, having mesh data as xml atm is not perfect.

Mar 2 2018, 9:15 AM · Cycles

Mar 1 2018

Thomas Dinges (dingto) accepted D3038: Cycles volume : fast empty space optimization by generating a tight mesh around the volume..

Code looks good to me! Nice work!

Mar 1 2018, 9:43 AM

Feb 19 2018

Thomas Dinges (dingto) updated subscribers of T54105: Wrong shading with "Random Walk" in combination with branched path tracing.

Confirmed, also happens with Glass BSDF. Any idea @Brecht Van Lommel (brecht)?

Feb 19 2018, 9:06 PM · BF Blender
Thomas Dinges (dingto) triaged T54105: Wrong shading with "Random Walk" in combination with branched path tracing as Confirmed priority.
Feb 19 2018, 8:53 PM · BF Blender
Thomas Dinges (dingto) added a comment to T54103: Solid color backgrounds have no multiple importance sampling causing volumes not to render properly .

Sorry, it's been a while. :)

Feb 19 2018, 3:23 PM · BF Blender
Thomas Dinges (dingto) claimed T54103: Solid color backgrounds have no multiple importance sampling causing volumes not to render properly .

Will check on that. Thanks for the report!

Feb 19 2018, 1:24 PM · BF Blender

Feb 17 2018

Thomas Dinges (dingto) committed rB9e717c0495a3: Cycles: Remove Fermi texture code. (authored by Thomas Dinges (dingto)).
Cycles: Remove Fermi texture code.
Feb 17 2018, 10:59 PM
Thomas Dinges (dingto) committed rBe1ef90205814: Cycles: Remove fermi related defines from the code. (authored by Thomas Dinges (dingto)).
Cycles: Remove fermi related defines from the code.
Feb 17 2018, 10:21 PM
Thomas Dinges (dingto) committed rB2eaf90b305fc: Cycles: Remove Fermi support from CMake and update runtime checks in… (authored by Thomas Dinges (dingto)).
Cycles: Remove Fermi support from CMake and update runtime checks in…
Feb 17 2018, 4:17 PM
Thomas Dinges (dingto) committed rB75396edb315c: Buildbot: Disable Cycles CUDA support on 32bit, and stop building sm_2x. (authored by Thomas Dinges (dingto)).
Buildbot: Disable Cycles CUDA support on 32bit, and stop building sm_2x.
Feb 17 2018, 3:50 PM

Feb 9 2018

Thomas Dinges (dingto) closed T54035: it does not work as Invalid.

Empty report, closing

Feb 9 2018, 11:35 AM · BF Blender

Feb 8 2018

Thomas Dinges (dingto) awarded D3054: Cycles: random walk subsurface scattering. a Love token.
Feb 8 2018, 9:08 PM

Aug 3 2017

Thomas Dinges (dingto) added a comment to D2768: Cycles: remove square samples option..

Sounds reasonable. :)

Aug 3 2017, 3:20 PM
Thomas Dinges (dingto) added a comment to D2764: Code refactor: use float4 instead of intrinsics for CPU denoise filtering..

Just some note about SSE2/3 in general, I think we can deprecate these soon (especially for 2.8x). Of course we still need a non SIMD Kernel for other architectures, but every computer that runs 2.8x should be modern enough to have SSE4 as well.

Aug 3 2017, 2:35 PM
Thomas Dinges (dingto) accepted D2768: Cycles: remove square samples option..

Don't think I will miss this, so fine with me. Just wondering if this (alongside your other UI / settings changes) is meant for 2.7x still or for 2.8x?

Aug 3 2017, 2:28 PM
Thomas Dinges (dingto) accepted D2767: Cycles: remove option to disable transparent shadows globally..
Aug 3 2017, 2:26 PM

Jun 14 2017

Thomas Dinges (dingto) added a comment to D2708: Cycles: Use correct multisample MIS model for branched path tracing.

Nice work Lukas!

Jun 14 2017, 11:42 AM

May 19 2017

Thomas Dinges (dingto) added a comment to D2679: Cycles: discard unused Principled BSDF inputs at shader compile time..

Don't think we need the extra _fac variants in constant fold. We can just use is_one and is_zero?

May 19 2017, 1:20 PM

Apr 27 2017

Thomas Dinges (dingto) committed rBa00f54332da1: Cleanup: Some style and code tweaks to Image Code after changes. (authored by Thomas Dinges (dingto)).
Cleanup: Some style and code tweaks to Image Code after changes.
Apr 27 2017, 11:12 AM

Apr 26 2017

Thomas Dinges (dingto) accepted D2650: Unlimited number of textures for Cycles.

Looks good to me then. :) We could only get half textures working on Fermi, if we take some of the float4 slots and make them half4 ones, but I wouldn't bother.

Apr 26 2017, 10:30 PM
Thomas Dinges (dingto) requested changes to D2650: Unlimited number of textures for Cycles.
Apr 26 2017, 4:55 PM
Thomas Dinges (dingto) added a comment to D2650: Unlimited number of textures for Cycles.

In general looks fine. Should be a first step towards easier code in this area. Once we can drop Fermi fully (as soon as nvidia drops it with CUDA 9), we can simplify it even further and get rid of the special cases.

Apr 26 2017, 4:52 PM
Thomas Dinges (dingto) edited reviewers for D2650: Unlimited number of textures for Cycles, added: Cycles; removed: Brecht Van Lommel (brecht), Lukas Stockner (lukasstockner97), Mai Lavelle (maiself), Sergey Sharybin (sergey).
Apr 26 2017, 4:32 PM
Thomas Dinges (dingto) added a comment to D2650: Unlimited number of textures for Cycles.

Please always assign entire Cycles project as Reviewers. I refactored most of the image code last year, so I'd like a chance to check on the proposed changes here too. Quite busy atm, but will check in the coming days.

Apr 26 2017, 4:31 PM

Apr 3 2017

Thomas Dinges (dingto) accepted D2595: [Cycles/msvc] Get cycles_kernel compile time under control..

Thank you for changing it, I prefer code readability and the ability to quickly debug stuff there over some very small speedup. :)

Apr 3 2017, 3:46 PM · Cycles
Thomas Dinges (dingto) requested changes to D2595: [Cycles/msvc] Get cycles_kernel compile time under control..

I don't see why you changed the if/else to switch statements, you said that the matrix inlining is responsible for the slow compilation?

Apr 3 2017, 1:58 PM · Cycles

Mar 28 2017

Thomas Dinges (dingto) accepted D2586: Cycles: Make all #include statements relative to cycles source directory.

I don't see an issue with this approach, fine with it.

Mar 28 2017, 8:50 PM

Mar 27 2017

Thomas Dinges (dingto) committed rB6a5e92c0222b: Cleanup: Use upper case consistently in adaptive feature compile logging. (authored by Thomas Dinges (dingto)).
Cleanup: Use upper case consistently in adaptive feature compile logging.
Mar 27 2017, 10:53 PM
Thomas Dinges (dingto) committed rB7a65f9b1716f: Cleanup: Resolve todo in CUDA voxel image code. (authored by Thomas Dinges (dingto)).
Cleanup: Resolve todo in CUDA voxel image code.
Mar 27 2017, 10:37 PM
Thomas Dinges (dingto) committed rB0df33cc52d20: Cycles UI: Avoid abreviation for Hair Extension. (authored by Thomas Dinges (dingto)).
Cycles UI: Avoid abreviation for Hair Extension.
Mar 27 2017, 10:00 PM
Thomas Dinges (dingto) committed rB0cfc557c5d20: Cycles: Move Shadow Catcher UI option next to Ray Visibility. (authored by Thomas Dinges (dingto)).
Cycles: Move Shadow Catcher UI option next to Ray Visibility.
Mar 27 2017, 9:53 PM

Mar 21 2017

Thomas Dinges (dingto) added a comment to T51019: Low FPS in new versions.

Please write your report in English.

Mar 21 2017, 10:43 AM · BF Blender
Thomas Dinges (dingto) accepted D1788: Cycles: Experiment with shadow catcher.

Read through the code quickly, looks good to me. Just found one little code style issue. :)

Mar 21 2017, 9:58 AM

Mar 19 2017

Thomas Dinges (dingto) closed T50997: Schrift verändert sich! as Invalid.

This is not a valid bug report. Please ask in a Blender forum for user help!

Mar 19 2017, 12:44 PM · BF Blender

Mar 1 2017

Thomas Dinges (dingto) accepted rB49c99549eb19: Cleanup: Use .enabled instead of .active.

Thanks for fixing the comment.

Mar 1 2017, 8:29 PM
Thomas Dinges (dingto) raised a concern with rB49c99549eb19: Cleanup: Use .enabled instead of .active.

Please be more precise when changing such things, how is that a cleanup? Also the comment still mentions ".active" which is now meaningless after the change.

Mar 1 2017, 7:55 PM

Feb 18 2017

Thomas Dinges (dingto) updated subscribers of T50700: Possible NaNs with refractive BSDF.

Doesn't look like a bug, just reflections from the lamp. Disable MIS for the lamp and the birght spots go away.

Feb 18 2017, 10:38 PM · BF Blender, Cycles
Thomas Dinges (dingto) closed T50711: OpenCL build on render fails on "Compiling OpenCL program split_direct_lighting" as Invalid.

Correct, we only support HD 7000 cards and above with GCN architecture.

Feb 18 2017, 11:31 AM · BF Blender

Feb 17 2017

Thomas Dinges (dingto) awarded D2513: Cycles: Speed up by avoiding extra calulations when unneeded a Like token.
Feb 17 2017, 4:12 PM

Feb 4 2017

Thomas Dinges (dingto) edited reviewers for D2499: procedural textures - lyapunov and mandelbulb fractals, added: Cycles; removed: Thomas Dinges (dingto).
Feb 4 2017, 10:43 PM · Cycles, BF Blender

Jan 28 2017

Thomas Dinges (dingto) triaged T50545: cycles render error as Incomplete priority.

We expect clear instructions and if possible a blend file showcasing the issue, as clearly outlined in our bug report guidelines.

Jan 28 2017, 12:10 PM · BF Blender

Jan 20 2017

Thomas Dinges (dingto) committed rBff1b850081b0: Fix T50460. Greying out issue with Cycles culling options. (authored by Thomas Dinges (dingto)).
Fix T50460. Greying out issue with Cycles culling options.
Jan 20 2017, 10:58 AM
Thomas Dinges (dingto) closed T50460: Cycles cull option ui problem as Resolved by committing rBff1b850081b0: Fix T50460. Greying out issue with Cycles culling options..
Jan 20 2017, 10:58 AM · User Interface, Cycles, BF Blender
Thomas Dinges (dingto) committed rB05ff32bd250d: Fix compile error (-Werror=float-conversion). (authored by Thomas Dinges (dingto)).
Fix compile error (-Werror=float-conversion).
Jan 20 2017, 10:51 AM
Thomas Dinges (dingto) added a comment to T50460: Cycles cull option ui problem.

I don't see how this is an underlying issue with the layout engine. Using a .active or .disabled tag, assigned to a certain layout block will affect all of its assigned properties. So using two different UI blocks is a proper fix.

Jan 20 2017, 10:37 AM · User Interface, Cycles, BF Blender

Jan 14 2017

Thomas Dinges (dingto) added a comment to D2348: Cycles: Refactor split kernel and implement for CPU.

I would not scatter Cycles development at this point, either we move all Cycles development to the 2.8 branch (which I wouldn't do just yet) or we stick to master. Putting some things into the branch while keeping maintenance and smaller changes in master will only ask for trouble later. Also we still have a few months until a 2.79 release, enough time to fix issues when they come up.

Jan 14 2017, 3:16 PM

Jan 6 2017

Thomas Dinges (dingto) added a comment to D2441: [Cycles] Add rounded corners to brick texture. .

I don't see this as a new texture or special case, more as a reasonable improvement to an already implemented procedural texture.

Jan 6 2017, 11:57 AM

Jan 3 2017

Thomas Dinges (dingto) accepted D2441: [Cycles] Add rounded corners to brick texture. .

I tested the patch quickly, works nicely. LGTM from my side. Thanks for the addition!

Jan 3 2017, 6:45 PM
Thomas Dinges (dingto) added inline comments to D2441: [Cycles] Add rounded corners to brick texture. .
Jan 3 2017, 8:29 AM

Jan 2 2017

Thomas Dinges (dingto) added inline comments to D2441: [Cycles] Add rounded corners to brick texture. .
Jan 2 2017, 10:33 PM
Thomas Dinges (dingto) added a reviewer for D2441: [Cycles] Add rounded corners to brick texture. : Thomas Dinges (dingto).

Nice addition!

Jan 2 2017, 10:29 PM

Dec 27 2016

Thomas Dinges (dingto) added a comment to T50268: Cycles allows to select un supported GPUs for OpenCL.

We explicitly white list certain OpenCL configurations, not sure we differentiate correctly on OSX though.

Dec 27 2016, 8:29 PM · Cycles, BF Blender
Thomas Dinges (dingto) closed T50268: Cycles allows to select un supported GPUs for OpenCL as Archived.

Intel GPUs are not officially supported yet for Cycles rendering. This might change in the future, with various split kernel improvements, but for now it's a known limitation.

Dec 27 2016, 8:14 PM · Cycles, BF Blender

Dec 26 2016

Thomas Dinges (dingto) added a comment to T50309: Renderman v21.2 settings in cycles.

Do you have a Renderman addon enabled? Disable it and it should be fine. If you use a vanilla Blender build without addon it works fine.

Dec 26 2016, 7:56 PM · BF Blender
Thomas Dinges (dingto) closed T50327: SPAM as Invalid.
Dec 26 2016, 7:53 PM
Thomas Dinges (dingto) closed T50326: SPAM as Invalid.
Dec 26 2016, 7:53 PM
Thomas Dinges (dingto) renamed T50314: SPAM from Supporting call $$ 1~800+204-4122$$$$ TOSHIBA printer customer Support phone number usa Call to SPAM.
Dec 26 2016, 7:50 PM
Thomas Dinges (dingto) renamed T50315: SPAM from WirLESS pRiNter $$+18002044122 ++ LEXMARK printer customer SErVice phone number to SPAM.
Dec 26 2016, 7:50 PM
Thomas Dinges (dingto) renamed T50316: SPAM from WirLESS pRiNter $$+18002044122 ++ KODAK printer customer SErVice phone number to SPAM.
Dec 26 2016, 7:49 PM
Thomas Dinges (dingto) renamed T50317: SPAM from contact number $$$$18002044122 $$$$HPtech support customer service number helpline number to SPAM.
Dec 26 2016, 7:49 PM
Thomas Dinges (dingto) renamed T50318: SPAM from DDLJ ♥@@Canada 18002044122 FREE CANONsupport number, CANONsupport, Aol to SPAM.
Dec 26 2016, 7:49 PM
Thomas Dinges (dingto) renamed T50320: SPAM from contact number 18002044122 MAC APPLE tech support customer service number helpline number to SPAM.
Dec 26 2016, 7:48 PM
Thomas Dinges (dingto) renamed T50321: SPAM from contact number 18002044122 PANASONIC tech support customer service number helpline number to SPAM.
Dec 26 2016, 7:48 PM
Thomas Dinges (dingto) renamed T50325: SPAM from LEXMARK:>> Call USA**** 18002044122@@ LEXMARKprinter tech support phone number usa to SPAM.
Dec 26 2016, 7:48 PM
Thomas Dinges (dingto) renamed T50323: SPAM from ++**D ~Support ***1~800~204~4122** LEXMARK printer Customer SUPPORT phone number, to SPAM.
Dec 26 2016, 7:47 PM
Thomas Dinges (dingto) renamed T50319: SPAM from contact number 18002044122 EPSONtech support customer service number helpline number to SPAM.
Dec 26 2016, 7:47 PM
Thomas Dinges (dingto) renamed T50324: SPAM from C@ll U$$D ***$$ 18002044122 \\\\\\$*** LEXMARKprinter tech support phone number usa to SPAM.
Dec 26 2016, 7:46 PM
Thomas Dinges (dingto) renamed T50322: SPAM from @@Canada 18002044122 FREE XEROXsupport number, XEROXsupport, Aol to SPAM.
Dec 26 2016, 7:46 PM
Thomas Dinges (dingto) added a comment to T50322: SPAM.

Please edit the content of such reports to "SPAM" or whatever too, so the content disappears.

Dec 26 2016, 7:45 PM
Thomas Dinges (dingto) renamed T50326: SPAM from Tech Support $$18002044122 ####### TOSHIBA printer customer Support phone number usa Call to SPAM.
Dec 26 2016, 7:45 PM
Thomas Dinges (dingto) renamed T50327: SPAM from ((1~800~204~4122)}}}})Samsung printer support phone number, Samsung printer support phone to SPAM.
Dec 26 2016, 7:44 PM

Dec 24 2016

Thomas Dinges (dingto) added a comment to T50292: SSS + Win10-64bit + gtx1070.

Try lowering the sub samples (Diffuse, SSS). That might help.

Dec 24 2016, 12:04 AM · BF Blender

Dec 23 2016

Thomas Dinges (dingto) renamed T50298: <WAS SPAM> from Tech service Support $$448002605606 ++++ TOSHIBA printer customer Support phone number usa Call to SPAM.
Dec 23 2016, 10:03 PM

Dec 14 2016

Vincent Olivier (up4) awarded T38279: Improve Cycles standalone a Like token.
Dec 14 2016, 1:36 AM · BF Blender, Cycles

Dec 8 2016

Thomas Dinges (dingto) added a comment to D2406: Cycles: Experiment with cutout object.

Idea and code looks good to me. :) Having this as a closure seems good, more intuitive than adding yet another UI checkbox to object/mesh data settings imo.

Dec 8 2016, 4:12 PM
Thomas Dinges (dingto) requested changes to D2399: Cycles: Expose diffuse and glossy depth to Light Path node.

Easy to add now, much better than before my refactor, which made PathState available to SVM directly. :)

Dec 8 2016, 9:36 AM
Thomas Dinges (dingto) added a comment to T50193: Cycles renders volumetrics very differently on CPU vs. GPU.

Decoupled Ray Marching for homogeneous volumes should work on GPU (when enabled via ifdefs of course), but when I tested that, it wasn't stable. For heterogenous volumes, the current code uses dynamic mem alloc, which is slow on GPU and was giving me mem errors. That was 1-2 years ago though, situation might have changed.

Dec 8 2016, 9:33 AM · BF Blender, Cycles

Nov 29 2016

Thomas Dinges (dingto) updated the task description for T50134: Rendering.
Nov 29 2016, 12:16 PM · Animation
Thomas Dinges (dingto) triaged T50134: Rendering as Incomplete priority.

We need a clear way to reproduce the issue, with an example blend file. Also, 2.77a is old, please try the 2.78a release. Also, are you on Windows, Linux, Mac?

Nov 29 2016, 12:15 PM · Animation

Nov 26 2016

Thomas Dinges (dingto) closed T50114: Open GL 2.1 as Invalid.

Seems you run an old and unsupported GPU/driver. There is nothing we can do to fix this.

Nov 26 2016, 3:48 PM · BF Blender

Nov 14 2016

Thomas Dinges (dingto) awarded rBb047d79871ce: Cycles: De-duplicate image loading functions a Like token.
Nov 14 2016, 2:14 PM

Nov 7 2016

Thomas Dinges (dingto) committed rB99127925642b: Forgot this in last commit. (Brick GLSL). (authored by Thomas Dinges (dingto)).
Forgot this in last commit. (Brick GLSL).
Nov 7 2016, 8:59 PM
Thomas Dinges (dingto) committed rB28639a22bcba: Fix Brick Texture GLSL, broken after Mortar Smooth addition. (authored by Thomas Dinges (dingto)).
Fix Brick Texture GLSL, broken after Mortar Smooth addition.
Nov 7 2016, 8:55 PM

Oct 20 2016

Thomas Dinges (dingto) added a comment to D2313: Cycles Disney BRDF.

Thanks for submitting the patch. Haven't tested it yet, but some comment about code style. That should be fixed in all places.

Oct 20 2016, 11:38 PM · Cycles

Oct 17 2016

Thomas Dinges (dingto) added a comment to D2299: Cycles: OpenCL 3d textures.

OpenCL split kernel doesn't support volume rendering yet.

Oct 17 2016, 2:14 PM

Oct 14 2016

Thomas Dinges (dingto) renamed T49705: Removed SPAM from USA$$U$$*****++++ I8008506928 +++********Epson printer tech support phone number usa Call to Removed SPAM.
Oct 14 2016, 9:21 PM
Thomas Dinges (dingto) added a comment to D2299: Cycles: OpenCL 3d textures.

Haven't tested the patch but code looks ok to me. Nice work! Have you tested this with both Mega and Split OpenCL kernel?

Oct 14 2016, 1:47 PM

Oct 13 2016

Thomas Dinges (dingto) closed T49642: OSL shader metadata and widget's not showing as Archived.

Hi,
we don't support OSL metadata yet, that has never been implemented. It's a known (low priority) todo.

Oct 13 2016, 12:44 PM · BF Blender, Cycles

Oct 12 2016

Thomas Dinges (dingto) added a comment to D2132: Enable Cycles Sky Texture in OpenGL viewport.

I am against putting this into e.g. extern/. It's part of Cycles SVM/OSL shading system and we should not start outsourcing such things here imho. Then I'd rather have these files twice in the source tree (once Cycles, once GLSL).

Oct 12 2016, 7:01 PM · OpenGL / Gfx, Cycles

Oct 10 2016

Thomas Dinges (dingto) added a comment to T49620: Grey scene when rendering with OpenCL.

Blender 2.78 is out, please update to the latest version and try again.

Oct 10 2016, 6:52 PM · Cycles, BF Blender

Oct 8 2016

Thomas Dinges (dingto) closed T49606: Cycles Hair Rendering panel is in the Particle System properties, even though it's a scene property as Archived.

This bugtracker is for bugs only, and the above mentioned behavior has been a design decision, and therefore works as intended.

Oct 8 2016, 1:12 PM · User Interface, BF Blender

Oct 7 2016

Thomas Dinges (dingto) added a comment to T49603: Blender/Cycles 2.78 CUDA error on Jetson-TX1.

My bad. Thanks Julian!

Oct 7 2016, 10:00 PM · BF Blender, Cycles
Thomas Dinges (dingto) added projects to T49603: Blender/Cycles 2.78 CUDA error on Jetson-TX1: BF Blender: 2.8, Cycles.

Not sure we do support Tegra devices. @Sergey Sharybin (sergey) @Brecht Van Lommel (brecht) ?

Oct 7 2016, 8:17 PM · BF Blender, Cycles
Thomas Dinges (dingto) added a comment to T49602: Selection for GPUs to render.

Hey,
It will happen when some developer picks it up and implements it. :)

Oct 7 2016, 8:11 PM
Thomas Dinges (dingto) closed T49602: Selection for GPUs to render as Archived.

This is a known todo, and has been requested many times already in various places. :) We will tackle it at some point.

Oct 7 2016, 7:51 PM