Page MenuHome

Clément Foucault (fclem)
Musician

Projects (11)

User Details

User Since
Jul 9 2014, 7:45 PM (375 w, 4 d)

Recent Activity

Yesterday

Clément Foucault (fclem) claimed T87801: Eevee ambient occlusion is incorrect on M1 macMini.

This will be tackled next week.

Sat, Sep 18, 12:56 PM · EEVEE & Viewport, Platform: macOS, BF Blender

Fri, Sep 17

Clément Foucault (fclem) added a comment to T89556: EEVEE lighsource reflections bug or feature? (shadowmap blocking).

Shadowing (or visibility) is not generally separable from shading but for realtime rendering purpose we consider this to be true as we only have shadowing information for one direction.

Fri, Sep 17, 5:47 PM · EEVEE & Viewport, BF Blender
Alexey Adamitsky (AlexeyAdamitsky) awarded T91293: Realtime Viewport Compositor a Love token.
Fri, Sep 17, 1:09 PM · EEVEE & Viewport

Thu, Sep 16

Andres Stephens (Draise) awarded rBae226426907d: Viewport Compositor: Initial commit a Love token.
Thu, Sep 16, 2:06 PM
Andres Stephens (Draise) awarded T91293: Realtime Viewport Compositor a Love token.
Thu, Sep 16, 2:05 PM · EEVEE & Viewport
Clément Foucault (fclem) accepted D12508: EEVEE fix gloss low roughness error.
Thu, Sep 16, 8:58 AM

Mon, Sep 13

Justin (blenux) awarded T68990: Vulkan support a Love token.
Mon, Sep 13, 4:38 PM · EEVEE & Viewport, BF Blender

Sun, Sep 12

Matteo Scopel (scopelma) awarded T68477: Parallax Occlusion Mapping a Love token.
Sun, Sep 12, 2:26 PM · EEVEE & Viewport

Sat, Sep 11

Clément Foucault (fclem) added a comment to D10481: Hair Info Length Attribute.

This is exactly what I had in mind. If there is no more memory leak, I think we are good to go.

Sat, Sep 11, 2:45 PM · Rendering, Nodes, EEVEE & Viewport, Render & Cycles

Fri, Sep 10

Gavriel Lavi (Gavriel5578) awarded T91293: Realtime Viewport Compositor a Pterodactyl token.
Fri, Sep 10, 10:38 PM · EEVEE & Viewport
Clément Foucault (fclem) added a comment to D10948: XR Controller Support Step 4: Controller Drawing.

@Julian Eisel (Severin) I do agree that creating a dedicated function call instead of using a registered callback is preferable. Just doing something like ED_annotation_draw_view3d should be enough and the XR draw routine should decide what to draw.

Fri, Sep 10, 10:13 PM · Virtual Reality
Clément Foucault (fclem) requested review of D12455: GHOST: Unify behavior of offscreen context creation.
Fri, Sep 10, 10:06 PM
Clément Foucault (fclem) accepted D10948: XR Controller Support Step 4: Controller Drawing.

For me it's good to go.

Fri, Sep 10, 3:28 PM · Virtual Reality
Clément Foucault (fclem) added inline comments to D12351: Fix T83529: Horizontal stripe artifacts in image editor.
Fri, Sep 10, 3:24 PM
Clément Foucault (fclem) added inline comments to D10481: Hair Info Length Attribute.
Fri, Sep 10, 2:08 PM · Rendering, Nodes, EEVEE & Viewport, Render & Cycles
Clément Foucault (fclem) requested changes to D10948: XR Controller Support Step 4: Controller Drawing.
Fri, Sep 10, 1:52 PM · Virtual Reality
Marcel Freyer (WorldBuilder) awarded T91293: Realtime Viewport Compositor a Like token.
Fri, Sep 10, 10:48 AM · EEVEE & Viewport
Vitalii Vlasov (Fracture128) awarded T91293: Realtime Viewport Compositor a Like token.
Fri, Sep 10, 10:32 AM · EEVEE & Viewport
Vitalii Vlasov (Fracture128) awarded T91296: Realtime Compositor GLSL node support a Like token.
Fri, Sep 10, 10:31 AM · EEVEE & Viewport
Paul Larson (GeorgiaPacific) awarded T91293: Realtime Viewport Compositor a Like token.
Fri, Sep 10, 2:14 AM · EEVEE & Viewport
Paul Larson (GeorgiaPacific) awarded T91296: Realtime Compositor GLSL node support a Like token.
Fri, Sep 10, 2:13 AM · EEVEE & Viewport
Alaska (Alaska) awarded T91293: Realtime Viewport Compositor a Love token.
Fri, Sep 10, 1:33 AM · EEVEE & Viewport
Jacob Merrill (blueprintrandom) awarded T91296: Realtime Compositor GLSL node support a Love token.
Fri, Sep 10, 1:13 AM · EEVEE & Viewport
Charlie Jolly (charlie) awarded T91296: Realtime Compositor GLSL node support a Love token.
Fri, Sep 10, 1:01 AM · EEVEE & Viewport
Yuro (Yuro) awarded T91293: Realtime Viewport Compositor a Love token.
Fri, Sep 10, 12:04 AM · EEVEE & Viewport

Thu, Sep 9

Stig Oskar (Stig) awarded T91293: Realtime Viewport Compositor a Love token.
Thu, Sep 9, 10:54 PM · EEVEE & Viewport
Jeroen Bakker (jbakker) awarded T91293: Realtime Viewport Compositor a Love token.
Thu, Sep 9, 10:26 PM · EEVEE & Viewport
Clément Foucault (fclem) created T91296: Realtime Compositor GLSL node support.
Thu, Sep 9, 9:01 PM · EEVEE & Viewport
Clément Foucault (fclem) updated the task description for T91293: Realtime Viewport Compositor.
Thu, Sep 9, 8:40 PM · EEVEE & Viewport
Clément Foucault (fclem) changed the status of T91293: Realtime Viewport Compositor from Needs Triage to Confirmed.
Thu, Sep 9, 8:38 PM · EEVEE & Viewport
Clément Foucault (fclem) added a comment to D10948: XR Controller Support Step 4: Controller Drawing.

I have no issue with the drawing being a callback in the draw manager.

Thu, Sep 9, 5:36 PM · Virtual Reality
Clément Foucault (fclem) added inline comments to D10948: XR Controller Support Step 4: Controller Drawing.
Thu, Sep 9, 5:33 PM · Virtual Reality
Clément Foucault (fclem) added inline comments to D12406: OpenSubDiv: add support for an OpenGL evaluator.
Thu, Sep 9, 4:58 PM
Clément Foucault (fclem) updated subscribers of D12375: PyAPI: GPU Shader: Humanize uniform_sampler parameters.

I looked at the addons that come with Blender and noticed that they all use the draw_texture_2d utility to draw textures. So I just edited this utility to avoid breakage.

Avoiding breakage only for our addons is not enough to me. This also complicates the usage of the API for simple scripts. Also depth texture do not have filter by default.

Thu, Sep 9, 1:14 PM

Wed, Sep 8

Clément Foucault (fclem) added a comment to D12375: PyAPI: GPU Shader: Humanize uniform_sampler parameters.

Therefore, gpu.types.GPUTextureState would only be useful for the uniform_sampler(...) method. Which makes me wonder if creating a new object for a single method wouldn't be too much.

This is a valid concern. The benefit of using an object is that it's easy to setup once and reuse, have error checking on assignment, and it replaces all states at once where distinct parameters would only override some.

Wed, Sep 8, 10:12 PM
Clément Foucault (fclem) added a comment to D12375: PyAPI: GPU Shader: Humanize uniform_sampler parameters.

The issue with changing the texture parameters is that if the texture comes from Blender (i.e: image Texture) the state changes will propagate to the internals of blender. I would like to avoid this case.

Wed, Sep 8, 5:06 PM
Clément Foucault (fclem) awarded D12406: OpenSubDiv: add support for an OpenGL evaluator a Mountain of Wealth token.
Wed, Sep 8, 9:25 AM
Clément Foucault (fclem) added a comment to D12375: PyAPI: GPU Shader: Humanize uniform_sampler parameters.

My point is that it should not be a flag but an object with different properties. This way it's much cleaner to setup.

Wed, Sep 8, 9:24 AM
Clément Foucault (fclem) accepted D12388: Fix T90825: Performance texture painting with limited scale..
Wed, Sep 8, 9:10 AM · Sculpt, Paint & Texture, EEVEE & Viewport

Tue, Sep 7

Clément Foucault (fclem) added a comment to D12406: OpenSubDiv: add support for an OpenGL evaluator.

First of all, impressive result. Do note that I'm not familiar with how OpenSubDiv works.

Tue, Sep 7, 10:52 PM
Clément Foucault (fclem) requested changes to D12388: Fix T90825: Performance texture painting with limited scale..

Seems to be the good thing to do to fix the issue. I'm just not sold on the naming used. But feature wise it's good to go.

Tue, Sep 7, 7:40 PM · Sculpt, Paint & Texture, EEVEE & Viewport
Clément Foucault (fclem) added inline comments to D12375: PyAPI: GPU Shader: Humanize uniform_sampler parameters.
Tue, Sep 7, 6:57 PM
Clément Foucault (fclem) accepted D12190: Asset: Dropping Material assets on material slot under mouse cursor..
Tue, Sep 7, 6:47 PM · EEVEE & Viewport, Asset Browser

Mon, Sep 6

Clément Foucault (fclem) accepted D11841: Geometry Nodes: Initial support for geometry instancing..
Mon, Sep 6, 5:30 PM

Fri, Sep 3

Clément Foucault (fclem) added a comment to D12375: PyAPI: GPU Shader: Humanize uniform_sampler parameters.

This has the side effect that if a previously written code uses uniform_sampler it will now always override the texture internal sampler parameters which are set by default.
But since there is currently no possibility to modify the internal texture state using PyGPU, I would not consider this a major issue.

Fri, Sep 3, 10:16 PM
Clément Foucault (fclem) accepted D12039: Cycles X: Use GPUDisplay for non-interactive render.

Looks good to me. Patch is quite straightforward.

Fri, Sep 3, 9:56 PM
Clément Foucault (fclem) added a comment to T91168: Collection holdout on grease pencil objects.

Yes, this is unsupported for now. However, I'm not sure even if Gpencil should have this functionallity. It is an easy feature to add though, since Gpencil materials now support creating "holes".

Fri, Sep 3, 9:20 PM · Grease Pencil, BF Blender
Clément Foucault (fclem) requested changes to D11841: Geometry Nodes: Initial support for geometry instancing..

Did simple tests. Seems to work fine with EEVEE and other viewport engines.

Fri, Sep 3, 6:02 PM

Wed, Sep 1

Clément Foucault (fclem) raised a concern with rB2aad8fc7bc2a: PyAPI: GPU Shader: add 'state' parameter to uniform sampler.

I'm not sure that exposing all enums is the way to go. It sure was the easiest option for your testing.

Wed, Sep 1, 11:19 PM

Tue, Aug 31

EthanHall (Ethan1080) awarded rB1c22b551d0c1: EEVEE: Add ensure_valid_reflection to glossy closures a Love token.
Tue, Aug 31, 8:43 PM
Clément Foucault (fclem) awarded D12332: Draw Manager: Optimize populate loop. a Like token.
Tue, Aug 31, 9:41 AM · EEVEE & Viewport
Clément Foucault (fclem) requested changes to D12190: Asset: Dropping Material assets on material slot under mouse cursor..

Selection as a whole is getting a bit too much inside the draw manager but it's a lesser evil than having a dedicated selection engine for overlays.
Maybe one day we will just have this dedicated engine with simpler drawing for overlays but I doubt.

Tue, Aug 31, 9:39 AM · EEVEE & Viewport, Asset Browser

Mon, Aug 30

Clément Foucault (fclem) accepted D12259: GPencil: Fix T90742 ghost point on selection.

Nice find! Thanks for the time you put into this fix!

Mon, Aug 30, 10:35 AM · Grease Pencil

Wed, Aug 25

kursad k (kursadk) awarded T68990: Vulkan support a Love token.
Wed, Aug 25, 6:04 PM · EEVEE & Viewport, BF Blender
Destro (Destrosvet) awarded T68990: Vulkan support a Love token.
Wed, Aug 25, 2:54 PM · EEVEE & Viewport, BF Blender

Aug 20 2021

Andres Stephens (Draise) awarded rB520962b3d6bf: EEVEE: Lights: Support infinite light count a Love token.
Aug 20 2021, 5:24 PM

Aug 13 2021

pedro machado (pedropm) awarded T68477: Parallax Occlusion Mapping a Love token.
Aug 13 2021, 9:16 PM · EEVEE & Viewport

Aug 11 2021

Clément Foucault (fclem) accepted D12194: Fix FTBFS on mips64el architecture.
Aug 11 2021, 5:57 PM · BF Blender (2.93)
Clément Foucault (fclem) added a comment to D12194: Fix FTBFS on mips64el architecture.

Maybe mip_count is better then. These are the number of mipmap levels. mips being plural was just shorter.

Aug 11 2021, 5:10 PM · BF Blender (2.93)

Aug 10 2021

Clément Foucault (fclem) added inline comments to D11841: Geometry Nodes: Initial support for geometry instancing..
Aug 10 2021, 3:59 PM
Clément Foucault (fclem) awarded T90576: As a user I want to apply an material to the material slot under the mouse cursor. a Love token.
Aug 10 2021, 2:31 PM · Asset Browser

Aug 5 2021

Clément Foucault (fclem) accepted D5490: DRW: New Select Debug Engine.
Aug 5 2021, 3:47 PM

Aug 3 2021

Clément Foucault (fclem) added inline comments to D5490: DRW: New Select Debug Engine.
Aug 3 2021, 9:16 PM
Clément Foucault (fclem) accepted D5490: DRW: New Select Debug Engine.
Aug 3 2021, 9:15 PM
Vyacheslav (hitrpr) awarded T88368: Regression: broken normal shading, sharp edges appear on smooth surfaces. a Burninate token.
Aug 3 2021, 2:57 PM · BF Blender (2.93), EEVEE & Viewport
Chingiz Jumagulov (Krayzmond) awarded T88368: Regression: broken normal shading, sharp edges appear on smooth surfaces. a Burninate token.
Aug 3 2021, 2:20 PM · BF Blender (2.93), EEVEE & Viewport

Jul 23 2021

Clément Foucault (fclem) added a comment to D11858: VR: Fix for Viewport Denoising Artifacts.

Looks good to me now! I'm wondering though, by how much does this increase VRAM usage? I guess duplicating the buffers, which aren't exactly small is not going to be too cheap.

@Clément Foucault (fclem) is there any good reason to even have a history buffer for VR, where we just constantly redraw with changed view matrices? I guess if the history buffer is only used for AA, that wouldn't work well in VR anyway.

Jul 23 2021, 2:27 PM · Virtual Reality

Jul 22 2021

Mario Hawat (kyraneth) awarded T68477: Parallax Occlusion Mapping a Love token.
Jul 22 2021, 4:45 PM · EEVEE & Viewport
Clément Foucault (fclem) added a comment to D11489: enable Wayland via environment variable at runtime.

I don't see any issues either. I think it is better to introduce the change now to track any potential issue down the road.

Jul 22 2021, 2:39 PM

Jul 19 2021

Clément Foucault (fclem) requested review of D11966: DRW: Move buffer & temp textures & framebuffer management to DrawManager.
Jul 19 2021, 7:47 PM
yoann (softyoda) awarded T68477: Parallax Occlusion Mapping a Love token.
Jul 19 2021, 7:27 PM · EEVEE & Viewport
Clément Foucault (fclem) added a comment to D11841: Geometry Nodes: Initial support for geometry instancing..

All I see should work fine, as long as the objects passed for evaluation are tagged as dupli objects (BASE_FROM_DUPLI).

Jul 19 2021, 6:58 PM
Clément Foucault (fclem) closed T87480: Closed model light leakage problem as Archived.

The issue is that shadow mapping (the shadow technique used in EEVEE) is not a perfect shadowing solution and will always leak a small amount of light.

Jul 19 2021, 11:03 AM · EEVEE & Viewport, BF Blender

Jul 17 2021

Clément Foucault (fclem) added a comment to D11843: Fix T89684: GPU builtin uniforms refactor..

What I don't really like:

  • Builtin Block definitions are not in the shader itself: Having it declared in the compilation call makes it hard to follow. For this I would prefer to have a sort of include system.
  • Depending on the complexity, the struct declaration could be shared just like in eevee-rewrite branch. Not sure if it is a problem if the structs are only a handfull.
  • Builtin Blocks are monolithic. Impossible to reuse. For instance I would keep a ViewBlock and a ModelBlock separated and even not managed by the shader, only by the GPUMatrix module. I would put the srgbTransform and color uniforms into the same block.
Jul 17 2021, 3:15 PM · EEVEE & Viewport

Jul 6 2021

Gilberto Rodrigues (gilberto_rodrigues) awarded rB520962b3d6bf: EEVEE: Lights: Support infinite light count a Love token.
Jul 6 2021, 6:26 AM

Jul 3 2021

Mindinsomnia (mindinsomnia) awarded rB520962b3d6bf: EEVEE: Lights: Support infinite light count a Love token.
Jul 3 2021, 7:09 PM
Mindinsomnia (mindinsomnia) awarded rB5697f96608ce: EEVEE: Light: 2.5D Culling: Initial implementation a Love token.
Jul 3 2021, 7:06 PM
Mindinsomnia (mindinsomnia) awarded rB89af2b0485fc: EEVE: Lights: Implement simple culling scheme. a Love token.
Jul 3 2021, 7:05 PM

Jun 29 2021

Clément Foucault (fclem) added a comment to T89525: Migrate OpenGL Shaders to Vulkan..

Another thing to not forget is how does one updates a pyGPU shader to this version.

Jun 29 2021, 7:49 PM · EEVEE & Viewport, BF Blender
Daniel Houghton (dhoughto) awarded T54638: OpenGL headless rendering a Love token.
Jun 29 2021, 6:20 PM · EEVEE & Viewport

Jun 22 2021

Christian Clavet (christianclavet) awarded T68990: Vulkan support a Love token.
Jun 22 2021, 2:08 PM · EEVEE & Viewport, BF Blender

Jun 21 2021

Clément Foucault (fclem) accepted D10810: Fix widget emboss: Also fade emboss on the right side.
Jun 21 2021, 9:41 PM · User Interface

Jun 17 2021

Juanfran Matheu (jfmatheu) awarded T80730: BGL deprecation a Love token.
Jun 17 2021, 4:07 PM · BF Blender (2.93), EEVEE & Viewport

Jun 15 2021

Clément Foucault (fclem) accepted D11588: DRAW Cache: sanitize 'DRW_mesh_batch_cache_dirty_tag'.

Dirty but better than nothing.

Jun 15 2021, 8:09 PM
massmaster (massmaster) awarded T80730: BGL deprecation a Like token.
Jun 15 2021, 1:21 AM · BF Blender (2.93), EEVEE & Viewport

Jun 14 2021

Simon Sommer (CreatorSiSo) awarded T68990: Vulkan support a Burninate token.
Jun 14 2021, 4:19 PM · EEVEE & Viewport, BF Blender

Jun 13 2021

Clément Foucault (fclem) accepted D11487: Viewport normal drawing with constant length.
Jun 13 2021, 11:48 PM · User Interface, BF Blender, EEVEE & Viewport, Good First Issue
Ray (DerivedC) awarded T68990: Vulkan support a Like token.
Jun 13 2021, 4:32 PM · EEVEE & Viewport, BF Blender

Jun 11 2021

Clément Foucault (fclem) requested changes to D11487: Viewport normal drawing with constant length.

The patch is good feature wise. I just have a few style comment.

Jun 11 2021, 2:46 PM · User Interface, BF Blender, EEVEE & Viewport, Good First Issue

Jun 8 2021

Alaska (Alaska) awarded rB520962b3d6bf: EEVEE: Lights: Support infinite light count a Love token.
Jun 8 2021, 12:26 AM

Jun 6 2021

Hadrien Brissaud (hadrien) awarded rB09e1f276ff62: EEVEE: Remove EEVEE a Party Time token.
Jun 6 2021, 5:46 PM
炎臻 (PrettyFireNOI7) awarded rB000a340afa67: EEVEE: Depth of field: New implementation a Love token.
Jun 6 2021, 9:53 AM

Jun 4 2021

Robert Baratheon (Dabi) awarded rB09e1f276ff62: EEVEE: Remove EEVEE a The World Burns token.
Jun 4 2021, 9:11 PM
Clément Foucault (fclem) awarded T88822: GPU: Multithreaded Index Buffer Builder a Like token.
Jun 4 2021, 2:33 PM · EEVEE & Viewport, Performance
Chris Margach (cagram) awarded T68990: Vulkan support a Love token.
Jun 4 2021, 9:14 AM · EEVEE & Viewport, BF Blender

Jun 3 2021

Clément Foucault (fclem) requested changes to D11487: Viewport normal drawing with constant length.

One question I have is about UI representation of toggle button to turn on/off this behavior. In this patch I implemented checkbox with text, but there is also possibility of less cluttered icon toggle button to the right of the normals size slider.

Jun 3 2021, 7:30 PM · User Interface, BF Blender, EEVEE & Viewport, Good First Issue
Clément Foucault (fclem) changed the status of T88766: EEVEE: Specular BSDF incompatible with Shader to RGB when SSR is active. from Needs Triage to Confirmed.
Jun 3 2021, 2:58 AM · BF Blender, EEVEE & Viewport

Jun 2 2021

Clément Foucault (fclem) closed T86858: 2.93 screen space reflection/refraction (?) regressions - white artifacts and missing translucency glow as Resolved.

I've investigated and.... it was a bug that has been fixed 2.93. Basically the clamp on SSR rays was not applied to really sharp refractions in 2.92. In 2.93 they are correctly clamped to avoid discrepency with rougher surfaces.

Jun 2 2021, 6:07 PM · EEVEE & Viewport, BF Blender
Clément Foucault (fclem) accepted D11455: GPUIndexBuf: Find the minimum and maximum index through the builder.
Jun 2 2021, 3:13 PM
Clément Foucault (fclem) requested changes to D11455: GPUIndexBuf: Find the minimum and maximum index through the builder.
Jun 2 2021, 12:47 PM