- User Since
- Jul 9 2014, 7:45 PM (202 w, 18 h)
Tue, May 22
Mon, May 21
Well done! I'm just not a fan of encoding the area shape inside the size sign. Maybe use l_type instead and create a new type?
Sun, May 20
Fri, May 18
Thu, May 17
Wed, May 16
Mon, May 14
So basically it's because the batches are tagged as dirty when switching from workbench to eevee.
Sun, May 13
Looks correct to me. If you upload the patch using arcanist I will test it. And yes missing the check and the SSS. But SSS is just adding the SSS radiance (or SSS radiance * SSS color in the case of separate albedo) to the overall radiance.
spec_accum is the output specular of this function. It's an inout arg because you can feed it with an already existing specular data (to blend with SSR). In this case, you did well by passing vec4(0.0).
The rgb part of ssr_data is the "glossy color" you must multiply the result of fallback_cubemap by it.
Sat, May 12
Fri, May 11
Some warning to silence.
gpencil_draw_cache_impl.c:941:18: warning: unused variable ‘C’ [-Wunused-variable] const bContext *C = draw_ctx->evil_C;
const bContext *C = draw_ctx->evil_C;
There might be others, my IDE does not list them.
Tue, May 8
Frankly, appart from the style issue it's good to go.
I'm ok with it. Appart from the drawing part of course :)
Mon, May 7
Sun, May 6
Sat, May 5
I really like the results. However I have concerns about the implementation.
I understand the issue and the extend of the problem.
Fri, May 4
I changed my plan of action.
Thu, May 3
Even if it's not optimized yet I would like to see if you can just optimize it really quickly.