Page MenuHome

Gary Oberbrunner (garyo123)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2019, 6:03 PM (14 w, 6 d)

Recent Activity

Thu, Feb 13

Gary Oberbrunner (garyo123) added a comment to T72167: glTF file loads extremely slowly (5+ min).

Upstream PR submitted: https://github.com/KhronosGroup/glTF-Blender-IO/pull/922

Thu, Feb 13, 7:17 PM · Add-ons
Gary Oberbrunner (garyo123) added a comment to T72167: glTF file loads extremely slowly (5+ min).

Never mind my prev comment; I didn't understand how the blender submodule stuff was organized. I see those two repos are much closer than I'd thought content-wise (even if the actual commits differ); I should be able to submit this as an upstream patch.

Thu, Feb 13, 5:24 PM · Add-ons
Gary Oberbrunner (garyo123) added a comment to T72167: glTF file loads extremely slowly (5+ min).

OK, I'm happy do that. Perhaps you can help me understand the differences though: the last commit in this area in the Blender tree is 06bb353c84, by you: "glTF importer: big perf improvement". But I don't see that commit in the upstream, so I'm not sure how best to apply my patch there. Should I treat the upstream as the "source of truth" and recreate my patch on that (ignoring your changes in 06bb353c84)?

Thu, Feb 13, 4:00 PM · Add-ons

Wed, Feb 12

Gary Oberbrunner (garyo123) added a comment to T72167: glTF file loads extremely slowly (5+ min).

I spent some time on this. It's not all just dependency graph rebuilding. I was able to cut down my import time for one of my samples from 261 sec to 132 sec, so about a 50% speedup.
My patch is at https://gist.github.com/garyo/e0fe3605d2be7c6308d795c988ec3b4b. (It's not finalized, it has some timing code which you may find useful. Let me know where to submit it if you think it's good.)
The main speedup for my use case comes from using numpy for color_linear_to_srgb and speed-hacking the inner vertex-color loop. I also got some speedups by using import_shading='SMOOTH' because the default import does a dot product on every vertex of every imported poly to see if it should be treated as smooth or flat.
After that, the largest time is spent in adding faces to the mesh. If there's a way to do bme.faces.new(array_of_face_data) that would improve things a lot.

Wed, Feb 12, 10:05 PM · Add-ons

Fri, Jan 24

Gary Oberbrunner (garyo123) awarded T68915: Light linking a Love token.
Fri, Jan 24, 2:47 PM · Cycles, BF Blender

Thu, Jan 23

Gary Oberbrunner (garyo123) added a comment to T73201: New volume object type.

This is an important feature for me as well; I'm happy to help if there's anything I can do.

Thu, Jan 23, 11:43 PM · Nodes & Physics, BF Blender
Gary Oberbrunner (garyo123) awarded T73201: New volume object type a Love token.
Thu, Jan 23, 11:40 PM · Nodes & Physics, BF Blender

Wed, Jan 22

Gary Oberbrunner (garyo123) added a comment to T72167: glTF file loads extremely slowly (5+ min).

This issue is significant for me. Is there anything I can do to improve the situation? I'm more than happy to do some python profiling on the importer for instance - and I could even refactor the addon if I have some guidance, but I don't know Blender's internals well enough yet to know if that would be useful.

Wed, Jan 22, 5:06 PM · Add-ons

Tue, Jan 21

Gary Oberbrunner (garyo123) added a reviewer for D6644: glTF importer: keep going if invalid custom property seen: Julien DUROURE (julien).

Hi Julien, I believe you authored this file; would you mind reviewing? It's my first patch to Blender.

Tue, Jan 21, 9:19 PM
Gary Oberbrunner (garyo123) created D6644: glTF importer: keep going if invalid custom property seen.
Tue, Jan 21, 9:15 PM

Dec 4 2019

Gary Oberbrunner (garyo123) created T72167: glTF file loads extremely slowly (5+ min).
Dec 4 2019, 4:19 PM · Add-ons

Nov 7 2019

Gary Oberbrunner (garyo123) added a comment to T41179: Cycles Voxel Data Node Mockup.

I'd also be very interested in direct volume rendering in Blender and would be willing to contribute some work toward it (I've done quite a lot of image processing and sci viz over the years). I'm specifically interested in high-quality renders of large semi-transparent volumes with Cycles.

Nov 7 2019, 6:05 PM · BF Blender, Cycles