- User Since
- Nov 7 2019, 6:03 PM (14 w, 6 d)
Thu, Feb 13
Upstream PR submitted: https://github.com/KhronosGroup/glTF-Blender-IO/pull/922
Never mind my prev comment; I didn't understand how the blender submodule stuff was organized. I see those two repos are much closer than I'd thought content-wise (even if the actual commits differ); I should be able to submit this as an upstream patch.
OK, I'm happy do that. Perhaps you can help me understand the differences though: the last commit in this area in the Blender tree is 06bb353c84, by you: "glTF importer: big perf improvement". But I don't see that commit in the upstream, so I'm not sure how best to apply my patch there. Should I treat the upstream as the "source of truth" and recreate my patch on that (ignoring your changes in 06bb353c84)?
Wed, Feb 12
I spent some time on this. It's not all just dependency graph rebuilding. I was able to cut down my import time for one of my samples from 261 sec to 132 sec, so about a 50% speedup.
My patch is at https://gist.github.com/garyo/e0fe3605d2be7c6308d795c988ec3b4b. (It's not finalized, it has some timing code which you may find useful. Let me know where to submit it if you think it's good.)
The main speedup for my use case comes from using numpy for color_linear_to_srgb and speed-hacking the inner vertex-color loop. I also got some speedups by using import_shading='SMOOTH' because the default import does a dot product on every vertex of every imported poly to see if it should be treated as smooth or flat.
After that, the largest time is spent in adding faces to the mesh. If there's a way to do bme.faces.new(array_of_face_data) that would improve things a lot.
Fri, Jan 24
Thu, Jan 23
This is an important feature for me as well; I'm happy to help if there's anything I can do.
Wed, Jan 22
This issue is significant for me. Is there anything I can do to improve the situation? I'm more than happy to do some python profiling on the importer for instance - and I could even refactor the addon if I have some guidance, but I don't know Blender's internals well enough yet to know if that would be useful.
Tue, Jan 21
Hi Julien, I believe you authored this file; would you mind reviewing? It's my first patch to Blender.
Dec 4 2019
Nov 7 2019
I'd also be very interested in direct volume rendering in Blender and would be willing to contribute some work toward it (I've done quite a lot of image processing and sci viz over the years). I'm specifically interested in high-quality renders of large semi-transparent volumes with Cycles.