• Collection-handling fix

I'm getting inconsistent crashes, which I assume are resulting from something not handled by this patch.
To my eyes, it's not consistent what's going on here.
It can take hours for it to happen; the most recent of which is sitting in my gdb right now.
(It's caught by gdb so I don't see a crash.txt):

#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50             [0/1886]
#1  0x00007ffff75b1537 in __GI_abort () at abort.c:79
#2  0x0000000011f71543 in _BLI_assert_abort ()
    at /home/jaguar/blender-src/blender-git/blender/source/blender/blenlib/intern/BLI_assert. c:46
#3  0x000000000470d797 in BKE_editmesh_from_object (ob=0x7fffcc356608)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/blenkernel/intern/editmesh.c:60
#4  0x0000000005d9a2a4 in snap_object_data_mesh_get (sctx=0x7fffc9746088, 
    ob_eval=0x7fffcc356608, me_eval=0x7fffd12be008, use_hide=false)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/editors/transform/transform_snap_object.cc:287
#5  0x0000000005d9f329 in snapMesh (sctx=0x7fffc9746088, params=0x7fffffffc70c, 
    ob_eval=0x7fffcc356608, me_eval=0x7fffd12be008, obmat=0x7fffc93c7328, use_hide=false, 
    dist_px=0x7fffffffc51c, r_loc=0x7fffffffc594, r_no=0x7fffffffc588, 
    r_index=0x7fffffffc53c)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/editors/transform/transform_snap_object.cc:2349
#6  0x0000000005da0464 in snap_obj_fn (sctx=0x7fffc9746088, params=0x7fffffffc70c, 
    ob_eval=0x7fffcc356608, obmat=0x7fffc93c7328, is_object_active=false, 
    data=0x7fffffffc470)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/editors/transform/transform_snap_object.cc:2760
#7  0x0000000005d9ab3c in iter_snap_objects (sctx=0x7fffc9746088, params=0x7fffffffc70c, 
    sob_callback=0x5da0129 <snap_obj_fn(SnapObjectContext*, SnapObjectParams const*, Object*, 
float const (*) [4], bool, void*)>, data=0x7fffffffc470)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/editors/transform/transform_snap_object.cc:485
#8  0x0000000005da0604 in snapObjectsRay (sctx=0x7fffc9746088, params=0x7fffffffc70c, 
    dist_px=0x7fffffffc51c, r_loc=0x7fffffffc594, r_no=0x7fffffffc588, 
    r_index=0x7fffffffc53c, r_ob=0x7fffffffc5a0, r_obmat=0x7fffffffc540)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/editors/transform/transform_snap_object.cc:2840
#9  0x0000000005da100b in transform_snap_context_project_view3d_mixed_impl (
    sctx=0x7fffc9746088, depsgraph=0x7fffd5ab7908, region=0x7fffcc626b88, 
    v3d=0x7fffcc331008, snap_to_flag=23, params=0x7fffffffc70c, mval=0x7fffffffc728, 
    prev_co=0x7fffffffc71c, dist_px=0x7fffffffc718, r_loc=0x7fffffffc7d4, 
    r_no=0x7fffffffc7c8, r_index=0x7fffffffc730, r_ob=0x0, r_obmat=0x7fffffffc770, 
    r_face_nor=0x7fffffffc7bc)
    at /home/jaguar/blender-src/blender-git/blender/source/blender/editors/transform/transform_snap_object.cc:3153
#10 0x0000000005da11d5 in ED_transform_snap_object_project_view3d_ex (sctx=0x7fffc9746088, 
    depsgraph=0x7fffd5ab7908, region=0x7fffcc626b88, v3d=0x7fffcc331008, snap_to=23, 
    params=0x7fffffffc70c, mval=0x7fffffffc728, prev_co=0x7fffffffc71c, 
    dist_px=0x7fffffffc718, r_loc=0x7fffffffc7d4, r_no=0x7fffffffc7c8, 
    r_index=0x7fffffffc730, r_ob=0x0, r_obmat=0x7fffffffc770, r_face_nor=0x7fffffffc7bc)

The bevel failure part seems like a bug. :)

• Converted to geometryset methods. Objects offering GEO_COMPONENT_TYPE_MESH can now be boolean targets.

• Converting object filters to va args
• Converted to geometryset methods. Objects offering GEO_COMPONENT_TYPE_MESH can now be boolean targets.

I spent quite a bit of time looking through to see what and how geometry_set_eval is to be used for this, but couldn't figure it out.
(I also saw a bunch of other nifty functions.) Personally I think there's a lot of power in allowing an option to choose a target's base mesh/final, etc. But anyway.

• Converting object filters to va args. Added curve support.

Rebased.
Updated to use the brand new Legacy curve def
set2 changed to setmulti

Fonts can be used as Boolean targets.

[Edited to correct] I presume modifier visibility is rarely used by drivers, although possibly heavily by some users / in some projects.

That's embarrassing. After I go through and ensure everything's manifold, no intersections -- was extra careful and checked probably a dozen times -- I swear even Shift+N'ing it (but tested now and that works fine. Thanks Omar.

Okay, except the fixme for Undo, I think this is a usable version. LMK. :)

• Restored object loc and size

Topology bug from an earlier object/bool makes this an invalid example.

Oh, the reason for removing the solidify from the slicing object is because it's easier to see when the boolean fails -- instead of a clean division of the part to either side, it ends up leaving mesh (on the 'wrong' side). Whereas, when it's a solidified planar'ish object, the topology and connectedness can be hard to see.

• Rotation working. Face normals in. Edit and Object mode functioning without context switch. Added FIXME notes to operator

In D13094#364882, @Campbell Barton (campbellbarton) wrote:

Thanks for the update, think this is close to being finished.

Some notes, while I don't have such strong opinions on exactly how this is done, the current state of this operator seems a bit awkward.

• Using face-selection in object mode seems strange - other 3D print operators (such as reporting volume) make sense to run an object mode. This operator however requires a selection logically - so I don't think it makes sense to expose it at all in object mode (unless we limit it to vertex-paint/texture-paint which do support face selection - although this seems like a very obscure use case).

• Rotation working. Face normalization is in. Edit and Object mode both functioning

• Rotation working. Face-area normalization. Edit and Object mode functioning.

• Rotation working. Face normals in. Edit and Object mode functioning

In D13094#358272, @Campbell Barton (campbellbarton) wrote:

Since this operator uses face-selection it should use the edit-mesh without toggling edit mode, see existing code that uses bmesh.from_edit_mesh.

• Allow multi-face, and multi-object use

• Allow multi-face, and multi-object use

Okay, I made some changes (I think Campbell's comments don't line up with the line numbers anymore).
It now loops through all selected objects so a user can handle many at once.
It also averages the selected faces' normals, should a user desire that.
I'm not sure if it's appropriate, but if they're in edit mode, I toggle out to get selection changes updated (and then back in).
(I'm sure there's some way to access the data in edit mode, but I couldn't find it just yet.)

• Allow multi-face, and multi-object use

Okay, got it using proper rotation setting instead of relying on parenting to an empty.

• Rotation now handled properly

• Rotation now handled properly

• Rebase to master

• Removed digit 2 from functions/macros

Added comments

ndof: spacenavd not found
Read prefs: /home/jaggz/.config/blender/3.0/config/userpref.blend
Read blend: /tmp/interlocking-layers-3d-printing.blend
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(BLI_system_backtrace+0x26) [0x1009e6c3]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(_BLI_assert_print_backtrace+0x16) [0xff6b844]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x4375458]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(DRW_mesh_batch_cache_get_surface_shaded+0x39) [0x4377baf]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(DRW_cache_mesh_surface_shaded_get+0x6a) [0x4365086]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(DRW_cache_object_surface_material_get+0x60) [0x435e1d7]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x432ec66]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x432f286]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(workbench_cache_populate+0x344) [0x432fb05]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x42eca2d]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(DRW_draw_render_loop_ex+0x3fd) [0x42ee0c4]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(DRW_draw_view+0x15c) [0x42edc6b]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x5338a2c]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(view3d_main_region_draw+0x43) [0x5338ad3]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(ED_region_do_draw+0x171) [0x4b61b75]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x3f966ba]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x3f96c79]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(wm_draw_update+0xc5) [0x3f972b1]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(WM_main+0x48) [0x3f934df]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender() [0x392393e]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xea) [0x7f70dec6fd0a]
/home/jaggz/blender-src/blender-git/build_linux_debug/bin/blender(_start+0x2a) [0x392334a]
BLI_assert failed: source/blender/draw/intern/draw_cache_impl_mesh.c:285, mesh_cd_ldata_get_from_mesh(), at '0'
Aborted

It's not crashing after restoring factory defaults.
Oh well. :) Feel free to close!
Be safe.

My bad. I'd like to strike my prior message from the record.
I updated but did not pull within master.
The crash is no longer. :)

Mine still crashes with a fresh build of master 518c5ce4cd75

I should have done a pull or at least posted my revision hash. I'll test and report back. Thanks.

Okay, I removed the code allowing all Mesh modifiers on Text objects. That can be a different branch and requires more work.
I still have two issues I need help with:

Updating D11272: Initial modifications allowing Text object (OB_FONT) boolean targets

Nevertheless, this text was then able to have a sphere booleaned onto it, followed by a wireframe.

OB_FONT to accept mesh modifiers (ex. boolean)

Clarification was requested:

1. Load blend
2. Add mirror modifier to the active object (fast method, default, should crash)

As I posted in https://developer.blender.org/T87233
It's produced in a scene with geometry and no light source at all.

If we can flag modifiers as targets/dependencies of drivers, that could allow at least a workable solution.

• Versioning fix. Filter order consistency...

• Removed the now-used UNUSED enum from versioning_280.c