Page MenuHome

Jeroen Bakker (jbakker)
Senior Software Engineer - Blender Institute

Projects (17)

User Details

User Since
Nov 30 2008, 9:31 PM (654 w, 4 d)

Recent Activity

Today

Jacob Merrill (blueprintrandom) awarded D11615: DrawManager: Multithreaded counting of material buckets. a Love token.
Fri, Jun 18, 5:25 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) committed rBe0f2f07d1e8b: DrawManager: Multithreaded counting of material buckets. (authored by Jeroen Bakker (jbakker)).
DrawManager: Multithreaded counting of material buckets.
Fri, Jun 18, 4:10 PM
Jeroen Bakker (jbakker) closed D11615: DrawManager: Multithreaded counting of material buckets..
Fri, Jun 18, 4:10 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) closed D11622: BMesh: use threading to count total selection..
Fri, Jun 18, 4:07 PM · Modeling, Performance
Jeroen Bakker (jbakker) committed rB6d73d98fb62d: BMesh: use threading to count total selection. (authored by Jeroen Bakker (jbakker)).
BMesh: use threading to count total selection.
Fri, Jun 18, 4:07 PM
Jeroen Bakker (jbakker) closed D11647: Performance: Limit recounting during selection mode flushing..
Fri, Jun 18, 3:44 PM · Modeling, Performance
Jeroen Bakker (jbakker) committed rBea4309925f1d: Performance: Limit recounting during selection mode flushing. (authored by Jeroen Bakker (jbakker)).
Performance: Limit recounting during selection mode flushing.
Fri, Jun 18, 3:44 PM
Jeroen Bakker (jbakker) updated the summary of D11647: Performance: Limit recounting during selection mode flushing..
Fri, Jun 18, 2:31 PM · Modeling, Performance
Jeroen Bakker (jbakker) added reviewers for D11647: Performance: Limit recounting during selection mode flushing.: Germano Cavalcante (mano-wii), Campbell Barton (campbellbarton).
Fri, Jun 18, 2:29 PM · Modeling, Performance
Jeroen Bakker (jbakker) requested review of D11647: Performance: Limit recounting during selection mode flushing..
Fri, Jun 18, 2:29 PM · Modeling, Performance
Jeroen Bakker (jbakker) placed T89260: Eevee instant crash with a custom node from template example up for grabs.
Fri, Jun 18, 10:42 AM · EEVEE & Viewport, Nodes, BF Blender
Jeroen Bakker (jbakker) changed the status of T89260: Eevee instant crash with a custom node from template example from Needs Triage to Confirmed.

Issue seems to be that the node compiler handles custom sockets as floats. float sockets has a default_value attribute but is stored in a different way, hence an error occurs.

Fri, Jun 18, 10:20 AM · EEVEE & Viewport, Nodes, BF Blender
Jeroen Bakker (jbakker) updated the task description for T88550: Mesh Optimization Project Progress.
Fri, Jun 18, 9:40 AM · Modeling
Jeroen Bakker (jbakker) updated the summary of D11644: Performance: Flush selection to edges/faces..
Fri, Jun 18, 9:39 AM · Modeling, Performance
Jeroen Bakker (jbakker) updated the summary of D11644: Performance: Flush selection to edges/faces..
Fri, Jun 18, 9:36 AM · Modeling, Performance
Jeroen Bakker (jbakker) updated the summary of D11644: Performance: Flush selection to edges/faces..
Fri, Jun 18, 9:35 AM · Modeling, Performance
Jeroen Bakker (jbakker) requested review of D11644: Performance: Flush selection to edges/faces..
Fri, Jun 18, 9:33 AM · Modeling, Performance
Jeroen Bakker (jbakker) updated the summary of D11622: BMesh: use threading to count total selection..
Fri, Jun 18, 9:26 AM · Modeling, Performance
Jeroen Bakker (jbakker) updated the summary of D11622: BMesh: use threading to count total selection..
Fri, Jun 18, 8:50 AM · Modeling, Performance
Jeroen Bakker (jbakker) updated the diff for D11622: BMesh: use threading to count total selection..

Use BM_iter_parallel.
Start counting from 0.

Fri, Jun 18, 8:42 AM · Modeling, Performance

Yesterday

Gilberto Rodrigues (gilberto_rodrigues) awarded D11622: BMesh: use threading to count total selection. a Burninate token.
Thu, Jun 17, 8:28 AM · Modeling, Performance

Wed, Jun 16

Jeroen Bakker (jbakker) planned changes to D11622: BMesh: use threading to count total selection..
Wed, Jun 16, 5:13 PM · Modeling, Performance
Jeroen Bakker (jbakker) changed the subtype of T89200: Research: refactor dotted/dashed lines to support line width. from "Report" to "To Do".
Wed, Jun 16, 4:31 PM · EEVEE & Viewport
Jeroen Bakker (jbakker) created T89200: Research: refactor dotted/dashed lines to support line width..
Wed, Jun 16, 4:31 PM · EEVEE & Viewport
Jeroen Bakker (jbakker) updated the task description for T88550: Mesh Optimization Project Progress.
Wed, Jun 16, 1:55 PM · Modeling
Jeroen Bakker (jbakker) committed rBbaa7a5397486: Fix T86956: VSE shading mode ignores Grease Pencil Vertex colors. (authored by Jeroen Bakker (jbakker)).
Fix T86956: VSE shading mode ignores Grease Pencil Vertex colors.
Wed, Jun 16, 1:49 PM
Jeroen Bakker (jbakker) updated the task description for T88449: Blender LTS: Maintenance Task 2.93.
Wed, Jun 16, 1:48 PM · BF Blender (2.93)
Jeroen Bakker (jbakker) committed rBfb67495c7feb: Versionbump: Blender 2.83.17-rc (authored by Jeroen Bakker (jbakker)).
Versionbump: Blender 2.83.17-rc
Wed, Jun 16, 1:37 PM
Jeroen Bakker (jbakker) updated the summary of D11622: BMesh: use threading to count total selection..
Wed, Jun 16, 1:33 PM · Modeling, Performance
Jeroen Bakker (jbakker) updated the task description for T88449: Blender LTS: Maintenance Task 2.93.
Wed, Jun 16, 1:30 PM · BF Blender (2.93)
Jeroen Bakker (jbakker) requested review of D11622: BMesh: use threading to count total selection..
Wed, Jun 16, 1:25 PM · Modeling, Performance
Jeroen Bakker (jbakker) added a comment to T88449: Blender LTS: Maintenance Task 2.93.

@Sebastian Parborg (zeddb) could help if you can find the commits. depending on how smooth it goes we might also consider a temp-branch.

Wed, Jun 16, 12:10 PM · BF Blender (2.93)
Jeroen Bakker (jbakker) closed T88822: GPU: Multithreaded Index Buffer Builder, a subtask of T87835: GPU: Mesh Drawing Performance, as Resolved.
Wed, Jun 16, 9:47 AM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) closed T88822: GPU: Multithreaded Index Buffer Builder as Resolved.
Wed, Jun 16, 9:47 AM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) closed T88369: DrawManager: Task counters atomics., a subtask of T87835: GPU: Mesh Drawing Performance, as Archived.
Wed, Jun 16, 9:46 AM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) closed T88369: DrawManager: Task counters atomics. as Archived.

Recent refactorings removed all the atomics but one in this case.

Wed, Jun 16, 9:46 AM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) abandoned D11310: T88369: Reduce locking of atomic counters..

Number of atomics are reduced in master (only one)

Wed, Jun 16, 9:45 AM
Jeroen Bakker (jbakker) committed rBb4a81d805374: Fix outdated face tessellation use when editing edit-mesh coodinates (authored by Campbell Barton (campbellbarton)).
Fix outdated face tessellation use when editing edit-mesh coodinates
Wed, Jun 16, 9:32 AM
Jeroen Bakker (jbakker) committed rBba7f11075354: Docs: remove deprecated parameter from bmesh docs (authored by Campbell Barton (campbellbarton)).
Docs: remove deprecated parameter from bmesh docs
Wed, Jun 16, 9:32 AM
Jeroen Bakker (jbakker) committed rBbc648018571d: Fix modifier deform by armature check ignoring virtual modifiers (authored by Campbell Barton (campbellbarton)).
Fix modifier deform by armature check ignoring virtual modifiers
Wed, Jun 16, 9:32 AM
Jeroen Bakker (jbakker) committed rBb61f4fd8da3a: Fix image space missing mask display panel (authored by Campbell Barton (campbellbarton)).
Fix image space missing mask display panel
Wed, Jun 16, 9:32 AM
Jeroen Bakker (jbakker) committed rBe24765d7d3a1: LineArt: Camera marker update fix. (authored by YimingWu (NicksBest)).
LineArt: Camera marker update fix.
Wed, Jun 16, 9:32 AM
Jeroen Bakker (jbakker) updated the task description for T88449: Blender LTS: Maintenance Task 2.93.
Wed, Jun 16, 9:31 AM · BF Blender (2.93)
Jeroen Bakker (jbakker) updated the task description for T88449: Blender LTS: Maintenance Task 2.93.
Wed, Jun 16, 9:20 AM · BF Blender (2.93)
Jeroen Bakker (jbakker) updated the diff for D11615: DrawManager: Multithreaded counting of material buckets..
  • Use [0] to indicate that the struct has a dynamic size.
  • Use min_iter_per_thread.
  • Use different variable name for userdata.
Wed, Jun 16, 8:46 AM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) committed rB9fed00341e17: Cleanup: reduce warnings when compiling release builds. (authored by Jeroen Bakker (jbakker)).
Cleanup: reduce warnings when compiling release builds.
Wed, Jun 16, 8:01 AM
Jeroen Bakker (jbakker) awarded rB1a5fa2b319e0: VSE: Improve animation evaluation performance a Mountain of Wealth token.
Wed, Jun 16, 7:02 AM

Tue, Jun 15

Jeroen Bakker (jbakker) updated the task description for T88550: Mesh Optimization Project Progress.
Tue, Jun 15, 4:40 PM · Modeling
Jeroen Bakker (jbakker) updated the task description for T88550: Mesh Optimization Project Progress.
Tue, Jun 15, 4:39 PM · Modeling
Jeroen Bakker (jbakker) added a reviewer for D11615: DrawManager: Multithreaded counting of material buckets.: Germano Cavalcante (mano-wii).
Tue, Jun 15, 4:38 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) requested review of D11615: DrawManager: Multithreaded counting of material buckets..
Tue, Jun 15, 4:37 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) closed D11612: DrawManager: Cache material offsets..
Tue, Jun 15, 3:31 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) committed rB174ed69c1ba8: DrawManager: Cache material offsets. (authored by Jeroen Bakker (jbakker)).
DrawManager: Cache material offsets.
Tue, Jun 15, 3:31 PM
Jeroen Bakker (jbakker) added a comment to D11612: DrawManager: Cache material offsets..

Well they aren't really lengths or counts. in the end they are offsets. I found mat_offsets.tri_offsets a bit too long.

Tue, Jun 15, 3:31 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) updated the summary of D11544: VSE: Improve animation evaluation performance.
Tue, Jun 15, 3:29 PM
Jeroen Bakker (jbakker) added inline comments to D11544: VSE: Improve animation evaluation performance.
Tue, Jun 15, 3:18 PM
Jeroen Bakker (jbakker) updated the diff for D11612: DrawManager: Cache material offsets..

Resend diff after incorrect sending the previous time.

Tue, Jun 15, 3:18 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • Renamed SEQ_sequence_lookup_destruct to SEQ_sequence_lookup_free.
  • Removed unused parameter in seq_sequence_lookup_new.
  • Use BLI_ghash_str_new to create lookup hashmap, all names are zero-terminated.
Tue, Jun 15, 3:17 PM
Jeroen Bakker (jbakker) updated the diff for D11612: DrawManager: Cache material offsets..
  • Revert "DrawManager: Cache material offsets."
Tue, Jun 15, 3:15 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) updated the diff for D11612: DrawManager: Cache material offsets..
  • Renamed SEQ_sequence_lookup_destruct to SEQ_sequence_lookup_free.
  • Removed unused parameter in seq_sequence_lookup_new.
  • Use BLI_ghash_str_new to create lookup hashmap, all names are zero-terminated.
Tue, Jun 15, 3:14 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) added a comment to D11450: Draw Manager: Mesh Extract: Balance the execution time of threads.

Due to recent changes is this still something we would want to integrate?
IMO the threading is good enough. Not sure if this fits in the parallel range implementation we have now.

Tue, Jun 15, 2:46 PM
Jeroen Bakker (jbakker) accepted D11566: Fix: Image node alpha socket converted to operations twice.
Tue, Jun 15, 2:44 PM · Compositing
Jeroen Bakker (jbakker) requested changes to D11559: Compositor: Full frame Image node.
Tue, Jun 15, 2:43 PM · Compositing
Jeroen Bakker (jbakker) accepted D11588: DRAW Cache: sanitize 'DRW_mesh_batch_cache_dirty_tag'.
Tue, Jun 15, 2:25 PM
Jeroen Bakker (jbakker) added 1 blocking reviewer(s) for D11588: DRAW Cache: sanitize 'DRW_mesh_batch_cache_dirty_tag': Clément Foucault (fclem).
Tue, Jun 15, 2:25 PM
Jeroen Bakker (jbakker) added a comment to D11588: DRAW Cache: sanitize 'DRW_mesh_batch_cache_dirty_tag'.

I have no objections adding this. But would like to have feedback from fclem.

Tue, Jun 15, 2:25 PM
Jeroen Bakker (jbakker) accepted D11593: Compositor: Full frame RGB node.
Tue, Jun 15, 2:15 PM · Compositing
Jeroen Bakker (jbakker) accepted D11594: Compositor: Full frame Value node.
Tue, Jun 15, 2:13 PM · Compositing
Jeroen Bakker (jbakker) added a comment to D11608: VSE: Fix Backdrop not updating during playback.

Just saw this fix, I committed a different one this morning. rB462bd8139937: Fix: Sequencer backdrop not updated during playback.

Tue, Jun 15, 2:12 PM
Jeroen Bakker (jbakker) accepted D11603: BLI: use explicit task isolation, no longer part of parallel operations.

LGTM

Tue, Jun 15, 2:10 PM
Jeroen Bakker (jbakker) added a reviewer for D11612: DrawManager: Cache material offsets.: Germano Cavalcante (mano-wii).
Tue, Jun 15, 1:34 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) requested review of D11612: DrawManager: Cache material offsets..
Tue, Jun 15, 1:33 PM · EEVEE & Viewport, Performance
Jeroen Bakker (jbakker) committed rB7f570a7174f3: Cleanup: Split mesh_render_data_loose_geom into multiple functions. (authored by Jeroen Bakker (jbakker)).
Cleanup: Split mesh_render_data_loose_geom into multiple functions.
Tue, Jun 15, 1:31 PM
Jeroen Bakker (jbakker) committed rB62906cdbea70: Cleanup: Added hierarchy in MeshBufferExtractionCache. (authored by Jeroen Bakker (jbakker)).
Cleanup: Added hierarchy in MeshBufferExtractionCache.
Tue, Jun 15, 1:31 PM
Jeroen Bakker (jbakker) committed rB051567553d29: Versionbump: 2.83.16-release (authored by Jeroen Bakker (jbakker)).
Versionbump: 2.83.16-release
Tue, Jun 15, 10:47 AM
Jeroen Bakker (jbakker) committed rB462bd8139937: Fix: Sequencer backdrop not updated during playback. (authored by Jeroen Bakker (jbakker)).
Fix: Sequencer backdrop not updated during playback.
Tue, Jun 15, 9:35 AM
Jeroen Bakker (jbakker) accepted D11544: VSE: Improve animation evaluation performance.

Just tested and the known edge cases are working as expected. Only have minor comments that can be done before committing.

Tue, Jun 15, 8:27 AM
Gilberto Rodrigues (gilberto_rodrigues) awarded rB44d2479dc36f: Refactor: DRW Mesh Extractor: Join the extractors in a same loop a Love token.
Tue, Jun 15, 5:28 AM
Gilberto Rodrigues (gilberto_rodrigues) awarded rB5f749a03ca1d: Fix T88456: DrawManager: Keep subset RenderMeshData around when geometry does… a Love token.
Tue, Jun 15, 5:27 AM

Mon, Jun 14

Andres Stephens (Draise) awarded rB7b30a3e98def: Performance: Use parallel range for ImBuf scanline processor. a Love token.
Mon, Jun 14, 6:10 PM
Andres Stephens (Draise) awarded rB28617bb16798: Sequencer: Transform ImBuf Processor. a Love token.
Mon, Jun 14, 6:10 PM
Andres Stephens (Draise) awarded rB7b76a160a464: Sequencer: Do not redraw during playback. a Love token.
Mon, Jun 14, 6:10 PM
Andres Stephens (Draise) awarded rB2e19649bb91b: Sequencer: Performance image crop transform. a Love token.
Mon, Jun 14, 6:10 PM
Jeroen Bakker (jbakker) added a comment to D11544: VSE: Improve animation evaluation performance.

The reason for SEQ_sequence_removed(scene) is that multiple strips can be tagged for removal and would be removed at the same time. Updating the lookup per strip would need locking as setting a tag doesn't.
Per intent I do the updates only when accessing the lookup and never in between.

Mon, Jun 14, 4:26 PM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.

Removed commented out code.

Mon, Jun 14, 4:21 PM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • incorrect copyright in new files.
Mon, Jun 14, 3:54 PM
Jeroen Bakker (jbakker) added a comment to D11544: VSE: Improve animation evaluation performance.

Although it sounds great to have a tagging system per item in the lookup, it is very hard to implement as you need to gather what has happening and in what order. When switching names of two strips before accessing them for example.

Mon, Jun 14, 3:50 PM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • Extracted lookup in its own file.
Mon, Jun 14, 3:50 PM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • Locking when rebuilding sequence lookup.
Mon, Jun 14, 12:21 PM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • Cleanup: rename to SEQ_sequence_find_by_name.
  • Rebuild sequence lookup when strips are renamed.
Mon, Jun 14, 12:07 PM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • Added update_core_runtime functions to depsgraph.
Mon, Jun 14, 11:24 AM
Jeroen Bakker (jbakker) updated the diff for D11544: VSE: Improve animation evaluation performance.
  • Flush caches when restoring the scene in depsgraph
  • Added max key length to match sequencer->name.
Mon, Jun 14, 9:50 AM
Jeroen Bakker (jbakker) updated subscribers of D11544: VSE: Improve animation evaluation performance.
Mon, Jun 14, 9:29 AM
Jeroen Bakker (jbakker) edited P2170 Addition to D11544: VSE animation performance..
Mon, Jun 14, 9:22 AM · Performance, Video Sequencer
Jeroen Bakker (jbakker) updated the title for P2170 Addition to D11544: VSE animation performance. from Masterwork From Distant Lands to Addition to D11544: VSE animation performance..
Mon, Jun 14, 9:17 AM · Performance, Video Sequencer
Jeroen Bakker (jbakker) edited P2170 Addition to D11544: VSE animation performance..
Mon, Jun 14, 9:16 AM · Performance, Video Sequencer
Jeroen Bakker (jbakker) added a comment to D11544: VSE: Improve animation evaluation performance.
diff --git a/source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequencer.cc b/source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequencer.cc
index 34c23740730..f0deb90b4c1 100644
--- a/source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequencer.cc
+++ b/source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequencer.cc
@@ -28,9 +28,12 @@
Mon, Jun 14, 9:15 AM

Sat, Jun 12

Jeroen Bakker (jbakker) added a comment to D11544: VSE: Improve animation evaluation performance.
Sat, Jun 12, 8:01 AM

Fri, Jun 11

Jeroen Bakker (jbakker) edited P2170 Addition to D11544: VSE animation performance..
Fri, Jun 11, 4:44 PM · Performance, Video Sequencer
Jeroen Bakker (jbakker) requested changes to D11544: VSE: Improve animation evaluation performance.
Fri, Jun 11, 4:35 PM