Page MenuHome

Justin Jones (jjones780)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 8 2016, 6:16 AM (222 w, 3 d)

Recent Activity

Mon, Jun 29

Justin Jones (jjones780) updated the summary of D6392: FFMPEG frame seek bug fix.
Mon, Jun 29, 8:48 AM · VFX & Video, Video Sequencer, BF Blender

Sun, Jun 28

Justin Jones (jjones780) added a comment to T56949: Pie menu design improvements.

Remove Issue? "Holding, Then Releasing Key Should Always Dismiss Pie" - This mentions the menu sticking open if the mouse isn't moved... I cannot replicate this behaviour. The pie menu will activate/cancel if menu key released.

Sun, Jun 28, 12:42 AM · User Interface, BF Blender: 2.8

May 14 2020

Evan Wilson (EAW) awarded D6392: FFMPEG frame seek bug fix a Love token.
May 14 2020, 8:47 PM · VFX & Video, Video Sequencer, BF Blender

May 11 2020

Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.

Commit message: Use refcounted_frames so ffmpeg can properly manage internal buffers. Use AVDictionary to set option.

May 11 2020, 12:00 PM · VFX & Video, Video Sequencer, BF Blender

Apr 15 2020

Justin Jones (jjones780) added a comment to T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.

Quick update.

Apr 15 2020, 4:11 AM · VFX & Video, Motion Tracking, BF Blender

Mar 29 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

I don't have any further additions to this patch except any requested by review.

Mar 29 2020, 11:40 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.

Added more UI notifications of ffmpeg frame seek issues.

Mar 29 2020, 11:13 AM · VFX & Video, Video Sequencer, BF Blender

Mar 17 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.
Mar 17 2020, 8:35 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.

"Clean up clip user notification warnings/errors"

Mar 17 2020, 7:04 AM · VFX & Video, Video Sequencer, BF Blender

Mar 16 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

For anyone interested:

Mar 16 2020, 12:11 PM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.
Changes and tuning thanks to ffmpeg fate-suite videos.
- handles a greater range of edge cases.
- warns user if a frame seek mismatch occurs.
- more efficienct seeking with fallback to earlier seek.
- change deprecated av_free_packet to unrefs.
- use stream specific pts timing for seeks.
Mar 16 2020, 11:35 AM · VFX & Video, Video Sequencer, BF Blender

Mar 2 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

Hi Sybren, Thanks for asking. I was able to get back to this after an unforeseen break.
I've tested quite a few edge cases thanks to the ffmpeg "fate" test videos - quite a learning experience.

Mar 2 2020, 12:38 PM · VFX & Video, Video Sequencer, BF Blender

Feb 20 2020

Justin Jones (jjones780) updated the summary of D4220: Action With Second Press of Pie Shortcut Key, or with 5 key..
Feb 20 2020, 9:02 AM
Justin Jones (jjones780) updated the diff for D4220: Action With Second Press of Pie Shortcut Key, or with 5 key..

Updated to more recent Master as a result of user discussion at Blender Community: Right-Click Select

Feb 20 2020, 8:55 AM

Jan 24 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

Quick note: Downloaded FFMPEG test videos ( accessible via ffmpeg source: make fate-rsync ).
I'll hold off on updating code here a few more days to test these edge cases.

Jan 24 2020, 11:11 PM · VFX & Video, Video Sequencer, BF Blender

Jan 17 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

Sergey and Sybren,

Jan 17 2020, 12:24 PM · VFX & Video, Video Sequencer, BF Blender

Jan 8 2020

Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.

Caught some bugs ( from latest changes but also one found during simulating re-use of packets )
Modified some AV_LOG_DEBUG messages to be more descriptive.
No longer uses last found pts in repeated search... impedes debugging and otherwise not necessary.

Jan 8 2020, 12:30 PM · VFX & Video, Video Sequencer, BF Blender

Jan 7 2020

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

Notes to self/FYI:

Jan 7 2020, 12:53 PM · VFX & Video, Video Sequencer, BF Blender

Jan 6 2020

Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.

Manage double decode buffers in own function.
Still some complex intermingling.. hoping to clean it up further and/or document.

Jan 6 2020, 1:25 PM · VFX & Video, Video Sequencer, BF Blender

Dec 22 2019

Justin Jones (jjones780) added a comment to T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.

Thanks for your vote of confidence.
My goal is to get this cleaned up and documented such that it requires the least amount of time to review.

Dec 22 2019, 12:25 AM · VFX & Video, Motion Tracking, BF Blender

Dec 21 2019

Justin Jones (jjones780) added a comment to T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.

Troy: Yep, the flushing of the codec is being done. ( I also double buffer the frames which adds more complexity here ). I've upgraded the ffmpeg calls away from the deprecated ones as well. If you can test with other codecs please do. The error message (with settings in replicating bug above ) I'm most interested in hearing about is "PTS for frame differs from previous decode!" and "PTS search for frame differs from previous scan!"

Dec 21 2019, 1:38 AM · VFX & Video, Motion Tracking, BF Blender

Dec 20 2019

Justin Jones (jjones780) claimed T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 20 2019, 10:03 PM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) added a comment to T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.

This, as you might guess, makes it very challenging to seek as there's no hard and fast rules on where those I frames will reside in a bitstream.

Dec 20 2019, 9:56 PM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

It turns out the video proxy time indexing code in Blender ( indexer.c ) is unfinished(?). All the index files produced are identical despite the differing types.

Dec 20 2019, 1:16 PM · VFX & Video, Video Sequencer, BF Blender

Dec 19 2019

Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.
  • fix length calculation and tune pts drift allotment.
Dec 19 2019, 3:06 AM · VFX & Video, Video Sequencer, BF Blender

Dec 18 2019

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

I've downloaded the Blender ffmpeg test videos ( and all the other test via make test ).

Dec 18 2019, 11:32 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.
  • improved variable names, plus changed _all_ camelcase names to underscored versions.
Dec 18 2019, 8:38 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.

wow-- did I write that!!? ;) - thanks for catching that Sergey.

Dec 18 2019, 7:27 AM · VFX & Video, Video Sequencer, BF Blender

Dec 17 2019

Justin Jones (jjones780) updated the diff for D6392: FFMPEG frame seek bug fix.
  • reinstate commented line from testing.
  • replace deprecated ffmpeg calls
  • handle EAGAIN result from avcodec_send_packet
  • upgrade deprecated call to write proxy videos
  • cleanup
Dec 17 2019, 1:16 PM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

I'm looking into replacing avcodec_decode_video2 with avcodec_receive_frame() because avcodec_decode_video2 is depreciated.

Dec 17 2019, 1:11 PM · VFX & Video, Video Sequencer, BF Blender

Dec 16 2019

Justin Jones (jjones780) updated the summary of D6392: FFMPEG frame seek bug fix.
Dec 16 2019, 11:59 AM · VFX & Video, Video Sequencer, BF Blender

Dec 13 2019

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

Just a few thoughts to this point:
There are certainly users, that would appreciate VFR support, but I didn't consider this to be priority. Sequencer already have time-altering effect, so I want to create method of mapping frame you see in preview to frame number in domain of the source media (because we currently use frame numbers).

As for implementation - I would check if there is any convention of positioning elements in time with sub-frame accuracy and work from there. I only know, that curves can use frame and decimal fraction. We could also use time directly. It may be good idea to generalize and document approach in cases like this, but I am not sure at this point.
Then on FFMPEG side there should be layer, that translates Blender time (or what the convention may dictate) to pts and vice-versa. Perhaps we could use that to retrieve stream length, because now it seeems, that length is calculated only from amount of frames.

In any case, to me this sounds like effort for it's own patch

Dec 13 2019, 3:13 AM · VFX & Video, Video Sequencer, BF Blender

Dec 11 2019

Justin Jones (jjones780) added a comment to D6392: FFMPEG frame seek bug fix.

I see that arc squashed the commits :(
I'm attaching the first commit (39e37c9) - I had referenced it above.

Dec 11 2019, 12:49 PM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 11:59 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) updated the summary of D6392: FFMPEG frame seek bug fix.
Dec 11 2019, 11:43 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the summary of D6392: FFMPEG frame seek bug fix.
Dec 11 2019, 11:17 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the summary of D6392: FFMPEG frame seek bug fix.
Dec 11 2019, 11:16 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) retitled D6392: FFMPEG frame seek bug fix from re: Issue T72347 to FFMPEG frame seek bug fix.
Dec 11 2019, 11:07 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) created D6392: FFMPEG frame seek bug fix.
Dec 11 2019, 10:45 AM · VFX & Video, Video Sequencer, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:45 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:39 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:37 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:35 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:32 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) updated the task description for T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:31 AM · VFX & Video, Motion Tracking, BF Blender
Justin Jones (jjones780) created T72347: FFMPEG video frame alignment issue - most notable when doing motion tracking.
Dec 11 2019, 9:28 AM · VFX & Video, Motion Tracking, BF Blender

Nov 8 2019

Justin Jones (jjones780) added a comment to D6105: Documentation: Add Tracking Video Clip Requirement.

"I don't think use of such strong imperative statement is something what belongs to a manual."
Thanks for being so diplomatic. In my defense I was recovering from a visit to the dentist.

Nov 8 2019, 1:38 AM · Motion Tracking

Oct 21 2019

Evan Wilson (EAW) awarded D6105: Documentation: Add Tracking Video Clip Requirement a Like token.
Oct 21 2019, 3:58 AM · Motion Tracking
Justin Jones (jjones780) retitled D6105: Documentation: Add Tracking Video Clip Requirement from Tracking Video Clip Requirement to Documentation: Add Tracking Video Clip Requirement.
Oct 21 2019, 3:49 AM · Motion Tracking
Justin Jones (jjones780) updated the summary of D6105: Documentation: Add Tracking Video Clip Requirement.
Oct 21 2019, 3:47 AM · Motion Tracking
Justin Jones (jjones780) added a comment to D6105: Documentation: Add Tracking Video Clip Requirement.

My best effort at writing some documentation.

Oct 21 2019, 3:40 AM · Motion Tracking
Justin Jones (jjones780) added a comment to T47720: First or second frame messes up in movie clip editor..

This is still an issue.
It's been on the radar for a while it seems.
2012: T31215
2014: T35133
2015: T44675

Oct 21 2019, 3:30 AM · BF Blender
Justin Jones (jjones780) created D6105: Documentation: Add Tracking Video Clip Requirement.
Oct 21 2019, 3:11 AM · Motion Tracking

Feb 2 2019

Justin Jones (jjones780) added a comment to D4220: Action With Second Press of Pie Shortcut Key, or with 5 key..

Please note that this small diff has been cleaned up from its originally intention (testing) to something I hope is more efficiently reviewable.

Feb 2 2019, 10:50 AM

Jan 28 2019

Justin Jones (jjones780) added a comment to T56949: Pie menu design improvements.

I cleaned up my original diff and added an Interface->Pie Menus preferences entry "Pie Key Again Click" - "Pressing pie shortcut again will act as click ( to cancel or select )" which defaults to enabled.

Jan 28 2019, 12:23 PM · User Interface, BF Blender: 2.8
Justin Jones (jjones780) updated the diff for D4220: Action With Second Press of Pie Shortcut Key, or with 5 key..

Added a preferences item to turn on or off this action (defaults to on ). This should help avoid any unforseen issues.

Jan 28 2019, 11:55 AM

Jan 17 2019

Justin Jones (jjones780) added a comment to T56949: Pie menu design improvements.

Complex Pie Menus for testing?
Are there any test pie menus hidden away... something involving pie menus with inner block menus/pie menus etc?

Jan 17 2019, 11:10 AM · User Interface, BF Blender: 2.8
Justin Jones (jjones780) added a comment to T56949: Pie menu design improvements.

Default Pie Menu Action.
Also... I'm experimenting on ways to allow the short 'tap' of a pie-menu key to perform an action ( instead of sticking the pie menu ).
For example, z held down brings up the Shading Pie menu however tapping it would simply toggle wireframe mode.

Jan 17 2019, 11:05 AM · User Interface, BF Blender: 2.8
Justin Jones (jjones780) added a comment to T56949: Pie menu design improvements.

D4220: Action With Second Press of Pie Shortcut Key
I've been trying out another change and have made a patch here

Jan 17 2019, 10:20 AM · User Interface, BF Blender: 2.8
Justin Jones (jjones780) created D4220: Action With Second Press of Pie Shortcut Key, or with 5 key..
Jan 17 2019, 9:52 AM

Jan 8 2019

Justin Jones (jjones780) added a comment to D4180: Pie Menu Tap Unstick Timeout.

I should've removed the
/* distance from initial point */
line just above my changes in source/blender/editors/interface/interface_handlers.c
That comment looks like it was left over from earlier code?

Jan 8 2019, 8:59 AM · BF Blender
Justin Jones (jjones780) created D4180: Pie Menu Tap Unstick Timeout.
Jan 8 2019, 8:51 AM · BF Blender
Justin Jones (jjones780) added a comment to T56949: Pie menu design improvements.

Fix for: Holding, Then Releasing Key Should Always Dismiss Pie
I believe this fix complies with the intended behaviour of the pie menu as per the discussion at devtalk

Jan 8 2019, 8:27 AM · User Interface, BF Blender: 2.8

Dec 2 2018

Justin Jones (jjones780) added a comment to T57565: Texture paint crash when toggle in/out editmesh mode.

I believe this is fixed now.
See my comments at related bug T57157

Dec 2 2018, 5:40 AM · BF Blender: 2.8
Justin Jones (jjones780) added a comment to T57157: crash, texture paint mode.

This bug is now fixed!
I was able to reproduce it before but not after this commit:

Dec 2 2018, 5:37 AM · BF Blender: 2.8

Nov 13 2018

Justin Jones (jjones780) added a comment to T57157: crash, texture paint mode.

Yes, Bug is still there:
I updated and used my test file to get crash.. bug is still there. I also tried the original UVsphere steps from scratch and it didn't immediately crash.. but didn't paint either. I then rotated the sphere a bit and tried to draw and then it crashed.

Nov 13 2018, 4:59 AM · BF Blender: 2.8

Oct 14 2018

Justin Jones (jjones780) added a comment to T57157: crash, texture paint mode.

My observation: ps.mvert_eval.co[2] is getting corrupted in a memcpy during python gui call.

Oct 14 2018, 9:46 AM · BF Blender: 2.8

Sep 10 2018

Justin Jones (jjones780) abandoned D3543: install_deps.sh : Slightly newer blosc version will avoid gcc5+ __cpu_model bug..

Issue solved via latest upgrade to all library versions.

Sep 10 2018, 11:48 PM

Aug 30 2018

Justin Jones (jjones780) added a comment to T56547: Properties are not aligned in single column format.

The NDOF ( i.e. space mouse ) menu has been adversely affected by this change ( T56547) and the earlier (T56511 ).
The menu can be brought up without a space mouse: edit->User Preferences->Input
In the Window section look for the "Call Menu" item with "NDOF Menu" key and change it to your preferred key.
Here's the affected menu:

Aug 30 2018, 10:17 AM · BF Blender: 2.8

Jul 22 2018

Justin Jones (jjones780) added a comment to T56066: Crash with Gizmo.

Hi Wayne,
Running a program from Windows console ( aka command line) will spit out information in the console.
Window's Blender has a command to see the console ( Window->Toggle System Console ) but this will disappear when Blender crashes.

Jul 22 2018, 12:29 AM · BF Blender: 2.8

Jul 21 2018

Justin Jones (jjones780) added a comment to T56066: Crash with Gizmo.

I tried this out ( on Linux however ) and it segfaults after saying "Exception: Add-on 'io_curve_svg' has not been upgraded to 2.8, ignoring"

Jul 21 2018, 9:18 AM · BF Blender: 2.8

Jul 14 2018

Justin Jones (jjones780) retitled D3543: install_deps.sh : Slightly newer blosc version will avoid gcc5+ __cpu_model bug. from install_deps.sh : Slightly newer blosc version will avoid gcc5 cpu_model bug. For new developers following Pablo Vazquez's post https://code.blender.org/2018/05/be-part-of-the-task-force. I bumped into this bug fairly quickly, solution not so. The... to install_deps.sh : Slightly newer blosc version will avoid gcc5+ __cpu_model bug..
Jul 14 2018, 11:14 AM
Justin Jones (jjones780) created D3543: install_deps.sh : Slightly newer blosc version will avoid gcc5+ __cpu_model bug..
Jul 14 2018, 11:04 AM