Page MenuHome

Jason Wilkins (jwilkins)
User

Projects

User Details

User Since
Mar 20 2010, 4:06 PM (483 w, 1 d)

Recent Activity

Apr 3 2017

Jason Wilkins (jwilkins) added a comment to T50939: porting adaptive spacing to head branch (from GSoC 2010).

I think it probably needs to over sample the surface (extra samples between where it will place dabs) and maybe even consider the derivative of the slope and do a proper quadrature to predict how much it should change spacing, instead of the simple change it does now (sorry if the implementation has been improved over my original simple one, I haven't had a chance to go over this patch)

Apr 3 2017, 4:49 PM · BF Blender
Jason Wilkins (jwilkins) added a comment to T50939: porting adaptive spacing to head branch (from GSoC 2010).

I hate to bike-shed my own feature, but I hate the name "adaptive spacing". It seems like this should be the default behavior and the old screen-space based spacing should be called "spacing *based on screen distance" and adaptive spacing should just be "spacing". If you have to call this anything it should be "spacing *based on object distance"

Apr 3 2017, 11:19 AM · BF Blender

Feb 25 2015

Jason Wilkins (jwilkins) added a comment to D1141: Windows: Spawn evil spoon feeding message box warning when user's OpenGL version is old or if driver is missing..

Was thinking that we only use the PFD from ChoosePixelFormat as a last resort, so we actually take full control over picking a context on Windows.

Feb 25 2015, 3:24 PM
Jason Wilkins (jwilkins) added a comment to D1141: Windows: Spawn evil spoon feeding message box warning when user's OpenGL version is old or if driver is missing..

Very interesting if you have to explicitly add the PFD flag to get the directx wrapper. Means that there are probably very few programs in the wild that actually ever use it.

Feb 25 2015, 1:32 PM

Feb 24 2015

Jason Wilkins (jwilkins) added a comment to D1141: Windows: Spawn evil spoon feeding message box warning when user's OpenGL version is old or if driver is missing..

OK, found the docs here: https://msdn.microsoft.com/en-us/library/cc231189.aspx

Feb 24 2015, 4:54 PM
Jason Wilkins (jwilkins) added a comment to D1141: Windows: Spawn evil spoon feeding message box warning when user's OpenGL version is old or if driver is missing..

It is surprisingly hard to find info on what the values of GL_RENDERER is when you get a Microsoft context that supports OpenGL 1.4 through Direct3D.

Feb 24 2015, 4:21 PM

Feb 23 2015

Jason Wilkins (jwilkins) added a comment to rBfed61d50c771: Debug GPU functionality from soc-viewport_fx by Jason Wilkins.

EDIT: The spec you linked, in the second paragraph, says multiple flags may be set due to potential parallelism in the implementation.

Feb 23 2015, 6:30 PM
Jason Wilkins (jwilkins) added inline comments to rBfed61d50c771: Debug GPU functionality from soc-viewport_fx by Jason Wilkins.
Feb 23 2015, 6:26 PM
Jason Wilkins (jwilkins) added inline comments to rBfed61d50c771: Debug GPU functionality from soc-viewport_fx by Jason Wilkins.

The performance problems I was concerned about were due to other checks that you did not put in this patch.

Feb 23 2015, 5:00 PM
Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

I'm create a patch that allows an external engine to use a separate context, but please feel free to send me a personal email if it looks like I've forgotten about it.

Feb 23 2015, 2:39 AM · Rendering, OpenGL / GPU

Feb 10 2015

Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

I was looking at how FreeGLUT handles what it calls "subwindows", which have an option to be created with their own context, even though they are child windows of a top-level window (or of another subwindow).

Feb 10 2015, 3:16 AM · Rendering, OpenGL / GPU

Feb 6 2015

Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

By sharing I mean objects created in one context are available in the other.

Feb 6 2015, 12:16 PM · Rendering, OpenGL / GPU
Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

following up,

Feb 6 2015, 12:46 AM · Rendering, OpenGL / GPU

Feb 5 2015

Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

Made several inline comments.

Feb 5 2015, 10:35 PM · Rendering, OpenGL / GPU
Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

@rdb (rdb), still not a great example because uniforms are a part of program state and if you implement your own matrix it wouldn't affect Blender and I don't think that Blender should make any assumptions about glUseProgram after calling a foreign renderer.

Feb 5 2015, 7:56 PM · Rendering, OpenGL / GPU
Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

The example given, of a matrix, is actually an example where there is a well know convention of pushing and popping a stack on order to preserve state.

Feb 5 2015, 4:02 PM · Rendering, OpenGL / GPU
Jason Wilkins (jwilkins) added a comment to D588: Fixes and workarounds for build problems: Windows 8.1, CMake 2.8.12.2, MSVC 2013.

Now I cannot get CMake to even configure WITH_CYCLES_STANDALONE, so I'm going to go ahead and voice my doubts that the build bot is actually building it.

Feb 5 2015, 12:04 AM

Feb 4 2015

Jason Wilkins (jwilkins) added a comment to D588: Fixes and workarounds for build problems: Windows 8.1, CMake 2.8.12.2, MSVC 2013.

I will check and see if the problem still exists.

Feb 4 2015, 9:56 PM
Jason Wilkins (jwilkins) added a comment to D589: More fixes for CMake, MSVC 2013, Windows 8 .

I cannot say because I don't know what the differences are.

Feb 4 2015, 8:37 PM
Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

Think that this shouldn't run every time for every engine.
To support some engines where we can't ensure the GL state I think it would be better to have an engine flag so you can optionally reset the state, but well behaved engines don't have to set this.

Feb 4 2015, 6:07 PM · Rendering, OpenGL / GPU

Jan 24 2015

Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.
Jan 24 2015, 1:03 AM · Rendering, OpenGL / GPU
Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

@rdb (rdb) I was actually talking about BGE, but I guess things are more compkex. I still need to look at it.

Jan 24 2015, 1:03 AM · Rendering, OpenGL / GPU

Jan 22 2015

Jason Wilkins (jwilkins) added a comment to D1017: Reset OpenGL state after calling into custom RenderEngine view_draw function.

I fix this problem in my SoC patch. I do it by making sure the Game engine follows a reasable GL state setting policy and (maybe) calling the gpu reset function when done (don't remember if its needed, cause ideally it shouldn't be).

Jan 22 2015, 7:01 PM · Rendering, OpenGL / GPU

Jan 12 2015

Jason Wilkins (jwilkins) added a comment to T43217: Suspicious '[m_openGLView clearGLContext]' in 'GHOST_ContextCGL::~GHOST_ContextCGL'.

Needs braces.

Jan 12 2015, 9:53 AM · BF Blender

Dec 3 2014

Jason Wilkins (jwilkins) added a comment to D700: Remove Simple Shader.

@Sergey Sharybin (sergey) ok, I'll just fold this in with the combined patch I'm currently working on

Dec 3 2014, 6:44 PM

Nov 28 2014

Jason Wilkins (jwilkins) added a comment to D919: Cleanup GPU: get rid of some extremely legacy draw code..

This reminds me about possibly renaming "draw normal" to something else like "draw default" since that always tripped me up, but I'm not even sure if that is relavent after this patch.

Nov 28 2014, 2:55 PM

Nov 10 2014

Jason Wilkins (jwilkins) added a comment to D589: More fixes for CMake, MSVC 2013, Windows 8 .

This problem still exists. Would this be an acceptable fix for the problem?

Nov 10 2014, 10:04 PM

Oct 14 2014

Jason Wilkins (jwilkins) added a comment to D825: MinGW64 compilation fix for D643 Ghost Context Refactor..

I think I could commit all of these remaining changes. My only question is whether the change to the type of embedder window should also be changed for msvc when compiling for 64 bit.

Oct 14 2014, 10:31 PM
Jason Wilkins (jwilkins) added a comment to D825: MinGW64 compilation fix for D643 Ghost Context Refactor..

I think I've fixed these issues now.

Oct 14 2014, 2:31 AM

Oct 13 2014

Jason Wilkins (jwilkins) added a comment to D699: Canonical OpenGL Procedure Binding.

Getting rid of GLEW would actually be pretty cool.

Oct 13 2014, 9:53 PM
Jason Wilkins (jwilkins) added a comment to D699: Canonical OpenGL Procedure Binding.

When I read Blender's OpenGL code I find a lot of mistakes made because somebody did not look up exactly where an entry point is defined. There is a failure to check for the right version or extention or to even check at all.

Oct 13 2014, 1:12 PM
Jason Wilkins (jwilkins) added a comment to D699: Canonical OpenGL Procedure Binding.

I am checking at this again.
I am feeling that this adds too much complexity with too little benefits at the moment. We have to keep track of various versions of external libraries and undefine certain functions and definitions in our own code. A good question at this point is: Why not write our own wrapper instead of GLEW if we are to do so much work redefining and reloading stuff? It will be much simpler to keep track of, instead of looking through 5 headers at a time trying to figure out what a symbol tracks back to, and we can maintain it better. I think this kind of abstraction, if needed, can certainly wait for later for when we have GLEW support in blender, but I would not go for it now.

Oct 13 2014, 12:59 PM

Oct 11 2014

Jason Wilkins (jwilkins) added a comment to rB8d084e8c8f48: Ghost Context Refactor https://developer.blender.org/D643 Separates graphics….

Does this occur with multiple Blender windows open?
My first guess would be a problem with display list sharing.

Oct 11 2014, 6:20 AM

Sep 14 2014

Jason Wilkins (jwilkins) added a reviewer for D706: WITH_GPU_DEBUG -- OpenGL debug contexts and utilities: Alexander Kuznetsov (alexk).
Sep 14 2014, 6:12 PM
Jason Wilkins (jwilkins) added a reviewer for D699: Canonical OpenGL Procedure Binding: Alexander Kuznetsov (alexk).
Sep 14 2014, 6:11 PM
Jason Wilkins (jwilkins) added a reviewer for D643: Ghost Context Refactor: Alexander Kuznetsov (alexk).
Sep 14 2014, 6:10 PM

Sep 10 2014

Jason Wilkins (jwilkins) added a comment to D706: WITH_GPU_DEBUG -- OpenGL debug contexts and utilities.

Generally seems rather fine, but consider:

  • Adding support of SCons at least.
  • Making it command line argument instead, so it's easy to see why shaders or something else fails (an why exactly) without rebuilding Blender.
Sep 10 2014, 2:37 AM
Jason Wilkins (jwilkins) added a comment to D700: Remove Simple Shader.

I added this now because it doesn't really have any dependencies. Doesn't really matter when it is done, but it is part of viewport.

Sep 10 2014, 2:32 AM
Jason Wilkins (jwilkins) added a comment to D699: Canonical OpenGL Procedure Binding.

OK, there's a reason to prefer defines rather than shims actually. If we use multiple contexts, then the shim will only have the pointer of the first context applied.

Sep 10 2014, 2:29 AM
Jason Wilkins (jwilkins) added a comment to D699: Canonical OpenGL Procedure Binding.

I am now slowly reading through the whole viewport branch, and given that there is already a level of abstraction in shim_init, I would be interested in hearing the detailed rationale for this actually.

Sep 10 2014, 2:24 AM

Aug 11 2014

Jason Wilkins (jwilkins) added a comment to D699: Canonical OpenGL Procedure Binding.

Did a review of my own code to make a todo list.

Aug 11 2014, 6:13 AM

Aug 5 2014

Jason Wilkins (jwilkins) added a comment to T41324: Blender does not sufficiently check OpenGL implementation’s capabilities .

In https://developer.blender.org/D706 I have a GPU_print_error function that prints to the console, but maybe a hook could be setup to send errors to a place a user can see more easily.

Aug 5 2014, 10:32 AM · BF Blender
Jason Wilkins (jwilkins) added a comment to T41324: Blender does not sufficiently check OpenGL implementation’s capabilities .

I don't mean to spam, but the glreport.py script that used to be in the tools directory will be useful here since it will tell you the version of every gl function that is used in blender.

Aug 5 2014, 9:29 AM · BF Blender
Jason Wilkins (jwilkins) added a comment to T41324: Blender does not sufficiently check OpenGL implementation’s capabilities .

One thing that I mean to do in the above patch is do further checking to make sure that extensions and versions are always checked, but it already creates a central place to handle this.

Aug 5 2014, 9:16 AM · BF Blender
Jason Wilkins (jwilkins) added a comment to T41324: Blender does not sufficiently check OpenGL implementation’s capabilities .

See https://developer.blender.org/D699

Aug 5 2014, 9:13 AM · BF Blender

Aug 3 2014

Jason Wilkins (jwilkins) retitled D706: WITH_GPU_DEBUG -- OpenGL debug contexts and utilities from to WITH_GPU_DEBUG -- OpenGL debug contexts and utilities.
Aug 3 2014, 10:04 PM
Jason Wilkins (jwilkins) updated the diff for D699: Canonical OpenGL Procedure Binding.
Aug 3 2014, 9:58 PM
Jason Wilkins (jwilkins) updated the diff for D699: Canonical OpenGL Procedure Binding.

small optimization of the MX_profile_* macros

Aug 3 2014, 11:02 AM

Aug 2 2014

Jason Wilkins (jwilkins) retitled D700: Remove Simple Shader from to Remove Simple Shader.
Aug 2 2014, 2:43 PM

Aug 1 2014

Jason Wilkins (jwilkins) retitled D699: Canonical OpenGL Procedure Binding from to Canonical OpenGL Procedure Binding.
Aug 1 2014, 8:04 PM

Jul 31 2014

Jason Wilkins (jwilkins) retitled D696: fix for potential pitfall with glMatrixMode from to fix for potential pitfall with glMatrixMode.
Jul 31 2014, 12:23 PM
Jason Wilkins (jwilkins) added a comment to D589: More fixes for CMake, MSVC 2013, Windows 8 .

This patch fixes a problem that stops the cycles standalone from compiling on MSVC.

Jul 31 2014, 12:19 PM
Jason Wilkins (jwilkins) added a reviewer for D589: More fixes for CMake, MSVC 2013, Windows 8 : Campbell Barton (campbellbarton).
Jul 31 2014, 12:19 PM

Jul 27 2014

Jason Wilkins (jwilkins) added a comment to D643: Ghost Context Refactor.

I did not succeed to build branch under ubuntu 14.04 64 bits ( i7 4770k _ Nividia Titan Black) Nvidia Driver 340.24.
Here is compilation failure log :
http://www.pasteall.org/53095

Jul 27 2014, 5:11 PM

Jul 26 2014

Jason Wilkins (jwilkins) added a comment to D682: Use /SAFESEH:NO for MSVC.

I have also run into this problem. I did think at the time that recompiling jpeglib would be a better solution than adding the flag, but I have been using the flag as a workaround so I can work.

Jul 26 2014, 7:54 PM · BF Blender
Jason Wilkins (jwilkins) added a comment to D643: Ghost Context Refactor.

Pushed some minor changes to the SDL context.

Jul 26 2014, 9:50 AM
Jason Wilkins (jwilkins) added a comment to D643: Ghost Context Refactor.

@cambellbarton The sdl context looks exactly like I imagined it. I've got a bit on insomnia, so I'm glad I didn't start working on it myself.

Jul 26 2014, 7:36 AM

Jul 24 2014

Jason Wilkins (jwilkins) retitled D676: make output of list_assert_duplicates a little more useful by showing original list from to make output of list_assert_duplicates a little more useful by showing original list.
Jul 24 2014, 7:54 PM

Jun 1 2014

Grigory Revzin (revzin) awarded rB0c3c49eee36f: fix: visual studio 2010 project built with cmake could not find libjpeg a Yellow Medal token.
Jun 1 2014, 2:39 PM