Page MenuHome

Keir Mierle (keir)
User

Projects (6)

User Details

User Since
Jun 10 2006, 8:13 PM (697 w, 3 d)

Recent Activity

Jan 8 2019

Keir Mierle (keir) added a comment to T60278: Clang-format migration: Investigate clang-format versions on common Linux & Mac distros.

6.0.0 should be good enough, though this needs a bit more verification.

Jan 8 2019, 9:03 AM · BF Blender

Jan 7 2019

Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Jan 7 2019, 5:51 PM · BF Blender
Keir Mierle (keir) added a comment to T53211: RFC: Clang-format for Blender.

@LazyDodo (LazyDodo) Good catch on the .editconfig discrepancy. I've extended T60279 to include updating other IDE configs that exist in the Blender source.

Jan 7 2019, 5:48 PM · BF Blender
Keir Mierle (keir) updated the task description for T60279: Clang-format migration: Write new `make format` command to apply clang-format to Blender.
Jan 7 2019, 5:47 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60284: Clang-format migration: Update documentation on IDE settings for Blender from Needs Triage by Developer to Normal.
Jan 7 2019, 5:45 PM · BF Blender
Keir Mierle (keir) added a subtask for T60283: Clang-format migration: Investigate branch migration plan & document it: T60275: Clang-format migration: Big-bang migration.
Jan 7 2019, 5:42 PM · BF Blender
Keir Mierle (keir) added a parent task for T60275: Clang-format migration: Big-bang migration: T60283: Clang-format migration: Investigate branch migration plan & document it.
Jan 7 2019, 5:42 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60283: Clang-format migration: Investigate branch migration plan & document it from Needs Triage by Developer to Normal.
Jan 7 2019, 5:41 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60281: Clang-format migration: Phabricator's Differential code review integration from Needs Triage by Developer to Normal.
Jan 7 2019, 5:40 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60280: Clang-format migration: Write blog post about migration process, schedule, results from Needs Triage by Developer to Normal.
Jan 7 2019, 5:38 PM · BF Blender
Keir Mierle (keir) added a parent task for T60275: Clang-format migration: Big-bang migration: T60279: Clang-format migration: Write new `make format` command to apply clang-format to Blender.
Jan 7 2019, 5:35 PM · BF Blender
Keir Mierle (keir) added a subtask for T60279: Clang-format migration: Write new `make format` command to apply clang-format to Blender: T60275: Clang-format migration: Big-bang migration.
Jan 7 2019, 5:35 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60279: Clang-format migration: Write new `make format` command to apply clang-format to Blender from Needs Triage by Developer to Normal.
Jan 7 2019, 5:34 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60278: Clang-format migration: Investigate clang-format versions on common Linux & Mac distros from Needs Triage by Developer to Normal.
Jan 7 2019, 5:31 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60277: Clang-format migration: Wiki documentation on how to run clang-format and when to do so from Needs Triage by Developer to Normal.
Jan 7 2019, 5:27 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60276: Clang-format migration: Update C++ style guide to reflect new standards from Needs Triage by Developer to Normal.
Jan 7 2019, 5:25 PM · BF Blender
Keir Mierle (keir) lowered the priority of T60275: Clang-format migration: Big-bang migration from Needs Triage by Developer to Normal.
Jan 7 2019, 5:23 PM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Jan 7 2019, 4:27 PM · BF Blender
Keir Mierle (keir) added a comment to T53211: RFC: Clang-format for Blender.

This is great! Nice progress.

Jan 7 2019, 12:53 PM · BF Blender
Keir Mierle (keir) added a comment to rB3a9753e8b99c: clang-format: add more ForEachMacros.

Wow! Talk about foreach macros.

Jan 7 2019, 11:03 AM
Keir Mierle (keir) added inline comments to rB7e7db2f01fe4: Tweak comments.
Jan 7 2019, 11:01 AM
Keir Mierle (keir) added inline comments to rB29525240a554: Initial clang-format.
Jan 7 2019, 10:50 AM

Jan 6 2019

Keir Mierle (keir) added a comment to P885 .clang-format (alternative 2 space, 80width).

Updated to turn on IndentPPDirectives.

Jan 6 2019, 7:22 PM
Keir Mierle (keir) edited P885 .clang-format (alternative 2 space, 80width).
Jan 6 2019, 7:22 PM
Keir Mierle (keir) added a comment to T53211: RFC: Clang-format for Blender.

I updated P884 and P885 to turn on IndentPPDirectives, which is now commonly available in deployed Clang versions (available as of Clang 6). This improves preprocessor formatting.

Jan 6 2019, 7:18 PM · BF Blender
Keir Mierle (keir) added a comment to P884 .clang-format (alternative 4 space, 100width).

I turned the IndentPPDirectives on, since it works nicely with modern clang-- a nice benefit to waiting a year!

Jan 6 2019, 7:05 PM
Keir Mierle (keir) edited P884 .clang-format (alternative 4 space, 100width).
Jan 6 2019, 7:05 PM
Keir Mierle (keir) created T60229: Rendering problem in "set password" dialog on Mac OS X + Chrome.
Jan 6 2019, 12:33 PM · Infrastructure: Blender Cloud
Keir Mierle (keir) added a comment to T53211: RFC: Clang-format for Blender.

@Campbell Barton (campbellbarton), are you still opposed to this approach? From reading the comments, it appears you are the primary detractor.

Jan 6 2019, 11:48 AM · BF Blender

Oct 31 2017

Keir Mierle (keir) added a comment to T53211: RFC: Clang-format for Blender.

Response to Campbell's questions:

Oct 31 2017, 2:09 PM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 1:45 PM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 1:35 PM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 12:49 PM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 12:42 PM · BF Blender
Keir Mierle (keir) added a comment to T53211: RFC: Clang-format for Blender.

Try brew install llvm; that should get clang-format. Agreed the best path forward would be to bundle clang format as part of the libraries on all platforms; that way it's easy for everyone to run, and the version of clang format will be fixed.

Oct 31 2017, 12:27 PM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 11:28 AM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 11:24 AM · BF Blender
Keir Mierle (keir) updated the task description for T53211: RFC: Clang-format for Blender.
Oct 31 2017, 11:23 AM · BF Blender
Keir Mierle (keir) created T53211: RFC: Clang-format for Blender.
Oct 31 2017, 11:11 AM · BF Blender

May 11 2015

Keir Mierle (keir) committed rLMV2b4aa0b7720c: Make README more informative for GitHub viewers (authored by Keir Mierle (keir)).
Make README more informative for GitHub viewers
May 11 2015, 11:17 AM
Keir Mierle (keir) closed D1295: Make README more informative for GitHub viewers by committing rLMV2b4aa0b7720c: Make README more informative for GitHub viewers.
May 11 2015, 11:17 AM
Keir Mierle (keir) retitled D1295: Make README more informative for GitHub viewers from to Make README more informative for GitHub viewers.
May 11 2015, 11:11 AM
Keir Mierle (keir) committed rLMV514e4491aea6: Simplify the modal solver Ceres cost function (authored by Keir Mierle (keir)).
Simplify the modal solver Ceres cost function
May 11 2015, 10:54 AM
Keir Mierle (keir) closed D756: Simplify the modal solver Ceres cost function by committing rLMV514e4491aea6: Simplify the modal solver Ceres cost function.
May 11 2015, 10:54 AM · Libmv
Keir Mierle (keir) updated the diff for D756: Simplify the modal solver Ceres cost function.

Copyright

May 11 2015, 10:53 AM · Libmv
Keir Mierle (keir) added a project to D756: Simplify the modal solver Ceres cost function: Libmv.
May 11 2015, 10:48 AM · Libmv
Keir Mierle (keir) created T44664: Autocalibration may be fixing the sign of eigenvalues incorrectly.
May 11 2015, 10:28 AM · Libmv
Keir Mierle (keir) created T44660: FocalFromFundamental does not handle the case when optical centers converge (no result is possible).
May 11 2015, 12:22 AM · Libmv

May 9 2015

Keir Mierle (keir) added a comment to D775: Improvements to "Setup Scene" in the MovieClipEditor.

This has grown stale; Sebastian, want to update this and get it landed?

May 9 2015, 8:04 PM · BF Blender

Oct 30 2014

Keir Mierle (keir) accepted rB788e74f5b901: Libmv: Support disabled color channels in trackign settings.

accepting since subsequent commit fixed the issue

Oct 30 2014, 6:41 PM
Keir Mierle (keir) added inline comments to rB0ea04447c547: Libmv: Inverse meaning of Marker::visible_channels.
Oct 30 2014, 6:32 PM
Keir Mierle (keir) added inline comments to rB788e74f5b901: Libmv: Support disabled color channels in trackign settings.
Oct 30 2014, 6:16 PM

Sep 6 2014

Keir Mierle (keir) accepted D775: Improvements to "Setup Scene" in the MovieClipEditor.

Looks good to me, but I am not especially qualified to answer here. Sergey?

Sep 6 2014, 11:02 PM · BF Blender

Aug 27 2014

Keir Mierle (keir) updated the diff for D756: Simplify the modal solver Ceres cost function.

Fix test by flipping the quaternion.

Aug 27 2014, 8:23 AM · Libmv

Aug 23 2014

Keir Mierle (keir) closed D757: Minor keyframe selection cleanups.

Closed by commit rLMVd976e034cdf7 (authored by @Keir Mierle (keir)).

Aug 23 2014, 9:38 AM

Aug 22 2014

Keir Mierle (keir) retitled D757: Minor keyframe selection cleanups from to Minor keyframe selection cleanups.
Aug 22 2014, 8:50 AM
Keir Mierle (keir) retitled D756: Simplify the modal solver Ceres cost function from to Simplify the modal solver Ceres cost function.
Aug 22 2014, 8:47 AM · Libmv
Keir Mierle (keir) closed D755: Make libmv compile on Ubuntu 14.04.

Closed by commit rLMV5b87682d98df (authored by @Keir Mierle (keir)).

Aug 22 2014, 7:45 AM
Keir Mierle (keir) updated subscribers of D755: Make libmv compile on Ubuntu 14.04.
Aug 22 2014, 6:19 AM
Keir Mierle (keir) retitled D755: Make libmv compile on Ubuntu 14.04 from to Make libmv compile on Ubuntu 14.04.
Aug 22 2014, 6:17 AM
Keir Mierle (keir) accepted D663: implement backward prediction.
Aug 22 2014, 5:35 AM

Nov 25 2013

Keir Mierle (keir) added a comment to T37477: Unbreak the blender build on FreeBSD.

Also note that Ceres has changed the handling of the hash stuff upstream; the proper solution is probably to upgrade Ceres first, then add the appropriate defines.

Nov 25 2013, 9:45 PM · BF Blender