Page MenuHome

Anthony Edlin (krash)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2008, 8:10 AM (586 w, 9 h)

Recent Activity

Mar 7 2019

Anthony Edlin (krash) added a reviewer for D4464: Add double click to walk model keymap so walk mode doesn't stutter when tapping movement keys.: User Interface.
Mar 7 2019, 10:56 PM

Mar 6 2019

Anthony Edlin (krash) updated the summary of D4464: Add double click to walk model keymap so walk mode doesn't stutter when tapping movement keys..
Mar 6 2019, 10:31 PM
Anthony Edlin (krash) created D4464: Add double click to walk model keymap so walk mode doesn't stutter when tapping movement keys..
Mar 6 2019, 10:26 PM
Anthony Edlin (krash) updated subscribers of T54237: Operator Panel Can Disappear And Won’t Come Back.

So this doesn't apply anymore to 2.8, but still applies for 2.79 even if it is probably not worth fixing. What is the proper way to deal with these tasks? @Brecht Van Lommel (brecht)

Mar 6 2019, 9:46 AM · User Interface, BF Blender

Apr 2 2018

Anthony Edlin (krash) triaged T54487: White Screen as Needs Information from User priority.

Hi, thanks for the report.

Apr 2 2018, 1:04 AM · Platform: Windows, BF Blender

Apr 1 2018

Anthony Edlin (krash) triaged T54237: Operator Panel Can Disappear And Won’t Come Back as Confirmed, Medium priority.

Ubuntu 16.04 Blender 2.79a master
GeForce GTX 1080 NVIDIA 384.111

Apr 1 2018, 9:57 AM · User Interface, BF Blender

Mar 30 2018

Anthony Edlin (krash) added a comment to D3120: C logging api.

Currently the debug flags are listed separately in help text of blender so you know what is available. Is there any way that the different logging categories are displayed so users can see what is available without having to search through code to find the names. I didn't see anything in patch but only looked through quickly.

Mar 30 2018, 7:55 PM · BF Blender

Mar 29 2018

Anthony Edlin (krash) triaged T54370: Box selection select random faces as Needs Information from User priority.

Sorry, but I can't reproduce here.

Mar 29 2018, 9:32 PM · BF Blender

Nov 6 2017

Anthony Edlin (krash) added a comment to T52979: N key doesn't open N-panel in tight space.

This is a long standing issue with design of areas and regions. There are many ways you can get the regions to force hide and therefore get it so that opening the region will fail with shortcuts. Scaling window like you said is just one.

Nov 6 2017, 11:02 PM · User Interface, BF Blender
Anthony Edlin (krash) added a comment to T53212: The constrain axis manipulator often fails to function when the 3d view is maximised.

Could not reproduce here on linux. Could be OS specific. File with bug happening for you would be needed.

Nov 6 2017, 7:55 PM · BF Blender

Dec 5 2016

Anthony Edlin (krash) added a comment to T50137: UV edge is not displayed.

Can confirm current behavior. Again I think it's just a lack of implementation. Not sure if it's useful to mark as todo as it will likely conflict with changes in 2.8 gl upgrade.

Dec 5 2016, 5:22 PM · User Interface, BF Blender

Dec 1 2016

Anthony Edlin (krash) reassigned T50132: UV Sticky mode is not respected with Border select from Anthony Edlin (krash) to cris (InsigMathK).
Dec 1 2016, 4:52 AM · Quick Hacks
Anthony Edlin (krash) added a comment to T50132: UV Sticky mode is not respected with Border select.

Sure go for it, you can assign me I'll help test and review once you have a patch.

Dec 1 2016, 4:25 AM · Quick Hacks

Nov 29 2016

Anthony Edlin (krash) triaged T50132: UV Sticky mode is not respected with Border select as Confirmed, Medium priority.

Can confirm this is current behavior. Also circle select and lasso select also don't follow sticky mode. Not sure if this is desired behavior or not. Shouldn't be that hard to add to those operators, could mark todo for someone that wants an easier task.

Nov 29 2016, 2:13 AM · Quick Hacks
Anthony Edlin (krash) added a comment to T50133: Objects added in 'Local view' don't get assigned to any layer.

Yeah it is strange, the v3d->layact is binary 1000000000000000000000000 which has local view flag but no active layer set, so new object is only on local view. Switching almost anything and layact becomes normal. Can't really do much unless we can reproduce what makes it get screwed up.

Nov 29 2016, 1:25 AM · BF Blender

Nov 24 2016

Anthony Edlin (krash) added a comment to D2377: OpenGL: convert anim_channel_defines.c to new imm mode.

As a general way to trace functions in code I use find in files from IDE or a "grep -r" from command line. In this case it's slightly harder because those functions are used by function pointer. Still find in files shows them being setup in several bAnimChannelType, looking at definition of bAnimChannelType in ED_anim_api.h you can see the function pointer name is draw_backdrop. Searching for draw_backdrop shows it's called from ANIM_channel_draw, and ANIM_channel_draw is called from action, nla, and graph editors draw code.

Nov 24 2016, 4:16 PM · BF Blender: 2.8

Nov 23 2016

Anthony Edlin (krash) accepted D2363: Moved UI_view2_multi_grid_draw() to Gawain.

Built and tested, seems good to go to me.

Nov 23 2016, 4:56 AM · BF Blender: 2.8

Nov 22 2016

Anthony Edlin (krash) accepted D2364: Replacing UI_view2d_scrollsers_draw() to immedaite mode.

Built and tested, seems fine.

Nov 22 2016, 5:36 PM
Anthony Edlin (krash) added a comment to D2363: Moved UI_view2_multi_grid_draw() to Gawain.

I was still getting asserts in some cases, think I've found all corner cases remaining now.

Nov 22 2016, 5:03 PM · BF Blender: 2.8

Nov 19 2016

Anthony Edlin (krash) requested changes to D2363: Moved UI_view2_multi_grid_draw() to Gawain.

I have to say, there is a lot wrong with this function. I think this is a case where just converting to gawain isn't really all that's needed because the original code isn't very good. Really have to try to understand what is going on and it's taken me a bit. Added a first pass review. There is more but have to go to work now so I'll do more tonight.

Nov 19 2016, 5:17 PM · BF Blender: 2.8

Nov 18 2016

Anthony Edlin (krash) added a comment to D2363: Moved UI_view2_multi_grid_draw() to Gawain.

I tested earlier and it was working but now issues with double assign of attributes.

Nov 18 2016, 8:02 AM · BF Blender: 2.8
Anthony Edlin (krash) accepted D2360: Moved UI_view2d_grid_draw() to immediate functions.

Tested and seems all issues are fixed.

Nov 18 2016, 3:51 AM

Nov 17 2016

Anthony Edlin (krash) added inline comments to D2361: blender 2.8: OpenGL immediate mode: area.
Nov 17 2016, 8:16 PM
Anthony Edlin (krash) added a comment to D2360: Moved UI_view2d_grid_draw() to immediate functions.

Did some more testing last night and found that gawain asserts if vertical_minor_step is 0. You should be able to test it by taking the default screen and making the time line at the bottom really small. It asserts on line 1361 and the reason is that it doesn't like that the color attribute was set on line 1347 but never used. To fix I think you'll have to wrap the vertical minor grid lines section in a "if (step != 0)". Try it out and see what you think.

Nov 17 2016, 8:04 PM

Nov 16 2016

Anthony Edlin (krash) requested changes to D2360: Moved UI_view2d_grid_draw() to immediate functions.
Nov 16 2016, 2:33 PM
Anthony Edlin (krash) added a comment to D2360: Moved UI_view2d_grid_draw() to immediate functions.

You're akrashe in IRC, right? You said you wanted to review this.

Nov 16 2016, 2:23 PM
Anthony Edlin (krash) added a comment to D2298: Blender2.8 convert UI_view2d_constant_grid_draw to new immediate mode.

I didn't want to bother you because I knew you were probably busy with bconf, but I don't want to let this sit forever. I'm not fussed if the patch is used or not. I just want to close it out either way so it isn't confusing for others going forward.

Nov 16 2016, 12:48 AM · BF Blender: 2.8
Anthony Edlin (krash) added a comment to D2289: Use new immediate mode for ED_region_grid_draw.

Any update on this? It's been a little while and I want to finalize this either open or closed.

Nov 16 2016, 12:25 AM · BF Blender: 2.8
Anthony Edlin (krash) added a comment to D2298: Blender2.8 convert UI_view2d_constant_grid_draw to new immediate mode.

I'd like to ask for a review or response for this as it's been a month. Otherwise, I'd like to just close this revision.

Nov 16 2016, 12:14 AM · BF Blender: 2.8

Nov 11 2016

Anthony Edlin (krash) triaged T49973: HotKey conflict (weight paint) as Confirmed, Medium priority.

Can confirm the conflict of keys in this case.

Nov 11 2016, 4:29 AM · User Interface, BF Blender
Anthony Edlin (krash) triaged T49980: Text is not working to change as Needs Information from User priority.

I'm sorry but this is an incomplete report, text for me seems to work fine. We need more information in order to find your issue, such as.

Nov 11 2016, 3:58 AM · BF Blender

Nov 10 2016

Anthony Edlin (krash) closed T49977: Imperial Inches Unit Scale Increments in Feet instead as Resolved.

Hi, thanks for report, this is a duplicate of T49960 reported a couple days ago. Please use that task for continued discussion.

Nov 10 2016, 7:03 AM · BF Blender

Nov 8 2016

Anthony Edlin (krash) added a comment to T49960: Units Feet and Inches.

I can confirm this. It seems blender does not take into account Unit Scale in some transform ops.

Nov 8 2016, 10:24 AM · User Interface, BF Blender

Oct 14 2016

Anthony Edlin (krash) retitled D2298: Blender2.8 convert UI_view2d_constant_grid_draw to new immediate mode from to Blender2.8 convert UI_view2d_constant_grid_draw to new immediate mode.
Oct 14 2016, 6:49 AM · BF Blender: 2.8

Oct 13 2016

Anthony Edlin (krash) added a comment to T49646: Switching from large to small image can get stuck zoom at max zoom distance.

Made a fix at D2291

Oct 13 2016, 11:36 AM · User Interface, BF Blender
Anthony Edlin (krash) retitled D2291: Switching from large to small image can get stuck zoom at max zoom distance. from to Switching from large to small image can get stuck zoom at max zoom distance..
Oct 13 2016, 11:35 AM
Anthony Edlin (krash) created T49646: Switching from large to small image can get stuck zoom at max zoom distance.
Oct 13 2016, 11:32 AM · User Interface, BF Blender
Anthony Edlin (krash) updated the diff for D2289: Use new immediate mode for ED_region_grid_draw.

Made most suggested changes, also used new immUniformThemeColorShade.

Oct 13 2016, 9:14 AM · BF Blender: 2.8
Anthony Edlin (krash) added a comment to D2289: Use new immediate mode for ED_region_grid_draw.

It does seem silly to add helper functions to just draw a line. Plus I don't think it works that well with gawain as it is, having to pass in attribs and do all the setup outside the function anyways, what's the point in helper function then really.

Oct 13 2016, 9:06 AM · BF Blender: 2.8

Oct 12 2016

Anthony Edlin (krash) added a comment to D2289: Use new immediate mode for ED_region_grid_draw.

This is one of four different grid drawing functions in blender. The others are in view2d.c. This one is used for UV/image editor and clip editor when there is no image or clip.

Oct 12 2016, 8:03 AM · BF Blender: 2.8
Anthony Edlin (krash) retitled D2289: Use new immediate mode for ED_region_grid_draw from to Use new immediate mode for ED_region_grid_draw.
Oct 12 2016, 7:57 AM · BF Blender: 2.8

Oct 8 2016

Anthony Edlin (krash) added a comment to D2271: draw region emboss with new immediate mode.

I can't commit anything as far as I know.

Oct 8 2016, 5:19 AM · BF Blender: 2.8
Anthony Edlin (krash) set the repository for D2271: draw region emboss with new immediate mode to rB Blender.
Oct 8 2016, 5:17 AM · BF Blender: 2.8

Oct 6 2016

Anthony Edlin (krash) updated the diff for D2271: draw region emboss with new immediate mode.

New diff with only 5 verts as suggested.

Oct 6 2016, 9:20 PM · BF Blender: 2.8

Oct 4 2016

Anthony Edlin (krash) retitled D2271: draw region emboss with new immediate mode from to draw region emboss with new immediate mode.
Oct 4 2016, 10:32 AM · BF Blender: 2.8

Oct 3 2016

Anthony Edlin (krash) retitled D2270: Spelling fix in freestyle output from to Spelling fix in freestyle output.
Oct 3 2016, 8:35 PM

Jan 18 2016

Anthony Edlin (krash) added a comment to T47111: render bug in freestyle.

Really I don't think it's a freestyle issue. Freestyle just uses blender's internal render database to get tri/quads. In this case if you use internal render and not cycles render you get the freestyle lines to match up. So issue is that internal render and cycles render do not do same quad splitting. You can see all of this in my post above. The function that does the internal render database quad splitting is check_non_flat_quads(). I'm not sure how cycles does quad splitting but it seems to always match viewport so it probably just always splits on vert index rather then doing any normals testing like check_non_flat_quads() does.

Jan 18 2016, 7:15 PM · BF Blender, Freestyle

Jan 16 2016

Anthony Edlin (krash) created T47188: Blender crashes when trying to undo adding new scene with "copy settings".
Jan 16 2016, 4:57 AM · BF Blender

Jan 7 2016

Anthony Edlin (krash) added a comment to T47111: render bug in freestyle.

I did a little debugging on this and have a little more info to give.

Jan 7 2016, 11:01 AM · BF Blender, Freestyle

Nov 7 2014

Anthony Edlin (krash) added a comment to T42380: Can't select the mesh in the viewport..

Did you try with a build that includes rBd968a1ebb0a1c1a7a7b34cdeb31fc5096debc845

Nov 7 2014, 12:22 AM · BF Blender, User Interface

Oct 25 2014

Anthony Edlin (krash) added a project to T42380: Can't select the mesh in the viewport.: BF Blender.
Oct 25 2014, 12:37 AM · BF Blender, User Interface
Anthony Edlin (krash) added a comment to T42380: Can't select the mesh in the viewport..

I can't reproduce this. In order to help fix your problem, someone will have to verify the problem. Are you saying that even on the default scene you cannot select the cube? Do you have custom user prefs? If you reset prefs to default do you still have the problem. What if you change the User Prefs->System->Selection setting to the different options? There was some fix for occlusion query selection recently but not sure it was in 2.72a.

Oct 25 2014, 12:34 AM · BF Blender, User Interface

Oct 15 2014

Anthony Edlin (krash) added a comment to T42139: Blender noise texture gives vertical stripe patterns.

Hi psy-fi,

Oct 15 2014, 2:21 AM · Compositing, BF Blender

Oct 12 2014

Anthony Edlin (krash) triaged T42189: Unable to select some objects in View3D (when close) as Confirmed, Medium priority.

Confirmed on Ubuntu 14.04 with NVidia 8800 GT - Driver version 331.38

Oct 12 2014, 9:29 AM · BF Blender: Regressions, BF Blender

Oct 8 2014

Anthony Edlin (krash) added a comment to T42139: Blender noise texture gives vertical stripe patterns.

To add a little more info, the lines only show up with certain render size X resolutions. At 1024 you get vertical lines, at 1023 you get diagonal lines, and at 1022 you get even more slanted lines. At a size of about 1000 I can't really see the lines anymore. At 512 and 2048 the lines show up again, with the same pattern of going away if you increment/decrement by 1 repeatedly.

Oct 8 2014, 11:38 AM · Compositing, BF Blender
Anthony Edlin (krash) added a comment to T42139: Blender noise texture gives vertical stripe patterns.

Well, looks like the problem may be in the texnoise function of the render_texture.c file. This is from a commit by Ton in 2003. Here it is:

static int texnoise(Tex *tex, TexResult *texres)
{
	float div=3.0;
	int val, ran, loop;
	
	ran= BLI_rand();
	val= (ran & 3);
	
	loop= tex->noisedepth;
	while (loop--) {
		ran= (ran>>2);
		val*= (ran & 3);
		div*= 3.0f;
	}
	
	texres->tin= ((float)val)/div;
Oct 8 2014, 10:44 AM · Compositing, BF Blender

Sep 18 2014

Anthony Edlin (krash) closed T31869: Island Select Mode Change as Resolved.

A change similar to what this patch did was added a while ago when some UV code was getting refactored.

Sep 18 2014, 9:52 AM · BF Blender
Anthony Edlin (krash) closed T31871: New Group Select Operators as Resolved.

Some form of what this patch did was added a while ago by Campbell.

Sep 18 2014, 9:51 AM · BF Blender

Sep 10 2014

Anthony Edlin (krash) closed T41112: Rotate manipulator (Trackball) + release confirm not working? as Resolved.

Closed by commit rB1811ffff5d8c.

Sep 10 2014, 12:06 PM · User Interface, BF Blender: Unconfirmed
Anthony Edlin (krash) added a comment to T41112: Rotate manipulator (Trackball) + release confirm not working?.

Well, after playing with it for a couple of hours I was able to reproduce this behaviour but it's pretty complicated to describe.

Sep 10 2014, 10:49 AM · User Interface, BF Blender: Unconfirmed
Anthony Edlin (krash) added a comment to T41112: Rotate manipulator (Trackball) + release confirm not working?.

I cannot really help you with your wish for a different rotation manipulator here. If you want to pursue that then I believe it would be best to get involved in the UI team, either by petitioning someone currently interested in that or getting involved yourself. You can find more info here.

Sep 10 2014, 8:28 AM · User Interface, BF Blender: Unconfirmed

Sep 6 2014

Anthony Edlin (krash) added a comment to T41112: Rotate manipulator (Trackball) + release confirm not working?.

2.71 linux32, can't reproduce this behaviour. Either with release confirm on or off.

Sep 6 2014, 8:17 AM · User Interface, BF Blender: Unconfirmed

Sep 5 2014

Anthony Edlin (krash) added a comment to T40537: Holding down "R" causes rapid switching between rotate and trackball rotate.

The double tap for edge slide and trackball are both hard coded into the translate and rotate event checking code. This implementation of these features is probably not the greatest but it's what was done.

Sep 5 2014, 12:36 AM · User Interface, BF Blender

Apr 6 2014

Anthony Edlin (krash) added a comment to T39605: Region Overlap setting in User Prefs and Node Editor.

Yeah I think it was mostly because the sliders didn't compensate for overlapping regions. Also pretty low priority to fix.
https://developer.blender.org/rB41753f4fddc69bee7b45baef79dff02288b0aeae

Apr 6 2014, 9:10 PM · BF Blender, User Interface

Nov 26 2013

Anthony Edlin (krash) added a comment to T37463: Maximizing window causes info panel to open partially.

Realistically, you could just add a hack that would just go through after the current scale algorithm and just scale back any verts for the info space type. That would probably be less then 30 lines of code. In fact, here is the code that does it.

Nov 26 2013, 1:25 AM · BF Blender, User Interface, Platform: Linux

Nov 25 2013

Anthony Edlin (krash) attached 0 file(s) of 1: F32965: fs_tvertex_testing3.blend

I added a testing file, but I don't think this is exactly related to this problem of subpixel tvertexes going in the wrong direction. It is more to do with some hidden lines showing up as visible. I still can't seem to reproduce the original issue.

Nov 25 2013, 9:15 PM · Freestyle, BF Blender
Anthony Edlin (krash) added a comment to T37463: Maximizing window causes info panel to open partially.

Yeah it's a pretty old problem going back a long ways. Currently the screen scaling code just doesn't consider what type of area is being scaled. It's just inherent in the current design of screen verts/edges that don't link to the areas at all.

Nov 25 2013, 8:38 PM · BF Blender, User Interface, Platform: Linux
Anthony Edlin (krash) closed T20968: Screen edge offscreen fix. as Resolved.

Closed as resolved by rBe626998a. Thanks Brecht.

Nov 25 2013, 5:40 PM · User Interface, BF Blender
Anthony Edlin (krash) added a comment to T20968: Screen edge offscreen fix..

Ok differential is here. With some comments as well.

Nov 25 2013, 7:05 AM · User Interface, BF Blender
Anthony Edlin (krash) attached 0 file(s) of 1: F32626: screen-edge-fix-v4.patch

I've uploaded a v4 for this patch. I'll add to differential too, which is I assume what you meant when you said code review. I don't have hardware to test the pixelsize stuff myself but I hacked it larger in linux ghost code and tested and it seemed to do the correct stuff, still someone to test on correct hardware would be good I think.

Nov 25 2013, 5:56 AM · User Interface, BF Blender

Nov 21 2013

Anthony Edlin (krash) reopened T20968: Screen edge offscreen fix. as "Open".

I see Ton closed this task as Resolved, which I assume was an error in assigning it to brecht, so I'm opening it again.

Nov 21 2013, 10:50 PM · User Interface, BF Blender
Anthony Edlin (krash) added a comment to T20968: Screen edge offscreen fix..

So, these problems are still in the region and screen code. It's not that hard to understand. These aren't sweeping UI changes. They just try to make the code that is there do the correct thing.

Nov 21 2013, 10:47 PM · User Interface, BF Blender

Nov 18 2013

Anthony Edlin (krash) triaged T37511: Crash on menu item drag as Confirmed, Medium priority.
Nov 18 2013, 11:11 AM · User Interface, BF Blender
Anthony Edlin (krash) added a project to T37511: Crash on menu item drag: User Interface.
Nov 18 2013, 11:10 AM · User Interface, BF Blender
Anthony Edlin (krash) assigned T37511: Crash on menu item drag to Campbell Barton (campbellbarton).
Nov 18 2013, 11:09 AM · User Interface, BF Blender
Anthony Edlin (krash) added a comment to T37511: Crash on menu item drag.

Pretty clear it is part of the toggle drag code. It commonly crashes for me in some subfunction of ui_drag_toggle_set_xy_xy. It doesn't always crash though; sometimes it will check 2 checkboxes and close the menu without crashing, so I'm guessing that sometimes the region/blocks/buttons are there and sometimes they have been destroyed.

Nov 18 2013, 11:09 AM · User Interface, BF Blender