- User Since
- Feb 21 2006, 12:41 AM (712 w, 1 d)
May 5 2018
@Campbell Barton (campbellbarton) Previously, snap_sel_to_grid_exec relied on Object *obedit = CTX_data_edit_object(C); being NULL in order to use CTX_DATA_BEGIN(C, Object *, ob, selected_editable_objects) instead to update multi-objects in object mode.
After updating to use Object objects = BKE_view_layer_array_from_objects_in_edit_mode_unique_data(view_layer, &objects_len);, which works great in edit mode, I can't rely on the null check since objects won't be null when you have objects selected in object mode.
@Campbell Barton (campbellbarton) I'm working on some tools that also work in object mode. I think there's a bug with BKE_view_layer_array_from_objects_in_edit_mode_unique_data, as I'm assuming it should only return objects that are in edit mode. Currently, it's always returning objects whether they're in edit mode or not. Wondering if someone can check it out to see if I'm correct or not.
May 4 2018
@Campbell Barton (campbellbarton) Did I follow the process correctly or is there something I should do differently? I'll review your edits and work on more patches.
May 1 2018
Apr 25 2018
Apr 23 2018
Thanks @Thomas Beck (plasmasolutions) , I've created a patch and added you as the reviewer. Please let me know if I did everything right. Once it's approved I'll move forward with more changes.
Apr 21 2018
@Campbell Barton (campbellbarton) I'd like to help contribute completing this task. I currently don't have commit rights, how do I proceed with submitting my code changes for review?
I believe MESH_OT_extrude_edges_move and MESH_OT_extrude_vertices_move are complete since they use MESH_OT_extrude_faces_indiv and MESH_OT_extrude_verts_indiv.