People lichtwerk

Philipp Oeser (lichtwerk)
User

Projects

User Details

User Since
Sep 14 2008, 10:31 PM (462 w, 4 d)

Recent Activity

Jan 30 2017

Philipp Oeser (lichtwerk) placed T50398: UV Constrain to bounds not constraining when scaling UV's up for grabs.

Hi there,
unfortunately I didnt find the time to finish/clean this up (and I am not sure when I will find time) so I'm just pasting a very rough diff for others to pick up....

P440 T50398 rough
1​
2​
3​diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c
4​--- a/source/blender/editors/transform/transform.c
5​+++ b/source/blender/editors/transform/transform.c
6​@@ -3453,6 +3453,8 @@ static void applyResize(TransInfo *t, const int mval[2])
7​
8​ /* evil hack - redo resize if cliping needed */
9​ if (t->flag & T_CLIP_UV && clipUVTransform(t, t->values, 1)) {
10​+ headerResize(t, t->values, str);
11​+
12​ size_to_mat3(mat, t->values);
13​
14​ if (t->con.applySize)
15​diff --git a/source/blender/editors/transform/transform_conversions.c b/source/blender/editors/transform/transform_conversions.c
16​--- a/source/blender/editors/transform/transform_conversions.c
17​+++ b/source/blender/editors/transform/transform_conversions.c
18​@@ -2955,46 +2955,107 @@ bool clipUVTransform(TransInfo *t, float vec[2], const bool resize)
19​ {
20​ TransData *td;
21​ int a;
22​- bool clipx = true, clipy = true;
23​- float min[2], max[2];
24​+ bool clipx = false, clipy = false;
25​+ bool sclipx[2], sclipy[2];
26​+ float min[2], max[2], median[2], scale_compensate[2][2];
27​
28​+ sclipx[0] = sclipx[1] = sclipy[0] = sclipy[1] = false;
29​+ scale_compensate[0][0] = scale_compensate[0][1] = scale_compensate[1][0] = scale_compensate[1][1] = 1.0f;
30​+ median[0] = median[1] = 0.0f;
31​ min[0] = min[1] = 0.0f;
32​ max[0] = t->aspect[0];
33​ max[1] = t->aspect[1];
34​
35​ for (a = 0, td = t->data; a < t->total; a++, td++) {
36​ minmax_v2v2_v2(min, max, td->loc);
37​+ add_v2_v2(median, td->iloc);
38​ }
39​+ mul_v2_fl(median, (1.0f / (float)t->total));
40​+
41​+ // still need to solve the case when scaling vec[0] or vec[1] is negative and cursor is outside of bounds
42​
43​ if (resize) {
44​- if (min[0] < 0.0f && t->center[0] > 0.0f && t->center[0] < t->aspect[0] * 0.5f)
45​- vec[0] *= t->center[0] / (t->center[0] - min[0]);
46​- else if (max[0] > t->aspect[0] && t->center[0] < t->aspect[0])
47​- vec[0] *= (t->center[0] - t->aspect[0]) / (t->center[0] - max[0]);
48​- else
49​- clipx = 0;
50​+ if (median[0] < 0.0f || median[0] > t->aspect[0] || median[1] < 0.0f || median[1] > t->aspect[1]) {
51​+ return false;
52​+ }
53​
54​- if (min[1] < 0.0f && t->center[1] > 0.0f && t->center[1] < t->aspect[1] * 0.5f)
55​- vec[1] *= t->center[1] / (t->center[1] - min[1]);
56​- else if (max[1] > t->aspect[1] && t->center[1] < t->aspect[1])
57​- vec[1] *= (t->center[1] - t->aspect[1]) / (t->center[1] - max[1]);
58​- else
59​- clipy = 0;
60​+ if (min[0] < 0.0f) {
61​+ /* could run into devide by zero? */
62​+ scale_compensate[0][0] = t->center[0] / (t->center[0] - min[0]);
63​+ sclipx[0] = true;
64​+ }
65​+ if (max[0] > t->aspect[0]) {
66​+ scale_compensate[0][1] = (t->center[0] - t->aspect[0]) / (t->center[0] - max[0]);
67​+ sclipx[1] = true;
68​+ }
69​+ if (sclipx[0] || sclipx[1]) {
70​+ if (sclipx[0] && !sclipx[1]) {
71​+ vec[0] *= scale_compensate[0][0];
72​+ }
73​+ else if (sclipx[1] && !sclipx[0]) {
74​+ vec[0] *= scale_compensate[0][1];
75​+ }
76​+ else {
77​+ if ((abs(1.0f - scale_compensate[0][0]) > abs(1.0f - scale_compensate[0][1])) && sclipx[0]) {
78​+ vec[0] *= scale_compensate[0][0];
79​+ }
80​+ else {
81​+ vec[0] *= scale_compensate[0][1];
82​+ }
83​+ }
84​+ clipx = true;
85​+ }
86​+
87​+ if (min[1] < 0.0f) {
88​+ scale_compensate[1][0] = t->center[1] / (t->center[1] - min[1]);
89​+ sclipy[0] = true;
90​+ }
91​+ if (max[1] > t->aspect[1]) {
92​+ scale_compensate[1][1] = (t->center[1] - t->aspect[1]) / (t->center[1] - max[1]);
93​+ sclipy[1] = true;
94​+ }
95​+ if (sclipy[0] || sclipy[1]) {
96​+ if (sclipy[0] && !sclipy[1]) {
97​+ vec[1] *= scale_compensate[1][0];
98​+ }
99​+ else if (sclipy[1] && !sclipy[0]) {
100​+ vec[1] *= scale_compensate[1][1];
101​+ }
102​+ else {
103​+ if ((abs(1.0f - scale_compensate[1][0]) > abs(1.0f - scale_compensate[1][1])) && sclipy[0]) {
104​+ vec[1] *= scale_compensate[1][0];
105​+ }
106​+ else {
107​+ vec[1] *= scale_compensate[1][1];
108​+ }
109​+ }
110​+ clipy = true;
111​+ }
112​+
113​+ /* just idea to keep scaling uniform in aspect
114​+ if (sclipx[0] || sclipx[1] || sclipy[0] || sclipy[1]) {
115​+ mul_v2_fl(vec, min_ffff(scale_compensate[0][0], scale_compensate[0][1], scale_compensate[1][0], scale_compensate[1][1]));
116​+ }
117​+ */
118​ }
119​ else {
120​- if (min[0] < 0.0f)
121​+ if (min[0] < 0.0f) {
122​ vec[0] -= min[0];
123​- else if (max[0] > t->aspect[0])
124​+ clipx = true;
125​+ }
126​+ else if (max[0] > t->aspect[0]) {
127​ vec[0] -= max[0] - t->aspect[0];
128​- else
129​- clipx = 0;
130​+ clipx = true;
131​+ }
132​
133​- if (min[1] < 0.0f)
134​+ if (min[1] < 0.0f) {
135​ vec[1] -= min[1];
136​- else if (max[1] > t->aspect[1])
137​+ clipy = true;
138​+ }
139​+ if (max[1] > t->aspect[1]) {
140​ vec[1] -= max[1] - t->aspect[1];
141​- else
142​- clipy = 0;
143​+ clipy = true;
144​+ }
145​ }
146​
147​ return (clipx || clipy);

This just tries to solve a couple of issues I found with the clipping code:

  • clip minx/miny not working (if center/cursor is 'in right side')
  • clip doesnt allow for cursor being outside of UV bounds (or directly on the bounds like in this report) [the paste allows for this]
  • when scaling and runnning into clipmax first, then scale further and run into clipmin after --> pop to clipmin
  • also wasnt sure if it is a good idea to scale further on other axis after running into one clipping border [making the scale non-uniform in aspect] - which is the case in current code. There is a small snippet in the paste that could prevent this
Jan 30 2017, 7:49 PM · BF Blender
Philipp Oeser (lichtwerk) created P440 T50398 rough.
Jan 30 2017, 7:38 PM

Jan 28 2017

Philipp Oeser (lichtwerk) claimed T50398: UV Constrain to bounds not constraining when scaling UV's.

I had a look at this just yesterday and have this working mostly already, only have to iron out a cornercase...
So assigning this to me [as I can finish it up this weekend] and hope you didnt already work on this.
If you already solved this though in the meantime feel free to comandeer back...

Jan 28 2017, 9:03 AM · BF Blender

Jan 11 2017

Philipp Oeser (lichtwerk) triaged T50398: UV Constrain to bounds not constraining when scaling UV's as "Confirmed" priority.

first note: seems to only happen when 2d cursor is exactly on the bounds (or outside)
Will check logic in clipUVTransform() when time permits [could take some time though due to dayjob... so if somebody wants to jump in....]

Jan 11 2017, 10:54 PM · BF Blender
Philipp Oeser (lichtwerk) committed rBA8c06e5c7d98d: Fix T50352: 3D-printing check misinterprates flat ngons as non-flat (authored by Philipp Oeser (lichtwerk)).
Fix T50352: 3D-printing check misinterprates flat ngons as non-flat
Jan 11 2017, 8:59 PM
Philipp Oeser (lichtwerk) closed T50352: 3D-printing check misinterprates flat ngons as non-flat as "Resolved" by committing rBA8c06e5c7d98d: Fix T50352: 3D-printing check misinterprates flat ngons as non-flat.
Jan 11 2017, 8:59 PM · BF Blender
Philipp Oeser (lichtwerk) added a comment to D2236: T49347 part two.

@Vilko Lafliksyon (Eranekao): once this is committed, you'll see a message here [something like "Closed by commit ... "]
(you can then update&build immedialtely after or use builbot builds the day after or the official/stable release after this commit)
Does this answer your question?

Jan 11 2017, 4:13 PM
Philipp Oeser (lichtwerk) added a comment to D2448: proposed fix for T50352.

@Bastien Montagne (mont29): yep, rBA is fine, can commit this when I'm back...

Jan 11 2017, 4:08 PM

Jan 10 2017

Philipp Oeser (lichtwerk) added a comment to D2236: T49347 part two.

@Vilko Lafliksyon (Eranekao): this still waits for review... no garuantuee it will end up in master.
@reviewers: got a minute to check on this? thanx in advance...

Jan 10 2017, 9:35 AM
Philipp Oeser (lichtwerk) added a reviewer for D2251: disallow editing restrict flag with 'Set/Clear Restrict View' operator for linked objects: Sergey Sharybin (sergey).
Jan 10 2017, 9:29 AM
Philipp Oeser (lichtwerk) closed T50373: Lattice object can get sudivision surface modifier, via Ctrl 1 - 5 shortcut (solved previously but present on 2.78b) as "Resolved".
Jan 10 2017, 9:27 AM · BF Blender

Jan 7 2017

Philipp Oeser (lichtwerk) updated subscribers of T50373: Lattice object can get sudivision surface modifier, via Ctrl 1 - 5 shortcut (solved previously but present on 2.78b).

@Eonmach Realm (eonmachrealm): afaiks, armatures were already covered [couldnt add subdivision modifiers to them], but now lattices should also be fine... Feel free to report other bugs you encounter as well...

Jan 7 2017, 12:50 PM · BF Blender

Jan 5 2017

Philipp Oeser (lichtwerk) triaged T50376: Vertex Weight Edit modifier - Texture Mask appears to be broken as "Incomplete" priority.

Hm, no issues here (see

T50376.blend2 MB
), the modifier seems to do its thing based on the texture data.

Jan 5 2017, 2:11 PM · BF Blender
Philipp Oeser (lichtwerk) added a comment to T50373: Lattice object can get sudivision surface modifier, via Ctrl 1 - 5 shortcut (solved previously but present on 2.78b).

D2449: proposed fix for T50373

Jan 5 2017, 11:11 AM · BF Blender
Philipp Oeser (lichtwerk) retitled D2449: proposed fix for T50373 from to proposed fix for T50373.
Jan 5 2017, 11:10 AM
Philipp Oeser (lichtwerk) triaged T50373: Lattice object can get sudivision surface modifier, via Ctrl 1 - 5 shortcut (solved previously but present on 2.78b) as "Confirmed" priority.

At first glance This is the "SubdivisionSet" python operator not polling for the right object types, but it boils down to being able to call obj.modifiers.new("Subsurf", 'SUBSURF') without checking there for appropriate object types... will have a look...

Jan 5 2017, 10:24 AM · BF Blender
Philipp Oeser (lichtwerk) added reviewers for D2448: proposed fix for T50352: Dalai Felinto (dfelinto), Bastien Montagne (mont29).

mind having a look if this is a feasable fix? thanx in advance!

Jan 5 2017, 10:02 AM

Jan 4 2017

Philipp Oeser (lichtwerk) added a comment to D2448: proposed fix for T50352.

this is what Mesh-Analysis (statvis) does: statvis_calc_distort() -- just to reference corresponding code for detecting non-flat faces that doesnt mark the faces from T50352: 3D-printing check misinterprates flat ngons as non-flat as non-flat...

Jan 4 2017, 10:52 PM
Philipp Oeser (lichtwerk) added a comment to T50352: 3D-printing check misinterprates flat ngons as non-flat.

proposed fix D2448: proposed fix for T50352

Jan 4 2017, 10:39 PM · BF Blender
Philipp Oeser (lichtwerk) retitled D2448: proposed fix for T50352 from to proposed fix for T50352.
Jan 4 2017, 10:31 PM
Philipp Oeser (lichtwerk) claimed T50352: 3D-printing check misinterprates flat ngons as non-flat.

Can confirm this, will have a look...
First note: N-Panel > Mesh-Analysis doesnt color the faces in question as distorted [so C code does it 'right'], python operator seems to have the bug... (most likely unhandled flipped normals)

Jan 4 2017, 10:20 PM · BF Blender

Nov 30 2016

Philipp Oeser (lichtwerk) added a watcher for Quick Hacks: Philipp Oeser (lichtwerk).
Nov 30 2016, 2:54 PM
Philipp Oeser (lichtwerk) added a comment to rB13e7dddebdc1: Node UI: * Add 3 more operators to the Node menu..

regarding wording of tooltip: -1 for "surrounding" vs. "neighboring" (dont think this makes it more clear), suggest "...and try to reconnect detached nodes" instead

Nov 30 2016, 10:48 AM
Philipp Oeser (lichtwerk) added a comment to rB13e7dddebdc1: Node UI: * Add 3 more operators to the Node menu..

This commit only added menu entries for the given operators (not the operators themselves).

Nov 30 2016, 9:41 AM

Oct 28 2016

Philipp Oeser (lichtwerk) added a comment to T49848: Bevel problem.

quick note: every mode except "Percent" will run into clamping ("Clamp Overlap" option) real quick [but clamping will actually prevent the behaviour in the video]. "Percent" mode will actually work quite nicely though, no?

Oct 28 2016, 1:41 PM · BF Blender

Sep 27 2016

Philipp Oeser (lichtwerk) added reviewers for D2236: T49347 part two: Jonathan Williamson (carter2422), Julian Eisel (Severin).

Hi Jonathan & Julian, adding you as reviewers here because you had a look at D2234: T49347 part one and if we get a decission on this we can close T49347: Color for edges with bevel weight same as selected edges color...
Thanx for having a lookin advance!

Sep 27 2016, 9:51 PM

Sep 25 2016

Duarte Farrajota Ramos (duarteframos) awarded D2257: bl_previews: take (local) group instances in groups into account a Like token.
Sep 25 2016, 3:47 PM
Philipp Oeser (lichtwerk) added a comment to T49423: Data Preview of group containing only group instances is empty..

diff is D2257: bl_previews: take (local) group instances in groups into account

Sep 25 2016, 3:16 PM · BF Blender
Philipp Oeser (lichtwerk) retitled D2257: bl_previews: take (local) group instances in groups into account from to bl_previews: take (local) group instances in groups into account.
Sep 25 2016, 3:15 PM

Sep 24 2016

Philipp Oeser (lichtwerk) added a comment to T49423: Data Preview of group containing only group instances is empty..

k, have it working for the case of group instances in groups, will do some further thinking/checking and post patch later/tomorrow...

Sep 24 2016, 3:36 PM · BF Blender
Philipp Oeser (lichtwerk) claimed T49423: Data Preview of group containing only group instances is empty..

Confirmed.
@Bastien Montagne (mont29) think this is your playground, but assigning to me cause I think I can get there and support this, will have a look (possibly this weekend). If it is real quick for you and you've got time, feel free to claim back...

Sep 24 2016, 1:00 PM · BF Blender

Sep 23 2016

Philipp Oeser (lichtwerk) placed T49438: Baking Geometry-Pointiness up for grabs.
Sep 23 2016, 11:02 PM · BF Blender
Philipp Oeser (lichtwerk) added a comment to T49439: LightWave importer.

just very quick first look gives tons of these:

P403 regarding T49439
1​BLI_assert failed: /blender/source/blender/blenlib/intern/edgehash.c:95, edgehash_bucket_index(), at 'v0 < v1'
2​./bin/blender(BLI_system_backtrace+0x26) [0x325f8ae]
3​./bin/blender(BLI_edgehash_lookup+0x118) [0x3206baf]
4​./bin/blender(BKE_mesh_convert_mfaces_to_mpolys_ex+0x2f3) [0x2e777c7]
5​./bin/blender(BKE_mesh_convert_mfaces_to_mpolys+0xc3) [0x2e7739c]
6​./bin/blender(ED_mesh_update+0x42) [0x24cceb8]
7​./bin/blender(Mesh_update_call+0x5c) [0x30a0b48]
8​
9​BLI_assert failed: /blender/source/blender/blenlib/intern/edgehash.c:155, edgehash_lookup_entry_ex(), at 'v0 < v1'
10​./bin/blender(BLI_system_backtrace+0x26) [0x325f8ae]
11​./bin/blender(BLI_edgehash_lookup+0x7e) [0x3206b15]
12​./bin/blender(BKE_mesh_convert_mfaces_to_mpolys_ex+0x3af) [0x2e77883]
13​./bin/blender(BKE_mesh_convert_mfaces_to_mpolys+0xc3) [0x2e7739c]
14​./bin/blender(ED_mesh_update+0x42) [0x24cceb8]
15​./bin/blender(Mesh_update_call+0x5c) [0x30a0b48]

Sep 23 2016, 11:00 PM · Addons
Philipp Oeser (lichtwerk) created P403 regarding T49439.
Sep 23 2016, 10:59 PM
Philipp Oeser (lichtwerk) added a comment to T49438: Baking Geometry-Pointiness.

Just for others to see quickly (havent checked further)

Sep 23 2016, 10:49 PM · BF Blender
Philipp Oeser (lichtwerk) triaged T49424: VSE Scene Strip (in "Use Sequence" mode) Incompatible with certain Effect Strips as "Confirmed" priority.

btw: issues from report confirmed

Sep 23 2016, 10:38 PM · Video Sequencer, BF Blender
Philipp Oeser (lichtwerk) added a comment to rBA434fa71f2dc7: Fix T49432: Archimesh crashes blender when room height info changed.

@Antonio Vazquez (antoniov) thanx, np :)

Sep 23 2016, 10:06 PM
Philipp Oeser (lichtwerk) added a comment to T49424: VSE Scene Strip (in "Use Sequence" mode) Incompatible with certain Effect Strips.

@Matt (HyperSphere): thanx for the patch!
Sequencer is not really a part of blender that I am very familiar with, at first glance I can confirm the patch seems to solve issues mentioned in the report. Hope I can spend some more time checking more in depth...

Sep 23 2016, 10:03 PM · Video Sequencer, BF Blender
Philipp Oeser (lichtwerk) added a comment to rBA434fa71f2dc7: Fix T49432: Archimesh crashes blender when room height info changed.

author credits please ;)

Sep 23 2016, 3:33 PM
Philipp Oeser (lichtwerk) added a comment to T49432: Archimesh crashes blender when room height info changed.

how about

P402 regarding T49432
1​--- \2.78\scripts\addons\archimesh\achm_room_maker_orig.py
2​+++ \2.78\scripts\addons\archimesh\achm_room_maker.py
3​@@ -465,6 +465,7 @@
4​ myshell = None
5​ # Create the walls (only mesh, because the object is 'myRoom', created before).
6​ create_walls(rp, tmp_mesh, get_blendunits(rp.room_height))
7​+ myroom.data = tmp_mesh
8​ # Mark Seams
9​ select_vertices(myroom, [0, 1])
10​ mark_seam(myroom)
?
only have very little time, but this seems to fix it for me... (also see comments in the paste)

Sep 23 2016, 2:55 PM · Addons, BF Blender
Philipp Oeser (lichtwerk) added a comment to P402 regarding T49432.

only very limited time here, but:
it seems the meshdata is never really set to the object (thats why its empty -- which is not what create_floor() expects, thus giving empty lists to from_pydata() -- which is also bad...)

Sep 23 2016, 2:53 PM · Addons
Philipp Oeser (lichtwerk) created P402 regarding T49432.
Sep 23 2016, 2:50 PM · Addons

Sep 22 2016

Philipp Oeser (lichtwerk) added a comment to T49351: Carver MT.

@Brendon Murphy (meta-androcto): like I said, Carver MT is not buggy itself, it just shows a bug in the bmesh boolean modifier

Sep 22 2016, 10:31 AM · Addons, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49424: VSE Scene Strip (in "Use Sequence" mode) Incompatible with certain Effect Strips.

@Matt (HyperSphere): didnt have a look at the issue yet, but you can post your diff here

Sep 22 2016, 10:27 AM · Video Sequencer, BF Blender

Sep 21 2016

Philipp Oeser (lichtwerk) added a comment to P388 2.8 monkey coding: draw speaker with new immediate mode.

no commit access unfortunately

Sep 21 2016, 10:23 PM
Philipp Oeser (lichtwerk) added a comment to P388 2.8 monkey coding: draw speaker with new immediate mode.

Hi merwin! almost forgot about this one. should be fine now?
Should I make a proper phabricator diff (instead of the paste)?

Sep 21 2016, 10:02 PM
Philipp Oeser (lichtwerk) edited P388 2.8 monkey coding: draw speaker with new immediate mode.
Sep 21 2016, 10:01 PM
Philipp Oeser (lichtwerk) added a comment to T49351: Carver MT.

looks like an issue with blenders bmesh boolean modifier (script uses this internally) which Carver MT only exposes, the script itself is not really doing anything wrong...

Sep 21 2016, 9:25 PM · Addons, BF Blender
Philipp Oeser (lichtwerk) added a comment to D2251: disallow editing restrict flag with 'Set/Clear Restrict View' operator for linked objects.

this is more of a followup to followup to rB03073 (where this was done for the Outliner)
Changes to restrict flag will be lost on save/reload, so we should propably be strict and not allow these anywhere?

Sep 21 2016, 8:44 PM
Philipp Oeser (lichtwerk) retitled D2251: disallow editing restrict flag with 'Set/Clear Restrict View' operator for linked objects from to disallow editing restrict flag with 'Set/Clear Restrict View' operator for linked objects.
Sep 21 2016, 8:41 PM
Philipp Oeser (lichtwerk) raised the priority of T49351: Carver MT from "Incomplete" to "Confirmed".
Sep 21 2016, 4:11 PM · Addons, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49351: Carver MT.

@YAFU (YAFU) : thanx for the files, can confirm issues in these, will have a look later

Sep 21 2016, 4:11 PM · Addons, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49419: Color symbol gone .

cannot reproduce this... color icon showing here in Properties Editor as well as Node Editor (for drag n drop)
tested this is current master and RC2 on linux

Sep 21 2016, 1:48 PM · BF Blender
Philipp Oeser (lichtwerk) added a comment to D2234: T49347 part one.

Totally agree about the duplicated standard colors that you tweeted about, as well as some others.
Anyways, could someone mark this as 'Accepted' then? Or just commit? Thanx in advance

Sep 21 2016, 1:39 PM

Sep 20 2016

Philipp Oeser (lichtwerk) added a comment to D2234: T49347 part one.

btw. while we are at it [and this is also UI-related]: what are your opinions on D2236: T49347 part two?

Sep 20 2016, 3:55 PM
Philipp Oeser (lichtwerk) added a comment to D2234: T49347 part one.

Hi UI-Team!

Sep 20 2016, 3:51 PM

Sep 19 2016

Philipp Oeser (lichtwerk) updated the diff for D2228: possible fix for T49343.

removed braces

Sep 19 2016, 6:10 PM
Philipp Oeser (lichtwerk) added a comment to rB1f5cd85976df: Fix T49375: align rotation with snap target isn't toggleable in edit mode..

wow, a last minute change must have sneaked this epic one in D2237 :/
sorry for this, and thanx for having an eye on me [again] @Bastien Montagne (mont29) :)

Sep 19 2016, 5:59 PM

Sep 17 2016

Philipp Oeser (lichtwerk) added a comment to T49336: The Outline Editor problem for the linked object.

hi @Sergey Sharybin (sergey)! should we be strict and do something like

P401 T49336 followup
1​
2​
3​diff --git a/source/blender/editors/object/object_edit.c b/source/blender/editors/object/object_edit.c
4​--- a/source/blender/editors/object/object_edit.c
5​+++ b/source/blender/editors/object/object_edit.c
6​@@ -186,23 +186,25 @@ static int object_hide_view_set_exec(bContext *C, wmOperator *op)
7​
8​ CTX_DATA_BEGIN(C, Base *, base, visible_bases)
9​ {
10​- if (!unselected) {
11​- if (base->flag & SELECT) {
12​- base->flag &= ~SELECT;
13​- base->object->flag = base->flag;
14​- base->object->restrictflag |= OB_RESTRICT_VIEW;
15​- changed = true;
16​- if (base == BASACT) {
17​- ED_base_object_activate(C, NULL);
18​+ if (!ID_IS_LINKED_DATABLOCK(&base->object->id)) {
19​+ if (!unselected) {
20​+ if (base->flag & SELECT) {
21​+ base->flag &= ~SELECT;
22​+ base->object->flag = base->flag;
23​+ base->object->restrictflag |= OB_RESTRICT_VIEW;
24​+ changed = true;
25​+ if (base == BASACT) {
26​+ ED_base_object_activate(C, NULL);
27​+ }
28​ }
29​ }
30​- }
31​- else {
32​- if (!(base->flag & SELECT)) {
33​- base->object->restrictflag |= OB_RESTRICT_VIEW;
34​- changed = true;
35​- if (base == BASACT) {
36​- ED_base_object_activate(C, NULL);
37​+ else {
38​+ if (!(base->flag & SELECT)) {
39​+ base->object->restrictflag |= OB_RESTRICT_VIEW;
40​+ changed = true;
41​+ if (base == BASACT) {
42​+ ED_base_object_activate(C, NULL);
43​+ }
44​ }
45​ }
46​ }
then [just to be consistent]?

Sep 17 2016, 2:09 PM · BF Blender
Philipp Oeser (lichtwerk) created P401 T49336 followup.
Sep 17 2016, 2:07 PM

Sep 16 2016

Philipp Oeser (lichtwerk) added a comment to T49347: Color for edges with bevel weight same as selected edges color.

@Vilko Lafliksyon (Eranekao): dont speak too soon, this hasnt been commited yet ;) [those patches are in review, added you as a subscriber there so you can see progress]

Sep 16 2016, 7:09 PM · User Interface, BF Blender
Philipp Oeser (lichtwerk) updated subscribers of D2236: T49347 part two.
Sep 16 2016, 7:08 PM
Philipp Oeser (lichtwerk) updated subscribers of D2234: T49347 part one.
Sep 16 2016, 7:08 PM
Philipp Oeser (lichtwerk) added a comment to T49376: Newly created “transparent” object cannot make older objects visible.

I think this is a long-standing 'problem' (not sure how easy it would be to fix it once and for all -- or if there's another solution to this), but there is a workaround though of the top of my head:

Sep 16 2016, 2:00 PM · BF Blender
Philipp Oeser (lichtwerk) added a comment to T49375: align rotation with snap target isn't toggleable in edit mode.

allowed the toggle in D2237: possible fix for T49375

Sep 16 2016, 1:29 PM · BF Blender
Philipp Oeser (lichtwerk) retitled D2237: possible fix for T49375 from to possible fix for T49375.
Sep 16 2016, 1:26 PM
Philipp Oeser (lichtwerk) lowered the priority of T49351: Carver MT from "Normal" to "Incomplete".

Hi @Erick Tukuniata (erickblender), I wasnt able to reproduce this (ortho and cursor depth seem to work fine here)

  • where is your 3D cursor at?
  • could you provide a .blend where this happens (3DCursor and view set exactly so the error happens)?
Sep 16 2016, 12:20 PM · Addons, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output.

@Michael Otto (mayqel): yep if you dont have a normal connected it will use GPU_VIEW_NORMAL, if you've got somethink linked it multiplies GPU_VIEW_MATRIX with this

Sep 16 2016, 11:29 AM · OpenGL / Gfx, Rendering, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output.

@Sergey Sharybin (sergey): cycles viewport seems fine to me, you mean BI/BGE use camera space normals whereas cycles uses world?

Sep 16 2016, 11:26 AM · OpenGL / Gfx, Rendering, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output.

change came in rB002de

Sep 16 2016, 11:18 AM · OpenGL / Gfx, Rendering, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output.

is this using the cycles Fresnel node? (not sure if this is even supposed to work with BI/GameEngine...)

Sep 16 2016, 10:44 AM · OpenGL / Gfx, Rendering, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49347: Color for edges with bevel weight same as selected edges color.

made edge bevel weights also draw in vertex selection mode D2236: T49347 part two

Sep 16 2016, 10:08 AM · User Interface, BF Blender
Philipp Oeser (lichtwerk) retitled D2236: T49347 part two from to T49347 part two.
Sep 16 2016, 10:06 AM

Sep 15 2016

Philipp Oeser (lichtwerk) added a comment to T49347: Color for edges with bevel weight same as selected edges color.

made this themable now D2234: T49347 part one

Sep 15 2016, 3:12 PM · User Interface, BF Blender
Philipp Oeser (lichtwerk) retitled D2234: T49347 part one from to T49347 part one.
Sep 15 2016, 3:11 PM
Philipp Oeser (lichtwerk) updated the diff for D2228: possible fix for T49343.

covered cases in scene: bake, render
covered cases in nodetree: CMP_NODE_OUTPUT_FILE and also the individual fileslots of that node
should be all cases now (at least I couldnt find more)

Sep 15 2016, 12:46 PM

Sep 14 2016

Philipp Oeser (lichtwerk) added a comment to T49347: Color for edges with bevel weight same as selected edges color.

@Vilko Lafliksyon (Eranekao): can have a look at that, too, guess it's fine to have just one report... will do tomorrow

Sep 14 2016, 6:18 PM · User Interface, BF Blender
Philipp Oeser (lichtwerk) added a comment to D2228: possible fix for T49343.

note: bake uses this too (more others even?) So might have to consider a path like scene.render.bake.image_settings as well...

Sep 14 2016, 3:43 PM
Philipp Oeser (lichtwerk) added a comment to T49347: Color for edges with bevel weight same as selected edges color.

@Sergey Sharybin (sergey): yes, would hop on that now [T49343 was taking longer than expected...]

Sep 14 2016, 3:15 PM · User Interface, BF Blender
Philipp Oeser (lichtwerk) added a comment to T49343: Python render setting commands are incorrect in the Info view.

ImageFormatSettings were not setting their rna struct path, so a possible fix here D2228: possible fix for T49343

Sep 14 2016, 3:05 PM · Python, BF Blender
Philipp Oeser (lichtwerk) retitled D2228: possible fix for T49343 from to possible fix for T49343.
Sep 14 2016, 3:04 PM
Philipp Oeser (lichtwerk) added a comment to T49342: TypeError when autocompleting bpy.app.something.

note: first occurance/autocomplete after a fresh restart of blender goes through without the error, only then (second/third) the error happens

Sep 14 2016, 9:59 AM · BF Blender: Regressions, Python
Philipp Oeser (lichtwerk) claimed T49343: Python render setting commands are incorrect in the Info view.
Sep 14 2016, 7:40 AM · Python, BF Blender
Philipp Oeser (lichtwerk) claimed T49347: Color for edges with bevel weight same as selected edges color.
Sep 14 2016, 7:40 AM · User Interface, BF Blender

Sep 13 2016

Philipp Oeser (lichtwerk) created P398 Outliner: renaming -- use operator reports.
Sep 13 2016, 12:59 PM
Philipp Oeser (lichtwerk) created P397 2.8 remove immediate mode drawing nurbs verts.
Sep 13 2016, 10:28 AM

Sep 1 2016

Philipp Oeser (lichtwerk) edited P388 2.8 monkey coding: draw speaker with new immediate mode.
Sep 1 2016, 6:38 PM

Aug 28 2016

Philipp Oeser (lichtwerk) added a comment to P388 2.8 monkey coding: draw speaker with new immediate mode.

thanx for the notes! will come back to this the comming days...

Aug 28 2016, 10:22 PM
Philipp Oeser (lichtwerk) added a comment to T49170: Specular highlights in BI don’t show proper colors in Textured Solid mode.

Sorry, was having a quick look, but didnt have enough time to investigate this completely. Will come back to this [if noone else picks this up before I have the time]

Aug 28 2016, 10:19 PM · BF Blender: 2.8

Aug 27 2016

Philipp Oeser (lichtwerk) added a comment to T49170: Specular highlights in BI don’t show proper colors in Textured Solid mode.

this apparently changed from 2.72 to 2.73 [looking into it now...]

Aug 27 2016, 5:19 PM · BF Blender: 2.8
Philipp Oeser (lichtwerk) added a comment to T49175: PBR crashes testbuild 2.78 ver2 .

cannot confirm here on linux (nvidia 970m with 367.35 drivers)
both current master and blender-2.78-testbuild2-linux-glibc219-x86_64 are not crashing here with specified file

Aug 27 2016, 1:46 PM · BF Blender: Regressions, BF Blender
Philipp Oeser (lichtwerk) created P388 2.8 monkey coding: draw speaker with new immediate mode.
Aug 27 2016, 1:18 PM
Philipp Oeser (lichtwerk) added a comment to T49170: Specular highlights in BI don’t show proper colors in Textured Solid mode.

note: your file uses MultiTexture materials, what you describe works in GLSL


not sure this is supposed to be supported in MultiTexture?

Aug 27 2016, 11:11 AM · BF Blender: 2.8

Aug 23 2016

Philipp Oeser (lichtwerk) added a comment to D2169: Boolean modifier (bmesh): option to set bevel weight / edge crease for new edges.

Aug 23 2016, 2:11 PM
Philipp Oeser (lichtwerk) retitled D2169: Boolean modifier (bmesh): option to set bevel weight / edge crease for new edges from to Boolean modifier (bmesh): option to set bevel weight / edge crease for new edges.
Aug 23 2016, 2:10 PM

Aug 11 2016

Philipp Oeser (lichtwerk) committed rBAebcb2e0e39c9: mesh_carver: fix broken scaling of profile brush (authored by Philipp Oeser (lichtwerk)).
mesh_carver: fix broken scaling of profile brush
Aug 11 2016, 6:15 PM
Philipp Oeser (lichtwerk) created P382 fix mesh_carver addon failing to scale profile brush.
Aug 11 2016, 5:38 PM

Jul 10 2016

Philipp Oeser (lichtwerk) created T48823: b.org credits are a bit outdated.
Jul 10 2016, 9:16 PM · Infrastructure: Websites
Philipp Oeser (lichtwerk) added a comment to D1875: Support "View Selected" to center on the last stroke for vertexpaint and weightpaint.

@Campbell Barton (campbellbarton): think this would have a chance to go into 2.78? I've heard it being requested numerous times... Could you have a look? Thanx in advance!

Jul 10 2016, 8:41 PM
Philipp Oeser (lichtwerk) added a comment to T48814: Displace modifier ignores 'Simple' subdivision if scale is unapplied.

Yep, looks like clouds procderural at scale 1 will give output values of .5 at corners [0,0], [0,1], [1,1], [1,0]
--> So no displacement there
file from report uses clouds at scale .25 which will give no displacement at all vertices even at subd level 2 or 3.

Jul 10 2016, 12:51 PM · Modifiers, BF Blender